* [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver
@ 2015-01-05 9:18 Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 2/8] ASoC: cs35l32: " Krzysztof Kozlowski
` (7 more replies)
0 siblings, 8 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
sound/soc/codecs/alc5632.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
index d1fdbc266631..07630260e1ba 100644
--- a/sound/soc/codecs/alc5632.c
+++ b/sound/soc/codecs/alc5632.c
@@ -1066,7 +1066,7 @@ static int alc5632_probe(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_device_alc5632 = {
+static const struct snd_soc_codec_driver soc_codec_device_alc5632 = {
.probe = alc5632_probe,
.resume = alc5632_resume,
.set_bias_level = alc5632_set_bias_level,
@@ -1080,7 +1080,7 @@ static struct snd_soc_codec_driver soc_codec_device_alc5632 = {
.num_dapm_routes = ARRAY_SIZE(alc5632_dapm_routes),
};
-static struct regmap_config alc5632_regmap = {
+static const struct regmap_config alc5632_regmap = {
.reg_bits = 8,
.val_bits = 16,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/8] ASoC: cs35l32: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-05 15:05 ` Brian Austin
2015-01-05 9:18 ` [PATCH 3/8] ASoC: cs42l52: " Krzysztof Kozlowski
` (6 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, Brian Austin, Paul Handrigan
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Brian Austin <brian.austin@cirrus.com>
Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
sound/soc/codecs/cs35l32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c
index ec55c590afd0..f2b8aad21274 100644
--- a/sound/soc/codecs/cs35l32.c
+++ b/sound/soc/codecs/cs35l32.c
@@ -264,7 +264,7 @@ static int cs35l32_codec_set_sysclk(struct snd_soc_codec *codec,
CS35L32_MCLK_DIV2_MASK | CS35L32_MCLK_RATIO_MASK, val);
}
-static struct snd_soc_codec_driver soc_codec_dev_cs35l32 = {
+static const struct snd_soc_codec_driver soc_codec_dev_cs35l32 = {
.set_sysclk = cs35l32_codec_set_sysclk,
.dapm_widgets = cs35l32_dapm_widgets,
@@ -288,7 +288,7 @@ static const struct reg_default cs35l32_monitor_patch[] = {
{ 0x00, 0x00 },
};
-static struct regmap_config cs35l32_regmap = {
+static const struct regmap_config cs35l32_regmap = {
.reg_bits = 8,
.val_bits = 8,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/8] ASoC: cs42l52: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 2/8] ASoC: cs35l32: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 4/8] ASoC: cs42l56: " Krzysztof Kozlowski
` (5 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, Brian Austin, Paul Handrigan
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Brian Austin <brian.austin@cirrus.com>
Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
sound/soc/codecs/cs42l52.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
index 35fbef743fbe..1589e7a881d8 100644
--- a/sound/soc/codecs/cs42l52.c
+++ b/sound/soc/codecs/cs42l52.c
@@ -1103,7 +1103,7 @@ static int cs42l52_remove(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_dev_cs42l52 = {
+static const struct snd_soc_codec_driver soc_codec_dev_cs42l52 = {
.probe = cs42l52_probe,
.remove = cs42l52_remove,
.set_bias_level = cs42l52_set_bias_level,
@@ -1130,7 +1130,7 @@ static const struct reg_default cs42l52_threshold_patch[] = {
};
-static struct regmap_config cs42l52_regmap = {
+static const struct regmap_config cs42l52_regmap = {
.reg_bits = 8,
.val_bits = 8,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/8] ASoC: cs42l56: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 2/8] ASoC: cs35l32: " Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 3/8] ASoC: cs42l52: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 5/8] ASoC: cs42l73: " Krzysztof Kozlowski
` (4 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, Brian Austin, Paul Handrigan
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Brian Austin <brian.austin@cirrus.com>
Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
sound/soc/codecs/cs42l56.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
index 2ddc7ac10ad7..cbc654fe48c7 100644
--- a/sound/soc/codecs/cs42l56.c
+++ b/sound/soc/codecs/cs42l56.c
@@ -1164,7 +1164,7 @@ static int cs42l56_remove(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_dev_cs42l56 = {
+static const struct snd_soc_codec_driver soc_codec_dev_cs42l56 = {
.probe = cs42l56_probe,
.remove = cs42l56_remove,
.set_bias_level = cs42l56_set_bias_level,
@@ -1179,7 +1179,7 @@ static struct snd_soc_codec_driver soc_codec_dev_cs42l56 = {
.num_controls = ARRAY_SIZE(cs42l56_snd_controls),
};
-static struct regmap_config cs42l56_regmap = {
+static const struct regmap_config cs42l56_regmap = {
.reg_bits = 8,
.val_bits = 8,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 5/8] ASoC: cs42l73: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
` (2 preceding siblings ...)
2015-01-05 9:18 ` [PATCH 4/8] ASoC: cs42l56: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 6/8] ASoC: wm8804: " Krzysztof Kozlowski
` (3 subsequent siblings)
7 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, Brian Austin, Paul Handrigan
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Brian Austin <brian.austin@cirrus.com>
Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
sound/soc/codecs/cs42l73.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 7c55537c69cf..8ecedba79606 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1347,7 +1347,7 @@ static int cs42l73_probe(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_dev_cs42l73 = {
+static const struct snd_soc_codec_driver soc_codec_dev_cs42l73 = {
.probe = cs42l73_probe,
.set_bias_level = cs42l73_set_bias_level,
.suspend_bias_off = true,
@@ -1361,7 +1361,7 @@ static struct snd_soc_codec_driver soc_codec_dev_cs42l73 = {
.num_controls = ARRAY_SIZE(cs42l73_snd_controls),
};
-static struct regmap_config cs42l73_regmap = {
+static const struct regmap_config cs42l73_regmap = {
.reg_bits = 8,
.val_bits = 8,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 6/8] ASoC: wm8804: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
` (3 preceding siblings ...)
2015-01-05 9:18 ` [PATCH 5/8] ASoC: cs42l73: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-06 9:13 ` Charles Keepax
2015-01-05 9:18 ` [PATCH 7/8] ASoC: wm8988: " Krzysztof Kozlowski
` (2 subsequent siblings)
7 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, patches
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: patches@opensource.wolfsonmicro.com
---
sound/soc/codecs/wm8804.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c
index 1315f7642503..b2b0e68f707e 100644
--- a/sound/soc/codecs/wm8804.c
+++ b/sound/soc/codecs/wm8804.c
@@ -648,7 +648,7 @@ static struct snd_soc_dai_driver wm8804_dai = {
.symmetric_rates = 1
};
-static struct snd_soc_codec_driver soc_codec_dev_wm8804 = {
+static const struct snd_soc_codec_driver soc_codec_dev_wm8804 = {
.probe = wm8804_probe,
.remove = wm8804_remove,
.set_bias_level = wm8804_set_bias_level,
@@ -664,7 +664,7 @@ static const struct of_device_id wm8804_of_match[] = {
};
MODULE_DEVICE_TABLE(of, wm8804_of_match);
-static struct regmap_config wm8804_regmap_config = {
+static const struct regmap_config wm8804_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 7/8] ASoC: wm8988: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
` (4 preceding siblings ...)
2015-01-05 9:18 ` [PATCH 6/8] ASoC: wm8804: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-06 9:13 ` Charles Keepax
2015-01-05 9:18 ` [PATCH 8/8] ASoC: wm8804: " Krzysztof Kozlowski
2015-01-05 21:19 ` [PATCH 1/8] ASoC: alc5632: " Mark Brown
7 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, patches
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: patches@opensource.wolfsonmicro.com
---
sound/soc/codecs/wm8988.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8988.c b/sound/soc/codecs/wm8988.c
index e418199155a8..d320c5251856 100644
--- a/sound/soc/codecs/wm8988.c
+++ b/sound/soc/codecs/wm8988.c
@@ -813,7 +813,7 @@ static int wm8988_probe(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_dev_wm8988 = {
+static const struct snd_soc_codec_driver soc_codec_dev_wm8988 = {
.probe = wm8988_probe,
.set_bias_level = wm8988_set_bias_level,
.suspend_bias_off = true,
@@ -826,7 +826,7 @@ static struct snd_soc_codec_driver soc_codec_dev_wm8988 = {
.num_dapm_routes = ARRAY_SIZE(wm8988_dapm_routes),
};
-static struct regmap_config wm8988_regmap = {
+static const struct regmap_config wm8988_regmap = {
.reg_bits = 7,
.val_bits = 9,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 8/8] ASoC: wm8804: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
` (5 preceding siblings ...)
2015-01-05 9:18 ` [PATCH 7/8] ASoC: wm8988: " Krzysztof Kozlowski
@ 2015-01-05 9:18 ` Krzysztof Kozlowski
2015-01-06 9:14 ` Charles Keepax
2015-01-05 21:19 ` [PATCH 1/8] ASoC: alc5632: " Mark Brown
7 siblings, 1 reply; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-01-05 9:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski, patches
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver (snd_soc_register_codec() accepts pointer to const)
and array of default register values const as well.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: patches@opensource.wolfsonmicro.com
---
sound/soc/codecs/wm8995.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c
index c280f0a3a424..120228b6b596 100644
--- a/sound/soc/codecs/wm8995.c
+++ b/sound/soc/codecs/wm8995.c
@@ -44,7 +44,7 @@ static const char *wm8995_supply_names[WM8995_NUM_SUPPLIES] = {
"MICVDD"
};
-static struct reg_default wm8995_reg_defaults[] = {
+static const struct reg_default wm8995_reg_defaults[] = {
{ 0, 0x8995 },
{ 5, 0x0100 },
{ 16, 0x000b },
@@ -2190,7 +2190,7 @@ static struct snd_soc_dai_driver wm8995_dai[] = {
}
};
-static struct snd_soc_codec_driver soc_codec_dev_wm8995 = {
+static const struct snd_soc_codec_driver soc_codec_dev_wm8995 = {
.probe = wm8995_probe,
.remove = wm8995_remove,
.set_bias_level = wm8995_set_bias_level,
@@ -2204,7 +2204,7 @@ static struct snd_soc_codec_driver soc_codec_dev_wm8995 = {
.num_dapm_routes = ARRAY_SIZE(wm8995_intercon),
};
-static struct regmap_config wm8995_regmap = {
+static const struct regmap_config wm8995_regmap = {
.reg_bits = 16,
.val_bits = 16,
--
1.9.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/8] ASoC: cs35l32: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 ` [PATCH 2/8] ASoC: cs35l32: " Krzysztof Kozlowski
@ 2015-01-05 15:05 ` Brian Austin
0 siblings, 0 replies; 15+ messages in thread
From: Brian Austin @ 2015-01-05 15:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, Brian Austin, Paul Handrigan
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Brian Austin <brian.austin@cirrus.com>
> Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
For the Cirrus Codecs
Acked-by: Brian Austin <brian.austin@cirrus.com>
Thanks
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/8] ASoC: cs35l32: Constify struct regmap_config and snd_soc_codec_driver
@ 2015-01-05 15:05 ` Brian Austin
0 siblings, 0 replies; 15+ messages in thread
From: Brian Austin @ 2015-01-05 15:05 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Brian Austin, alsa-devel, Takashi Iwai, linux-kernel,
Paul Handrigan, Liam Girdwood, Mark Brown
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Brian Austin <brian.austin@cirrus.com>
> Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
For the Cirrus Codecs
Acked-by: Brian Austin <brian.austin@cirrus.com>
Thanks
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
` (6 preceding siblings ...)
2015-01-05 9:18 ` [PATCH 8/8] ASoC: wm8804: " Krzysztof Kozlowski
@ 2015-01-05 21:19 ` Mark Brown
7 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2015-01-05 21:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
On Mon, Jan 05, 2015 at 10:18:21AM +0100, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
Applied all, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 6/8] ASoC: wm8804: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 ` [PATCH 6/8] ASoC: wm8804: " Krzysztof Kozlowski
@ 2015-01-06 9:13 ` Charles Keepax
0 siblings, 0 replies; 15+ messages in thread
From: Charles Keepax @ 2015-01-06 9:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, patches
On Mon, Jan 05, 2015 at 10:18:26AM +0100, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: patches@opensource.wolfsonmicro.com
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 7/8] ASoC: wm8988: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 ` [PATCH 7/8] ASoC: wm8988: " Krzysztof Kozlowski
@ 2015-01-06 9:13 ` Charles Keepax
0 siblings, 0 replies; 15+ messages in thread
From: Charles Keepax @ 2015-01-06 9:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, patches
On Mon, Jan 05, 2015 at 10:18:27AM +0100, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: patches@opensource.wolfsonmicro.com
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 8/8] ASoC: wm8804: Constify struct regmap_config and snd_soc_codec_driver
2015-01-05 9:18 ` [PATCH 8/8] ASoC: wm8804: " Krzysztof Kozlowski
@ 2015-01-06 9:14 ` Charles Keepax
0 siblings, 0 replies; 15+ messages in thread
From: Charles Keepax @ 2015-01-06 9:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, patches
On Mon, Jan 05, 2015 at 10:18:28AM +0100, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver (snd_soc_register_codec() accepts pointer to const)
> and array of default register values const as well.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: patches@opensource.wolfsonmicro.com
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 8/8] ASoC: wm8804: Constify struct regmap_config and snd_soc_codec_driver
@ 2015-01-06 9:14 ` Charles Keepax
0 siblings, 0 replies; 15+ messages in thread
From: Charles Keepax @ 2015-01-06 9:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: alsa-devel, Takashi Iwai, patches, linux-kernel, Liam Girdwood,
Mark Brown
On Mon, Jan 05, 2015 at 10:18:28AM +0100, Krzysztof Kozlowski wrote:
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver (snd_soc_register_codec() accepts pointer to const)
> and array of default register values const as well.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: patches@opensource.wolfsonmicro.com
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-01-06 9:14 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-05 9:18 [PATCH 1/8] ASoC: alc5632: Constify struct regmap_config and snd_soc_codec_driver Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 2/8] ASoC: cs35l32: " Krzysztof Kozlowski
2015-01-05 15:05 ` Brian Austin
2015-01-05 15:05 ` Brian Austin
2015-01-05 9:18 ` [PATCH 3/8] ASoC: cs42l52: " Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 4/8] ASoC: cs42l56: " Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 5/8] ASoC: cs42l73: " Krzysztof Kozlowski
2015-01-05 9:18 ` [PATCH 6/8] ASoC: wm8804: " Krzysztof Kozlowski
2015-01-06 9:13 ` Charles Keepax
2015-01-05 9:18 ` [PATCH 7/8] ASoC: wm8988: " Krzysztof Kozlowski
2015-01-06 9:13 ` Charles Keepax
2015-01-05 9:18 ` [PATCH 8/8] ASoC: wm8804: " Krzysztof Kozlowski
2015-01-06 9:14 ` Charles Keepax
2015-01-06 9:14 ` Charles Keepax
2015-01-05 21:19 ` [PATCH 1/8] ASoC: alc5632: " Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.