* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 8:24 ` Lokesh Vutla
0 siblings, 0 replies; 10+ messages in thread
From: Lokesh Vutla @ 2015-01-06 8:24 UTC (permalink / raw)
To: linux-omap, linux-arm-kernel, tony
Cc: nsekhar, t-kristo, nm, balbi, lokeshvutla, stable
With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
On beagle-x15, we use uart3 for console and missed enabling this flag
for uart3 hwmod, so boot fails with DEBUG_LL. Enable DEBUG_OMAP4UART3_FLAGS for
uart3 hwmod.
For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Cc: <stable@vger.kernel.org> # v3.12+
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index ffd6604..b6ea88f 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = {
.class = &dra7xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
.main_clk = "uart3_gfclk_mux",
- .flags = HWMOD_SWSUP_SIDLE_ACT,
+ .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS,
.prcm = {
.omap4 = {
.clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 8:24 ` Lokesh Vutla
0 siblings, 0 replies; 10+ messages in thread
From: Lokesh Vutla @ 2015-01-06 8:24 UTC (permalink / raw)
To: linux-arm-kernel
With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
On beagle-x15, we use uart3 for console and missed enabling this flag
for uart3 hwmod, so boot fails with DEBUG_LL. Enable DEBUG_OMAP4UART3_FLAGS for
uart3 hwmod.
For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Cc: <stable@vger.kernel.org> # v3.12+
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index ffd6604..b6ea88f 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = {
.class = &dra7xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
.main_clk = "uart3_gfclk_mux",
- .flags = HWMOD_SWSUP_SIDLE_ACT,
+ .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS,
.prcm = {
.omap4 = {
.clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
2015-01-06 8:24 ` Lokesh Vutla
@ 2015-01-06 14:05 ` Nishanth Menon
-1 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2015-01-06 14:05 UTC (permalink / raw)
To: Lokesh Vutla
Cc: linux-omap, linux-arm-kernel, tony, nsekhar, t-kristo, balbi, stable
$subject should probably need a cleanup: this is hwmod support for
DEBUG_LL on UART3 - x15 happens to be one of the platforms that uses
that, but not the only one.. I suggest removing x15 from $subject and
rephrasing accordingly.
On 13:54-20150106, Lokesh Vutla wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On beagle-x15, we use uart3 for console and missed enabling this flag
Official name of the platform is BeagleBoard-X15
> for uart3 hwmod, so boot fails with DEBUG_LL. Enable DEBUG_OMAP4UART3_FLAGS for
> uart3 hwmod.
Could you align your commit message to 70 chars if possible?
>
> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
>
> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
> Cc: <stable@vger.kernel.org> # v3.12+
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index ffd6604..b6ea88f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart3_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,
> --
> 1.9.1
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 14:05 ` Nishanth Menon
0 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2015-01-06 14:05 UTC (permalink / raw)
To: linux-arm-kernel
$subject should probably need a cleanup: this is hwmod support for
DEBUG_LL on UART3 - x15 happens to be one of the platforms that uses
that, but not the only one.. I suggest removing x15 from $subject and
rephrasing accordingly.
On 13:54-20150106, Lokesh Vutla wrote:
> With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with
> DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon
> to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
>
> On beagle-x15, we use uart3 for console and missed enabling this flag
Official name of the platform is BeagleBoard-X15
> for uart3 hwmod, so boot fails with DEBUG_LL. Enable DEBUG_OMAP4UART3_FLAGS for
> uart3 hwmod.
Could you align your commit message to 70 chars if possible?
>
> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
>
> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
> Cc: <stable@vger.kernel.org> # v3.12+
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index ffd6604..b6ea88f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = {
> .class = &dra7xx_uart_hwmod_class,
> .clkdm_name = "l4per_clkdm",
> .main_clk = "uart3_gfclk_mux",
> - .flags = HWMOD_SWSUP_SIDLE_ACT,
> + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,
> --
> 1.9.1
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
2015-01-06 14:05 ` Nishanth Menon
@ 2015-01-06 15:08 ` Felipe Balbi
-1 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2015-01-06 15:08 UTC (permalink / raw)
To: Nishanth Menon
Cc: Lokesh Vutla, linux-omap, linux-arm-kernel, tony, nsekhar,
t-kristo, balbi, stable
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
> > For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
> >
> > Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
>
> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
what's the difference ? why do you want that many more characters if
those 7 are enough for git to find a uniq commit ? Try this:
$ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 15:08 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2015-01-06 15:08 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
> > For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
> >
> > Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
>
> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
what's the difference ? why do you want that many more characters if
those 7 are enough for git to find a uniq commit ? Try this:
$ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/61afa5b0/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
2015-01-06 15:08 ` Felipe Balbi
@ 2015-01-06 15:17 ` Nishanth Menon
-1 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2015-01-06 15:17 UTC (permalink / raw)
To: balbi
Cc: Lokesh Vutla, linux-omap, linux-arm-kernel, tony, nsekhar,
t-kristo, stable
On 01/06/2015 09:08 AM, Felipe Balbi wrote:
> On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
>>> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
>>>
>>> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
>>
>> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
>
> what's the difference ? why do you want that many more characters if
> those 7 are enough for git to find a uniq commit ? Try this:
>
> $ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
>
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n160
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 15:17 ` Nishanth Menon
0 siblings, 0 replies; 10+ messages in thread
From: Nishanth Menon @ 2015-01-06 15:17 UTC (permalink / raw)
To: linux-arm-kernel
On 01/06/2015 09:08 AM, Felipe Balbi wrote:
> On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
>>> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
>>>
>>> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
>>
>> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
>
> what's the difference ? why do you want that many more characters if
> those 7 are enough for git to find a uniq commit ? Try this:
>
> $ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
>
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n160
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
2015-01-06 15:17 ` Nishanth Menon
@ 2015-01-06 15:42 ` Felipe Balbi
-1 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2015-01-06 15:42 UTC (permalink / raw)
To: Nishanth Menon
Cc: balbi, Lokesh Vutla, linux-omap, linux-arm-kernel, tony, nsekhar,
t-kristo, stable
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Hi,
On Tue, Jan 06, 2015 at 09:17:59AM -0600, Nishanth Menon wrote:
> On 01/06/2015 09:08 AM, Felipe Balbi wrote:
> > On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
> >>> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
> >>>
> >>> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
> >>
> >> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
> >
> > what's the difference ? why do you want that many more characters if
> > those 7 are enough for git to find a uniq commit ? Try this:
> >
> > $ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
> >
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n160
alright, if it's Documented, it's best done ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
@ 2015-01-06 15:42 ` Felipe Balbi
0 siblings, 0 replies; 10+ messages in thread
From: Felipe Balbi @ 2015-01-06 15:42 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Jan 06, 2015 at 09:17:59AM -0600, Nishanth Menon wrote:
> On 01/06/2015 09:08 AM, Felipe Balbi wrote:
> > On Tue, Jan 06, 2015 at 08:05:17AM -0600, Nishanth Menon wrote:
> >>> For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
> >>>
> >>> Fixes: 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
> >>
> >> Fixes: 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
> >
> > what's the difference ? why do you want that many more characters if
> > those 7 are enough for git to find a uniq commit ? Try this:
> >
> > $ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
> >
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n160
alright, if it's Documented, it's best done ;-)
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/ead50429/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-06 15:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-06 8:24 [PATCH] ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL Lokesh Vutla
2015-01-06 8:24 ` Lokesh Vutla
2015-01-06 14:05 ` Nishanth Menon
2015-01-06 14:05 ` Nishanth Menon
2015-01-06 15:08 ` Felipe Balbi
2015-01-06 15:08 ` Felipe Balbi
2015-01-06 15:17 ` Nishanth Menon
2015-01-06 15:17 ` Nishanth Menon
2015-01-06 15:42 ` Felipe Balbi
2015-01-06 15:42 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.