From: Jeff Layton <jeff.layton@primarydata.com> To: Christoph Hellwig <hch@lst.de> Cc: linux-nfs@vger.kernel.org, trond.myklebust@primarydata.com, Sachin Bhamare <sachin.bhamare@primarydata.com>, xfs@oss.sgi.com, "J. Bruce Fields" <bfields@fieldses.org>, linux-fsdevel@vger.kernel.org, thomas.haynes@primarydata.com, Jeff Layton <jeff.layton@primarydata.com> Subject: Re: [PATCH 09/18] nfsd: implement pNFS operations Date: Fri, 9 Jan 2015 09:28:35 -0800 [thread overview] Message-ID: <20150109092835.5fdbac5d@synchrony.poochiereds.net> (raw) In-Reply-To: <20150109171641.GA17464@lst.de> On Fri, 9 Jan 2015 18:16:41 +0100 Christoph Hellwig <hch@lst.de> wrote: > On Fri, Jan 09, 2015 at 08:51:30AM -0800, Jeff Layton wrote: > > Ok, it'd be good to document that in some comments then for the sake of > > posterity (maybe it is later in the set -- I haven't gotten to the end > > yet). > > What kinds of comments do you expect? Not implementing unused features > of a protocol should be the default for anything in Linux. > I was thinking just a comment saying that ROC is always true in this implementation, or maybe consider eliminating the lg_roc field in struct nfsd4_layoutget altogether since it's currently always "1". It's a little confusing now since the encoder can handle the case where lg_roc is 0, but the rest of the code can't. > > Now, that said...I think that your ROC semantics are wrong here. You > > also have to take delegations into account. [1] > > > > Basically the semantics that you want are that nfsd should do all of > > the ROC stuff on last close iff there are no outstanding delegations or > > on delegreturn iff there are no opens. > > > > What we ended up doing in the unreleased code we have was to create a > > new per-client and per-file object (that we creatively called an > > "odstate"). An open stateid and a delegation stateid would hold a > > reference to this object which is put when those stateids are freed. > > When its refcount goes to zero, then we'd free any outstanding layouts > > on the file for that client and free the object. > > > > You probably want to do something similar here. > > > > [1]: Tom and Trond mentioned that there's a RFC5661 errata pending for > > this, but I don't see it right offhand. > > It would be good to look at the errata. While the idea of keeping > layouts around longer makes sense, I would only expect to do this > if they layout state was created based on a delegation stateid, not > a lock or open stateid. In that case having the layouts hang off > the "parent" stateid might be another option. I found it: http://www.rfc-editor.org/errata_search.php?rfc=5661&eid=3226 -- Jeff Layton <jlayton@primarydata.com> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jeff.layton@primarydata.com> To: Christoph Hellwig <hch@lst.de> Cc: Jeff Layton <jeff.layton@primarydata.com>, "J. Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, thomas.haynes@primarydata.com, trond.myklebust@primarydata.com, Sachin Bhamare <sachin.bhamare@primarydata.com> Subject: Re: [PATCH 09/18] nfsd: implement pNFS operations Date: Fri, 9 Jan 2015 09:28:35 -0800 [thread overview] Message-ID: <20150109092835.5fdbac5d@synchrony.poochiereds.net> (raw) In-Reply-To: <20150109171641.GA17464@lst.de> On Fri, 9 Jan 2015 18:16:41 +0100 Christoph Hellwig <hch@lst.de> wrote: > On Fri, Jan 09, 2015 at 08:51:30AM -0800, Jeff Layton wrote: > > Ok, it'd be good to document that in some comments then for the sake of > > posterity (maybe it is later in the set -- I haven't gotten to the end > > yet). > > What kinds of comments do you expect? Not implementing unused features > of a protocol should be the default for anything in Linux. > I was thinking just a comment saying that ROC is always true in this implementation, or maybe consider eliminating the lg_roc field in struct nfsd4_layoutget altogether since it's currently always "1". It's a little confusing now since the encoder can handle the case where lg_roc is 0, but the rest of the code can't. > > Now, that said...I think that your ROC semantics are wrong here. You > > also have to take delegations into account. [1] > > > > Basically the semantics that you want are that nfsd should do all of > > the ROC stuff on last close iff there are no outstanding delegations or > > on delegreturn iff there are no opens. > > > > What we ended up doing in the unreleased code we have was to create a > > new per-client and per-file object (that we creatively called an > > "odstate"). An open stateid and a delegation stateid would hold a > > reference to this object which is put when those stateids are freed. > > When its refcount goes to zero, then we'd free any outstanding layouts > > on the file for that client and free the object. > > > > You probably want to do something similar here. > > > > [1]: Tom and Trond mentioned that there's a RFC5661 errata pending for > > this, but I don't see it right offhand. > > It would be good to look at the errata. While the idea of keeping > layouts around longer makes sense, I would only expect to do this > if they layout state was created based on a delegation stateid, not > a lock or open stateid. In that case having the layouts hang off > the "parent" stateid might be another option. I found it: http://www.rfc-editor.org/errata_search.php?rfc=5661&eid=3226 -- Jeff Layton <jlayton@primarydata.com>
next prev parent reply other threads:[~2015-01-09 17:28 UTC|newest] Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-06 16:28 a simple and scalable pNFS block layout server Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 01/18] nfs: add LAYOUT_TYPE_MAX enum value Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 02/18] fs: add FL_LAYOUT lease type Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 18:46 ` Jeff Layton 2015-01-06 18:46 ` Jeff Layton 2015-01-07 10:30 ` Christoph Hellwig 2015-01-07 10:30 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 03/18] nfsd: factor out a helper to decode nfstime4 values Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig [not found] ` <1420561721-9150-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-09 23:02 ` Tom Haynes 2015-01-09 23:02 ` Tom Haynes 2015-01-09 23:02 ` Tom Haynes 2015-01-11 11:42 ` Christoph Hellwig 2015-01-11 11:42 ` Christoph Hellwig [not found] ` <20150111114242.GA11939-jcswGhMUV9g@public.gmane.org> 2015-01-11 23:53 ` Tom Haynes 2015-01-11 23:53 ` Tom Haynes 2015-01-11 23:53 ` Tom Haynes 2015-01-06 16:28 ` [PATCH 04/18] nfsd: move nfsd_fh_match to nfsfh.h Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 05/18] nfsd: add fh_fsid_match helper Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 06/18] nfsd: make lookup/alloc/unhash_stid available outside nfs4state.c Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 07/18] nfsd: make find/get/put file " Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig [not found] ` <1420561721-9150-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-06 16:28 ` [PATCH 08/18] nfsd: make find_any_file " Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 10/18] nfsd: implement pNFS layout recalls Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig [not found] ` <1420561721-9150-11-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-06 17:25 ` J. Bruce Fields 2015-01-06 17:25 ` J. Bruce Fields 2015-01-06 17:25 ` J. Bruce Fields 2015-01-06 17:42 ` Christoph Hellwig 2015-01-06 17:42 ` Christoph Hellwig [not found] ` <20150106174214.GB16200-jcswGhMUV9g@public.gmane.org> 2015-01-06 17:59 ` Tom Haynes 2015-01-06 17:59 ` Tom Haynes 2015-01-06 17:59 ` Tom Haynes 2015-01-06 16:28 ` [PATCH 11/18] nfsd: update documentation for pNFS support Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 12/18] nfsd: add trace events Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 14/18] nfsd: pNFS block layout driver Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 17:16 ` J. Bruce Fields 2015-01-06 17:16 ` J. Bruce Fields 2015-01-06 17:39 ` Christoph Hellwig 2015-01-06 17:39 ` Christoph Hellwig 2015-01-06 19:39 ` J. Bruce Fields 2015-01-06 19:39 ` J. Bruce Fields [not found] ` <20150106193949.GD28003-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> 2015-01-06 19:42 ` Jeff Layton 2015-01-06 19:42 ` Jeff Layton 2015-01-06 19:42 ` Jeff Layton 2015-01-07 10:28 ` Christoph Hellwig 2015-01-07 10:28 ` Christoph Hellwig 2015-01-08 20:41 ` Jeff Layton 2015-01-08 20:41 ` Jeff Layton 2015-01-08 20:54 ` J. Bruce Fields 2015-01-08 20:54 ` J. Bruce Fields [not found] ` <1420561721-9150-15-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-12 4:56 ` Tom Haynes 2015-01-12 4:56 ` Tom Haynes 2015-01-12 4:56 ` Tom Haynes 2015-01-12 12:43 ` Christoph Hellwig 2015-01-12 12:43 ` Christoph Hellwig 2015-01-12 6:14 ` Tom Haynes 2015-01-12 6:14 ` Tom Haynes 2015-01-12 12:46 ` Christoph Hellwig 2015-01-12 12:46 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 15/18] xfs: pass a 64-bit count argument to xfs_iomap_write_unwritten Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 16/18] xfs: do not allocate blocks when converting unwritten extents Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 23:21 ` Dave Chinner 2015-01-06 23:21 ` Dave Chinner 2015-01-06 16:28 ` [PATCH 17/18] xfs: implement pnfs export operations Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-07 0:24 ` Dave Chinner 2015-01-07 0:24 ` Dave Chinner 2015-01-07 10:40 ` Christoph Hellwig 2015-01-07 10:40 ` Christoph Hellwig 2015-01-07 10:40 ` Christoph Hellwig 2015-01-07 21:11 ` Dave Chinner 2015-01-07 21:11 ` Dave Chinner 2015-01-07 21:11 ` Dave Chinner 2015-01-08 12:43 ` Christoph Hellwig 2015-01-08 12:43 ` Christoph Hellwig 2015-01-08 21:04 ` Dave Chinner 2015-01-08 21:04 ` Dave Chinner 2015-01-09 11:41 ` Christoph Hellwig 2015-01-09 11:41 ` Christoph Hellwig [not found] ` <20150109114159.GA25728-jcswGhMUV9g@public.gmane.org> 2015-01-12 3:04 ` Dave Chinner 2015-01-12 3:04 ` Dave Chinner 2015-01-12 3:04 ` Dave Chinner 2015-01-14 10:08 ` Christoph Hellwig 2015-01-14 10:08 ` Christoph Hellwig 2015-01-14 10:08 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 09/18] nfsd: implement pNFS operations Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig [not found] ` <1420561721-9150-10-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-09 0:48 ` Jeff Layton 2015-01-09 0:48 ` Jeff Layton 2015-01-09 0:48 ` Jeff Layton 2015-01-09 10:05 ` Christoph Hellwig 2015-01-09 10:05 ` Christoph Hellwig 2015-01-09 16:51 ` Jeff Layton 2015-01-09 16:51 ` Jeff Layton 2015-01-09 17:16 ` Christoph Hellwig 2015-01-09 17:16 ` Christoph Hellwig 2015-01-09 17:28 ` Jeff Layton [this message] 2015-01-09 17:28 ` Jeff Layton 2015-01-09 17:33 ` Jeff Layton 2015-01-09 17:33 ` Jeff Layton 2015-01-09 17:43 ` Trond Myklebust 2015-01-09 17:43 ` Trond Myklebust 2015-01-09 18:49 ` rfc5661 errata 3901, was: " Christoph Hellwig 2015-01-14 19:16 ` Tom Haynes 2015-01-15 16:26 ` Christoph Hellwig 2015-01-15 16:30 ` [nfsv4] " Trond Myklebust 2015-01-12 17:54 ` Tom Haynes 2015-01-12 17:54 ` Tom Haynes 2015-01-12 17:54 ` Tom Haynes 2015-01-06 16:28 ` [PATCH 13/18] exportfs: add methods for block layout exports Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig 2015-01-06 16:28 ` [PATCH 18/18] xfs: recall pNFS layouts on conflicting access Christoph Hellwig 2015-01-06 16:28 ` Christoph Hellwig [not found] ` <1420561721-9150-19-git-send-email-hch-jcswGhMUV9g@public.gmane.org> 2015-01-06 23:18 ` Dave Chinner 2015-01-06 23:18 ` Dave Chinner 2015-01-06 23:18 ` Dave Chinner 2015-01-07 10:31 ` Christoph Hellwig 2015-01-07 10:31 ` Christoph Hellwig 2015-01-06 17:32 ` a simple and scalable pNFS block layout server J. Bruce Fields 2015-01-06 17:32 ` J. Bruce Fields 2015-01-06 17:56 ` Christoph Hellwig 2015-01-06 17:56 ` Christoph Hellwig [not found] ` <20150106175611.GA16413-jcswGhMUV9g@public.gmane.org> 2015-01-06 18:37 ` Jeff Layton 2015-01-06 18:37 ` Jeff Layton 2015-01-06 18:37 ` Jeff Layton 2015-01-06 18:39 ` Weston Andros Adamson 2015-01-06 18:39 ` Weston Andros Adamson 2015-01-06 18:39 ` Weston Andros Adamson 2015-01-06 19:17 ` J. Bruce Fields 2015-01-06 19:17 ` J. Bruce Fields 2015-01-06 19:17 ` J. Bruce Fields
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150109092835.5fdbac5d@synchrony.poochiereds.net \ --to=jeff.layton@primarydata.com \ --cc=bfields@fieldses.org \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=sachin.bhamare@primarydata.com \ --cc=thomas.haynes@primarydata.com \ --cc=trond.myklebust@primarydata.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.