[Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1 Compliant Controllers

[Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1 Compliant Controllers

[Anubhav Rakshit]

According to NVMe specifications Bits 15:08 represent Minor Version number.

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
---
 hw/block/nvme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index aa1ed98..26e69a7 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -813,7 +813,7 @@ static int nvme_init(PCIDevice *pci_dev)
     NVME_CAP_SET_CSS(n->bar.cap, 1);
     NVME_CAP_SET_MPSMAX(n->bar.cap, 4);

-    n->bar.vs = 0x00010001;
+    n->bar.vs = 0x00010100;
     n->bar.intmc = n->bar.intms = 0;

     for (i = 0; i < n->num_namespaces; i++) {
--
1.7.0.4

Re: [Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1 Compliant Controllers

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

On Thu, Jan 08, 2015 at 03:10:35PM +0530, Anubhav Rakshit wrote:
> 
> According to NVMe specifications Bits 15:08 represent Minor Version number.
> 
> Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
> ---
>  hw/block/nvme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I confirmed that the NVMe 1.1b specification wants 1000 and not 0001 for
the minor version.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]