All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 19:39 ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel, devicetree; +Cc: Baruch Siach

This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
one of the Digicolor series of SoCs, all sharing many of the same peripherals.
The code was tested on the CX92755 evaluation kit, AKA Equinox.

Uses attempting to try this code will most likely also want the UART/console
driver available from https://patchwork.kernel.org/patch/5515861/.

v2:

   * Remove .map_io assignment, debug_ll is enabled by default (Arnd Bergmann)

   * Migrate the irq driver to generic irq chip, simplifying the code somewhat
     (Arnd Bergmann)

   * Change the timer dt binding, so that the 'reg' property points to the
     first "Agent Communication" register. This should improve the chance of
     reusing this binding for other SoCs in this series.

   * Add the CONTROL() and COUNT() macros to the timer driver to make the code
     clearer.

   * Move arch/arm Kconfig changes from the clocksource driver patch to the
     base arch support patch to reduce dependency between them

v1:
   http://thread.gmane.org/gmane.linux.kernel/1855027

Baruch Siach (8):
  ARM: initial support for Conexant Digicolor CX92755 SoC
  ARM: digicolor: add low level debug support
  ARM: digicolor: add minimal device tree description
  irqchip: devicetree: document Conexant Digicolor irq binding
  irqchip: Conexant CX92755 interrupts controller driver
  clocksource: devicetree: document Conexant Digicolor timer binding
  clocksource: driver for Conexant Digicolor SoC timer
  ARM: devicetree: document supported Conexant Digicolor SoC

 .../devicetree/bindings/arm/digicolor.txt          |   6 +
 .../bindings/interrupt-controller/digicolor-ic.txt |  20 +++
 .../devicetree/bindings/timer/digicolor-timer.txt  |  18 +++
 arch/arm/Kconfig                                   |   2 +
 arch/arm/Kconfig.debug                             |  12 +-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/conexant_equinox.dts             |  67 +++++++++
 arch/arm/boot/dts/cx92755.dtsi                     | 103 +++++++++++++
 arch/arm/include/debug/digicolor.S                 |  35 +++++
 arch/arm/mach-digicolor/Kconfig                    |   5 +
 arch/arm/mach-digicolor/Makefile                   |   1 +
 arch/arm/mach-digicolor/digicolor.c                |  18 +++
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-digicolor.c              | 164 +++++++++++++++++++++
 drivers/irqchip/Makefile                           |   1 +
 drivers/irqchip/irq-digicolor.c                    | 112 ++++++++++++++
 16 files changed, 564 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
 create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi
 create mode 100644 arch/arm/include/debug/digicolor.S
 create mode 100644 arch/arm/mach-digicolor/Kconfig
 create mode 100644 arch/arm/mach-digicolor/Makefile
 create mode 100644 arch/arm/mach-digicolor/digicolor.c
 create mode 100644 drivers/clocksource/timer-digicolor.c
 create mode 100644 drivers/irqchip/irq-digicolor.c

-- 
2.1.4


^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 19:39 ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: Baruch Siach

This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
one of the Digicolor series of SoCs, all sharing many of the same peripherals.
The code was tested on the CX92755 evaluation kit, AKA Equinox.

Uses attempting to try this code will most likely also want the UART/console
driver available from https://patchwork.kernel.org/patch/5515861/.

v2:

   * Remove .map_io assignment, debug_ll is enabled by default (Arnd Bergmann)

   * Migrate the irq driver to generic irq chip, simplifying the code somewhat
     (Arnd Bergmann)

   * Change the timer dt binding, so that the 'reg' property points to the
     first "Agent Communication" register. This should improve the chance of
     reusing this binding for other SoCs in this series.

   * Add the CONTROL() and COUNT() macros to the timer driver to make the code
     clearer.

   * Move arch/arm Kconfig changes from the clocksource driver patch to the
     base arch support patch to reduce dependency between them

v1:
   http://thread.gmane.org/gmane.linux.kernel/1855027

Baruch Siach (8):
  ARM: initial support for Conexant Digicolor CX92755 SoC
  ARM: digicolor: add low level debug support
  ARM: digicolor: add minimal device tree description
  irqchip: devicetree: document Conexant Digicolor irq binding
  irqchip: Conexant CX92755 interrupts controller driver
  clocksource: devicetree: document Conexant Digicolor timer binding
  clocksource: driver for Conexant Digicolor SoC timer
  ARM: devicetree: document supported Conexant Digicolor SoC

 .../devicetree/bindings/arm/digicolor.txt          |   6 +
 .../bindings/interrupt-controller/digicolor-ic.txt |  20 +++
 .../devicetree/bindings/timer/digicolor-timer.txt  |  18 +++
 arch/arm/Kconfig                                   |   2 +
 arch/arm/Kconfig.debug                             |  12 +-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/conexant_equinox.dts             |  67 +++++++++
 arch/arm/boot/dts/cx92755.dtsi                     | 103 +++++++++++++
 arch/arm/include/debug/digicolor.S                 |  35 +++++
 arch/arm/mach-digicolor/Kconfig                    |   5 +
 arch/arm/mach-digicolor/Makefile                   |   1 +
 arch/arm/mach-digicolor/digicolor.c                |  18 +++
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-digicolor.c              | 164 +++++++++++++++++++++
 drivers/irqchip/Makefile                           |   1 +
 drivers/irqchip/irq-digicolor.c                    | 112 ++++++++++++++
 16 files changed, 564 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
 create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi
 create mode 100644 arch/arm/include/debug/digicolor.S
 create mode 100644 arch/arm/mach-digicolor/Kconfig
 create mode 100644 arch/arm/mach-digicolor/Makefile
 create mode 100644 arch/arm/mach-digicolor/digicolor.c
 create mode 100644 drivers/clocksource/timer-digicolor.c
 create mode 100644 drivers/irqchip/irq-digicolor.c

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 19:39 ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
one of the Digicolor series of SoCs, all sharing many of the same peripherals.
The code was tested on the CX92755 evaluation kit, AKA Equinox.

Uses attempting to try this code will most likely also want the UART/console
driver available from https://patchwork.kernel.org/patch/5515861/.

v2:

   * Remove .map_io assignment, debug_ll is enabled by default (Arnd Bergmann)

   * Migrate the irq driver to generic irq chip, simplifying the code somewhat
     (Arnd Bergmann)

   * Change the timer dt binding, so that the 'reg' property points to the
     first "Agent Communication" register. This should improve the chance of
     reusing this binding for other SoCs in this series.

   * Add the CONTROL() and COUNT() macros to the timer driver to make the code
     clearer.

   * Move arch/arm Kconfig changes from the clocksource driver patch to the
     base arch support patch to reduce dependency between them

v1:
   http://thread.gmane.org/gmane.linux.kernel/1855027

Baruch Siach (8):
  ARM: initial support for Conexant Digicolor CX92755 SoC
  ARM: digicolor: add low level debug support
  ARM: digicolor: add minimal device tree description
  irqchip: devicetree: document Conexant Digicolor irq binding
  irqchip: Conexant CX92755 interrupts controller driver
  clocksource: devicetree: document Conexant Digicolor timer binding
  clocksource: driver for Conexant Digicolor SoC timer
  ARM: devicetree: document supported Conexant Digicolor SoC

 .../devicetree/bindings/arm/digicolor.txt          |   6 +
 .../bindings/interrupt-controller/digicolor-ic.txt |  20 +++
 .../devicetree/bindings/timer/digicolor-timer.txt  |  18 +++
 arch/arm/Kconfig                                   |   2 +
 arch/arm/Kconfig.debug                             |  12 +-
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/conexant_equinox.dts             |  67 +++++++++
 arch/arm/boot/dts/cx92755.dtsi                     | 103 +++++++++++++
 arch/arm/include/debug/digicolor.S                 |  35 +++++
 arch/arm/mach-digicolor/Kconfig                    |   5 +
 arch/arm/mach-digicolor/Makefile                   |   1 +
 arch/arm/mach-digicolor/digicolor.c                |  18 +++
 drivers/clocksource/Makefile                       |   1 +
 drivers/clocksource/timer-digicolor.c              | 164 +++++++++++++++++++++
 drivers/irqchip/Makefile                           |   1 +
 drivers/irqchip/irq-digicolor.c                    | 112 ++++++++++++++
 16 files changed, 564 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
 create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi
 create mode 100644 arch/arm/include/debug/digicolor.S
 create mode 100644 arch/arm/mach-digicolor/Kconfig
 create mode 100644 arch/arm/mach-digicolor/Makefile
 create mode 100644 arch/arm/mach-digicolor/digicolor.c
 create mode 100644 drivers/clocksource/timer-digicolor.c
 create mode 100644 drivers/irqchip/irq-digicolor.c

-- 
2.1.4

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:39   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel, Russell King; +Cc: Baruch Siach, linux-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/Kconfig                    |  2 ++
 arch/arm/mach-digicolor/Kconfig     |  5 +++++
 arch/arm/mach-digicolor/Makefile    |  1 +
 arch/arm/mach-digicolor/digicolor.c | 18 ++++++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 arch/arm/mach-digicolor/Kconfig
 create mode 100644 arch/arm/mach-digicolor/Makefile
 create mode 100644 arch/arm/mach-digicolor/digicolor.c

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 97d07ed60a0b..86e2202565e6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -858,6 +858,8 @@ source "arch/arm/mach-cns3xxx/Kconfig"
 
 source "arch/arm/mach-davinci/Kconfig"
 
+source "arch/arm/mach-digicolor/Kconfig"
+
 source "arch/arm/mach-dove/Kconfig"
 
 source "arch/arm/mach-ep93xx/Kconfig"
diff --git a/arch/arm/mach-digicolor/Kconfig b/arch/arm/mach-digicolor/Kconfig
new file mode 100644
index 000000000000..5a0669a2738e
--- /dev/null
+++ b/arch/arm/mach-digicolor/Kconfig
@@ -0,0 +1,5 @@
+config ARCH_DIGICOLOR
+	bool "Conexant Digicolor SoC Support"
+	depends on ARCH_MULTI_V7
+	select CLKSRC_MMIO
+	select GENERIC_IRQ_CHIP
diff --git a/arch/arm/mach-digicolor/Makefile b/arch/arm/mach-digicolor/Makefile
new file mode 100644
index 000000000000..3d8a1d228408
--- /dev/null
+++ b/arch/arm/mach-digicolor/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_ARCH_DIGICOLOR)	+= digicolor.o
diff --git a/arch/arm/mach-digicolor/digicolor.c b/arch/arm/mach-digicolor/digicolor.c
new file mode 100644
index 000000000000..cfc88d1caa47
--- /dev/null
+++ b/arch/arm/mach-digicolor/digicolor.c
@@ -0,0 +1,18 @@
+/*
+ * Support for Conexant Digicolor SoCs
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <asm/mach/arch.h>
+
+static const char *digicolor_dt_compat[] __initconst = {
+	"cnxt,cx92755",
+	NULL,
+};
+
+DT_MACHINE_START(DIGICOLOR, "Conexant Digicolor (Flattened Device Tree)")
+	.dt_compat	= digicolor_dt_compat,
+MACHINE_END
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC
@ 2015-01-08 19:39   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/Kconfig                    |  2 ++
 arch/arm/mach-digicolor/Kconfig     |  5 +++++
 arch/arm/mach-digicolor/Makefile    |  1 +
 arch/arm/mach-digicolor/digicolor.c | 18 ++++++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 arch/arm/mach-digicolor/Kconfig
 create mode 100644 arch/arm/mach-digicolor/Makefile
 create mode 100644 arch/arm/mach-digicolor/digicolor.c

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 97d07ed60a0b..86e2202565e6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -858,6 +858,8 @@ source "arch/arm/mach-cns3xxx/Kconfig"
 
 source "arch/arm/mach-davinci/Kconfig"
 
+source "arch/arm/mach-digicolor/Kconfig"
+
 source "arch/arm/mach-dove/Kconfig"
 
 source "arch/arm/mach-ep93xx/Kconfig"
diff --git a/arch/arm/mach-digicolor/Kconfig b/arch/arm/mach-digicolor/Kconfig
new file mode 100644
index 000000000000..5a0669a2738e
--- /dev/null
+++ b/arch/arm/mach-digicolor/Kconfig
@@ -0,0 +1,5 @@
+config ARCH_DIGICOLOR
+	bool "Conexant Digicolor SoC Support"
+	depends on ARCH_MULTI_V7
+	select CLKSRC_MMIO
+	select GENERIC_IRQ_CHIP
diff --git a/arch/arm/mach-digicolor/Makefile b/arch/arm/mach-digicolor/Makefile
new file mode 100644
index 000000000000..3d8a1d228408
--- /dev/null
+++ b/arch/arm/mach-digicolor/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_ARCH_DIGICOLOR)	+= digicolor.o
diff --git a/arch/arm/mach-digicolor/digicolor.c b/arch/arm/mach-digicolor/digicolor.c
new file mode 100644
index 000000000000..cfc88d1caa47
--- /dev/null
+++ b/arch/arm/mach-digicolor/digicolor.c
@@ -0,0 +1,18 @@
+/*
+ * Support for Conexant Digicolor SoCs
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <asm/mach/arch.h>
+
+static const char *digicolor_dt_compat[] __initconst = {
+	"cnxt,cx92755",
+	NULL,
+};
+
+DT_MACHINE_START(DIGICOLOR, "Conexant Digicolor (Flattened Device Tree)")
+	.dt_compat	= digicolor_dt_compat,
+MACHINE_END
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 2/8] ARM: digicolor: add low level debug support
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:39   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel, Russell King; +Cc: Baruch Siach, linux-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/Kconfig.debug             | 12 ++++++++++--
 arch/arm/include/debug/digicolor.S | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/debug/digicolor.S

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 5ddd4906f7a7..7ccab0629dd2 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -241,6 +241,13 @@ choice
 		  Say Y here if you want the debug print routines to direct
 		  their output to the serial port in the DC21285 (Footbridge).
 
+	config DEBUG_DIGICOLOR_UA0
+		bool "Kernel low-level debugging messages via Digicolor UA0"
+		depends on ARCH_DIGICOLOR
+		help
+		  Say Y here if you want the debug print routines to direct
+		  their output to the UA0 serial port in the CX92755.
+
 	config DEBUG_FOOTBRIDGE_COM1
 		bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1"
 		depends on FOOTBRIDGE
@@ -1204,6 +1211,7 @@ config DEBUG_LL_INCLUDE
 	default "debug/vt8500.S" if DEBUG_VT8500_UART0
 	default "debug/zynq.S" if DEBUG_ZYNQ_UART0 || DEBUG_ZYNQ_UART1
 	default "debug/bcm63xx.S" if DEBUG_UART_BCM63XX
+	default "debug/digicolor.S" if DEBUG_DIGICOLOR_UA0
 	default "mach/debug-macro.S"
 
 # Compatibility options for PL01x
@@ -1320,7 +1328,7 @@ config DEBUG_UART_PHYS
 		DEBUG_RCAR_GEN2_SCIF0 || DEBUG_RCAR_GEN2_SCIF2 || \
 		DEBUG_RMOBILE_SCIFA0 || DEBUG_RMOBILE_SCIFA1 || \
 		DEBUG_RMOBILE_SCIFA4 || DEBUG_S3C24XX_UART || \
-		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART
+		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART || DEBUG_DIGICOLOR_UA0
 
 config DEBUG_UART_VIRT
 	hex "Virtual base address of debug UART"
@@ -1398,7 +1406,7 @@ config DEBUG_UART_VIRT
 	depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
 		DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \
 		DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART || \
-		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART
+		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART || DEBUG_DIGICOLOR_UA0
 
 config DEBUG_UART_8250_SHIFT
 	int "Register offset shift for the 8250 debug UART"
diff --git a/arch/arm/include/debug/digicolor.S b/arch/arm/include/debug/digicolor.S
new file mode 100644
index 000000000000..c9517150766a
--- /dev/null
+++ b/arch/arm/include/debug/digicolor.S
@@ -0,0 +1,35 @@
+/*
+ * Debugging macro include header for Conexant Digicolor USART
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+*/
+
+#define UA0_STATUS	0x0742
+#define UA0_EMI_REC	0x0744
+
+#define UA0_STATUS_TX_READY	0x40
+
+#ifdef CONFIG_DEBUG_UART_PHYS
+		.macro	addruart, rp, rv, tmp
+		ldr	\rp, =CONFIG_DEBUG_UART_PHYS
+		ldr	\rv, =CONFIG_DEBUG_UART_VIRT
+		.endm
+#endif
+
+		.macro	senduart,rd,rx
+		strb	\rd, [\rx, #UA0_EMI_REC]
+		.endm
+
+		.macro	waituart,rd,rx
+		.endm
+
+	.macro	busyuart,rd,rx
+1001:		ldrb	\rd, [\rx, #UA0_STATUS]
+		tst	\rd, #UA0_STATUS_TX_READY
+		beq	1001b
+		.endm
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 2/8] ARM: digicolor: add low level debug support
@ 2015-01-08 19:39   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/Kconfig.debug             | 12 ++++++++++--
 arch/arm/include/debug/digicolor.S | 35 +++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/debug/digicolor.S

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 5ddd4906f7a7..7ccab0629dd2 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -241,6 +241,13 @@ choice
 		  Say Y here if you want the debug print routines to direct
 		  their output to the serial port in the DC21285 (Footbridge).
 
+	config DEBUG_DIGICOLOR_UA0
+		bool "Kernel low-level debugging messages via Digicolor UA0"
+		depends on ARCH_DIGICOLOR
+		help
+		  Say Y here if you want the debug print routines to direct
+		  their output to the UA0 serial port in the CX92755.
+
 	config DEBUG_FOOTBRIDGE_COM1
 		bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1"
 		depends on FOOTBRIDGE
@@ -1204,6 +1211,7 @@ config DEBUG_LL_INCLUDE
 	default "debug/vt8500.S" if DEBUG_VT8500_UART0
 	default "debug/zynq.S" if DEBUG_ZYNQ_UART0 || DEBUG_ZYNQ_UART1
 	default "debug/bcm63xx.S" if DEBUG_UART_BCM63XX
+	default "debug/digicolor.S" if DEBUG_DIGICOLOR_UA0
 	default "mach/debug-macro.S"
 
 # Compatibility options for PL01x
@@ -1320,7 +1328,7 @@ config DEBUG_UART_PHYS
 		DEBUG_RCAR_GEN2_SCIF0 || DEBUG_RCAR_GEN2_SCIF2 || \
 		DEBUG_RMOBILE_SCIFA0 || DEBUG_RMOBILE_SCIFA1 || \
 		DEBUG_RMOBILE_SCIFA4 || DEBUG_S3C24XX_UART || \
-		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART
+		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART || DEBUG_DIGICOLOR_UA0
 
 config DEBUG_UART_VIRT
 	hex "Virtual base address of debug UART"
@@ -1398,7 +1406,7 @@ config DEBUG_UART_VIRT
 	depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
 		DEBUG_UART_8250 || DEBUG_UART_PL01X || DEBUG_MESON_UARTAO || \
 		DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART || \
-		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART
+		DEBUG_UART_BCM63XX || DEBUG_ASM9260_UART || DEBUG_DIGICOLOR_UA0
 
 config DEBUG_UART_8250_SHIFT
 	int "Register offset shift for the 8250 debug UART"
diff --git a/arch/arm/include/debug/digicolor.S b/arch/arm/include/debug/digicolor.S
new file mode 100644
index 000000000000..c9517150766a
--- /dev/null
+++ b/arch/arm/include/debug/digicolor.S
@@ -0,0 +1,35 @@
+/*
+ * Debugging macro include header for Conexant Digicolor USART
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+*/
+
+#define UA0_STATUS	0x0742
+#define UA0_EMI_REC	0x0744
+
+#define UA0_STATUS_TX_READY	0x40
+
+#ifdef CONFIG_DEBUG_UART_PHYS
+		.macro	addruart, rp, rv, tmp
+		ldr	\rp, =CONFIG_DEBUG_UART_PHYS
+		ldr	\rv, =CONFIG_DEBUG_UART_VIRT
+		.endm
+#endif
+
+		.macro	senduart,rd,rx
+		strb	\rd, [\rx, #UA0_EMI_REC]
+		.endm
+
+		.macro	waituart,rd,rx
+		.endm
+
+	.macro	busyuart,rd,rx
+1001:		ldrb	\rd, [\rx, #UA0_STATUS]
+		tst	\rd, #UA0_STATUS_TX_READY
+		beq	1001b
+		.endm
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:39   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala
  Cc: Baruch Siach, Russell King, devicetree, linux-kernel

cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
describes the Equinox evaluation board for the CX92755 SoC.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
 arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
 3 files changed, 171 insertions(+)
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 91bd5bd62857..fbeb65eaddda 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
 	da850-evm.dtb
+dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
 dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
 	exynos3250-rinato.dtb \
diff --git a/arch/arm/boot/dts/conexant_equinox.dts b/arch/arm/boot/dts/conexant_equinox.dts
new file mode 100644
index 000000000000..b2917d914740
--- /dev/null
+++ b/arch/arm/boot/dts/conexant_equinox.dts
@@ -0,0 +1,67 @@
+/*
+ * Device Tree file for the Conexant Equinox CX92755 EVK
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include "cx92755.dtsi"
+
+/ {
+	model = "Conexant Equinox CX92755 EVK";
+	compatible = "cnxt,equinox", "cnxt,cx92755";
+
+	memory@0 {
+		reg = <0 0x8000000>;
+		device_type = "memory";
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/cx92755.dtsi b/arch/arm/boot/dts/cx92755.dtsi
new file mode 100644
index 000000000000..4088e8974b4b
--- /dev/null
+++ b/arch/arm/boot/dts/cx92755.dtsi
@@ -0,0 +1,103 @@
+/*
+ * Device Tree Include file for the Conexant Digicolor CX92755 SoC
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "skeleton.dtsi"
+
+/ {
+	compatible = "cnxt,cx92755";
+
+	interrupt-parent = <&intc>;
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+	};
+
+	main_clk: main_clk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency  = <200000000>;
+	};
+
+	intc: intc@f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+
+	timer@f0000fc0 {
+		compatible = "cnxt,cx92755-timer";
+		reg = <0xf0000fc0 0x40>;
+		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
+		clocks = <&main_clk>;
+	};
+
+	uart0: uart@f0000740 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000740 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <44>;
+		status = "disabled";
+	};
+
+	uart1: uart@f0000760 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000760 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <45>;
+		status = "disabled";
+	};
+
+	uart2: uart@f0000780 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000780 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <46>;
+		status = "disabled";
+	};
+};
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-08 19:39   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:39 UTC (permalink / raw)
  To: linux-arm-kernel

cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
describes the Equinox evaluation board for the CX92755 SoC.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
 arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
 3 files changed, 171 insertions(+)
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 91bd5bd62857..fbeb65eaddda 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
 	da850-evm.dtb
+dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
 dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
 	exynos3250-rinato.dtb \
diff --git a/arch/arm/boot/dts/conexant_equinox.dts b/arch/arm/boot/dts/conexant_equinox.dts
new file mode 100644
index 000000000000..b2917d914740
--- /dev/null
+++ b/arch/arm/boot/dts/conexant_equinox.dts
@@ -0,0 +1,67 @@
+/*
+ * Device Tree file for the Conexant Equinox CX92755 EVK
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include "cx92755.dtsi"
+
+/ {
+	model = "Conexant Equinox CX92755 EVK";
+	compatible = "cnxt,equinox", "cnxt,cx92755";
+
+	memory at 0 {
+		reg = <0 0x8000000>;
+		device_type = "memory";
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/cx92755.dtsi b/arch/arm/boot/dts/cx92755.dtsi
new file mode 100644
index 000000000000..4088e8974b4b
--- /dev/null
+++ b/arch/arm/boot/dts/cx92755.dtsi
@@ -0,0 +1,103 @@
+/*
+ * Device Tree Include file for the Conexant Digicolor CX92755 SoC
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "skeleton.dtsi"
+
+/ {
+	compatible = "cnxt,cx92755";
+
+	interrupt-parent = <&intc>;
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+	};
+
+	main_clk: main_clk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency  = <200000000>;
+	};
+
+	intc: intc at f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+
+	timer at f0000fc0 {
+		compatible = "cnxt,cx92755-timer";
+		reg = <0xf0000fc0 0x40>;
+		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
+		clocks = <&main_clk>;
+	};
+
+	uart0: uart at f0000740 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000740 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <44>;
+		status = "disabled";
+	};
+
+	uart1: uart at f0000760 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000760 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <45>;
+		status = "disabled";
+	};
+
+	uart2: uart at f0000780 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000780 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <46>;
+		status = "disabled";
+	};
+};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:40   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel, Thomas Gleixner, Jason Cooper
  Cc: Baruch Siach, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, linux-kernel, devicetree

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
new file mode 100644
index 000000000000..fdf9a4c59bf3
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
@@ -0,0 +1,20 @@
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-ic"
+- reg : Specifies base physical address and size of the MISC area, that is
+  where the interrupt controller registers are located
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an
+  interrupt source. The value shall be 1.
+
+Example:
+
+	intc: intc@f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-08 19:40   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
new file mode 100644
index 000000000000..fdf9a4c59bf3
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
@@ -0,0 +1,20 @@
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-ic"
+- reg : Specifies base physical address and size of the MISC area, that is
+  where the interrupt controller registers are located
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an
+  interrupt source. The value shall be 1.
+
+Example:
+
+	intc: intc at f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 5/8] irqchip: Conexant CX92755 interrupts controller driver
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:40   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel, Thomas Gleixner, Jason Cooper
  Cc: Baruch Siach, linux-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/irqchip/Makefile        |   1 +
 drivers/irqchip/irq-digicolor.c | 112 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+)
 create mode 100644 drivers/irqchip/irq-digicolor.c

diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 9516a324be6d..42965d2476bb 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -42,3 +42,4 @@ obj-$(CONFIG_BRCMSTB_L2_IRQ)		+= irq-brcmstb-l2.o
 obj-$(CONFIG_KEYSTONE_IRQ)		+= irq-keystone.o
 obj-$(CONFIG_MIPS_GIC)			+= irq-mips-gic.o
 obj-$(CONFIG_ARCH_MEDIATEK)		+= irq-mtk-sysirq.o
+obj-$(CONFIG_ARCH_DIGICOLOR)		+= irq-digicolor.o
diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
new file mode 100644
index 000000000000..8fcb82e8527e
--- /dev/null
+++ b/drivers/irqchip/irq-digicolor.c
@@ -0,0 +1,112 @@
+/*
+ * Conexant Digicolor SoCs IRQ chip driver
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/io.h>
+#include <linux/irq.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+
+#include <asm/exception.h>
+
+#include "irqchip.h"
+
+#define UC_IRQ_CONTROL		0x03a4
+
+#define IC_FLAG_CLEAR_LO	0x40
+#define IC_FLAG_CLEAR_XLO	0x44
+#define IC_INT0ENABLE_LO	0x50
+#define IC_INT0ENABLE_XLO	0x54
+#define IC_INT0STATUS_LO	0x58
+#define IC_INT0STATUS_XLO	0x5c
+
+static struct irq_domain *digicolor_irq_domain;
+
+static void __exception_irq_entry digicolor_handle_irq(struct pt_regs *regs)
+{
+	struct irq_domain_chip_generic *dgc = digicolor_irq_domain->gc;
+	struct irq_chip_generic *gc = dgc->gc[0];
+	u32 status, hwirq;
+
+	do {
+		status = irq_reg_readl(gc, IC_INT0STATUS_LO);
+		if (status) {
+			hwirq = ffs(status) - 1;
+		} else {
+			status = irq_reg_readl(gc, IC_INT0STATUS_XLO);
+			if (status)
+				hwirq = ffs(status) - 1 + 32;
+			else
+				return;
+		}
+
+		handle_domain_irq(digicolor_irq_domain, hwirq, regs);
+	} while (1);
+}
+
+static void digicolor_set_gc(void __iomem *reg_base, unsigned irq_base,
+			     unsigned en_reg, unsigned ack_reg)
+{
+	struct irq_chip_generic *gc;
+
+	gc = irq_get_domain_generic_chip(digicolor_irq_domain, irq_base);
+	gc->reg_base = reg_base;
+	gc->chip_types[0].regs.ack = ack_reg;
+	gc->chip_types[0].regs.mask = en_reg;
+	gc->chip_types[0].chip.irq_ack = irq_gc_ack_set_bit;
+	gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit;
+	gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;
+}
+
+static int __init digicolor_of_init(struct device_node *node,
+				struct device_node *parent)
+{
+	static void __iomem *reg_base;
+	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
+	int ret;
+
+	reg_base = of_iomap(node, 0);
+	if (!reg_base) {
+		pr_err("%s: unable to map IC registers\n", node->full_name);
+		return -ENXIO;
+	}
+
+	/* disable all interrupts */
+	writel(0, reg_base + IC_INT0ENABLE_LO);
+	writel(0, reg_base + IC_INT0ENABLE_XLO);
+
+	/* channel 1, regular IRQs */
+	writeb(1, reg_base + UC_IRQ_CONTROL);
+
+	digicolor_irq_domain =
+		irq_domain_add_linear(node, 64, &irq_generic_chip_ops, NULL);
+	if (!digicolor_irq_domain) {
+		pr_err("%s: unable to create IRQ domain\n", node->full_name);
+		return -ENOMEM;
+	}
+
+	ret = irq_alloc_domain_generic_chips(digicolor_irq_domain, 32, 1,
+					     "digicolor_irq", handle_level_irq,
+					     clr, 0, 0);
+	if (ret) {
+		pr_err("%s: unable to allocate IRQ gc\n", node->full_name);
+		return ret;
+	}
+
+	digicolor_set_gc(reg_base, 0, IC_INT0ENABLE_LO, IC_FLAG_CLEAR_LO);
+	digicolor_set_gc(reg_base, 32, IC_INT0ENABLE_XLO, IC_FLAG_CLEAR_XLO);
+
+	set_handle_irq(digicolor_handle_irq);
+
+	return 0;
+}
+IRQCHIP_DECLARE(conexant_digicolor_ic, "cnxt,cx92755-ic", digicolor_of_init);
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 5/8] irqchip: Conexant CX92755 interrupts controller driver
@ 2015-01-08 19:40   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/irqchip/Makefile        |   1 +
 drivers/irqchip/irq-digicolor.c | 112 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+)
 create mode 100644 drivers/irqchip/irq-digicolor.c

diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 9516a324be6d..42965d2476bb 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -42,3 +42,4 @@ obj-$(CONFIG_BRCMSTB_L2_IRQ)		+= irq-brcmstb-l2.o
 obj-$(CONFIG_KEYSTONE_IRQ)		+= irq-keystone.o
 obj-$(CONFIG_MIPS_GIC)			+= irq-mips-gic.o
 obj-$(CONFIG_ARCH_MEDIATEK)		+= irq-mtk-sysirq.o
+obj-$(CONFIG_ARCH_DIGICOLOR)		+= irq-digicolor.o
diff --git a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
new file mode 100644
index 000000000000..8fcb82e8527e
--- /dev/null
+++ b/drivers/irqchip/irq-digicolor.c
@@ -0,0 +1,112 @@
+/*
+ * Conexant Digicolor SoCs IRQ chip driver
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/io.h>
+#include <linux/irq.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+
+#include <asm/exception.h>
+
+#include "irqchip.h"
+
+#define UC_IRQ_CONTROL		0x03a4
+
+#define IC_FLAG_CLEAR_LO	0x40
+#define IC_FLAG_CLEAR_XLO	0x44
+#define IC_INT0ENABLE_LO	0x50
+#define IC_INT0ENABLE_XLO	0x54
+#define IC_INT0STATUS_LO	0x58
+#define IC_INT0STATUS_XLO	0x5c
+
+static struct irq_domain *digicolor_irq_domain;
+
+static void __exception_irq_entry digicolor_handle_irq(struct pt_regs *regs)
+{
+	struct irq_domain_chip_generic *dgc = digicolor_irq_domain->gc;
+	struct irq_chip_generic *gc = dgc->gc[0];
+	u32 status, hwirq;
+
+	do {
+		status = irq_reg_readl(gc, IC_INT0STATUS_LO);
+		if (status) {
+			hwirq = ffs(status) - 1;
+		} else {
+			status = irq_reg_readl(gc, IC_INT0STATUS_XLO);
+			if (status)
+				hwirq = ffs(status) - 1 + 32;
+			else
+				return;
+		}
+
+		handle_domain_irq(digicolor_irq_domain, hwirq, regs);
+	} while (1);
+}
+
+static void digicolor_set_gc(void __iomem *reg_base, unsigned irq_base,
+			     unsigned en_reg, unsigned ack_reg)
+{
+	struct irq_chip_generic *gc;
+
+	gc = irq_get_domain_generic_chip(digicolor_irq_domain, irq_base);
+	gc->reg_base = reg_base;
+	gc->chip_types[0].regs.ack = ack_reg;
+	gc->chip_types[0].regs.mask = en_reg;
+	gc->chip_types[0].chip.irq_ack = irq_gc_ack_set_bit;
+	gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit;
+	gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;
+}
+
+static int __init digicolor_of_init(struct device_node *node,
+				struct device_node *parent)
+{
+	static void __iomem *reg_base;
+	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
+	int ret;
+
+	reg_base = of_iomap(node, 0);
+	if (!reg_base) {
+		pr_err("%s: unable to map IC registers\n", node->full_name);
+		return -ENXIO;
+	}
+
+	/* disable all interrupts */
+	writel(0, reg_base + IC_INT0ENABLE_LO);
+	writel(0, reg_base + IC_INT0ENABLE_XLO);
+
+	/* channel 1, regular IRQs */
+	writeb(1, reg_base + UC_IRQ_CONTROL);
+
+	digicolor_irq_domain =
+		irq_domain_add_linear(node, 64, &irq_generic_chip_ops, NULL);
+	if (!digicolor_irq_domain) {
+		pr_err("%s: unable to create IRQ domain\n", node->full_name);
+		return -ENOMEM;
+	}
+
+	ret = irq_alloc_domain_generic_chips(digicolor_irq_domain, 32, 1,
+					     "digicolor_irq", handle_level_irq,
+					     clr, 0, 0);
+	if (ret) {
+		pr_err("%s: unable to allocate IRQ gc\n", node->full_name);
+		return ret;
+	}
+
+	digicolor_set_gc(reg_base, 0, IC_INT0ENABLE_LO, IC_FLAG_CLEAR_LO);
+	digicolor_set_gc(reg_base, 32, IC_INT0ENABLE_XLO, IC_FLAG_CLEAR_XLO);
+
+	set_handle_irq(digicolor_handle_irq);
+
+	return 0;
+}
+IRQCHIP_DECLARE(conexant_digicolor_ic, "cnxt,cx92755-ic", digicolor_of_init);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 6/8] clocksource: devicetree: document Conexant Digicolor timer binding
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:40   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel
  Cc: Baruch Siach, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../devicetree/bindings/timer/digicolor-timer.txt      | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt

diff --git a/Documentation/devicetree/bindings/timer/digicolor-timer.txt b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
new file mode 100644
index 000000000000..d1b659bbc29f
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
@@ -0,0 +1,18 @@
+Conexant Digicolor SoCs Timer Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-timer"
+- reg : Specifies base physical address and size of the "Agent Communication"
+  timer registers
+- interrupts : Contains 8 interrupts, one for each timer
+- clocks: phandle to the main clock
+
+Example:
+
+	timer@f0000fc0 {
+		compatible = "cnxt,cx92755-timer";
+		reg = <0xf0000fc0 0x40>;
+		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
+		clocks = <&main_clk>;
+	};
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 6/8] clocksource: devicetree: document Conexant Digicolor timer binding
@ 2015-01-08 19:40   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../devicetree/bindings/timer/digicolor-timer.txt      | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt

diff --git a/Documentation/devicetree/bindings/timer/digicolor-timer.txt b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
new file mode 100644
index 000000000000..d1b659bbc29f
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/digicolor-timer.txt
@@ -0,0 +1,18 @@
+Conexant Digicolor SoCs Timer Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-timer"
+- reg : Specifies base physical address and size of the "Agent Communication"
+  timer registers
+- interrupts : Contains 8 interrupts, one for each timer
+- clocks: phandle to the main clock
+
+Example:
+
+	timer at f0000fc0 {
+		compatible = "cnxt,cx92755-timer";
+		reg = <0xf0000fc0 0x40>;
+		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
+		clocks = <&main_clk>;
+	};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 7/8] clocksource: driver for Conexant Digicolor SoC timer
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:40   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel, Daniel Lezcano, Thomas Gleixner
  Cc: Baruch Siach, linux-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/clocksource/Makefile          |   1 +
 drivers/clocksource/timer-digicolor.c | 164 ++++++++++++++++++++++++++++++++++
 2 files changed, 165 insertions(+)
 create mode 100644 drivers/clocksource/timer-digicolor.c

diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 94d90b24b56b..a993c108be67 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU)	+= sh_tmu.o
 obj-$(CONFIG_EM_TIMER_STI)	+= em_sti.o
 obj-$(CONFIG_CLKBLD_I8253)	+= i8253.o
 obj-$(CONFIG_CLKSRC_MMIO)	+= mmio.o
+obj-$(CONFIG_ARCH_DIGICOLOR)	+= timer-digicolor.o
 obj-$(CONFIG_DW_APB_TIMER)	+= dw_apb_timer.o
 obj-$(CONFIG_DW_APB_TIMER_OF)	+= dw_apb_timer_of.o
 obj-$(CONFIG_CLKSRC_NOMADIK_MTU)	+= nomadik-mtu.o
diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
new file mode 100644
index 000000000000..014c50675980
--- /dev/null
+++ b/drivers/clocksource/timer-digicolor.c
@@ -0,0 +1,164 @@
+/*
+ * Conexant Digicolor timer driver
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * Based on:
+ *	Allwinner SoCs hstimer driver
+ *
+ * Copyright (C) 2013 Maxime Ripard
+ *
+ * Maxime Ripard <maxime.ripard@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/*
+ * Conexant Digicolor SoCs have 8 configurable timers, named from "Timer A" to
+ * "Timer H". Timer A is the only one with watchdog support, so it is dedicated
+ * to the watchdog driver. This driver uses Timer B for sched_clock(), and
+ * Timer C for clockevents.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/clk.h>
+#include <linux/clockchips.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/irqreturn.h>
+#include <linux/sched_clock.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+
+enum {
+	TIMER_A,
+	TIMER_B,
+	TIMER_C,
+	TIMER_D,
+	TIMER_E,
+	TIMER_F,
+	TIMER_G,
+	TIMER_H,
+};
+
+#define CONTROL(t)	((t)*8)
+#define COUNT(t)	((t)*8 + 4)
+
+static void __iomem *timer_base;
+static u32 ticks_per_jiffy;
+
+static void digicolor_clkevt_mode(enum clock_event_mode mode,
+				  struct clock_event_device *clk)
+{
+	switch (mode) {
+	case CLOCK_EVT_MODE_PERIODIC:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		writel(ticks_per_jiffy, timer_base + COUNT(TIMER_C));
+		writeb(0x21, timer_base + CONTROL(TIMER_C));
+		break;
+	case CLOCK_EVT_MODE_ONESHOT:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		writeb(0x11, timer_base + CONTROL(TIMER_C));
+		break;
+	case CLOCK_EVT_MODE_UNUSED:
+	case CLOCK_EVT_MODE_SHUTDOWN:
+	default:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		break;
+	}
+}
+
+static int digicolor_clkevt_next_event(unsigned long evt,
+				       struct clock_event_device *unused)
+{
+	writeb(0, timer_base + CONTROL(TIMER_C));
+	writel(evt, timer_base + COUNT(TIMER_C));
+	writeb(0x11, timer_base + CONTROL(TIMER_C));
+
+	return 0;
+}
+
+static struct clock_event_device digicolor_clockevent = {
+	.name = "digicolor_tick",
+	.rating = 340,
+	.features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
+	.set_mode = digicolor_clkevt_mode,
+	.set_next_event = digicolor_clkevt_next_event,
+};
+
+
+static irqreturn_t digicolor_timer_interrupt(int irq, void *dev_id)
+{
+	struct clock_event_device *evt = (struct clock_event_device *)dev_id;
+
+	evt->event_handler(evt);
+
+	return IRQ_HANDLED;
+}
+
+static struct irqaction digicolor_timer_irq = {
+	.name = "digicolor_timerC",
+	.flags = IRQF_TIMER | IRQF_IRQPOLL,
+	.handler = digicolor_timer_interrupt,
+	.dev_id = &digicolor_clockevent,
+};
+
+static u64 digicolor_timer_sched_read(void)
+{
+	return ~readl(timer_base + COUNT(TIMER_B));
+}
+
+static void __init digicolor_timer_init(struct device_node *node)
+{
+	unsigned long rate;
+	struct clk *clk;
+	int ret, irq;
+
+	timer_base = of_iomap(node, 0);
+	if (!timer_base) {
+		pr_err("Can't map registers");
+		return;
+	}
+
+	irq = irq_of_parse_and_map(node, TIMER_C);
+	if (irq <= 0) {
+		pr_err("Can't parse IRQ");
+		return;
+	}
+
+	clk = of_clk_get(node, 0);
+	if (IS_ERR(clk)) {
+		pr_err("Can't get timer clock");
+		return;
+	}
+	clk_prepare_enable(clk);
+	rate = clk_get_rate(clk);
+
+	writeb(0, timer_base + CONTROL(TIMER_B));
+	writel(~0, timer_base + COUNT(TIMER_B));
+	writeb(1, timer_base + CONTROL(TIMER_B));
+
+	sched_clock_register(digicolor_timer_sched_read, 32, rate);
+	clocksource_mmio_init(timer_base + COUNT(TIMER_B), node->name,
+			      rate, 340, 32, clocksource_mmio_readl_down);
+
+	ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
+
+	ret = setup_irq(irq, &digicolor_timer_irq);
+	if (ret)
+		pr_warn("failed to setup timer irq %d (%d)\n", irq, ret);
+
+	digicolor_clockevent.cpumask = cpu_possible_mask;
+	digicolor_clockevent.irq = irq;
+
+	clockevents_config_and_register(&digicolor_clockevent, rate, 0,
+					0xffffffff);
+}
+CLOCKSOURCE_OF_DECLARE(conexant_digicolor, "cnxt,cx92755-timer",
+		       digicolor_timer_init);
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 7/8] clocksource: driver for Conexant Digicolor SoC timer
@ 2015-01-08 19:40   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/clocksource/Makefile          |   1 +
 drivers/clocksource/timer-digicolor.c | 164 ++++++++++++++++++++++++++++++++++
 2 files changed, 165 insertions(+)
 create mode 100644 drivers/clocksource/timer-digicolor.c

diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 94d90b24b56b..a993c108be67 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU)	+= sh_tmu.o
 obj-$(CONFIG_EM_TIMER_STI)	+= em_sti.o
 obj-$(CONFIG_CLKBLD_I8253)	+= i8253.o
 obj-$(CONFIG_CLKSRC_MMIO)	+= mmio.o
+obj-$(CONFIG_ARCH_DIGICOLOR)	+= timer-digicolor.o
 obj-$(CONFIG_DW_APB_TIMER)	+= dw_apb_timer.o
 obj-$(CONFIG_DW_APB_TIMER_OF)	+= dw_apb_timer_of.o
 obj-$(CONFIG_CLKSRC_NOMADIK_MTU)	+= nomadik-mtu.o
diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
new file mode 100644
index 000000000000..014c50675980
--- /dev/null
+++ b/drivers/clocksource/timer-digicolor.c
@@ -0,0 +1,164 @@
+/*
+ * Conexant Digicolor timer driver
+ *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
+ * Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * Based on:
+ *	Allwinner SoCs hstimer driver
+ *
+ * Copyright (C) 2013 Maxime Ripard
+ *
+ * Maxime Ripard <maxime.ripard@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/*
+ * Conexant Digicolor SoCs have 8 configurable timers, named from "Timer A" to
+ * "Timer H". Timer A is the only one with watchdog support, so it is dedicated
+ * to the watchdog driver. This driver uses Timer B for sched_clock(), and
+ * Timer C for clockevents.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/clk.h>
+#include <linux/clockchips.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/irqreturn.h>
+#include <linux/sched_clock.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/of_irq.h>
+
+enum {
+	TIMER_A,
+	TIMER_B,
+	TIMER_C,
+	TIMER_D,
+	TIMER_E,
+	TIMER_F,
+	TIMER_G,
+	TIMER_H,
+};
+
+#define CONTROL(t)	((t)*8)
+#define COUNT(t)	((t)*8 + 4)
+
+static void __iomem *timer_base;
+static u32 ticks_per_jiffy;
+
+static void digicolor_clkevt_mode(enum clock_event_mode mode,
+				  struct clock_event_device *clk)
+{
+	switch (mode) {
+	case CLOCK_EVT_MODE_PERIODIC:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		writel(ticks_per_jiffy, timer_base + COUNT(TIMER_C));
+		writeb(0x21, timer_base + CONTROL(TIMER_C));
+		break;
+	case CLOCK_EVT_MODE_ONESHOT:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		writeb(0x11, timer_base + CONTROL(TIMER_C));
+		break;
+	case CLOCK_EVT_MODE_UNUSED:
+	case CLOCK_EVT_MODE_SHUTDOWN:
+	default:
+		writeb(0, timer_base + CONTROL(TIMER_C));
+		break;
+	}
+}
+
+static int digicolor_clkevt_next_event(unsigned long evt,
+				       struct clock_event_device *unused)
+{
+	writeb(0, timer_base + CONTROL(TIMER_C));
+	writel(evt, timer_base + COUNT(TIMER_C));
+	writeb(0x11, timer_base + CONTROL(TIMER_C));
+
+	return 0;
+}
+
+static struct clock_event_device digicolor_clockevent = {
+	.name = "digicolor_tick",
+	.rating = 340,
+	.features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
+	.set_mode = digicolor_clkevt_mode,
+	.set_next_event = digicolor_clkevt_next_event,
+};
+
+
+static irqreturn_t digicolor_timer_interrupt(int irq, void *dev_id)
+{
+	struct clock_event_device *evt = (struct clock_event_device *)dev_id;
+
+	evt->event_handler(evt);
+
+	return IRQ_HANDLED;
+}
+
+static struct irqaction digicolor_timer_irq = {
+	.name = "digicolor_timerC",
+	.flags = IRQF_TIMER | IRQF_IRQPOLL,
+	.handler = digicolor_timer_interrupt,
+	.dev_id = &digicolor_clockevent,
+};
+
+static u64 digicolor_timer_sched_read(void)
+{
+	return ~readl(timer_base + COUNT(TIMER_B));
+}
+
+static void __init digicolor_timer_init(struct device_node *node)
+{
+	unsigned long rate;
+	struct clk *clk;
+	int ret, irq;
+
+	timer_base = of_iomap(node, 0);
+	if (!timer_base) {
+		pr_err("Can't map registers");
+		return;
+	}
+
+	irq = irq_of_parse_and_map(node, TIMER_C);
+	if (irq <= 0) {
+		pr_err("Can't parse IRQ");
+		return;
+	}
+
+	clk = of_clk_get(node, 0);
+	if (IS_ERR(clk)) {
+		pr_err("Can't get timer clock");
+		return;
+	}
+	clk_prepare_enable(clk);
+	rate = clk_get_rate(clk);
+
+	writeb(0, timer_base + CONTROL(TIMER_B));
+	writel(~0, timer_base + COUNT(TIMER_B));
+	writeb(1, timer_base + CONTROL(TIMER_B));
+
+	sched_clock_register(digicolor_timer_sched_read, 32, rate);
+	clocksource_mmio_init(timer_base + COUNT(TIMER_B), node->name,
+			      rate, 340, 32, clocksource_mmio_readl_down);
+
+	ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);
+
+	ret = setup_irq(irq, &digicolor_timer_irq);
+	if (ret)
+		pr_warn("failed to setup timer irq %d (%d)\n", irq, ret);
+
+	digicolor_clockevent.cpumask = cpu_possible_mask;
+	digicolor_clockevent.irq = irq;
+
+	clockevents_config_and_register(&digicolor_clockevent, rate, 0,
+					0xffffffff);
+}
+CLOCKSOURCE_OF_DECLARE(conexant_digicolor, "cnxt,cx92755-timer",
+		       digicolor_timer_init);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 8/8] ARM: devicetree: document supported Conexant Digicolor SoC
  2015-01-08 19:39 ` Baruch Siach
@ 2015-01-08 19:40   ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel
  Cc: Baruch Siach, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 Documentation/devicetree/bindings/arm/digicolor.txt | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt

diff --git a/Documentation/devicetree/bindings/arm/digicolor.txt b/Documentation/devicetree/bindings/arm/digicolor.txt
new file mode 100644
index 000000000000..658553f40b23
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/digicolor.txt
@@ -0,0 +1,6 @@
+Conexant Digicolor Platforms Device Tree Bindings
+
+Each device tree must specify which Conexant Digicolor SoC it uses.
+Must be the following compatible string:
+
+  cnxt,cx92755
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 55+ messages in thread

* [PATCH v2 8/8] ARM: devicetree: document supported Conexant Digicolor SoC
@ 2015-01-08 19:40   ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-08 19:40 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 Documentation/devicetree/bindings/arm/digicolor.txt | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/digicolor.txt

diff --git a/Documentation/devicetree/bindings/arm/digicolor.txt b/Documentation/devicetree/bindings/arm/digicolor.txt
new file mode 100644
index 000000000000..658553f40b23
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/digicolor.txt
@@ -0,0 +1,6 @@
+Conexant Digicolor Platforms Device Tree Bindings
+
+Each device tree must specify which Conexant Digicolor SoC it uses.
+Must be the following compatible string:
+
+  cnxt,cx92755
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-08 22:41     ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:41 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Baruch Siach, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree, Russell King, linux-kernel

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-08 22:41     ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:41 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Baruch Siach, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Russell King, linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-08 22:41     ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};

Better move the aliases into the board specific file.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 22:46   ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:46 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: Baruch Siach, linux-kernel, devicetree

On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
> one of the Digicolor series of SoCs, all sharing many of the same peripherals.
> The code was tested on the CX92755 evaluation kit, AKA Equinox.
> 
> Uses attempting to try this code will most likely also want the UART/console
> driver available from https://patchwork.kernel.org/patch/5515861/.
 
Looks great overall now.

I have just two more comments in one patch, and one general request:

Please add a patch description for every patch. The text above would
be a good start for the first patch, but it would be lost in the git
history if it's only in the cover letter.

other than that, feel free to add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

Once there are no more review comments, please submit the first three
patches to arm@kernel.org, and send the other patches as separate
series to the respective maintainers for irqchip and clocksource.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 22:46   ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:46 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Baruch Siach, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
> one of the Digicolor series of SoCs, all sharing many of the same peripherals.
> The code was tested on the CX92755 evaluation kit, AKA Equinox.
> 
> Uses attempting to try this code will most likely also want the UART/console
> driver available from https://patchwork.kernel.org/patch/5515861/.
 
Looks great overall now.

I have just two more comments in one patch, and one general request:

Please add a patch description for every patch. The text above would
be a good start for the first patch, but it would be lost in the git
history if it's only in the cover letter.

other than that, feel free to add my

Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

Once there are no more review comments, please submit the first three
patches to arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, and send the other patches as separate
series to the respective maintainers for irqchip and clocksource.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-08 22:46   ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-08 22:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
> one of the Digicolor series of SoCs, all sharing many of the same peripherals.
> The code was tested on the CX92755 evaluation kit, AKA Equinox.
> 
> Uses attempting to try this code will most likely also want the UART/console
> driver available from https://patchwork.kernel.org/patch/5515861/.
 
Looks great overall now.

I have just two more comments in one patch, and one general request:

Please add a patch description for every patch. The text above would
be a good start for the first patch, but it would be lost in the git
history if it's only in the cover letter.

other than that, feel free to add my

Acked-by: Arnd Bergmann <arnd@arndb.de>

Once there are no more review comments, please submit the first three
patches to arm at kernel.org, and send the other patches as separate
series to the respective maintainers for irqchip and clocksource.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-09 11:46     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:46 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-arm-kernel, Rob Herring, Pawel Moll, Ian Campbell,
	Kumar Gala, Russell King, devicetree, linux-kernel

On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> describes the Equinox evaluation board for the CX92755 SoC.

I didn't spot any cpu nodes below. While that might happen to work at
the moment for UP, there really should be a node for the boot CPU.

Thanks,
Mark.

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm/boot/dts/Makefile             |   1 +
>  arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
>  arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
>  3 files changed, 171 insertions(+)
>  create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
>  create mode 100644 arch/arm/boot/dts/cx92755.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 91bd5bd62857..fbeb65eaddda 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>  	bcm7445-bcm97445svmb.dtb
>  dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
>  	da850-evm.dtb
> +dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
>  dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
>  dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
>  	exynos3250-rinato.dtb \
> diff --git a/arch/arm/boot/dts/conexant_equinox.dts b/arch/arm/boot/dts/conexant_equinox.dts
> new file mode 100644
> index 000000000000..b2917d914740
> --- /dev/null
> +++ b/arch/arm/boot/dts/conexant_equinox.dts
> @@ -0,0 +1,67 @@
> +/*
> + * Device Tree file for the Conexant Equinox CX92755 EVK
> + *
> + * Author: Baruch Siach <baruch@tkos.co.il>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +
> +#include "cx92755.dtsi"
> +
> +/ {
> +	model = "Conexant Equinox CX92755 EVK";
> +	compatible = "cnxt,equinox", "cnxt,cx92755";
> +
> +	memory@0 {
> +		reg = <0 0x8000000>;
> +		device_type = "memory";
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/cx92755.dtsi b/arch/arm/boot/dts/cx92755.dtsi
> new file mode 100644
> index 000000000000..4088e8974b4b
> --- /dev/null
> +++ b/arch/arm/boot/dts/cx92755.dtsi
> @@ -0,0 +1,103 @@
> +/*
> + * Device Tree Include file for the Conexant Digicolor CX92755 SoC
> + *
> + * Author: Baruch Siach <baruch@tkos.co.il>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "skeleton.dtsi"
> +
> +/ {
> +	compatible = "cnxt,cx92755";
> +
> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};
> +
> +	main_clk: main_clk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency  = <200000000>;
> +	};
> +
> +	intc: intc@f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> +	timer@f0000fc0 {
> +		compatible = "cnxt,cx92755-timer";
> +		reg = <0xf0000fc0 0x40>;
> +		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
> +		clocks = <&main_clk>;
> +	};
> +
> +	uart0: uart@f0000740 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000740 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <44>;
> +		status = "disabled";
> +	};
> +
> +	uart1: uart@f0000760 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000760 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <45>;
> +		status = "disabled";
> +	};
> +
> +	uart2: uart@f0000780 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000780 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <46>;
> +		status = "disabled";
> +	};
> +};
> -- 
> 2.1.4
> 
> 

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-09 11:46     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:46 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
	Pawel Moll, Ian Campbell, Kumar Gala, Russell King,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> describes the Equinox evaluation board for the CX92755 SoC.

I didn't spot any cpu nodes below. While that might happen to work at
the moment for UP, there really should be a node for the boot CPU.

Thanks,
Mark.

> 
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> ---
>  arch/arm/boot/dts/Makefile             |   1 +
>  arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
>  arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
>  3 files changed, 171 insertions(+)
>  create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
>  create mode 100644 arch/arm/boot/dts/cx92755.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 91bd5bd62857..fbeb65eaddda 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>  	bcm7445-bcm97445svmb.dtb
>  dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
>  	da850-evm.dtb
> +dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
>  dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
>  dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
>  	exynos3250-rinato.dtb \
> diff --git a/arch/arm/boot/dts/conexant_equinox.dts b/arch/arm/boot/dts/conexant_equinox.dts
> new file mode 100644
> index 000000000000..b2917d914740
> --- /dev/null
> +++ b/arch/arm/boot/dts/conexant_equinox.dts
> @@ -0,0 +1,67 @@
> +/*
> + * Device Tree file for the Conexant Equinox CX92755 EVK
> + *
> + * Author: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +
> +#include "cx92755.dtsi"
> +
> +/ {
> +	model = "Conexant Equinox CX92755 EVK";
> +	compatible = "cnxt,equinox", "cnxt,cx92755";
> +
> +	memory@0 {
> +		reg = <0 0x8000000>;
> +		device_type = "memory";
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/cx92755.dtsi b/arch/arm/boot/dts/cx92755.dtsi
> new file mode 100644
> index 000000000000..4088e8974b4b
> --- /dev/null
> +++ b/arch/arm/boot/dts/cx92755.dtsi
> @@ -0,0 +1,103 @@
> +/*
> + * Device Tree Include file for the Conexant Digicolor CX92755 SoC
> + *
> + * Author: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "skeleton.dtsi"
> +
> +/ {
> +	compatible = "cnxt,cx92755";
> +
> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};
> +
> +	main_clk: main_clk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency  = <200000000>;
> +	};
> +
> +	intc: intc@f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> +	timer@f0000fc0 {
> +		compatible = "cnxt,cx92755-timer";
> +		reg = <0xf0000fc0 0x40>;
> +		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
> +		clocks = <&main_clk>;
> +	};
> +
> +	uart0: uart@f0000740 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000740 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <44>;
> +		status = "disabled";
> +	};
> +
> +	uart1: uart@f0000760 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000760 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <45>;
> +		status = "disabled";
> +	};
> +
> +	uart2: uart@f0000780 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000780 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <46>;
> +		status = "disabled";
> +	};
> +};
> -- 
> 2.1.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-09 11:46     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> describes the Equinox evaluation board for the CX92755 SoC.

I didn't spot any cpu nodes below. While that might happen to work at
the moment for UP, there really should be a node for the boot CPU.

Thanks,
Mark.

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm/boot/dts/Makefile             |   1 +
>  arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
>  arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
>  3 files changed, 171 insertions(+)
>  create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
>  create mode 100644 arch/arm/boot/dts/cx92755.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 91bd5bd62857..fbeb65eaddda 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>  	bcm7445-bcm97445svmb.dtb
>  dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
>  	da850-evm.dtb
> +dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
>  dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
>  dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
>  	exynos3250-rinato.dtb \
> diff --git a/arch/arm/boot/dts/conexant_equinox.dts b/arch/arm/boot/dts/conexant_equinox.dts
> new file mode 100644
> index 000000000000..b2917d914740
> --- /dev/null
> +++ b/arch/arm/boot/dts/conexant_equinox.dts
> @@ -0,0 +1,67 @@
> +/*
> + * Device Tree file for the Conexant Equinox CX92755 EVK
> + *
> + * Author: Baruch Siach <baruch@tkos.co.il>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +
> +#include "cx92755.dtsi"
> +
> +/ {
> +	model = "Conexant Equinox CX92755 EVK";
> +	compatible = "cnxt,equinox", "cnxt,cx92755";
> +
> +	memory at 0 {
> +		reg = <0 0x8000000>;
> +		device_type = "memory";
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200 earlyprintk";
> +	};
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/cx92755.dtsi b/arch/arm/boot/dts/cx92755.dtsi
> new file mode 100644
> index 000000000000..4088e8974b4b
> --- /dev/null
> +++ b/arch/arm/boot/dts/cx92755.dtsi
> @@ -0,0 +1,103 @@
> +/*
> + * Device Tree Include file for the Conexant Digicolor CX92755 SoC
> + *
> + * Author: Baruch Siach <baruch@tkos.co.il>
> + *
> + *  Copyright (C) 2014 Paradox Innovation Ltd.
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "skeleton.dtsi"
> +
> +/ {
> +	compatible = "cnxt,cx92755";
> +
> +	interrupt-parent = <&intc>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +	};
> +
> +	main_clk: main_clk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency  = <200000000>;
> +	};
> +
> +	intc: intc at f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> +	timer at f0000fc0 {
> +		compatible = "cnxt,cx92755-timer";
> +		reg = <0xf0000fc0 0x40>;
> +		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
> +		clocks = <&main_clk>;
> +	};
> +
> +	uart0: uart at f0000740 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000740 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <44>;
> +		status = "disabled";
> +	};
> +
> +	uart1: uart at f0000760 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000760 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <45>;
> +		status = "disabled";
> +	};
> +
> +	uart2: uart at f0000780 {
> +		compatible = "cnxt,cx92755-usart";
> +		reg = <0xf0000780 0x20>;
> +		clocks = <&main_clk>;
> +		interrupts = <46>;
> +		status = "disabled";
> +	};
> +};
> -- 
> 2.1.4
> 
> 

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-09 11:50     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:50 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-arm-kernel, Thomas Gleixner, Jason Cooper, Rob Herring,
	Pawel Moll, Ian Campbell, Kumar Gala, linux-kernel, devicetree

On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"

I didn't spot "cnxt" in
Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
did I spot it added as part of this series. Please add it, assuming a
patch doing so is not already queued elsewhere.

> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located

Is this area shared with other devices?

> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.

There is no configuration that can be applied to individual interrupt
lines (e.g. trigger type)?

Thanks,
Mark.

> +
> +Example:
> +
> +	intc: intc@f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> -- 
> 2.1.4
> 
> 

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-09 11:50     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:50 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Thomas Gleixner, Jason Cooper, Rob Herring, Pawel Moll,
	Ian Campbell, Kumar Gala, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
> ---
>  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"

I didn't spot "cnxt" in
Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
did I spot it added as part of this series. Please add it, assuming a
patch doing so is not already queued elsewhere.

> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located

Is this area shared with other devices?

> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.

There is no configuration that can be applied to individual interrupt
lines (e.g. trigger type)?

Thanks,
Mark.

> +
> +Example:
> +
> +	intc: intc@f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> -- 
> 2.1.4
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-09 11:50     ` Mark Rutland
  0 siblings, 0 replies; 55+ messages in thread
From: Mark Rutland @ 2015-01-09 11:50 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"

I didn't spot "cnxt" in
Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
did I spot it added as part of this series. Please add it, assuming a
patch doing so is not already queued elsewhere.

> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located

Is this area shared with other devices?

> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.

There is no configuration that can be applied to individual interrupt
lines (e.g. trigger type)?

Thanks,
Mark.

> +
> +Example:
> +
> +	intc: intc at f0000000 {
> +		compatible = "cnxt,cx92755-ic";
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +		reg = <0xf0000000 0x1000>;
> +	};
> +
> -- 
> 2.1.4
> 
> 

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
  2015-01-08 19:40   ` Baruch Siach
@ 2015-01-09 15:12     ` Sergei Shtylyov
  -1 siblings, 0 replies; 55+ messages in thread
From: Sergei Shtylyov @ 2015-01-09 15:12 UTC (permalink / raw)
  To: Baruch Siach, linux-arm-kernel, Thomas Gleixner, Jason Cooper
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, linux-kernel,
	Rob Herring, Kumar Gala

Hello.

On 1/8/2015 10:40 PM, Baruch Siach wrote:

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"
> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.
> +
> +Example:
> +
> +	intc: intc@f0000000 {

    The node name should be "interrupt-controller@f0000000", according to the 
ePAPR standard, section 2.2.2.

[...]

WBR, Sergei


^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-09 15:12     ` Sergei Shtylyov
  0 siblings, 0 replies; 55+ messages in thread
From: Sergei Shtylyov @ 2015-01-09 15:12 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 1/8/2015 10:40 PM, Baruch Siach wrote:

> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>   .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> new file mode 100644
> index 000000000000..fdf9a4c59bf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> @@ -0,0 +1,20 @@
> +Conexant Digicolor Interrupt Controller
> +
> +Required properties:
> +
> +- compatible : should be "cnxt,cx92755-ic"
> +- reg : Specifies base physical address and size of the MISC area, that is
> +  where the interrupt controller registers are located
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 1.
> +
> +Example:
> +
> +	intc: intc at f0000000 {

    The node name should be "interrupt-controller at f0000000", according to the 
ePAPR standard, section 2.2.2.

[...]

WBR, Sergei

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
  2015-01-09 11:46     ` Mark Rutland
  (?)
@ 2015-01-11  9:38       ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11  9:38 UTC (permalink / raw)
  To: Mark Rutland
  Cc: linux-arm-kernel, Rob Herring, Pawel Moll, Ian Campbell,
	Kumar Gala, Russell King, devicetree, linux-kernel

Hi Mark,

On Fri, Jan 09, 2015 at 11:46:24AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> > cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> > describes the Equinox evaluation board for the CX92755 SoC.
> 
> I didn't spot any cpu nodes below. While that might happen to work at
> the moment for UP, there really should be a node for the boot CPU.

OK. I'll add one in the next revision.

Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-11  9:38       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11  9:38 UTC (permalink / raw)
  To: Mark Rutland
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
	Pawel Moll, Ian Campbell, Kumar Gala, Russell King,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Hi Mark,

On Fri, Jan 09, 2015 at 11:46:24AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> > cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> > describes the Equinox evaluation board for the CX92755 SoC.
> 
> I didn't spot any cpu nodes below. While that might happen to work at
> the moment for UP, there really should be a node for the boot CPU.

OK. I'll add one in the next revision.

Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 3/8] ARM: digicolor: add minimal device tree description
@ 2015-01-11  9:38       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11  9:38 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mark,

On Fri, Jan 09, 2015 at 11:46:24AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:39:59PM +0000, Baruch Siach wrote:
> > cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts
> > describes the Equinox evaluation board for the CX92755 SoC.
> 
> I didn't spot any cpu nodes below. While that might happen to work at
> the moment for UP, there really should be a node for the boot CPU.

OK. I'll add one in the next revision.

Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
  2015-01-09 11:50     ` Mark Rutland
  (?)
@ 2015-01-11 11:21       ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:21 UTC (permalink / raw)
  To: Mark Rutland
  Cc: linux-arm-kernel, Thomas Gleixner, Jason Cooper, Rob Herring,
	Pawel Moll, Ian Campbell, Kumar Gala, linux-kernel, devicetree

Hi Mark,

On Fri, Jan 09, 2015 at 11:50:14AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > new file mode 100644
> > index 000000000000..fdf9a4c59bf3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > @@ -0,0 +1,20 @@
> > +Conexant Digicolor Interrupt Controller
> > +
> > +Required properties:
> > +
> > +- compatible : should be "cnxt,cx92755-ic"
> 
> I didn't spot "cnxt" in
> Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
> did I spot it added as part of this series. Please add it, assuming a
> patch doing so is not already queued elsewhere.

I sent a vendor-prefixes.txt update earlier as part of the UART driver series. 
Greg has it queued in the tty-testing branch of his tty tree 
(https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-testing&id=48c738631753186e0ec7dd0079beffb3a6f4bb5c).

> > +- reg : Specifies base physical address and size of the MISC area, that is
> > +  where the interrupt controller registers are located
> 
> Is this area shared with other devices?

Yes. The interrupt controller uses just a small area in this registers space 
(offsets 0x40 - 0x80). This trouble is that I also need access to the system 
global UC_IRQ_CONTROL register (offset 0x3a4), to configure interrupts channel 
and routing (IRQ/FIQ). I wonder whether register access via syscon is better.

> > +- interrupt-controller : Identifies the node as an interrupt controller
> > +- #interrupt-cells : Specifies the number of cells needed to encode an
> > +  interrupt source. The value shall be 1.
> 
> There is no configuration that can be applied to individual interrupt
> lines (e.g. trigger type)?

No. There is none.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-11 11:21       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:21 UTC (permalink / raw)
  To: Mark Rutland
  Cc: linux-arm-kernel, Thomas Gleixner, Jason Cooper, Rob Herring,
	Pawel Moll, Ian Campbell, Kumar Gala, linux-kernel, devicetree

Hi Mark,

On Fri, Jan 09, 2015 at 11:50:14AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > new file mode 100644
> > index 000000000000..fdf9a4c59bf3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > @@ -0,0 +1,20 @@
> > +Conexant Digicolor Interrupt Controller
> > +
> > +Required properties:
> > +
> > +- compatible : should be "cnxt,cx92755-ic"
> 
> I didn't spot "cnxt" in
> Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
> did I spot it added as part of this series. Please add it, assuming a
> patch doing so is not already queued elsewhere.

I sent a vendor-prefixes.txt update earlier as part of the UART driver series. 
Greg has it queued in the tty-testing branch of his tty tree 
(https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-testing&id=48c738631753186e0ec7dd0079beffb3a6f4bb5c).

> > +- reg : Specifies base physical address and size of the MISC area, that is
> > +  where the interrupt controller registers are located
> 
> Is this area shared with other devices?

Yes. The interrupt controller uses just a small area in this registers space 
(offsets 0x40 - 0x80). This trouble is that I also need access to the system 
global UC_IRQ_CONTROL register (offset 0x3a4), to configure interrupts channel 
and routing (IRQ/FIQ). I wonder whether register access via syscon is better.

> > +- interrupt-controller : Identifies the node as an interrupt controller
> > +- #interrupt-cells : Specifies the number of cells needed to encode an
> > +  interrupt source. The value shall be 1.
> 
> There is no configuration that can be applied to individual interrupt
> lines (e.g. trigger type)?

No. There is none.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-11 11:21       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mark,

On Fri, Jan 09, 2015 at 11:50:14AM +0000, Mark Rutland wrote:
> On Thu, Jan 08, 2015 at 07:40:00PM +0000, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > new file mode 100644
> > index 000000000000..fdf9a4c59bf3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> > @@ -0,0 +1,20 @@
> > +Conexant Digicolor Interrupt Controller
> > +
> > +Required properties:
> > +
> > +- compatible : should be "cnxt,cx92755-ic"
> 
> I didn't spot "cnxt" in
> Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor
> did I spot it added as part of this series. Please add it, assuming a
> patch doing so is not already queued elsewhere.

I sent a vendor-prefixes.txt update earlier as part of the UART driver series. 
Greg has it queued in the tty-testing branch of his tty tree 
(https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/commit/?h=tty-testing&id=48c738631753186e0ec7dd0079beffb3a6f4bb5c).

> > +- reg : Specifies base physical address and size of the MISC area, that is
> > +  where the interrupt controller registers are located
> 
> Is this area shared with other devices?

Yes. The interrupt controller uses just a small area in this registers space 
(offsets 0x40 - 0x80). This trouble is that I also need access to the system 
global UC_IRQ_CONTROL register (offset 0x3a4), to configure interrupts channel 
and routing (IRQ/FIQ). I wonder whether register access via syscon is better.

> > +- interrupt-controller : Identifies the node as an interrupt controller
> > +- #interrupt-cells : Specifies the number of cells needed to encode an
> > +  interrupt source. The value shall be 1.
> 
> There is no configuration that can be applied to individual interrupt
> lines (e.g. trigger type)?

No. There is none.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
  2015-01-09 15:12     ` Sergei Shtylyov
@ 2015-01-11 11:29       ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:29 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: linux-arm-kernel, Thomas Gleixner, Jason Cooper, Mark Rutland,
	devicetree, Pawel Moll, Ian Campbell, linux-kernel, Rob Herring,
	Kumar Gala

Hi Sergei,

On Fri, Jan 09, 2015 at 06:12:44PM +0300, Sergei Shtylyov wrote:
> On 1/8/2015 10:40 PM, Baruch Siach wrote:
> 
> >Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> >diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >new file mode 100644
> >index 000000000000..fdf9a4c59bf3
> >--- /dev/null
> >+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >@@ -0,0 +1,20 @@
> >+Conexant Digicolor Interrupt Controller
> >+
> >+Required properties:
> >+
> >+- compatible : should be "cnxt,cx92755-ic"
> >+- reg : Specifies base physical address and size of the MISC area, that is
> >+  where the interrupt controller registers are located
> >+- interrupt-controller : Identifies the node as an interrupt controller
> >+- #interrupt-cells : Specifies the number of cells needed to encode an
> >+  interrupt source. The value shall be 1.
> >+
> >+Example:
> >+
> >+	intc: intc@f0000000 {
> 
>    The node name should be "interrupt-controller@f0000000", according to the
> ePAPR standard, section 2.2.2.

I'll change that in my next submission.

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding
@ 2015-01-11 11:29       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:29 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sergei,

On Fri, Jan 09, 2015 at 06:12:44PM +0300, Sergei Shtylyov wrote:
> On 1/8/2015 10:40 PM, Baruch Siach wrote:
> 
> >Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >---
> >  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> 
> >diff --git a/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >new file mode 100644
> >index 000000000000..fdf9a4c59bf3
> >--- /dev/null
> >+++ b/Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt
> >@@ -0,0 +1,20 @@
> >+Conexant Digicolor Interrupt Controller
> >+
> >+Required properties:
> >+
> >+- compatible : should be "cnxt,cx92755-ic"
> >+- reg : Specifies base physical address and size of the MISC area, that is
> >+  where the interrupt controller registers are located
> >+- interrupt-controller : Identifies the node as an interrupt controller
> >+- #interrupt-cells : Specifies the number of cells needed to encode an
> >+  interrupt source. The value shall be 1.
> >+
> >+Example:
> >+
> >+	intc: intc at f0000000 {
> 
>    The node name should be "interrupt-controller at f0000000", according to the
> ePAPR standard, section 2.2.2.

I'll change that in my next submission.

Thanks,
baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
  2015-01-08 22:46   ` Arnd Bergmann
@ 2015-01-11 11:33     ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:33 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: linux-arm-kernel, linux-kernel, devicetree

Hi Arnd,

On Thu, Jan 08, 2015 at 11:46:46PM +0100, Arnd Bergmann wrote:
> On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> > This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
> > one of the Digicolor series of SoCs, all sharing many of the same peripherals.
> > The code was tested on the CX92755 evaluation kit, AKA Equinox.
> > 
> > Uses attempting to try this code will most likely also want the UART/console
> > driver available from https://patchwork.kernel.org/patch/5515861/.
>  
> Looks great overall now.
> 
> I have just two more comments in one patch, and one general request:
> 
> Please add a patch description for every patch. The text above would
> be a good start for the first patch, but it would be lost in the git
> history if it's only in the cover letter.
> 
> other than that, feel free to add my
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks.

> Once there are no more review comments, please submit the first three
> patches to arm@kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.

What about the last patch in this series (ARM: devicetree: document supported 
Conexant Digicolor SoC)? What tree should it go through.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-11 11:33     ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-11 11:33 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Arnd,

On Thu, Jan 08, 2015 at 11:46:46PM +0100, Arnd Bergmann wrote:
> On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:
> > This series adds initial support for the Conexant CX92755 SoC. The CX92755 is
> > one of the Digicolor series of SoCs, all sharing many of the same peripherals.
> > The code was tested on the CX92755 evaluation kit, AKA Equinox.
> > 
> > Uses attempting to try this code will most likely also want the UART/console
> > driver available from https://patchwork.kernel.org/patch/5515861/.
>  
> Looks great overall now.
> 
> I have just two more comments in one patch, and one general request:
> 
> Please add a patch description for every patch. The text above would
> be a good start for the first patch, but it would be lost in the git
> history if it's only in the cover letter.
> 
> other than that, feel free to add my
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks.

> Once there are no more review comments, please submit the first three
> patches to arm at kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.

What about the last patch in this series (ARM: devicetree: document supported 
Conexant Digicolor SoC)? What tree should it go through.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-11 15:49       ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-11 15:49 UTC (permalink / raw)
  To: Baruch Siach; +Cc: linux-arm-kernel, linux-kernel, devicetree

On Sunday 11 January 2015 13:33:27 Baruch Siach wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm@kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> What about the last patch in this series (ARM: devicetree: document supported 
> Conexant Digicolor SoC)? What tree should it go through.

That can go along with the first three patches for the platform.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-11 15:49       ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-11 15:49 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Sunday 11 January 2015 13:33:27 Baruch Siach wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> What about the last patch in this series (ARM: devicetree: document supported 
> Conexant Digicolor SoC)? What tree should it go through.

That can go along with the first three patches for the platform.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-11 15:49       ` Arnd Bergmann
  0 siblings, 0 replies; 55+ messages in thread
From: Arnd Bergmann @ 2015-01-11 15:49 UTC (permalink / raw)
  To: linux-arm-kernel

On Sunday 11 January 2015 13:33:27 Baruch Siach wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm at kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> What about the last patch in this series (ARM: devicetree: document supported 
> Conexant Digicolor SoC)? What tree should it go through.

That can go along with the first three patches for the platform.

	Arnd

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
  2015-01-08 22:46   ` Arnd Bergmann
  (?)
@ 2015-01-28 22:33     ` Paul Bolle
  -1 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:33 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Valentin Rothberg, linux-arm-kernel, Baruch Siach, linux-kernel,
	devicetree

On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> Once there are no more review comments, please submit the first three
> patches to arm@kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.

I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
Kconfig macro entered linux-next in next-20150128. But there's no
Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

As you might be aware I try to check each linux-next release for Kconfig
oddities. One of the oddities I tend _not_ to report are things like
this. That is, SoC's, MFD's, or whatever, were specific drivers can get
merged before the core functionality. In this case the irqchip driver
got merged into linux-next while the core ARCH_DIGICOLOR code is still
pending. And you happen to be involved with quite a bit of code in areas
like that. 

Pre-merges like this appear unavoidable (ie, other workflows would be
more trouble for the people involved). But what would be a good moment
to still raise an issue like this? Just to make sure things don't fall
through the cracks. As in: "this driver got merged into mainline but do
you know you can't yet build it?". Perhaps with each -rc1?


Paul Bolle


^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:33     ` Paul Bolle
  0 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:33 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: devicetree, Baruch Siach, linux-kernel, linux-arm-kernel,
	Valentin Rothberg

On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> Once there are no more review comments, please submit the first three
> patches to arm@kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.

I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
Kconfig macro entered linux-next in next-20150128. But there's no
Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

As you might be aware I try to check each linux-next release for Kconfig
oddities. One of the oddities I tend _not_ to report are things like
this. That is, SoC's, MFD's, or whatever, were specific drivers can get
merged before the core functionality. In this case the irqchip driver
got merged into linux-next while the core ARCH_DIGICOLOR code is still
pending. And you happen to be involved with quite a bit of code in areas
like that. 

Pre-merges like this appear unavoidable (ie, other workflows would be
more trouble for the people involved). But what would be a good moment
to still raise an issue like this? Just to make sure things don't fall
through the cracks. As in: "this driver got merged into mainline but do
you know you can't yet build it?". Perhaps with each -rc1?


Paul Bolle

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:33     ` Paul Bolle
  0 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> Once there are no more review comments, please submit the first three
> patches to arm at kernel.org, and send the other patches as separate
> series to the respective maintainers for irqchip and clocksource.

I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
Kconfig macro entered linux-next in next-20150128. But there's no
Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

As you might be aware I try to check each linux-next release for Kconfig
oddities. One of the oddities I tend _not_ to report are things like
this. That is, SoC's, MFD's, or whatever, were specific drivers can get
merged before the core functionality. In this case the irqchip driver
got merged into linux-next while the core ARCH_DIGICOLOR code is still
pending. And you happen to be involved with quite a bit of code in areas
like that. 

Pre-merges like this appear unavoidable (ie, other workflows would be
more trouble for the people involved). But what would be a good moment
to still raise an issue like this? Just to make sure things don't fall
through the cracks. As in: "this driver got merged into mainline but do
you know you can't yet build it?". Perhaps with each -rc1?


Paul Bolle

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
  2015-01-28 22:33     ` Paul Bolle
  (?)
@ 2015-01-28 22:41       ` Baruch Siach
  -1 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-28 22:41 UTC (permalink / raw)
  To: Paul Bolle
  Cc: Arnd Bergmann, Valentin Rothberg, linux-arm-kernel, linux-kernel,
	devicetree

Hi Paul,

On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm@kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> Kconfig macro entered linux-next in next-20150128. But there's no
> Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

Just for the record: base digicolor platform support is in the for-next branch 
of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:41       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-28 22:41 UTC (permalink / raw)
  To: Paul Bolle
  Cc: linux-kernel, devicetree, linux-arm-kernel, Arnd Bergmann,
	Valentin Rothberg

Hi Paul,

On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm@kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> Kconfig macro entered linux-next in next-20150128. But there's no
> Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

Just for the record: base digicolor platform support is in the for-next branch 
of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:41       ` Baruch Siach
  0 siblings, 0 replies; 55+ messages in thread
From: Baruch Siach @ 2015-01-28 22:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Paul,

On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > Once there are no more review comments, please submit the first three
> > patches to arm at kernel.org, and send the other patches as separate
> > series to the respective maintainers for irqchip and clocksource.
> 
> I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> Kconfig macro entered linux-next in next-20150128. But there's no
> Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

Just for the record: base digicolor platform support is in the for-next branch 
of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
  2015-01-28 22:41       ` Baruch Siach
  (?)
@ 2015-01-28 22:52         ` Paul Bolle
  -1 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:52 UTC (permalink / raw)
  To: Baruch Siach
  Cc: Arnd Bergmann, Valentin Rothberg, linux-arm-kernel, linux-kernel,
	devicetree

Hi Baruch,

On Thu, 2015-01-29 at 00:41 +0200, Baruch Siach wrote:
> On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> > On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > > Once there are no more review comments, please submit the first three
> > > patches to arm@kernel.org, and send the other patches as separate
> > > series to the respective maintainers for irqchip and clocksource.
> > 
> > I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> > Kconfig macro entered linux-next in next-20150128. But there's no
> > Kconfig symbol ARCH_DIGICOLOR yet in linux-next.
> 
> Just for the record: base digicolor platform support is in the for-next branch 
> of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

So I choose a less convincing patch series to discuss this. But that
doesn't alter the general issue I raised. At least, I hope it doesn't.

Thanks!


Paul Bolle


^ permalink raw reply	[flat|nested] 55+ messages in thread

* Re: [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:52         ` Paul Bolle
  0 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:52 UTC (permalink / raw)
  To: Baruch Siach
  Cc: linux-kernel, devicetree, linux-arm-kernel, Arnd Bergmann,
	Valentin Rothberg

Hi Baruch,

On Thu, 2015-01-29 at 00:41 +0200, Baruch Siach wrote:
> On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> > On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > > Once there are no more review comments, please submit the first three
> > > patches to arm@kernel.org, and send the other patches as separate
> > > series to the respective maintainers for irqchip and clocksource.
> > 
> > I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> > Kconfig macro entered linux-next in next-20150128. But there's no
> > Kconfig symbol ARCH_DIGICOLOR yet in linux-next.
> 
> Just for the record: base digicolor platform support is in the for-next branch 
> of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

So I choose a less convincing patch series to discuss this. But that
doesn't alter the general issue I raised. At least, I hope it doesn't.

Thanks!


Paul Bolle

^ permalink raw reply	[flat|nested] 55+ messages in thread

* [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support
@ 2015-01-28 22:52         ` Paul Bolle
  0 siblings, 0 replies; 55+ messages in thread
From: Paul Bolle @ 2015-01-28 22:52 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Baruch,

On Thu, 2015-01-29 at 00:41 +0200, Baruch Siach wrote:
> On Wed, Jan 28, 2015 at 11:33:15PM +0100, Paul Bolle wrote:
> > On Thu, 2015-01-08 at 23:46 +0100, Arnd Bergmann wrote:
> > > Once there are no more review comments, please submit the first three
> > > patches to arm at kernel.org, and send the other patches as separate
> > > series to the respective maintainers for irqchip and clocksource.
> > 
> > I found this message while looking into CONFIG_ARCH_DIGICOLOR. That
> > Kconfig macro entered linux-next in next-20150128. But there's no
> > Kconfig symbol ARCH_DIGICOLOR yet in linux-next.
> 
> Just for the record: base digicolor platform support is in the for-next branch 
> of arm-soc.git since today. I guess it should appear in linux-next tomorrow.

So I choose a less convincing patch series to discuss this. But that
doesn't alter the general issue I raised. At least, I hope it doesn't.

Thanks!


Paul Bolle

^ permalink raw reply	[flat|nested] 55+ messages in thread

end of thread, other threads:[~2015-01-29  1:15 UTC | newest]

Thread overview: 55+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 19:39 [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Baruch Siach
2015-01-08 19:39 ` Baruch Siach
2015-01-08 19:39 ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 1/8] ARM: initial support for Conexant Digicolor CX92755 SoC Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 2/8] ARM: digicolor: add low level debug support Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 19:39 ` [PATCH v2 3/8] ARM: digicolor: add minimal device tree description Baruch Siach
2015-01-08 19:39   ` Baruch Siach
2015-01-08 22:41   ` Arnd Bergmann
2015-01-08 22:41     ` Arnd Bergmann
2015-01-08 22:41     ` Arnd Bergmann
2015-01-09 11:46   ` Mark Rutland
2015-01-09 11:46     ` Mark Rutland
2015-01-09 11:46     ` Mark Rutland
2015-01-11  9:38     ` Baruch Siach
2015-01-11  9:38       ` Baruch Siach
2015-01-11  9:38       ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 4/8] irqchip: devicetree: document Conexant Digicolor irq binding Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-09 11:50   ` Mark Rutland
2015-01-09 11:50     ` Mark Rutland
2015-01-09 11:50     ` Mark Rutland
2015-01-11 11:21     ` Baruch Siach
2015-01-11 11:21       ` Baruch Siach
2015-01-11 11:21       ` Baruch Siach
2015-01-09 15:12   ` Sergei Shtylyov
2015-01-09 15:12     ` Sergei Shtylyov
2015-01-11 11:29     ` Baruch Siach
2015-01-11 11:29       ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 5/8] irqchip: Conexant CX92755 interrupts controller driver Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 6/8] clocksource: devicetree: document Conexant Digicolor timer binding Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 7/8] clocksource: driver for Conexant Digicolor SoC timer Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 19:40 ` [PATCH v2 8/8] ARM: devicetree: document supported Conexant Digicolor SoC Baruch Siach
2015-01-08 19:40   ` Baruch Siach
2015-01-08 22:46 ` [PATCH v2 0/8] ARM: Conexant Digicolor CX92755 SoC support Arnd Bergmann
2015-01-08 22:46   ` Arnd Bergmann
2015-01-08 22:46   ` Arnd Bergmann
2015-01-11 11:33   ` Baruch Siach
2015-01-11 11:33     ` Baruch Siach
2015-01-11 15:49     ` Arnd Bergmann
2015-01-11 15:49       ` Arnd Bergmann
2015-01-11 15:49       ` Arnd Bergmann
2015-01-28 22:33   ` Paul Bolle
2015-01-28 22:33     ` Paul Bolle
2015-01-28 22:33     ` Paul Bolle
2015-01-28 22:41     ` Baruch Siach
2015-01-28 22:41       ` Baruch Siach
2015-01-28 22:41       ` Baruch Siach
2015-01-28 22:52       ` Paul Bolle
2015-01-28 22:52         ` Paul Bolle
2015-01-28 22:52         ` Paul Bolle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.