[PATCH] staging, addi_apci_1500: fix IRQ spew

[PATCH] staging, addi_apci_1500: fix IRQ spew

[Alan Cox]

The driver very carefully checks if the card is the IRQ source, and if it
isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it
can be used on a shared interrupt line.

Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
 .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
index 0ea081e..b7b9857 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
@@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
 			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
 		/* Authorizes the main interrupt on the board */
 		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
-	} else {
-		dev_warn(dev->class_dev,
-			"Interrupt from unknown source\n");
-
 	}
 }
 

Re: [PATCH] staging, addi_apci_1500: fix IRQ spew

[Greg KH]

On Wed, Dec 10, 2014 at 02:42:01PM +0000, Alan Cox wrote:
> The driver very carefully checks if the card is the IRQ source, and if it
> isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it
> can be used on a shared interrupt line.
> 
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>  .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> index 0ea081e..b7b9857 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> @@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
>  			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
>  		/* Authorizes the main interrupt on the board */
>  		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
> -	} else {
> -		dev_warn(dev->class_dev,
> -			"Interrupt from unknown source\n");
> -
>  	}
>  }
>  

No longer applies to my tree due to other changes in this driver :(

thanks,

greg k-h