[PATCH v6] Staging: comedi: patch to fix 80 characters line over warnings

[PATCH v6] Staging: comedi: patch to fix 80 characters line over warnings

[jitendra kumar khasdev]

This is the patch to pcl812.c that fix 80 character line over warnings.
These warnings are identified by checkpatch.pl tool.
For this patch I have did following changes,
1. convert single line comment into multiline comment
2. provide tab sapce for indentation purpose
3. reduce extra space between ( = ) sign.

Signed-off-by: Jitendra kumar khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..3eac017 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -507,20 +507,26 @@ static const struct pcl812_board boardtypes[] = {
 };
 
 struct pcl812_private {
-	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
+	unsigned char dma;		/*  >0 use dma ( usedDMA channel) */
 	unsigned char range_correction;	/*  =1 we must add 1 to range number */
 	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
+	unsigned char mode_reg_int;	/*  there is stored INT number for
+					 *  some card
+					 */
 	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
 	unsigned int dmapages;
 	unsigned int hwdmasize;
 	unsigned long dmabuf[2];	/*  PTR to DMA buf */
 	unsigned int hwdmaptr[2];	/*  HW PTR to DMA buf */
 	unsigned int dmabytestomove[2];	/*  how many bytes DMA transfer */
-	int next_dma_buf;	/*  which buffer is next to use */
-	unsigned int dma_runs_to_end;	/*  how many times we must switch DMA buffers */
-	unsigned int last_dma_run;	/*  how many bytes to transfer on last DMA buffer */
-	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
+	int next_dma_buf;		/*  which buffer is next to use */
+	unsigned int dma_runs_to_end;	/*  how many times we must switch
+					 *  DMA buffers
+					 */
+	unsigned int last_dma_run;	/*  how many bytes to transfer on
+					 *  last DMA buffer
+					 */
+	unsigned int max_812_ai_mode0_rangewait;    /* setling time for gain */
 	unsigned int divisor1;
 	unsigned int divisor2;
 	unsigned int use_diff:1;
@@ -1235,7 +1241,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		for (i = 0; i < 2; i++) {
 			unsigned long dmabuf;
 
-			dmabuf =  __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
+			dmabuf = __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
 			if (!dmabuf)
 				return -ENOMEM;
 
-- 
1.9.1

Re: [PATCH v6] Staging: comedi: patch to fix 80 characters line over warnings

[Greg KH]

On Sat, Jan 10, 2015 at 09:54:39AM +0530, jitendra kumar khasdev wrote:
> This is the patch to pcl812.c that fix 80 character line over warnings.
> These warnings are identified by checkpatch.pl tool.
> For this patch I have did following changes,
> 1. convert single line comment into multiline comment
> 2. provide tab sapce for indentation purpose
> 3. reduce extra space between ( = ) sign.

You did 3 things here, so make it 3 different patches please.

thanks,

greg k-h