All of lore.kernel.org
 help / color / mirror / Atom feed
* re: drm: Remove useless else block
@ 2015-01-10  4:48 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-01-10  4:48 UTC (permalink / raw)
  To: treding, Dave Airlie; +Cc: dri-devel


Hi Dave,

There is a bad merge in drm-next and it causes a static checker warning.

The patch 2ca651d15aff: "drm: Remove useless else block" from Dec 10,
2014, leads to the following static checker warning:

	drivers/gpu/drm/drm_crtc.c:4380 drm_property_change_valid_get()
	info: ignoring unreachable code.

drivers/gpu/drm/drm_crtc.c
  4371                  }
  4372          } else {
  4373                  int i;
  4374                  for (i = 0; i < property->num_values; i++)
  4375                          if (property->values[i] == value)
  4376                                  return true;
  4377                  return false;
  4378          }
  4379  
  4380          for (i = 0; i < property->num_values; i++)
  4381                  if (property->values[i] == value)
  4382                          return true;
  4383          return false;

This block was in the else statement before, but now it's moved to here
as well.

  4384  }

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-10  4:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-10  4:48 drm: Remove useless else block Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.