All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: acme@redhat.com, namhyung@kernel.org, peterz@infradead.org,
	jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org,
	Alexey.Brodkin@synopsys.com
Subject: Re: [PATCH v2 3/5] perf tools: [uclibc] Avoid build splat for syscall numbers
Date: Mon, 12 Jan 2015 12:09:07 +0100	[thread overview]
Message-ID: <20150112110907.GD26229@krava.redhat.com> (raw)
In-Reply-To: <1420888254-17504-4-git-send-email-vgupta@synopsys.com>

On Sat, Jan 10, 2015 at 04:40:52PM +0530, Vineet Gupta wrote:
> This is due to duplicated unistd inclusion (via uClibc headers + kernel headers)
> Also seen on ARM uClibc based tools
> 
> ------- ARC build ---------->8-------------
> 
>   CC       util/evlist.o
> In file included from
> ~/arc/k.org/arch/arc/include/uapi/asm/unistd.h:25:0,
>                  from util/../perf-sys.h:10,
>                  from util/../perf.h:15,
>                  from util/event.h:7,
>                  from util/event.c:3:
> ~/arc/k.org/include/uapi/asm-generic/unistd.h:906:0:
> warning: "__NR_fcntl64" redefined [enabled by default]
>  #define __NR_fcntl64 __NR3264_fcntl
>  ^
> In file included from
> ~/arc/gnu/INSTALL_1412-arc-2014.12-rc1/arc-snps-linux-uclibc/sysroot/usr/include/sys/syscall.h:24:0,
>                  from util/../perf-sys.h:6,
> ----------------->8-------------------
> 
> ------- ARM build ---------->8-------------
> 
>   CC FPIC  plugin_scsi.o
> In file included from util/../perf-sys.h:9:0,
>                  from util/../perf.h:15,
>                  from util/cache.h:7,
>                  from perf.c:12:
> ~/arc/k.org/arch/arm/include/uapi/asm/unistd.h:28:0:
> warning: "__NR_restart_syscall" redefined [enabled by default]
> In file included from
> ~/buildroot/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/sys/syscall.h:25:0,
>                  from util/../perf-sys.h:6,
>                  from util/../perf.h:15,
>                  from util/cache.h:7,
>                  from perf.c:12:
> ~/buildroot/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/bits/sysnum.h:17:0:
> note: this is the location of the previous definition
> ----------------->8-------------------

Could you please point out what's the right logic for including those headers?

I've always thought that just adding:

  #include <linux/unistd.h>

should be safe no matter what.. feels like bug in one of those
header files? (uClibc headers & kernel headers)

thanks for info,
jirka

  reply	other threads:[~2015-01-12 11:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10 11:10 [PATCH v2 0/5] Perf tool fixes for ARC + uClibc Vineet Gupta
2015-01-10 11:10 ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:05   ` Jiri Olsa
2015-01-13  1:47     ` Arnaldo Carvalho de Melo
2015-01-13  4:49       ` Vineet Gupta
2015-01-17 10:11   ` [tip:perf/urgent] perf tools: Fix statfs.f_type data type mismatch build error with uclibc tip-bot for Alexey Brodkin
2015-01-10 11:10 ` [PATCH v2 2/5] perf tools: [uclibc] Elide strlcpy warning Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 3/5] perf tools: [uclibc] Avoid build splat for syscall numbers Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:09   ` Jiri Olsa [this message]
2015-01-12 12:00     ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0 Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:04   ` Jiri Olsa
2015-01-12 11:13     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112110907.GD26229@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=acme@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.