All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	namhyung@kernel.org, peterz@infradead.org, jolsa@kernel.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org,
	Alexey.Brodkin@synopsys.com, Borislav Petkov <bp@suse.de>,
	Cody P Schafer <dev@codyps.com>
Subject: Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error
Date: Mon, 12 Jan 2015 22:47:57 -0300	[thread overview]
Message-ID: <20150113014757.GG29743@kernel.org> (raw)
In-Reply-To: <20150112110522.GC26229@krava.redhat.com>

Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu:
> On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote:
> > From: Alexey Brodkin <abrodkin@synopsys.com>
> > 
> > ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
> > statfs defines f_type to be U32 which causes perf build breakage
> > 
> > http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h
> > 
> > ----------->8---------------
> >   CC       fs/fs.o
> > fs/fs.c: In function 'fs__valid_mount':
> > fs/fs.c:82:24: error: comparison between signed and unsigned integer
> > expressions [-Werror=sign-compare]
> >   else if (st_fs.f_type != magic)
> >                         ^
> > cc1: all warnings being treated as errors
> > ----------->8---------------
> > 
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Cody P Schafer <dev@codyps.com>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: linux-perf-users@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied, but please do not start lines in the changelog comment
with ---, that breaks some patch applying scripts. I fixed it up this
time.

- Arnaldo

  reply	other threads:[~2015-01-13  1:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10 11:10 [PATCH v2 0/5] Perf tool fixes for ARC + uClibc Vineet Gupta
2015-01-10 11:10 ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:05   ` Jiri Olsa
2015-01-13  1:47     ` Arnaldo Carvalho de Melo [this message]
2015-01-13  4:49       ` Vineet Gupta
2015-01-17 10:11   ` [tip:perf/urgent] perf tools: Fix statfs.f_type data type mismatch build error with uclibc tip-bot for Alexey Brodkin
2015-01-10 11:10 ` [PATCH v2 2/5] perf tools: [uclibc] Elide strlcpy warning Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 3/5] perf tools: [uclibc] Avoid build splat for syscall numbers Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:09   ` Jiri Olsa
2015-01-12 12:00     ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0 Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-10 11:10 ` [PATCH v2 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np Vineet Gupta
2015-01-10 11:10   ` Vineet Gupta
2015-01-12 11:04   ` Jiri Olsa
2015-01-12 11:13     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113014757.GG29743@kernel.org \
    --to=acme@redhat.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=bp@suse.de \
    --cc=dev@codyps.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.