From: Tejun Heo <tj@kernel.org> To: Vladimir Davydov <vdavydov@parallels.com> Cc: Johannes Weiner <hannes@cmpxchg.org>, "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>, linux-mm@kvack.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Will Deacon <Will.Deacon@arm.com> Subject: Re: [PATCH cgroup/for-3.19-fixes] cgroup: implement cgroup_subsys->unbind() callback Date: Mon, 12 Jan 2015 06:28:45 -0500 [thread overview] Message-ID: <20150112112845.GS25319@htj.dyndns.org> (raw) In-Reply-To: <20150112080114.GE2110@esperanza> Hello, Vladimir. On Mon, Jan 12, 2015 at 11:01:14AM +0300, Vladimir Davydov wrote: > Come to think of it, I wonder how many users actually want to mount > different controllers subset after unmount. Because we could allow It wouldn't be a common use case but, on the face of it, we still support it. If we collecctively decide that once a sub cgroup is created for any controller no further hierarchy configuration for that controller is allowed, that'd work too, but one way or the other, the behavior, I believe, should be well-defined. As it currently stands, the conditions and failure mode are opaque to userland, which is never a good thing. > mounting the same subset perfectly well, even if it includes memcg. BTW, > AFAIU in the unified hierarchy we won't have this problem at all, > because by definition it mounts all controllers IIRC, so do we need to > bother fixing this in such a complicated manner at all for the setup > that's going to be deprecated anyway? There will likely be a quite long transition period and if and when the old things can be removed, this added cleanup logic can go away with it. It depends on how complex the implementation would get but as long as it isn't too much and stays mostly isolated from the saner paths, I think it's probably the right thing to do. Thanks. -- tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org> To: Vladimir Davydov <vdavydov@parallels.com> Cc: Johannes Weiner <hannes@cmpxchg.org>, "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>, linux-mm@kvack.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Will Deacon <Will.Deacon@arm.com> Subject: Re: [PATCH cgroup/for-3.19-fixes] cgroup: implement cgroup_subsys->unbind() callback Date: Mon, 12 Jan 2015 06:28:45 -0500 [thread overview] Message-ID: <20150112112845.GS25319@htj.dyndns.org> (raw) In-Reply-To: <20150112080114.GE2110@esperanza> Hello, Vladimir. On Mon, Jan 12, 2015 at 11:01:14AM +0300, Vladimir Davydov wrote: > Come to think of it, I wonder how many users actually want to mount > different controllers subset after unmount. Because we could allow It wouldn't be a common use case but, on the face of it, we still support it. If we collecctively decide that once a sub cgroup is created for any controller no further hierarchy configuration for that controller is allowed, that'd work too, but one way or the other, the behavior, I believe, should be well-defined. As it currently stands, the conditions and failure mode are opaque to userland, which is never a good thing. > mounting the same subset perfectly well, even if it includes memcg. BTW, > AFAIU in the unified hierarchy we won't have this problem at all, > because by definition it mounts all controllers IIRC, so do we need to > bother fixing this in such a complicated manner at all for the setup > that's going to be deprecated anyway? There will likely be a quite long transition period and if and when the old things can be removed, this added cleanup logic can go away with it. It depends on how complex the implementation would get but as long as it isn't too much and stays mostly isolated from the saner paths, I think it's probably the right thing to do. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-12 11:28 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-09 17:43 [Regression] 3.19-rc3 : memcg: Hang in mount memcg Suzuki K. Poulose 2015-01-09 17:43 ` Suzuki K. Poulose 2015-01-09 21:46 ` Tejun Heo 2015-01-09 21:46 ` Tejun Heo 2015-01-12 17:02 ` Suzuki K. Poulose 2015-01-12 17:02 ` Suzuki K. Poulose 2015-01-10 8:55 ` Vladimir Davydov 2015-01-10 8:55 ` Vladimir Davydov 2015-01-10 21:43 ` [PATCH cgroup/for-3.19-fixes] cgroup: implement cgroup_subsys->unbind() callback Tejun Heo 2015-01-10 21:43 ` Tejun Heo 2015-01-11 20:55 ` Johannes Weiner 2015-01-11 20:55 ` Johannes Weiner 2015-01-12 8:01 ` Vladimir Davydov 2015-01-12 8:01 ` Vladimir Davydov 2015-01-12 11:28 ` Tejun Heo [this message] 2015-01-12 11:28 ` Tejun Heo 2015-01-12 12:59 ` Vladimir Davydov 2015-01-12 12:59 ` Vladimir Davydov 2015-01-12 13:05 ` Tejun Heo 2015-01-12 13:05 ` Tejun Heo 2015-01-14 11:16 ` Suzuki K. Poulose 2015-01-14 11:16 ` Suzuki K. Poulose 2015-01-15 17:56 ` Michal Hocko 2015-01-15 17:56 ` Michal Hocko 2015-01-15 17:26 ` Michal Hocko 2015-01-15 17:26 ` Michal Hocko 2015-01-19 12:51 ` [Regression] 3.19-rc3 : memcg: Hang in mount memcg Suzuki K. Poulose 2015-01-19 12:51 ` Suzuki K. Poulose 2015-01-21 16:39 ` Will Deacon 2015-01-21 16:39 ` Will Deacon 2015-01-22 13:45 ` Johannes Weiner 2015-01-22 13:45 ` Johannes Weiner 2015-01-22 14:34 ` Tejun Heo 2015-01-22 14:34 ` Tejun Heo 2015-01-22 15:19 ` Johannes Weiner 2015-01-22 15:19 ` Johannes Weiner 2015-01-22 15:28 ` Tejun Heo 2015-01-22 15:28 ` Tejun Heo 2015-01-23 15:00 ` Suzuki K. Poulose 2015-01-23 15:00 ` Suzuki K. Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150112112845.GS25319@htj.dyndns.org \ --to=tj@kernel.org \ --cc=Suzuki.Poulose@arm.com \ --cc=Will.Deacon@arm.com \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=vdavydov@parallels.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.