Re: [PATCH] MIPS: Changed current_thread_info() to an equivalent supported by both clang and GCC

From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Sanders <Daniel.Sanders@imgtec.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	Paul Burton <Paul.Burton@imgtec.com>,
	Markos Chandras <Markos.Chandras@imgtec.com>,
	James Hogan <James.Hogan@imgtec.com>,
	Behan Webster <behanw@converseincode.com>
Subject: Re: [PATCH] MIPS: Changed current_thread_info() to an equivalent supported by both clang and GCC
Date: Fri, 16 Jan 2015 15:37:25 +0100	[thread overview]
Message-ID: <20150116143725.GB22296@linux-mips.org> (raw)
In-Reply-To: <E484D272A3A61B4880CDF2E712E9279F458E8336@hhmail02.hh.imgtec.org>

On Sat, Jan 10, 2015 at 12:53:22PM +0000, Daniel Sanders wrote:

> The main reason I renamed it is that identifiers starting with '__' are reserved. It's pretty unlikely but it's possible that the name will conflict with a C implementation in the future.

The whole kernel is using identifiers starting with a double underscore
left and right.  The risk should be acceptable though - also because the
kernel isn't linked against external libraries.

The sole reason why _current_thread_info was a local variable is so nobody
else can use it - the proper interface to use is current_thread_info().

Other than that, both the current and the proposed variant aren't really
correct for a variable that really is per thread.  So I'm going to just
queue this for 3.20.

Thanks!

  Ralf