From: Andrew Lunn <andrew@lunn.ch> To: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: arnd@arndb.de, olof@lixom.net, linux@arm.linux.org.uk, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] ARM: Marvell: Remove init cpus function Date: Mon, 19 Jan 2015 22:30:28 +0100 [thread overview] Message-ID: <20150119213028.GB2938@lunn.ch> (raw) In-Reply-To: <1421686381-12397-1-git-send-email-daniel.lezcano@linaro.org> On Mon, Jan 19, 2015 at 05:52:59PM +0100, Daniel Lezcano wrote: > With the next patches, the init cpus function will be changed to be factored > out. > > The function 'armada_xp_smp_init_cpus' does nothing more than a sanity check > after the DT has been parsed. Even if this code is valid, it does not give a > real benefit as the DT should be correctly filled. > > Remove this callback. Hi Daniel What is your plan for getting these merged? Do you want me to take the mvebu patch? Or are you thinking of sending the complete series to the arm-soc maintainers? Thanks Andrew > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm/mach-mvebu/platsmp.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c > index 58cc8c1..3e93422 100644 > --- a/arch/arm/mach-mvebu/platsmp.c > +++ b/arch/arm/mach-mvebu/platsmp.c > @@ -30,8 +30,6 @@ > #include "pmsu.h" > #include "coherency.h" > > -#define ARMADA_XP_MAX_CPUS 4 > - > #define AXP_BOOTROM_BASE 0xfff00000 > #define AXP_BOOTROM_SIZE 0x100000 > > @@ -114,14 +112,6 @@ static void armada_xp_secondary_init(unsigned int cpu) > mvebu_v7_pmsu_idle_exit(); > } > > -static void __init armada_xp_smp_init_cpus(void) > -{ > - unsigned int ncores = num_possible_cpus(); > - > - if (ncores == 0 || ncores > ARMADA_XP_MAX_CPUS) > - panic("Invalid number of CPUs in DT\n"); > -} > - > static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus) > { > struct device_node *node; > @@ -171,7 +161,6 @@ static int armada_xp_cpu_kill(unsigned int cpu) > #endif > > struct smp_operations armada_xp_smp_ops __initdata = { > - .smp_init_cpus = armada_xp_smp_init_cpus, > .smp_prepare_cpus = armada_xp_smp_prepare_cpus, > .smp_boot_secondary = armada_xp_boot_secondary, > .smp_secondary_init = armada_xp_secondary_init, > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] ARM: Marvell: Remove init cpus function Date: Mon, 19 Jan 2015 22:30:28 +0100 [thread overview] Message-ID: <20150119213028.GB2938@lunn.ch> (raw) In-Reply-To: <1421686381-12397-1-git-send-email-daniel.lezcano@linaro.org> On Mon, Jan 19, 2015 at 05:52:59PM +0100, Daniel Lezcano wrote: > With the next patches, the init cpus function will be changed to be factored > out. > > The function 'armada_xp_smp_init_cpus' does nothing more than a sanity check > after the DT has been parsed. Even if this code is valid, it does not give a > real benefit as the DT should be correctly filled. > > Remove this callback. Hi Daniel What is your plan for getting these merged? Do you want me to take the mvebu patch? Or are you thinking of sending the complete series to the arm-soc maintainers? Thanks Andrew > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm/mach-mvebu/platsmp.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c > index 58cc8c1..3e93422 100644 > --- a/arch/arm/mach-mvebu/platsmp.c > +++ b/arch/arm/mach-mvebu/platsmp.c > @@ -30,8 +30,6 @@ > #include "pmsu.h" > #include "coherency.h" > > -#define ARMADA_XP_MAX_CPUS 4 > - > #define AXP_BOOTROM_BASE 0xfff00000 > #define AXP_BOOTROM_SIZE 0x100000 > > @@ -114,14 +112,6 @@ static void armada_xp_secondary_init(unsigned int cpu) > mvebu_v7_pmsu_idle_exit(); > } > > -static void __init armada_xp_smp_init_cpus(void) > -{ > - unsigned int ncores = num_possible_cpus(); > - > - if (ncores == 0 || ncores > ARMADA_XP_MAX_CPUS) > - panic("Invalid number of CPUs in DT\n"); > -} > - > static void __init armada_xp_smp_prepare_cpus(unsigned int max_cpus) > { > struct device_node *node; > @@ -171,7 +161,6 @@ static int armada_xp_cpu_kill(unsigned int cpu) > #endif > > struct smp_operations armada_xp_smp_ops __initdata = { > - .smp_init_cpus = armada_xp_smp_init_cpus, > .smp_prepare_cpus = armada_xp_smp_prepare_cpus, > .smp_boot_secondary = armada_xp_boot_secondary, > .smp_secondary_init = armada_xp_secondary_init, > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-01-19 21:32 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-19 16:52 [PATCH 1/3] ARM: Marvell: Remove init cpus function Daniel Lezcano 2015-01-19 16:52 ` Daniel Lezcano 2015-01-19 16:53 ` [PATCH 2/3] ARM: Make smp_init_cpus to return the number of cores Daniel Lezcano 2015-01-19 16:53 ` Daniel Lezcano 2015-01-19 16:53 ` [PATCH 3/3] ARM: Factor out the smp_init_cpus function Daniel Lezcano 2015-01-19 16:53 ` Daniel Lezcano 2015-01-19 17:53 ` [PATCH 1/3] ARM: Marvell: Remove init cpus function Gregory CLEMENT 2015-01-19 17:53 ` Gregory CLEMENT 2015-01-19 21:30 ` Andrew Lunn [this message] 2015-01-19 21:30 ` Andrew Lunn 2015-01-19 22:02 ` Daniel Lezcano 2015-01-19 22:02 ` Daniel Lezcano 2015-01-23 13:15 ` Daniel Lezcano 2015-01-23 13:15 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150119213028.GB2938@lunn.ch \ --to=andrew@lunn.ch \ --cc=arnd@arndb.de \ --cc=daniel.lezcano@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=olof@lixom.net \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.