* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 0:03 ` Paul Walmsley
0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2015-01-21 0:03 UTC (permalink / raw)
To: gregory.clement
Cc: hdegoede, tj, treding, pwalmsley, linux-tegra, linux-arm-kernel,
linux-kernel, linux-next, linux-ide
(linux-ide@ added)
Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
using multiple regulators") in Linux-next 20150120 causes a panic
during boot on multiple Tegra boards:
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
Taking the latter boot log as an example, the 6b6b6b9f value that the
kernel is trying to dereference is being passed into _regulator_put() as a
struct regulator *.
- Paul
[ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
[ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
[ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
[ 1.382689] pgd = c0004000
[ 1.385517] [6b6b6b9f] *pgd=00000000
[ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
[ 1.394403] Modules linked in:
[ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
[ 1.417891] PC is at _regulator_put+0x14/0xa0
[ 1.422241] LR is at regulator_put+0x1c/0x2c
[ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
[ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
[ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
[ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
[ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
[ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
[ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
[ 1.475242] Stack: (0xee055e40 to 0xee056000)
[ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
[ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
[ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
[ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
[ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
[ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
[ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
[ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
[ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
[ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
[ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
[ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
[ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
[ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
[ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
[ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
[ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
[ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
[ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
[ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
[ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
[ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
[ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
[ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
[ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
[ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
[ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
[ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 1.704225]
[ 1.713348] CPU2: stopping
[ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
[ 1.774734] 9f80: ffffffed 00000000
[ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
[ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.821831] CPU3: stopping
[ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
[ 1.883212] bf80: ffffffed 00000000
[ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
[ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.930309] CPU1: stopping
[ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
[ 1.991690] 7f80: ffffffed 00000000
[ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
[ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 2.038794]
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 0:03 ` Paul Walmsley
0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2015-01-21 0:03 UTC (permalink / raw)
To: gregory.clement
Cc: hdegoede, tj, treding, pwalmsley, linux-tegra, linux-arm-kernel,
linux-kernel, linux-next, linux-ide
(linux-ide@ added)
Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
using multiple regulators") in Linux-next 20150120 causes a panic
during boot on multiple Tegra boards:
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
Taking the latter boot log as an example, the 6b6b6b9f value that the
kernel is trying to dereference is being passed into _regulator_put() as a
struct regulator *.
- Paul
[ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
[ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
[ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
[ 1.382689] pgd = c0004000
[ 1.385517] [6b6b6b9f] *pgd=00000000
[ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
[ 1.394403] Modules linked in:
[ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
[ 1.417891] PC is at _regulator_put+0x14/0xa0
[ 1.422241] LR is at regulator_put+0x1c/0x2c
[ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
[ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
[ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
[ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
[ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
[ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
[ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
[ 1.475242] Stack: (0xee055e40 to 0xee056000)
[ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
[ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
[ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
[ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
[ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
[ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
[ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
[ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
[ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
[ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
[ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
[ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
[ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
[ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
[ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
[ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
[ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
[ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
[ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
[ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
[ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
[ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
[ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
[ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
[ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
[ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
[ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
[ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 1.704225]
[ 1.713348] CPU2: stopping
[ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
[ 1.774734] 9f80: ffffffed 00000000
[ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
[ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.821831] CPU3: stopping
[ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
[ 1.883212] bf80: ffffffed 00000000
[ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
[ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.930309] CPU1: stopping
[ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
[ 1.991690] 7f80: ffffffed 00000000
[ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
[ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 2.038794]
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 0:03 ` Paul Walmsley
0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2015-01-21 0:03 UTC (permalink / raw)
To: linux-arm-kernel
(linux-ide@ added)
Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
using multiple regulators") in Linux-next 20150120 causes a panic
during boot on multiple Tegra boards:
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
Taking the latter boot log as an example, the 6b6b6b9f value that the
kernel is trying to dereference is being passed into _regulator_put() as a
struct regulator *.
- Paul
[ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
[ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
[ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
[ 1.382689] pgd = c0004000
[ 1.385517] [6b6b6b9f] *pgd=00000000
[ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
[ 1.394403] Modules linked in:
[ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
[ 1.417891] PC is at _regulator_put+0x14/0xa0
[ 1.422241] LR is at regulator_put+0x1c/0x2c
[ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
[ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
[ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
[ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
[ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
[ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
[ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
[ 1.475242] Stack: (0xee055e40 to 0xee056000)
[ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
[ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
[ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
[ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
[ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
[ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
[ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
[ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
[ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
[ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
[ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
[ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
[ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
[ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
[ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
[ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
[ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
[ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
[ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
[ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
[ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
[ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
[ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
[ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
[ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
[ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
[ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
[ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 1.704225]
[ 1.713348] CPU2: stopping
[ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
[ 1.774734] 9f80: ffffffed 00000000
[ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
[ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.821831] CPU3: stopping
[ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
[ 1.883212] bf80: ffffffed 00000000
[ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
[ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.930309] CPU1: stopping
[ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
[ 1.991690] 7f80: ffffffed 00000000
[ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
[ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 2.038794]
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
2015-01-21 0:03 ` Paul Walmsley
(?)
@ 2015-01-21 10:50 ` Thierry Reding
-1 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 10:50 UTC (permalink / raw)
To: Paul Walmsley
Cc: gregory.clement, hdegoede, tj, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
[-- Attachment #1.1: Type: text/plain, Size: 13191 bytes --]
On Wed, Jan 21, 2015 at 12:03:41AM +0000, Paul Walmsley wrote:
> (linux-ide@ added)
>
> Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
> using multiple regulators") in Linux-next 20150120 causes a panic
> during boot on multiple Tegra boards:
>
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
>
> Taking the latter boot log as an example, the 6b6b6b9f value that the
> kernel is trying to dereference is being passed into _regulator_put() as a
> struct regulator *.
>
>
> - Paul
>
Here's the devres log of what's happening:
[ 4.949689] tegra-ahci 70027000.sata: DEVRES ADD ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.957886] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.965984] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.974079] tegra-ahci 70027000.sata: DEVRES REM ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.982298] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 grp< (0 bytes)
[ 4.989006] tegra-ahci 70027000.sata: DEVRES ADD ee1dae00 ahci_platform_put_resources (96 bytes)
[ 4.997784] tegra-ahci 70027000.sata: DEVRES ADD ee1e2980 devm_region_release (12 bytes)
[ 5.005879] tegra-ahci 70027000.sata: DEVRES ADD ee1e2900 devm_ioremap_release (4 bytes)
[ 5.014005] tegra-ahci 70027000.sata: DEVRES ADD ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.022096] tegra-ahci 70027000.sata: DEVRES ADD ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.030209] tegra-ahci 70027000.sata: DEVRES ADD ee1e2840 devm_phy_release (4 bytes)
[ 5.037952] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 grp< (0 bytes)
[ 5.044660] tegra-ahci 70027000.sata: DEVRES ADD ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.052845] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_region_release (12 bytes)
[ 5.060938] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.069039] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.077647] tegra-ahci 70027000.sata: DEVRES ADD ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.086271] tegra-ahci 70027000.sata: DEVRES ADD ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.094890] tegra-ahci 70027000.sata: DEVRES ADD ee1e2dc0 devm_clk_release (4 bytes)
[ 5.102659] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 5.109276] tegra-ahci 70027000.sata: Failed to get regulators
[ 5.115103] tegra-ahci 70027000.sata: DEVRES REL ee1e2dc0 devm_clk_release (4 bytes)
[ 5.122850] tegra-ahci 70027000.sata: DEVRES REL ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.131462] tegra-ahci 70027000.sata: DEVRES REL ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.140073] tegra-ahci 70027000.sata: DEVRES REL ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.148672] tegra-ahci 70027000.sata: DEVRES REL ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.156764] tegra-ahci 70027000.sata: DEVRES REL ee1e29c0 devm_region_release (12 bytes)
[ 5.164856] tegra-ahci 70027000.sata: DEVRES REL ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.173034] tegra-ahci 70027000.sata: DEVRES REL ee1e2840 devm_phy_release (4 bytes)
[ 5.180778] tegra-ahci 70027000.sata: DEVRES REL ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.188868] tegra-ahci 70027000.sata: DEVRES REL ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.196948] tegra-ahci 70027000.sata: DEVRES REL ee1e2900 devm_ioremap_release (4 bytes)
[ 5.205037] tegra-ahci 70027000.sata: DEVRES REL ee1e2980 devm_region_release (12 bytes)
[ 5.213129] tegra-ahci 70027000.sata: DEVRES REL ee1dae00 ahci_platform_put_resources (96 bytes)
What's happening here is that ahci_platform_put_resources() is added to
the devres list before the devm_kzalloc() that allocates the target_pwrs
array, which causes the target_pwrs array to be freed before devres gets
to call ahci_platform_put_resources().
Mixing managed and non-managed resources this way doesn't work, so I had
to apply the attached patch to fix this.
Tejun, preferably the attached patch should be squashed into commit
c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
breaking bisectability. If you don't want to rewrite history, let me
know and I can turn it into a proper patch.
Thierry
> [ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
> [ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
> [ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
> [ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
> [ 1.382689] pgd = c0004000
> [ 1.385517] [6b6b6b9f] *pgd=00000000
> [ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [ 1.394403] Modules linked in:
> [ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
> [ 1.417891] PC is at _regulator_put+0x14/0xa0
> [ 1.422241] LR is at regulator_put+0x1c/0x2c
> [ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
> [ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
> [ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
> [ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
> [ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
> [ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> [ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
> [ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
> [ 1.475242] Stack: (0xee055e40 to 0xee056000)
> [ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
> [ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
> [ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
> [ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
> [ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
> [ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
> [ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
> [ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
> [ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
> [ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
> [ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
> [ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
> [ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
> [ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
> [ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
> [ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
> [ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
> [ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
> [ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
> [ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
> [ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
> [ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
> [ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
> [ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
> [ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
> [ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
> [ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
> [ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 1.704225]
> [ 1.713348] CPU2: stopping
> [ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
> [ 1.774734] 9f80: ffffffed 00000000
> [ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
> [ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.821831] CPU3: stopping
> [ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
> [ 1.883212] bf80: ffffffed 00000000
> [ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
> [ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.930309] CPU1: stopping
> [ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
> [ 1.991690] 7f80: ffffffed 00000000
> [ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
> [ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 2.038794]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #1.2: patch --]
[-- Type: text/plain, Size: 850 bytes --]
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 73a086664ee7..504d534ccbfe 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -276,6 +276,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
+ kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -412,7 +413,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
goto err_out;
}
sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
- hpriv->target_pwrs = devm_kzalloc(dev, sz, GFP_KERNEL);
+ hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 10:50 ` Thierry Reding
0 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 10:50 UTC (permalink / raw)
To: Paul Walmsley, Tejun Heo
Cc: gregory.clement, hdegoede, tj, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
[-- Attachment #1.1: Type: text/plain, Size: 13191 bytes --]
On Wed, Jan 21, 2015 at 12:03:41AM +0000, Paul Walmsley wrote:
> (linux-ide@ added)
>
> Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
> using multiple regulators") in Linux-next 20150120 causes a panic
> during boot on multiple Tegra boards:
>
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
>
> Taking the latter boot log as an example, the 6b6b6b9f value that the
> kernel is trying to dereference is being passed into _regulator_put() as a
> struct regulator *.
>
>
> - Paul
>
Here's the devres log of what's happening:
[ 4.949689] tegra-ahci 70027000.sata: DEVRES ADD ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.957886] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.965984] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.974079] tegra-ahci 70027000.sata: DEVRES REM ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.982298] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 grp< (0 bytes)
[ 4.989006] tegra-ahci 70027000.sata: DEVRES ADD ee1dae00 ahci_platform_put_resources (96 bytes)
[ 4.997784] tegra-ahci 70027000.sata: DEVRES ADD ee1e2980 devm_region_release (12 bytes)
[ 5.005879] tegra-ahci 70027000.sata: DEVRES ADD ee1e2900 devm_ioremap_release (4 bytes)
[ 5.014005] tegra-ahci 70027000.sata: DEVRES ADD ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.022096] tegra-ahci 70027000.sata: DEVRES ADD ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.030209] tegra-ahci 70027000.sata: DEVRES ADD ee1e2840 devm_phy_release (4 bytes)
[ 5.037952] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 grp< (0 bytes)
[ 5.044660] tegra-ahci 70027000.sata: DEVRES ADD ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.052845] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_region_release (12 bytes)
[ 5.060938] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.069039] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.077647] tegra-ahci 70027000.sata: DEVRES ADD ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.086271] tegra-ahci 70027000.sata: DEVRES ADD ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.094890] tegra-ahci 70027000.sata: DEVRES ADD ee1e2dc0 devm_clk_release (4 bytes)
[ 5.102659] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 5.109276] tegra-ahci 70027000.sata: Failed to get regulators
[ 5.115103] tegra-ahci 70027000.sata: DEVRES REL ee1e2dc0 devm_clk_release (4 bytes)
[ 5.122850] tegra-ahci 70027000.sata: DEVRES REL ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.131462] tegra-ahci 70027000.sata: DEVRES REL ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.140073] tegra-ahci 70027000.sata: DEVRES REL ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.148672] tegra-ahci 70027000.sata: DEVRES REL ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.156764] tegra-ahci 70027000.sata: DEVRES REL ee1e29c0 devm_region_release (12 bytes)
[ 5.164856] tegra-ahci 70027000.sata: DEVRES REL ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.173034] tegra-ahci 70027000.sata: DEVRES REL ee1e2840 devm_phy_release (4 bytes)
[ 5.180778] tegra-ahci 70027000.sata: DEVRES REL ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.188868] tegra-ahci 70027000.sata: DEVRES REL ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.196948] tegra-ahci 70027000.sata: DEVRES REL ee1e2900 devm_ioremap_release (4 bytes)
[ 5.205037] tegra-ahci 70027000.sata: DEVRES REL ee1e2980 devm_region_release (12 bytes)
[ 5.213129] tegra-ahci 70027000.sata: DEVRES REL ee1dae00 ahci_platform_put_resources (96 bytes)
What's happening here is that ahci_platform_put_resources() is added to
the devres list before the devm_kzalloc() that allocates the target_pwrs
array, which causes the target_pwrs array to be freed before devres gets
to call ahci_platform_put_resources().
Mixing managed and non-managed resources this way doesn't work, so I had
to apply the attached patch to fix this.
Tejun, preferably the attached patch should be squashed into commit
c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
breaking bisectability. If you don't want to rewrite history, let me
know and I can turn it into a proper patch.
Thierry
> [ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
> [ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
> [ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
> [ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
> [ 1.382689] pgd = c0004000
> [ 1.385517] [6b6b6b9f] *pgd=00000000
> [ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [ 1.394403] Modules linked in:
> [ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
> [ 1.417891] PC is at _regulator_put+0x14/0xa0
> [ 1.422241] LR is at regulator_put+0x1c/0x2c
> [ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
> [ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
> [ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
> [ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
> [ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
> [ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> [ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
> [ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
> [ 1.475242] Stack: (0xee055e40 to 0xee056000)
> [ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
> [ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
> [ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
> [ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
> [ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
> [ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
> [ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
> [ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
> [ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
> [ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
> [ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
> [ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
> [ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
> [ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
> [ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
> [ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
> [ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
> [ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
> [ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
> [ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
> [ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
> [ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
> [ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
> [ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
> [ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
> [ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
> [ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
> [ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 1.704225]
> [ 1.713348] CPU2: stopping
> [ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
> [ 1.774734] 9f80: ffffffed 00000000
> [ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
> [ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.821831] CPU3: stopping
> [ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
> [ 1.883212] bf80: ffffffed 00000000
> [ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
> [ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.930309] CPU1: stopping
> [ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
> [ 1.991690] 7f80: ffffffed 00000000
> [ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
> [ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 2.038794]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #1.2: patch --]
[-- Type: text/plain, Size: 850 bytes --]
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 73a086664ee7..504d534ccbfe 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -276,6 +276,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
+ kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -412,7 +413,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
goto err_out;
}
sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
- hpriv->target_pwrs = devm_kzalloc(dev, sz, GFP_KERNEL);
+ hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 10:50 ` Thierry Reding
0 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 10:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 21, 2015 at 12:03:41AM +0000, Paul Walmsley wrote:
> (linux-ide@ added)
>
> Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
> using multiple regulators") in Linux-next 20150120 causes a panic
> during boot on multiple Tegra boards:
>
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
>
> Taking the latter boot log as an example, the 6b6b6b9f value that the
> kernel is trying to dereference is being passed into _regulator_put() as a
> struct regulator *.
>
>
> - Paul
>
Here's the devres log of what's happening:
[ 4.949689] tegra-ahci 70027000.sata: DEVRES ADD ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.957886] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.965984] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 devm_pinctrl_release (4 bytes)
[ 4.974079] tegra-ahci 70027000.sata: DEVRES REM ee1e2a00 devm_kzalloc_release (16 bytes)
[ 4.982298] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 grp< (0 bytes)
[ 4.989006] tegra-ahci 70027000.sata: DEVRES ADD ee1dae00 ahci_platform_put_resources (96 bytes)
[ 4.997784] tegra-ahci 70027000.sata: DEVRES ADD ee1e2980 devm_region_release (12 bytes)
[ 5.005879] tegra-ahci 70027000.sata: DEVRES ADD ee1e2900 devm_ioremap_release (4 bytes)
[ 5.014005] tegra-ahci 70027000.sata: DEVRES ADD ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.022096] tegra-ahci 70027000.sata: DEVRES ADD ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.030209] tegra-ahci 70027000.sata: DEVRES ADD ee1e2840 devm_phy_release (4 bytes)
[ 5.037952] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 grp< (0 bytes)
[ 5.044660] tegra-ahci 70027000.sata: DEVRES ADD ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.052845] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_region_release (12 bytes)
[ 5.060938] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.069039] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.077647] tegra-ahci 70027000.sata: DEVRES ADD ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.086271] tegra-ahci 70027000.sata: DEVRES ADD ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.094890] tegra-ahci 70027000.sata: DEVRES ADD ee1e2dc0 devm_clk_release (4 bytes)
[ 5.102659] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 5.109276] tegra-ahci 70027000.sata: Failed to get regulators
[ 5.115103] tegra-ahci 70027000.sata: DEVRES REL ee1e2dc0 devm_clk_release (4 bytes)
[ 5.122850] tegra-ahci 70027000.sata: DEVRES REL ee1e2e40 devm_reset_control_release (4 bytes)
[ 5.131462] tegra-ahci 70027000.sata: DEVRES REL ee1e2ec0 devm_reset_control_release (4 bytes)
[ 5.140073] tegra-ahci 70027000.sata: DEVRES REL ee1e2f40 devm_reset_control_release (4 bytes)
[ 5.148672] tegra-ahci 70027000.sata: DEVRES REL ee1e2f80 devm_ioremap_release (4 bytes)
[ 5.156764] tegra-ahci 70027000.sata: DEVRES REL ee1e29c0 devm_region_release (12 bytes)
[ 5.164856] tegra-ahci 70027000.sata: DEVRES REL ee1dad80 devm_kzalloc_release (84 bytes)
[ 5.173034] tegra-ahci 70027000.sata: DEVRES REL ee1e2840 devm_phy_release (4 bytes)
[ 5.180778] tegra-ahci 70027000.sata: DEVRES REL ee1e2880 devm_kzalloc_release (4 bytes)
[ 5.188868] tegra-ahci 70027000.sata: DEVRES REL ee1e28c0 devm_kzalloc_release (4 bytes)
[ 5.196948] tegra-ahci 70027000.sata: DEVRES REL ee1e2900 devm_ioremap_release (4 bytes)
[ 5.205037] tegra-ahci 70027000.sata: DEVRES REL ee1e2980 devm_region_release (12 bytes)
[ 5.213129] tegra-ahci 70027000.sata: DEVRES REL ee1dae00 ahci_platform_put_resources (96 bytes)
What's happening here is that ahci_platform_put_resources() is added to
the devres list before the devm_kzalloc() that allocates the target_pwrs
array, which causes the target_pwrs array to be freed before devres gets
to call ahci_platform_put_resources().
Mixing managed and non-managed resources this way doesn't work, so I had
to apply the attached patch to fix this.
Tejun, preferably the attached patch should be squashed into commit
c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
breaking bisectability. If you don't want to rewrite history, let me
know and I can turn it into a proper patch.
Thierry
> [ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
> [ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
> [ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
> [ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
> [ 1.382689] pgd = c0004000
> [ 1.385517] [6b6b6b9f] *pgd=00000000
> [ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> [ 1.394403] Modules linked in:
> [ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
> [ 1.417891] PC is at _regulator_put+0x14/0xa0
> [ 1.422241] LR is at regulator_put+0x1c/0x2c
> [ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
> [ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
> [ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
> [ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
> [ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
> [ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> [ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
> [ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
> [ 1.475242] Stack: (0xee055e40 to 0xee056000)
> [ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
> [ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
> [ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
> [ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
> [ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
> [ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
> [ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
> [ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
> [ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
> [ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
> [ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
> [ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
> [ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
> [ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
> [ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
> [ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
> [ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
> [ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
> [ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
> [ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
> [ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
> [ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
> [ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
> [ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
> [ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
> [ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
> [ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
> [ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 1.704225]
> [ 1.713348] CPU2: stopping
> [ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
> [ 1.774734] 9f80: ffffffed 00000000
> [ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
> [ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.821831] CPU3: stopping
> [ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
> [ 1.883212] bf80: ffffffed 00000000
> [ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
> [ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 1.930309] CPU1: stopping
> [ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
> [ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
> [ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
> [ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
> [ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
> [ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
> [ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
> [ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
> [ 1.991690] 7f80: ffffffed 00000000
> [ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
> [ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
> [ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
> [ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
> [ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
> [ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> [ 2.038794]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-------------- next part --------------
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 73a086664ee7..504d534ccbfe 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -276,6 +276,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
+ kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -412,7 +413,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
goto err_out;
}
sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
- hpriv->target_pwrs = devm_kzalloc(dev, sz, GFP_KERNEL);
+ hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150121/4ce5c96b/attachment.sig>
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
2015-01-21 10:50 ` Thierry Reding
@ 2015-01-21 11:23 ` Gregory CLEMENT
-1 siblings, 0 replies; 19+ messages in thread
From: Gregory CLEMENT @ 2015-01-21 11:23 UTC (permalink / raw)
To: Thierry Reding
Cc: Paul Walmsley, Tejun Heo, hdegoede, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
Hi Thierry,
On 21/01/2015 11:50, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 12:03:41AM +0000, Paul Walmsley wrote:
>> (linux-ide@ added)
>>
>> Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
>> using multiple regulators") in Linux-next 20150120 causes a panic
>> during boot on multiple Tegra boards:
>>
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
>>
>> Taking the latter boot log as an example, the 6b6b6b9f value that the
>> kernel is trying to dereference is being passed into _regulator_put() as a
>> struct regulator *.
>>
>>
>> - Paul
>>
>
> Here's the devres log of what's happening:
>
> [ 4.949689] tegra-ahci 70027000.sata: DEVRES ADD ee1e2a00 devm_kzalloc_release (16 bytes)
> [ 4.957886] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_pinctrl_release (4 bytes)
> [ 4.965984] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 devm_pinctrl_release (4 bytes)
> [ 4.974079] tegra-ahci 70027000.sata: DEVRES REM ee1e2a00 devm_kzalloc_release (16 bytes)
> [ 4.982298] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 grp< (0 bytes)
> [ 4.989006] tegra-ahci 70027000.sata: DEVRES ADD ee1dae00 ahci_platform_put_resources (96 bytes)
> [ 4.997784] tegra-ahci 70027000.sata: DEVRES ADD ee1e2980 devm_region_release (12 bytes)
> [ 5.005879] tegra-ahci 70027000.sata: DEVRES ADD ee1e2900 devm_ioremap_release (4 bytes)
> [ 5.014005] tegra-ahci 70027000.sata: DEVRES ADD ee1e28c0 devm_kzalloc_release (4 bytes)
> [ 5.022096] tegra-ahci 70027000.sata: DEVRES ADD ee1e2880 devm_kzalloc_release (4 bytes)
> [ 5.030209] tegra-ahci 70027000.sata: DEVRES ADD ee1e2840 devm_phy_release (4 bytes)
> [ 5.037952] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 grp< (0 bytes)
> [ 5.044660] tegra-ahci 70027000.sata: DEVRES ADD ee1dad80 devm_kzalloc_release (84 bytes)
> [ 5.052845] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_region_release (12 bytes)
> [ 5.060938] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f80 devm_ioremap_release (4 bytes)
> [ 5.069039] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f40 devm_reset_control_release (4 bytes)
> [ 5.077647] tegra-ahci 70027000.sata: DEVRES ADD ee1e2ec0 devm_reset_control_release (4 bytes)
> [ 5.086271] tegra-ahci 70027000.sata: DEVRES ADD ee1e2e40 devm_reset_control_release (4 bytes)
> [ 5.094890] tegra-ahci 70027000.sata: DEVRES ADD ee1e2dc0 devm_clk_release (4 bytes)
> [ 5.102659] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
> [ 5.109276] tegra-ahci 70027000.sata: Failed to get regulators
> [ 5.115103] tegra-ahci 70027000.sata: DEVRES REL ee1e2dc0 devm_clk_release (4 bytes)
> [ 5.122850] tegra-ahci 70027000.sata: DEVRES REL ee1e2e40 devm_reset_control_release (4 bytes)
> [ 5.131462] tegra-ahci 70027000.sata: DEVRES REL ee1e2ec0 devm_reset_control_release (4 bytes)
> [ 5.140073] tegra-ahci 70027000.sata: DEVRES REL ee1e2f40 devm_reset_control_release (4 bytes)
> [ 5.148672] tegra-ahci 70027000.sata: DEVRES REL ee1e2f80 devm_ioremap_release (4 bytes)
> [ 5.156764] tegra-ahci 70027000.sata: DEVRES REL ee1e29c0 devm_region_release (12 bytes)
> [ 5.164856] tegra-ahci 70027000.sata: DEVRES REL ee1dad80 devm_kzalloc_release (84 bytes)
> [ 5.173034] tegra-ahci 70027000.sata: DEVRES REL ee1e2840 devm_phy_release (4 bytes)
> [ 5.180778] tegra-ahci 70027000.sata: DEVRES REL ee1e2880 devm_kzalloc_release (4 bytes)
> [ 5.188868] tegra-ahci 70027000.sata: DEVRES REL ee1e28c0 devm_kzalloc_release (4 bytes)
> [ 5.196948] tegra-ahci 70027000.sata: DEVRES REL ee1e2900 devm_ioremap_release (4 bytes)
> [ 5.205037] tegra-ahci 70027000.sata: DEVRES REL ee1e2980 devm_region_release (12 bytes)
> [ 5.213129] tegra-ahci 70027000.sata: DEVRES REL ee1dae00 ahci_platform_put_resources (96 bytes)
>
> What's happening here is that ahci_platform_put_resources() is added to
> the devres list before the devm_kzalloc() that allocates the target_pwrs
> array, which causes the target_pwrs array to be freed before devres gets
> to call ahci_platform_put_resources().
>
> Mixing managed and non-managed resources this way doesn't work, so I had
> to apply the attached patch to fix this.
>
> Tejun, preferably the attached patch should be squashed into commit
> c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> breaking bisectability. If you don't want to rewrite history, let me
> know and I can turn it into a proper patch.
Thanks having took care of it. I tested your patch and it didn't introduce
any regression on the board I tested.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 11:23 ` Gregory CLEMENT
0 siblings, 0 replies; 19+ messages in thread
From: Gregory CLEMENT @ 2015-01-21 11:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Thierry,
On 21/01/2015 11:50, Thierry Reding wrote:
> On Wed, Jan 21, 2015 at 12:03:41AM +0000, Paul Walmsley wrote:
>> (linux-ide@ added)
>>
>> Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
>> using multiple regulators") in Linux-next 20150120 causes a panic
>> during boot on multiple Tegra boards:
>>
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
>> http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
>>
>> Taking the latter boot log as an example, the 6b6b6b9f value that the
>> kernel is trying to dereference is being passed into _regulator_put() as a
>> struct regulator *.
>>
>>
>> - Paul
>>
>
> Here's the devres log of what's happening:
>
> [ 4.949689] tegra-ahci 70027000.sata: DEVRES ADD ee1e2a00 devm_kzalloc_release (16 bytes)
> [ 4.957886] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_pinctrl_release (4 bytes)
> [ 4.965984] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 devm_pinctrl_release (4 bytes)
> [ 4.974079] tegra-ahci 70027000.sata: DEVRES REM ee1e2a00 devm_kzalloc_release (16 bytes)
> [ 4.982298] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 grp< (0 bytes)
> [ 4.989006] tegra-ahci 70027000.sata: DEVRES ADD ee1dae00 ahci_platform_put_resources (96 bytes)
> [ 4.997784] tegra-ahci 70027000.sata: DEVRES ADD ee1e2980 devm_region_release (12 bytes)
> [ 5.005879] tegra-ahci 70027000.sata: DEVRES ADD ee1e2900 devm_ioremap_release (4 bytes)
> [ 5.014005] tegra-ahci 70027000.sata: DEVRES ADD ee1e28c0 devm_kzalloc_release (4 bytes)
> [ 5.022096] tegra-ahci 70027000.sata: DEVRES ADD ee1e2880 devm_kzalloc_release (4 bytes)
> [ 5.030209] tegra-ahci 70027000.sata: DEVRES ADD ee1e2840 devm_phy_release (4 bytes)
> [ 5.037952] tegra-ahci 70027000.sata: DEVRES REM ee1e29c0 grp< (0 bytes)
> [ 5.044660] tegra-ahci 70027000.sata: DEVRES ADD ee1dad80 devm_kzalloc_release (84 bytes)
> [ 5.052845] tegra-ahci 70027000.sata: DEVRES ADD ee1e29c0 devm_region_release (12 bytes)
> [ 5.060938] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f80 devm_ioremap_release (4 bytes)
> [ 5.069039] tegra-ahci 70027000.sata: DEVRES ADD ee1e2f40 devm_reset_control_release (4 bytes)
> [ 5.077647] tegra-ahci 70027000.sata: DEVRES ADD ee1e2ec0 devm_reset_control_release (4 bytes)
> [ 5.086271] tegra-ahci 70027000.sata: DEVRES ADD ee1e2e40 devm_reset_control_release (4 bytes)
> [ 5.094890] tegra-ahci 70027000.sata: DEVRES ADD ee1e2dc0 devm_clk_release (4 bytes)
> [ 5.102659] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
> [ 5.109276] tegra-ahci 70027000.sata: Failed to get regulators
> [ 5.115103] tegra-ahci 70027000.sata: DEVRES REL ee1e2dc0 devm_clk_release (4 bytes)
> [ 5.122850] tegra-ahci 70027000.sata: DEVRES REL ee1e2e40 devm_reset_control_release (4 bytes)
> [ 5.131462] tegra-ahci 70027000.sata: DEVRES REL ee1e2ec0 devm_reset_control_release (4 bytes)
> [ 5.140073] tegra-ahci 70027000.sata: DEVRES REL ee1e2f40 devm_reset_control_release (4 bytes)
> [ 5.148672] tegra-ahci 70027000.sata: DEVRES REL ee1e2f80 devm_ioremap_release (4 bytes)
> [ 5.156764] tegra-ahci 70027000.sata: DEVRES REL ee1e29c0 devm_region_release (12 bytes)
> [ 5.164856] tegra-ahci 70027000.sata: DEVRES REL ee1dad80 devm_kzalloc_release (84 bytes)
> [ 5.173034] tegra-ahci 70027000.sata: DEVRES REL ee1e2840 devm_phy_release (4 bytes)
> [ 5.180778] tegra-ahci 70027000.sata: DEVRES REL ee1e2880 devm_kzalloc_release (4 bytes)
> [ 5.188868] tegra-ahci 70027000.sata: DEVRES REL ee1e28c0 devm_kzalloc_release (4 bytes)
> [ 5.196948] tegra-ahci 70027000.sata: DEVRES REL ee1e2900 devm_ioremap_release (4 bytes)
> [ 5.205037] tegra-ahci 70027000.sata: DEVRES REL ee1e2980 devm_region_release (12 bytes)
> [ 5.213129] tegra-ahci 70027000.sata: DEVRES REL ee1dae00 ahci_platform_put_resources (96 bytes)
>
> What's happening here is that ahci_platform_put_resources() is added to
> the devres list before the devm_kzalloc() that allocates the target_pwrs
> array, which causes the target_pwrs array to be freed before devres gets
> to call ahci_platform_put_resources().
>
> Mixing managed and non-managed resources this way doesn't work, so I had
> to apply the attached patch to fix this.
>
> Tejun, preferably the attached patch should be squashed into commit
> c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> breaking bisectability. If you don't want to rewrite history, let me
> know and I can turn it into a proper patch.
Thanks having took care of it. I tested your patch and it didn't introduce
any regression on the board I tested.
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
2015-01-21 10:50 ` Thierry Reding
(?)
@ 2015-01-21 12:31 ` Tejun Heo
-1 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 12:31 UTC (permalink / raw)
To: Thierry Reding
Cc: Paul Walmsley, gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA,
pwalmsley-DDmLM1+adcrQT0dZR+AlfA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-next-u79uwXL29TY76Z2rM5mHXA,
linux-ide-u79uwXL29TY76Z2rM5mHXA
On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> Tejun, preferably the attached patch should be squashed into commit
> c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> breaking bisectability. If you don't want to rewrite history, let me
> know and I can turn it into a proper patch.
Yes, please make it a proper patch.
Thanks a lot!
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 12:31 ` Tejun Heo
0 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 12:31 UTC (permalink / raw)
To: Thierry Reding
Cc: Paul Walmsley, gregory.clement, hdegoede, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> Tejun, preferably the attached patch should be squashed into commit
> c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> breaking bisectability. If you don't want to rewrite history, let me
> know and I can turn it into a proper patch.
Yes, please make it a proper patch.
Thanks a lot!
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 12:31 ` Tejun Heo
0 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 12:31 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> Tejun, preferably the attached patch should be squashed into commit
> c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> breaking bisectability. If you don't want to rewrite history, let me
> know and I can turn it into a proper patch.
Yes, please make it a proper patch.
Thanks a lot!
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
2015-01-21 12:31 ` Tejun Heo
(?)
@ 2015-01-21 15:55 ` Thierry Reding
-1 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 15:55 UTC (permalink / raw)
To: Tejun Heo
Cc: Paul Walmsley, gregory.clement, hdegoede, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]
On Wed, Jan 21, 2015 at 07:31:34AM -0500, Tejun Heo wrote:
> On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> > Tejun, preferably the attached patch should be squashed into commit
> > c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> > breaking bisectability. If you don't want to rewrite history, let me
> > know and I can turn it into a proper patch.
>
> Yes, please make it a proper patch.
>
> Thanks a lot!
Attaching the patch.
Thierry
[-- Attachment #1.2: 0001-ata-libahci-Fix-devres-cleanup-on-failure.patch --]
[-- Type: text/x-diff, Size: 2009 bytes --]
From a4f78e3ec05f1b2ad86aa44d6bd5394d75a23a06 Mon Sep 17 00:00:00 2001
From: Thierry Reding <treding@nvidia.com>
Date: Wed, 21 Jan 2015 11:50:52 +0100
Subject: [PATCH] ata: libahci: Fix devres cleanup on failure
Commit c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
releases regulators during ahci_platform_put_resources(). That doesn't
work because the function is run as part of the devres machinery. Such
resources are torn down in reverse order. Since the array that holds
pointers to the regulators is allocated using devres after the device
context to which ahci_platform_put_resources() is attached, the memory
will be freed before calling ahci_platform_put_resources() and thereby
causing a use-after-free error.
This commit fixes this by using regular allocations for the array. The
memory can then be freed after the regulators have been released. This
conserves the advantages of using the managed API.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/ata/libahci_platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 73a086664ee7..504d534ccbfe 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -276,6 +276,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
+ kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -412,7 +413,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
goto err_out;
}
sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
- hpriv->target_pwrs = devm_kzalloc(dev, sz, GFP_KERNEL);
+ hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
--
2.1.3
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 15:55 ` Thierry Reding
0 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 15:55 UTC (permalink / raw)
To: Tejun Heo
Cc: Paul Walmsley, gregory.clement, hdegoede, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]
On Wed, Jan 21, 2015 at 07:31:34AM -0500, Tejun Heo wrote:
> On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> > Tejun, preferably the attached patch should be squashed into commit
> > c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> > breaking bisectability. If you don't want to rewrite history, let me
> > know and I can turn it into a proper patch.
>
> Yes, please make it a proper patch.
>
> Thanks a lot!
Attaching the patch.
Thierry
[-- Attachment #1.2: 0001-ata-libahci-Fix-devres-cleanup-on-failure.patch --]
[-- Type: text/x-diff, Size: 2009 bytes --]
From a4f78e3ec05f1b2ad86aa44d6bd5394d75a23a06 Mon Sep 17 00:00:00 2001
From: Thierry Reding <treding@nvidia.com>
Date: Wed, 21 Jan 2015 11:50:52 +0100
Subject: [PATCH] ata: libahci: Fix devres cleanup on failure
Commit c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
releases regulators during ahci_platform_put_resources(). That doesn't
work because the function is run as part of the devres machinery. Such
resources are torn down in reverse order. Since the array that holds
pointers to the regulators is allocated using devres after the device
context to which ahci_platform_put_resources() is attached, the memory
will be freed before calling ahci_platform_put_resources() and thereby
causing a use-after-free error.
This commit fixes this by using regular allocations for the array. The
memory can then be freed after the regulators have been released. This
conserves the advantages of using the managed API.
Reported-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/ata/libahci_platform.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 73a086664ee7..504d534ccbfe 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -276,6 +276,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res)
if (hpriv->target_pwrs && hpriv->target_pwrs[c])
regulator_put(hpriv->target_pwrs[c]);
+ kfree(hpriv->target_pwrs);
}
static int ahci_platform_get_phy(struct ahci_host_priv *hpriv, u32 port,
@@ -412,7 +413,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
goto err_out;
}
sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
- hpriv->target_pwrs = devm_kzalloc(dev, sz, GFP_KERNEL);
+ hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
if (!hpriv->target_pwrs) {
rc = -ENOMEM;
goto err_out;
--
2.1.3
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply related [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 15:55 ` Thierry Reding
0 siblings, 0 replies; 19+ messages in thread
From: Thierry Reding @ 2015-01-21 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 21, 2015 at 07:31:34AM -0500, Tejun Heo wrote:
> On Wed, Jan 21, 2015 at 11:50:03AM +0100, Thierry Reding wrote:
> > Tejun, preferably the attached patch should be squashed into commit
> > c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") to avoid
> > breaking bisectability. If you don't want to rewrite history, let me
> > know and I can turn it into a proper patch.
>
> Yes, please make it a proper patch.
>
> Thanks a lot!
Attaching the patch.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ata-libahci-Fix-devres-cleanup-on-failure.patch
Type: text/x-diff
Size: 1961 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150121/416f7897/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150121/416f7897/attachment.sig>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
2015-01-21 15:55 ` Thierry Reding
(?)
@ 2015-01-21 16:25 ` Tejun Heo
-1 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 16:25 UTC (permalink / raw)
To: Thierry Reding
Cc: Paul Walmsley, gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA,
pwalmsley-DDmLM1+adcrQT0dZR+AlfA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-next-u79uwXL29TY76Z2rM5mHXA,
linux-ide-u79uwXL29TY76Z2rM5mHXA
On Wed, Jan 21, 2015 at 04:55:21PM +0100, Thierry Reding wrote:
> From a4f78e3ec05f1b2ad86aa44d6bd5394d75a23a06 Mon Sep 17 00:00:00 2001
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Date: Wed, 21 Jan 2015 11:50:52 +0100
> Subject: [PATCH] ata: libahci: Fix devres cleanup on failure
>
> Commit c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
> releases regulators during ahci_platform_put_resources(). That doesn't
> work because the function is run as part of the devres machinery. Such
> resources are torn down in reverse order. Since the array that holds
> pointers to the regulators is allocated using devres after the device
> context to which ahci_platform_put_resources() is attached, the memory
> will be freed before calling ahci_platform_put_resources() and thereby
> causing a use-after-free error.
>
> This commit fixes this by using regular allocations for the array. The
> memory can then be freed after the regulators have been released. This
> conserves the advantages of using the managed API.
>
> Reported-by: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Applied to libata/for-3.20.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 16:25 ` Tejun Heo
0 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 16:25 UTC (permalink / raw)
To: Thierry Reding
Cc: Paul Walmsley, gregory.clement, hdegoede, pwalmsley, linux-tegra,
linux-arm-kernel, linux-kernel, linux-next, linux-ide
On Wed, Jan 21, 2015 at 04:55:21PM +0100, Thierry Reding wrote:
> From a4f78e3ec05f1b2ad86aa44d6bd5394d75a23a06 Mon Sep 17 00:00:00 2001
> From: Thierry Reding <treding@nvidia.com>
> Date: Wed, 21 Jan 2015 11:50:52 +0100
> Subject: [PATCH] ata: libahci: Fix devres cleanup on failure
>
> Commit c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
> releases regulators during ahci_platform_put_resources(). That doesn't
> work because the function is run as part of the devres machinery. Such
> resources are torn down in reverse order. Since the array that holds
> pointers to the regulators is allocated using devres after the device
> context to which ahci_platform_put_resources() is attached, the memory
> will be freed before calling ahci_platform_put_resources() and thereby
> causing a use-after-free error.
>
> This commit fixes this by using regular allocations for the array. The
> memory can then be freed after the regulators have been released. This
> conserves the advantages of using the managed API.
>
> Reported-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied to libata/for-3.20.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 16:25 ` Tejun Heo
0 siblings, 0 replies; 19+ messages in thread
From: Tejun Heo @ 2015-01-21 16:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 21, 2015 at 04:55:21PM +0100, Thierry Reding wrote:
> From a4f78e3ec05f1b2ad86aa44d6bd5394d75a23a06 Mon Sep 17 00:00:00 2001
> From: Thierry Reding <treding@nvidia.com>
> Date: Wed, 21 Jan 2015 11:50:52 +0100
> Subject: [PATCH] ata: libahci: Fix devres cleanup on failure
>
> Commit c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators")
> releases regulators during ahci_platform_put_resources(). That doesn't
> work because the function is run as part of the devres machinery. Such
> resources are torn down in reverse order. Since the array that holds
> pointers to the regulators is allocated using devres after the device
> context to which ahci_platform_put_resources() is attached, the memory
> will be freed before calling ahci_platform_put_resources() and thereby
> causing a use-after-free error.
>
> This commit fixes this by using regular allocations for the array. The
> memory can then be freed after the regulators have been released. This
> conserves the advantages of using the managed API.
>
> Reported-by: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Applied to libata/for-3.20.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 0:00 ` Paul Walmsley
0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2015-01-21 0:00 UTC (permalink / raw)
To: gregory.clement
Cc: hdegoede, tj, treding, pwalmsley, linux-tegra, linux-arm-kernel,
linux-kernel, linux-next
Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
using multiple regulators") in Linux-next 20150120 causes a panic
during boot on multiple Tegra boards:
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
Taking the latter boot log as an example, the 6b6b6b9f value that the
kernel is trying to dereference is being passed into _regulator_put() as a
struct regulator *.
- Paul
[ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
[ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
[ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
[ 1.382689] pgd = c0004000
[ 1.385517] [6b6b6b9f] *pgd=00000000
[ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
[ 1.394403] Modules linked in:
[ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
[ 1.417891] PC is at _regulator_put+0x14/0xa0
[ 1.422241] LR is at regulator_put+0x1c/0x2c
[ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
[ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
[ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
[ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
[ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
[ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
[ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
[ 1.475242] Stack: (0xee055e40 to 0xee056000)
[ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
[ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
[ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
[ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
[ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
[ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
[ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
[ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
[ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
[ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
[ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
[ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
[ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
[ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
[ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
[ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
[ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
[ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
[ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
[ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
[ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
[ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
[ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
[ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
[ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
[ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
[ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
[ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 1.704225]
[ 1.713348] CPU2: stopping
[ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
[ 1.774734] 9f80: ffffffed 00000000
[ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
[ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.821831] CPU3: stopping
[ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
[ 1.883212] bf80: ffffffed 00000000
[ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
[ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.930309] CPU1: stopping
[ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
[ 1.991690] 7f80: ffffffed 00000000
[ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
[ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 2.038794]
^ permalink raw reply [flat|nested] 19+ messages in thread
* next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators"
@ 2015-01-21 0:00 ` Paul Walmsley
0 siblings, 0 replies; 19+ messages in thread
From: Paul Walmsley @ 2015-01-21 0:00 UTC (permalink / raw)
To: linux-arm-kernel
Commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0 ("ata: libahci: Allow
using multiple regulators") in Linux-next 20150120 causes a panic
during boot on multiple Tegra boards:
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra30-beaver/tegra30-beaver/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra114-dalmore-a04/tegra114-dalmore/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150120/20150120001539/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
Taking the latter boot log as an example, the 6b6b6b9f value that the
kernel is trying to dereference is being passed into _regulator_put() as a
struct regulator *.
- Paul
[ 1.353036] platform as3722-regulator: Driver as3722-regulator requests probe deferral
[ 1.362978] tegra-ahci 70027000.sata: Failed to get supply 'avdd': -517
[ 1.369607] tegra-ahci 70027000.sata: Failed to get regulators
[ 1.375479] Unable to handle kernel paging request at virtual address 6b6b6b9f
[ 1.382689] pgd = c0004000
[ 1.385517] [6b6b6b9f] *pgd=00000000
[ 1.389101] Internal error: Oops: 5 [#1] PREEMPT SMP ARM
[ 1.394403] Modules linked in:
[ 1.397467] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.406237] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.412493] task: ee053840 ti: ee054000 task.ti: ee054000
[ 1.417891] PC is at _regulator_put+0x14/0xa0
[ 1.422241] LR is at regulator_put+0x1c/0x2c
[ 1.426506] pc : [<c027764c>] lr : [<c02776f4>] psr: 00000113
[ 1.426506] sp : ee055e40 ip : ee18aedc fp : 00000000
[ 1.437964] r10: c02f94b4 r9 : c02f94b0 r8 : ee055e70
[ 1.443179] r7 : 0000000d r6 : 00000005 r5 : 6b6b6b6b r4 : 6b6b6b6b
[ 1.449695] r3 : ee053840 r2 : ee055e48 r1 : 00000000 r0 : 6b6b6b6b
[ 1.456213] Flags: nzcv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
[ 1.463509] Control: 10c5387d Table: 8000406a DAC: 00000015
[ 1.469245] Process swapper/0 (pid: 1, stack limit = 0xee054210)
[ 1.475242] Stack: (0xee055e40 to 0xee056000)
[ 1.479596] 5e40: c08ff470 6b6b6b6b 00000005 c02776f4 6b6b6b6b 00000001 ee3d9990 c03481a4
[ 1.487761] 5e60: ee3d9980 ee055e70 ee18ae10 c02f99f8 ee3d9980 ee3ed980 ee18ae10 c09804c0
[ 1.495927] 5e80: fffffdfb c0910898 00000000 c08d31e4 00000000 c02f6ea8 ee18ae10 c0910898
[ 1.504093] 5ea0: ee18ae44 00000000 c08b996c c02f70f0 00000000 c0910898 c02f7064 c02f577c
[ 1.512258] 5ec0: ee036560 ee15f934 c0910898 ee3d9a00 c090dc08 c02f6744 c07e6d00 c0910898
[ 1.520423] 5ee0: c08ee018 c0910898 c08ee018 ee3ed700 c0939340 c02f7714 00000000 c08ee018
[ 1.528588] 5f00: c08ee018 c0008b04 c063dd14 00000014 00000000 00000000 00000000 c012d2dc
[ 1.536752] 5f20: 00000000 c08f2684 60000113 00000001 ef7fcca0 c0659cbc 000000d9 c003bdd4
[ 1.544917] 5f40: c08626bc 00000006 ef7fcca8 00000006 c08f264c ef7fcc40 c08e3474 00000006
[ 1.553082] 5f60: c08d31d8 c0939340 000000d9 c08d31e4 c089c598 c089cd80 00000006 00000006
[ 1.561247] 5f80: c089c598 7fffffff 00000000 c062f028 00000000 00000000 00000000 00000000
[ 1.569413] 5fa0: 00000000 c062f030 00000000 c000e9c0 00000000 00000000 00000000 00000000
[ 1.577578] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[ 1.585743] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff 7fffffff
[ 1.593920] [<c027764c>] (_regulator_put) from [<c02776f4>] (regulator_put+0x1c/0x2c)
[ 1.601751] [<c02776f4>] (regulator_put) from [<c03481a4>] (ahci_platform_put_resources+0x74/0xa0)
[ 1.610704] [<c03481a4>] (ahci_platform_put_resources) from [<c02f99f8>] (release_nodes+0x164/0x1d8)
[ 1.619828] [<c02f99f8>] (release_nodes) from [<c02f6ea8>] (driver_probe_device+0x70/0x22c)
[ 1.628170] [<c02f6ea8>] (driver_probe_device) from [<c02f70f0>] (__driver_attach+0x8c/0x90)
[ 1.636604] [<c02f70f0>] (__driver_attach) from [<c02f577c>] (bus_for_each_dev+0x54/0x88)
[ 1.644774] [<c02f577c>] (bus_for_each_dev) from [<c02f6744>] (bus_add_driver+0xd4/0x1d0)
[ 1.652940] [<c02f6744>] (bus_add_driver) from [<c02f7714>] (driver_register+0x78/0xf4)
[ 1.660936] [<c02f7714>] (driver_register) from [<c0008b04>] (do_one_initcall+0x80/0x1d0)
[ 1.669108] [<c0008b04>] (do_one_initcall) from [<c089cd80>] (kernel_init_freeable+0x108/0x1d4)
[ 1.677802] [<c089cd80>] (kernel_init_freeable) from [<c062f030>] (kernel_init+0x8/0xec)
[ 1.685887] [<c062f030>] (kernel_init) from [<c000e9c0>] (ret_from_fork+0x14/0x34)
[ 1.693447] Code: e2504000 08bd8070 e3740a01 88bd8070 (e5940034)
[ 1.699578] ---[ end trace 6cc7849b05d3269f ]---
[ 1.704225] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 1.704225]
[ 1.713348] CPU2: stopping
[ 1.716059] CPU: 2 PID: 0 Comm: swapper/2 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.726041] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.732316] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.740057] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.747273] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.754660] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.762222] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.769691] Exception stack(0xee079f98 to 0xee079fe0)
[ 1.774734] 9f80: ffffffed 00000000
[ 1.782900] 9fa0: ee079fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.791064] 9fc0: ffffffed 00000000 00000000 ee079fe0 c000f48c c000f490 60000113 ffffffff
[ 1.799236] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.806626] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.814881] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.821831] CPU3: stopping
[ 1.824542] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.834526] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.840797] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.848536] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.855751] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.863138] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.870701] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.878170] Exception stack(0xee07bf98 to 0xee07bfe0)
[ 1.883212] bf80: ffffffed 00000000
[ 1.891377] bfa0: ee07bfe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 1.899543] bfc0: ffffffed 00000000 00000000 ee07bfe0 c000f48c c000f490 60000113 ffffffff
[ 1.907715] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 1.915105] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 1.923358] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 1.930309] CPU1: stopping
[ 1.933018] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G D 3.19.0-rc5-next-20150120-72727-g5d0eebb #1
[ 1.943002] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree)
[ 1.949273] [<c0015a90>] (unwind_backtrace) from [<c00114a8>] (show_stack+0x10/0x14)
[ 1.957012] [<c00114a8>] (show_stack) from [<c0632e9c>] (dump_stack+0x84/0xd0)
[ 1.964227] [<c0632e9c>] (dump_stack) from [<c001429c>] (handle_IPI+0x134/0x160)
[ 1.971614] [<c001429c>] (handle_IPI) from [<c00087d4>] (gic_handle_irq+0x54/0x5c)
[ 1.979177] [<c00087d4>] (gic_handle_irq) from [<c0012000>] (__irq_svc+0x40/0x74)
[ 1.986646] Exception stack(0xee077f98 to 0xee077fe0)
[ 1.991690] 7f80: ffffffed 00000000
[ 1.999856] 7fa0: ee077fe8 c001ee80 c08ea4f8 c08ea494 00000000 00000000 c08e6a00 c08e5d98
[ 2.008022] 7fc0: ffffffed 00000000 00000000 ee077fe0 c000f48c c000f490 60000113 ffffffff
[ 2.016194] [<c0012000>] (__irq_svc) from [<c000f490>] (arch_cpu_idle+0x30/0x3c)
[ 2.023585] [<c000f490>] (arch_cpu_idle) from [<c00554cc>] (cpu_startup_entry+0x1a4/0x278)
[ 2.031838] [<c00554cc>] (cpu_startup_entry) from [<80008864>] (0x80008864)
[ 2.038794] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 2.038794]
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2015-01-21 16:25 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-21 0:03 next-20150120 broken on Tegra by "ata: libahci: Allow using multiple regulators" Paul Walmsley
2015-01-21 0:03 ` Paul Walmsley
2015-01-21 0:03 ` Paul Walmsley
2015-01-21 10:50 ` Thierry Reding
2015-01-21 10:50 ` Thierry Reding
2015-01-21 10:50 ` Thierry Reding
2015-01-21 11:23 ` Gregory CLEMENT
2015-01-21 11:23 ` Gregory CLEMENT
[not found] ` <20150121105001.GA9921-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-01-21 12:31 ` Tejun Heo
2015-01-21 12:31 ` Tejun Heo
2015-01-21 12:31 ` Tejun Heo
2015-01-21 15:55 ` Thierry Reding
2015-01-21 15:55 ` Thierry Reding
2015-01-21 15:55 ` Thierry Reding
[not found] ` <20150121155519.GA25166-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2015-01-21 16:25 ` Tejun Heo
2015-01-21 16:25 ` Tejun Heo
2015-01-21 16:25 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-01-21 0:00 Paul Walmsley
2015-01-21 0:00 ` Paul Walmsley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.