* [PATCH trace] tracing: tracefs_dir_inode_operations can be static
2015-01-21 21:53 [trace:ftrace/tracefs-v1 8/9] fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static? kbuild test robot
@ 2015-01-21 21:53 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-01-21 21:53 UTC (permalink / raw)
To: Steven Rostedt (Red Hat); +Cc: kbuild-all, linux-kernel
fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 29632ce..3462360 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -92,7 +92,7 @@ static int tracefs_syscall_rmdir(struct inode *inode, struct dentry *dentry)
return ret;
}
-const struct inode_operations tracefs_dir_inode_operations = {
+static const struct inode_operations tracefs_dir_inode_operations = {
.lookup = simple_lookup,
.mkdir = tracefs_syscall_mkdir,
.rmdir = tracefs_syscall_rmdir,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [trace:ftrace/tracefs-v1 8/9] fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static?
@ 2015-01-21 21:53 kbuild test robot
2015-01-21 21:53 ` [PATCH trace] tracing: tracefs_dir_inode_operations can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-01-21 21:53 UTC (permalink / raw)
To: Steven Rostedt (Red Hat); +Cc: kbuild-all, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/tracefs-v1
head: a9cda87887e46b28202c20658ad0e8de939b09cd
commit: d85d95eb1961627f3d16ced602f9653ee13ed427 [8/9] tracing: Have mkdir and rmdir be part of tracefs
reproduce:
# apt-get install sparse
git checkout d85d95eb1961627f3d16ced602f9653ee13ed427
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-21 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-21 21:53 [trace:ftrace/tracefs-v1 8/9] fs/tracefs/inode.c:95:31: sparse: symbol 'tracefs_dir_inode_operations' was not declared. Should it be static? kbuild test robot
2015-01-21 21:53 ` [PATCH trace] tracing: tracefs_dir_inode_operations can be static kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.