Re: [PATCH 1/4] x86/HVM: replace plain number in hvm_combine_hw_exceptions()

From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Keir Fraser <keir@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/4] x86/HVM: replace plain number in hvm_combine_hw_exceptions()
Date: Thu, 22 Jan 2015 15:42:09 +0100	[thread overview]
Message-ID: <20150122144209.GA98445@deinos.phlegethon.org> (raw)
In-Reply-To: <54C10FCD0200007800058291@mail.emea.novell.com>

At 13:57 +0000 on 22 Jan (1421931437), Jan Beulich wrote:
> While doing so also take care of #VE here (even if we don't make use of
> it yet).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -205,6 +205,16 @@ int hvm_event_needs_reinjection(uint8_t 
>   */
>  uint8_t hvm_combine_hw_exceptions(uint8_t vec1, uint8_t vec2)
>  {
> +    const unsigned int contributory_exceptions =
> +        (1 << TRAP_divide_error) |
> +        (1 << TRAP_invalid_tss) |
> +        (1 << TRAP_no_segment) |
> +        (1 << TRAP_stack_error) |
> +        (1 << TRAP_gp_fault);

== 0x3c01, i.e. TRAP_page_fault has gone missing.  AFAICS that's
correct, but please mention it in the patch description.

Cheers,

Tim.