All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inha Song <ideal.song@samsung.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: alsa-devel@alsa-project.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, sbkim73@samsung.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	lgirdwood@gmail.com, tiwai@suse.de, broonie@kernel.org,
	kgene@kernel.org, galak@codeaurora.org, grant.likely@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v3 3/4] ARM: dts: set clock out parent to XUSBXTI
Date: Fri, 23 Jan 2015 09:49:16 +0900	[thread overview]
Message-ID: <20150123094916.32beb50f@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <54C0EC23.9070209@samsung.com>

Hi,
Thanks for your comment.

On Thu, 22 Jan 2015 13:25:07 +0100
Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:

> On 22/01/15 12:18, Inha Song wrote:
> > This patch set clock out parent to XUSBXTI.
> > 
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index b8168f1..020bbaf 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -141,6 +141,8 @@
> >  	pmu_system_controller: system-controller@10020000 {
> >  		compatible = "samsung,exynos4210-pmu", "syscon";
> >  		reg = <0x10020000 0x4000>;
> > +		assigned-clocks = <&pmu_system_controller 0>;
> > +		assigned-clock-parents =  <&clock CLK_XUSBXTI>;
> >  	};
> 
> Looks good, except it needs to be done only for the Trats2 board, i.e.
> the PMU device node including these properties should be added to
> exynos4412-trats2.dts.  I think it's fine to make it a one patch including
> all dts changes.

Opps! I understand. I will move this node to exynos4412-trats2.dts.

&pmu_system_controller {
   assigned-clocks = <&pmu_system_controller 0>;
   assigned-clock-parents =  <&clock CLK_XUSBXTI>;
};

Thanks!

Best Regards,
Inha Song.

> 
> 
> -- 
> Regards,
> Sylwester
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: ideal.song@samsung.com (Inha Song)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v3 3/4] ARM: dts: set clock out parent to XUSBXTI
Date: Fri, 23 Jan 2015 09:49:16 +0900	[thread overview]
Message-ID: <20150123094916.32beb50f@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <54C0EC23.9070209@samsung.com>

Hi,
Thanks for your comment.

On Thu, 22 Jan 2015 13:25:07 +0100
Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:

> On 22/01/15 12:18, Inha Song wrote:
> > This patch set clock out parent to XUSBXTI.
> > 
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> > index b8168f1..020bbaf 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -141,6 +141,8 @@
> >  	pmu_system_controller: system-controller at 10020000 {
> >  		compatible = "samsung,exynos4210-pmu", "syscon";
> >  		reg = <0x10020000 0x4000>;
> > +		assigned-clocks = <&pmu_system_controller 0>;
> > +		assigned-clock-parents =  <&clock CLK_XUSBXTI>;
> >  	};
> 
> Looks good, except it needs to be done only for the Trats2 board, i.e.
> the PMU device node including these properties should be added to
> exynos4412-trats2.dts.  I think it's fine to make it a one patch including
> all dts changes.

Opps! I understand. I will move this node to exynos4412-trats2.dts.

&pmu_system_controller {
   assigned-clocks = <&pmu_system_controller 0>;
   assigned-clock-parents =  <&clock CLK_XUSBXTI>;
};

Thanks!

Best Regards,
Inha Song.

> 
> 
> -- 
> Regards,
> Sylwester
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2015-01-23  0:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 11:17 [alsa-devel] [PATCH v3 0/4] Sound support for Exynos4412 Trats2 board Inha Song
2015-01-22 11:17 ` Inha Song
2015-01-22 11:17 ` [alsa-devel] [PATCH v3 1/4] ASoC: samsung: Add machine driver for Trats2 Inha Song
2015-01-22 11:17   ` Inha Song
2015-01-22 11:17   ` Inha Song
2015-01-22 12:16   ` [alsa-devel] " Sylwester Nawrocki
2015-01-22 12:16     ` Sylwester Nawrocki
2015-01-23  0:56     ` Inha Song
2015-01-23  0:56       ` Inha Song
2015-01-23  0:56       ` Inha Song
2015-01-22 11:18 ` [alsa-devel] [PATCH v3 2/4] ASoC: samsung: Document Trats2 audio subsystem bindings Inha Song
2015-01-22 11:18   ` Inha Song
2015-01-22 12:17   ` Sylwester Nawrocki
2015-01-22 12:17     ` Sylwester Nawrocki
2015-01-22 11:18 ` [alsa-devel] [PATCH v3 3/4] ARM: dts: set clock out parent to XUSBXTI Inha Song
2015-01-22 11:18   ` Inha Song
2015-01-22 12:25   ` Sylwester Nawrocki
2015-01-22 12:25     ` Sylwester Nawrocki
2015-01-23  0:49     ` Inha Song [this message]
2015-01-23  0:49       ` Inha Song
2015-01-23  6:41     ` Kukjin Kim
2015-01-23  6:41       ` Kukjin Kim
2015-01-23  6:41       ` Kukjin Kim
2015-01-22 11:18 ` [alsa-devel] [PATCH v3 4/4] ARM: dts: Add sound nodes for exynos4412-trats2 Inha Song
2015-01-22 11:18   ` Inha Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123094916.32beb50f@songinha-Samsung-DeskTop-System \
    --to=ideal.song@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.