From: Wolfram Sang <wsa@the-dreams.de>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: jdelvare@suse.de, arnd@arndb.de,
maxime.ripard@free-electrons.com, dianders@chromium.org,
u.kleine-koenig@pengutronix.de,
laurent.pinchart+renesas@ideasonboard.com,
boris.brezillon@free-electrons.com, maxime.coquelin@st.com,
andrew@lunn.ch, sjg@chromium.org, markus.mayer@linaro.org,
ch.naveen@samsung.com, jacob.jun.pan@linux.intel.com,
max.schwarz@online.de, mika.westerberg@linux.intel.com,
skuribay@pobox.com, Romain.Baeriswyl@abilis.com,
wenkai.du@intel.com, christian.ruppert@abilis.com,
alan@linux.intel.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support
Date: Fri, 23 Jan 2015 15:18:53 +0100 [thread overview]
Message-ID: <20150123141853.GA9592@katana> (raw)
In-Reply-To: <1421313137-1613-3-git-send-email-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Mostly good, except one thing:
> +config I2C_DESIGNWARE_BAYTRAIL
> + bool "Intel Baytrail I2C semaphore support"
> + depends on I2C_DESIGNWARE_PLATFORM
> + select IOSF_MBI
This needs some dependency on something Baytrail specific. Otherwise, it
causes lots of build errors:
With ARM allnoconfig, I can select this option but there are no headers
for iosf.
With x86_64_defconfig and disabled ACPI, I can select this option but it
fails over "implicit declaration of function ‘acpi_evaluate_integer’".
An incremental patch will do for me, the rest looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "David E. Box" <david.e.box-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: jdelvare-l3A5Bk7waGM@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
maxime.coquelin-qxv4g6HH51o@public.gmane.org,
andrew-g2DYL2Zd6BY@public.gmane.org,
sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
markus.mayer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org,
mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
skuribay-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org,
Romain.Baeriswyl-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org,
wenkai.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org,
alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support
Date: Fri, 23 Jan 2015 15:18:53 +0100 [thread overview]
Message-ID: <20150123141853.GA9592@katana> (raw)
In-Reply-To: <1421313137-1613-3-git-send-email-david.e.box-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Mostly good, except one thing:
> +config I2C_DESIGNWARE_BAYTRAIL
> + bool "Intel Baytrail I2C semaphore support"
> + depends on I2C_DESIGNWARE_PLATFORM
> + select IOSF_MBI
This needs some dependency on something Baytrail specific. Otherwise, it
causes lots of build errors:
With ARM allnoconfig, I can select this option but there are no headers
for iosf.
With x86_64_defconfig and disabled ACPI, I can select this option but it
fails over "implicit declaration of function ‘acpi_evaluate_integer’".
An incremental patch will do for me, the rest looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-23 14:19 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 17:36 [PATCH] i2c-designware: Intel BayTrail PMIC I2C bus support David E. Box
2014-09-15 6:57 ` Maxime Coquelin
2014-09-15 6:57 ` Maxime Coquelin
2014-09-15 16:55 ` David E. Box
2014-09-15 16:55 ` David E. Box
2014-09-16 9:44 ` Mika Westerberg
2014-09-16 9:44 ` Mika Westerberg
2014-09-16 10:53 ` Jacob Pan
2014-09-16 10:53 ` Jacob Pan
2014-09-16 10:58 ` Mika Westerberg
2014-09-17 4:01 ` Li, Aubrey
2014-09-17 11:02 ` One Thousand Gnomes
2014-09-17 11:02 ` One Thousand Gnomes
2014-09-23 18:40 ` [PATCH V2] i2c-designware: Add Intel Baytrail " David E. Box
2014-09-23 18:40 ` David E. Box
2014-09-23 19:00 ` Maxime Ripard
2014-09-23 19:00 ` Maxime Ripard
2014-09-23 19:58 ` David E. Box
2014-09-25 9:47 ` Maxime Ripard
2014-09-25 9:47 ` Maxime Ripard
[not found] ` <20141007191420.GA25126@pathfinder>
2014-10-09 12:36 ` Maxime Ripard
2014-10-09 12:36 ` Maxime Ripard
2014-11-11 11:32 ` Wolfram Sang
2014-11-11 17:11 ` David E. Box
2014-11-11 17:11 ` David E. Box
2014-11-11 11:50 ` Mika Westerberg
2014-11-11 11:50 ` Mika Westerberg
2014-12-02 0:09 ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver David E. Box
2014-12-02 0:09 ` David E. Box
2014-12-02 0:09 ` [PATCH V3 1/2] i2c-designware: Add i2c bus locking support David E. Box
2014-12-03 16:01 ` Mika Westerberg
2014-12-04 18:49 ` David E. Box
2014-12-04 18:49 ` David E. Box
2014-12-04 7:59 ` Jarkko Nikula
2014-12-04 7:59 ` Jarkko Nikula
2014-12-04 18:42 ` David E. Box
2015-01-13 9:48 ` Wolfram Sang
2015-01-13 9:48 ` Wolfram Sang
2015-01-14 18:15 ` David E. Box
2015-01-14 18:15 ` David E. Box
2014-12-02 0:09 ` [PATCH V3 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2014-12-03 16:10 ` Mika Westerberg
2014-12-04 19:11 ` David E. Box
2014-12-04 19:11 ` David E. Box
2014-12-06 3:51 ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver Shinya Kuribayashi
2014-12-06 3:51 ` Shinya Kuribayashi
2015-01-15 9:12 ` [PATCH V4 0/2] i2c-designware: Add Intel Baytrail pmic i2c bus support David E. Box
2015-01-15 9:12 ` David E. Box
2015-01-26 11:27 ` Wolfram Sang
2015-01-26 11:27 ` Wolfram Sang
2015-01-15 9:12 ` [PATCH V4 1/2] i2c-designware: Add i2c bus locking support David E. Box
2015-01-22 14:22 ` Mika Westerberg
2015-01-22 14:22 ` Mika Westerberg
2015-01-15 9:12 ` [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2015-01-15 9:12 ` David E. Box
2015-01-22 14:28 ` Mika Westerberg
2015-01-22 14:28 ` Mika Westerberg
2015-01-22 20:48 ` David E. Box
2015-01-23 9:32 ` Mika Westerberg
2015-01-23 14:18 ` Wolfram Sang [this message]
2015-01-23 14:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123141853.GA9592@katana \
--to=wsa@the-dreams.de \
--cc=Romain.Baeriswyl@abilis.com \
--cc=alan@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=ch.naveen@samsung.com \
--cc=christian.ruppert@abilis.com \
--cc=david.e.box@linux.intel.com \
--cc=dianders@chromium.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=max.schwarz@online.de \
--cc=maxime.coquelin@st.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mika.westerberg@linux.intel.com \
--cc=sjg@chromium.org \
--cc=skuribay@pobox.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenkai.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.