From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Lameter <cl@linux.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz
Subject: Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'
Date: Sat, 24 Jan 2015 02:16:23 -0500 [thread overview]
Message-ID: <20150124071623.GA17705@phnom.home.cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1501231508020.7871@gentwo.org>
On Fri, Jan 23, 2015 at 03:09:20PM -0600, Christoph Lameter wrote:
> On Fri, 23 Jan 2015, Guenter Roeck wrote:
>
> > Wouldn't that have unintended consequences ? So far
> > rb tree nodes are allocated even if a node not online;
> > the above would change that. Are you saying it is
> > unnecessary to initialize rb tree nodes if the node
> > is not online ?
>
> It is not advisable to allocate since an offline node means that the
> structure cannot be allocated on the node where it would be most
> beneficial. Typically subsystems allocate the per node data structures
> when the node is brought online.
I would generally agree, but this code, which implements a userspace
interface, is already grotesquely inefficient and heavyhanded. It's
also superseded in the next release, so we can just keep this simple
at this point.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Lameter <cl@linux.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
sfr@canb.auug.org.au, mhocko@suse.cz
Subject: Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'
Date: Sat, 24 Jan 2015 02:16:23 -0500 [thread overview]
Message-ID: <20150124071623.GA17705@phnom.home.cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1501231508020.7871@gentwo.org>
On Fri, Jan 23, 2015 at 03:09:20PM -0600, Christoph Lameter wrote:
> On Fri, 23 Jan 2015, Guenter Roeck wrote:
>
> > Wouldn't that have unintended consequences ? So far
> > rb tree nodes are allocated even if a node not online;
> > the above would change that. Are you saying it is
> > unnecessary to initialize rb tree nodes if the node
> > is not online ?
>
> It is not advisable to allocate since an offline node means that the
> structure cannot be allocated on the node where it would be most
> beneficial. Typically subsystems allocate the per node data structures
> when the node is brought online.
I would generally agree, but this code, which implements a userspace
interface, is already grotesquely inefficient and heavyhanded. It's
also superseded in the next release, so we can just keep this simple
at this point.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-24 7:16 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 23:05 mmotm 2015-01-22-15-04 uploaded akpm
2015-01-22 23:05 ` akpm
2015-01-23 5:04 ` mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' Guenter Roeck
2015-01-23 5:04 ` Guenter Roeck
2015-01-23 11:13 ` Kirill A. Shutemov
2015-01-23 11:13 ` Kirill A. Shutemov
2015-01-23 11:13 ` Kirill A. Shutemov
2015-01-23 15:07 ` Guenter Roeck
2015-01-23 15:07 ` Guenter Roeck
2015-01-23 21:55 ` Andrew Morton
2015-01-23 21:55 ` Andrew Morton
2015-01-24 2:44 ` Guenter Roeck
2015-01-24 2:44 ` Guenter Roeck
2015-01-24 3:05 ` Guenter Roeck
2015-01-24 3:05 ` Guenter Roeck
2015-01-24 5:52 ` Guenter Roeck
2015-01-24 5:52 ` Guenter Roeck
2015-01-26 12:29 ` Kirill A. Shutemov
2015-01-26 12:29 ` Kirill A. Shutemov
2015-01-26 14:03 ` Guenter Roeck
2015-01-26 14:03 ` Guenter Roeck
2015-01-26 14:17 ` Guenter Roeck
2015-01-26 14:17 ` Guenter Roeck
2015-01-27 16:16 ` Kirill A. Shutemov
2015-01-27 16:16 ` Kirill A. Shutemov
2015-01-27 16:16 ` Kirill A. Shutemov
2015-01-27 16:24 ` Guenter Roeck
2015-01-27 16:24 ` Guenter Roeck
2015-01-27 21:24 ` Andrew Morton
2015-01-27 21:24 ` Andrew Morton
2015-01-28 6:16 ` Guenter Roeck
2015-01-28 6:16 ` Guenter Roeck
2015-01-23 5:08 ` mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test' Guenter Roeck
2015-01-23 5:08 ` Guenter Roeck
2015-01-23 14:18 ` Johannes Weiner
2015-01-23 14:18 ` Johannes Weiner
2015-01-23 15:17 ` Christoph Lameter
2015-01-23 15:17 ` Christoph Lameter
2015-01-23 16:02 ` Johannes Weiner
2015-01-23 16:02 ` Johannes Weiner
2015-01-23 16:59 ` Guenter Roeck
2015-01-23 16:59 ` Guenter Roeck
2015-01-23 17:36 ` Johannes Weiner
2015-01-23 17:36 ` Johannes Weiner
2015-01-23 17:38 ` Johannes Weiner
2015-01-23 17:38 ` Johannes Weiner
2015-01-24 2:02 ` Guenter Roeck
2015-01-24 2:02 ` Guenter Roeck
2015-01-27 17:24 ` Michal Hocko
2015-01-27 17:24 ` Michal Hocko
2015-01-28 15:03 ` Christoph Lameter
2015-01-28 15:03 ` Christoph Lameter
2015-01-23 15:46 ` Guenter Roeck
2015-01-23 15:46 ` Guenter Roeck
2015-01-23 16:03 ` Johannes Weiner
2015-01-23 16:03 ` Johannes Weiner
2015-01-23 20:20 ` Christoph Lameter
2015-01-23 20:20 ` Christoph Lameter
2015-01-23 20:33 ` Guenter Roeck
2015-01-23 20:33 ` Guenter Roeck
2015-01-23 21:09 ` Christoph Lameter
2015-01-23 21:09 ` Christoph Lameter
2015-01-24 7:16 ` Johannes Weiner [this message]
2015-01-24 7:16 ` Johannes Weiner
2015-01-25 21:36 ` Valdis.Kletnieks
2015-01-26 13:37 ` Johannes Weiner
2015-01-26 13:37 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124071623.GA17705@phnom.home.cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.