* [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
@ 2015-01-24 20:20 Heba Aamer
2015-01-25 11:57 ` Greg KH
2015-01-25 14:14 ` Aya Mahfouz
0 siblings, 2 replies; 4+ messages in thread
From: Heba Aamer @ 2015-01-24 20:20 UTC (permalink / raw)
To: devel
Cc: Larry.Finger, florian.c.schilhabel, gregkh, tapaswenipathak,
thomas, sudipm.mukherjee, rickard_strandqvist, linux-kernel
This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
netdev_info was used since it is a network subsystem
Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 7d0d171..7748a75 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
struct net_device *pnetdev;
struct usb_device *udev;
- printk(KERN_INFO "r8712u: Staging version\n");
+ netdev_info(pnetdev, "r8712u: Staging version\n");
/* In this probe function, O.S. will provide the usb interface pointer
* to driver. We have to increase the reference count of the usb device
* structure by using the usb_get_dev function.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
2015-01-24 20:20 [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
@ 2015-01-25 11:57 ` Greg KH
2015-01-26 12:30 ` Heba Aamer
2015-01-25 14:14 ` Aya Mahfouz
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2015-01-25 11:57 UTC (permalink / raw)
To: Heba Aamer
Cc: devel, florian.c.schilhabel, thomas, tapaswenipathak,
rickard_strandqvist, linux-kernel, sudipm.mukherjee,
Larry.Finger
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network subsystem
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> struct net_device *pnetdev;
> struct usb_device *udev;
>
> - printk(KERN_INFO "r8712u: Staging version\n");
> + netdev_info(pnetdev, "r8712u: Staging version\n");
> /* In this probe function, O.S. will provide the usb interface pointer
> * to driver. We have to increase the reference count of the usb device
> * structure by using the usb_get_dev function.
Please don't send patches that you do not at least test-build, it's a
bit rude and wastes people's time.
Oh, and also ensure that your patch is correct, hint, this one does not
work at all :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
2015-01-24 20:20 [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
2015-01-25 11:57 ` Greg KH
@ 2015-01-25 14:14 ` Aya Mahfouz
1 sibling, 0 replies; 4+ messages in thread
From: Aya Mahfouz @ 2015-01-25 14:14 UTC (permalink / raw)
To: Heba Aamer
Cc: devel, florian.c.schilhabel, thomas, tapaswenipathak, gregkh,
rickard_strandqvist, linux-kernel, sudipm.mukherjee,
Larry.Finger
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network subsystem
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> struct net_device *pnetdev;
> struct usb_device *udev;
>
> - printk(KERN_INFO "r8712u: Staging version\n");
> + netdev_info(pnetdev, "r8712u: Staging version\n");
I've applied your patch and there is one problem here, pnetdev is not initialized yet.
It's better to use pr_info for now.
Kind Regards,
Aya Saif El-yazal Mahfouz
> /* In this probe function, O.S. will provide the usb interface pointer
> * to driver. We have to increase the reference count of the usb device
> * structure by using the usb_get_dev function.
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
2015-01-25 11:57 ` Greg KH
@ 2015-01-26 12:30 ` Heba Aamer
0 siblings, 0 replies; 4+ messages in thread
From: Heba Aamer @ 2015-01-26 12:30 UTC (permalink / raw)
To: Greg KH
Cc: devel, florian.c.schilhabel, thomas, tapaswenipathak,
rickard_strandqvist, linux-kernel, sudipm.mukherjee,
Larry.Finger
On Sun, Jan 25, 2015 at 07:57:55PM +0800, Greg KH wrote:
> On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> > This patch fixes the following checkpatch.pl warning:
> > fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> >
> > netdev_info was used since it is a network subsystem
> >
> > Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> > ---
> > drivers/staging/rtl8712/usb_intf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> > index 7d0d171..7748a75 100644
> > --- a/drivers/staging/rtl8712/usb_intf.c
> > +++ b/drivers/staging/rtl8712/usb_intf.c
> > @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> > struct net_device *pnetdev;
> > struct usb_device *udev;
> >
> > - printk(KERN_INFO "r8712u: Staging version\n");
> > + netdev_info(pnetdev, "r8712u: Staging version\n");
> > /* In this probe function, O.S. will provide the usb interface pointer
> > * to driver. We have to increase the reference count of the usb device
> > * structure by using the usb_get_dev function.
>
> Please don't send patches that you do not at least test-build, it's a
> bit rude and wastes people's time.
>
Sorry Greg! I did build the module but it was cached. I built the
driver again after cleaning it, and I did find a warning related to
my patch. I had a question though, I found a warning related to an
unused function. Here is the warning:
drivers/staging/rtl8712/rtl871x_mp_ioctl.c:708:12: warning:
‘mp_query_drv_var’ defined but not used [-Wunused-function]
Should I remove this function or should I keep it as is?
If it will be removed, I will send it in a different patch.
> Oh, and also ensure that your patch is correct, hint, this one does not
> work at all :(
Sorry again and I will be sending the new patch soon.
>
> greg k-h
Heba Aamer
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-26 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-24 20:20 [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO Heba Aamer
2015-01-25 11:57 ` Greg KH
2015-01-26 12:30 ` Heba Aamer
2015-01-25 14:14 ` Aya Mahfouz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.