* [PATCH] drm/nouveau/bar: fix simple_return.cocci warnings
[not found] <201501251444.W2sR21oD%fengguang.wu@intel.com>
@ 2015-01-25 6:24 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-01-25 6:24 UTC (permalink / raw)
To: Ben Skeggs
Cc: kbuild-all, David Airlie, Alexandre Courbot, Thierry Reding,
dri-devel, linux-kernel
drivers/gpu/drm/nouveau/core/subdev/bar/base.c:132:5-8: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
base.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -129,10 +129,7 @@ nouveau_bar_create_(struct nouveau_objec
ret = nouveau_subdev_create_(parent, engine, oclass, 0, "BARCTL",
"bar", length, pobject);
bar = *pobject;
- if (ret)
- return ret;
-
- return 0;
+ return ret;
}
void
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] drm/nouveau/bar: fix simple_return.cocci warnings
@ 2015-01-25 6:24 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-01-25 6:24 UTC (permalink / raw)
To: Ben Skeggs; +Cc: linux-kernel, dri-devel, kbuild-all, Thierry Reding
drivers/gpu/drm/nouveau/core/subdev/bar/base.c:132:5-8: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
base.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bar/base.c
@@ -129,10 +129,7 @@ nouveau_bar_create_(struct nouveau_objec
ret = nouveau_subdev_create_(parent, engine, oclass, 0, "BARCTL",
"bar", length, pobject);
bar = *pobject;
- if (ret)
- return ret;
-
- return 0;
+ return ret;
}
void
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-25 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201501251444.W2sR21oD%fengguang.wu@intel.com>
2015-01-25 6:24 ` [PATCH] drm/nouveau/bar: fix simple_return.cocci warnings kbuild test robot
2015-01-25 6:24 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.