All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Matthew Wilcox <willy@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Yan Liu <yan@purestorage.com>
Subject: Re: [PATCH 1/1] NVMe: Do not take nsid while a passthrough IO command is being issued via a block device file descriptor
Date: Sun, 25 Jan 2015 06:41:46 -0800	[thread overview]
Message-ID: <20150125144146.GA23199@infradead.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1501231737070.15481@localhost.lm.intel.com>

On Fri, Jan 23, 2015 at 05:50:33PM +0000, Keith Busch wrote:
> No argument against removing the hidden attribute handling, but there
> are unadvertised NSID's that have special meaning. Like NSID 0xffffffff
> means to apply a command to all namespaces. Vendor specific commands
> may have other special NSID meanings as well.

What is the practical use of those?  Just because something is
theoretically possible we don't really need to support it.

(and yes, it's a really bad design - I wish the NVME designers had spent a
little more time with existing designs instead of applying the full NIH
mantra)

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/1] NVMe: Do not take nsid while a passthrough IO command is being issued via a block device file descriptor
Date: Sun, 25 Jan 2015 06:41:46 -0800	[thread overview]
Message-ID: <20150125144146.GA23199@infradead.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1501231737070.15481@localhost.lm.intel.com>

On Fri, Jan 23, 2015@05:50:33PM +0000, Keith Busch wrote:
> No argument against removing the hidden attribute handling, but there
> are unadvertised NSID's that have special meaning. Like NSID 0xffffffff
> means to apply a command to all namespaces. Vendor specific commands
> may have other special NSID meanings as well.

What is the practical use of those?  Just because something is
theoretically possible we don't really need to support it.

(and yes, it's a really bad design - I wish the NVME designers had spent a
little more time with existing designs instead of applying the full NIH
mantra)

  reply	other threads:[~2015-01-25 14:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  0:02 [PATCH 1/1] NVMe: Do not take nsid while a passthrough IO command is being issued via a block device file descriptor Yan Liu
2015-01-23  0:02 ` Yan Liu
2015-01-23  7:57 ` Christoph Hellwig
2015-01-23  7:57   ` Christoph Hellwig
2015-01-23 16:22   ` Keith Busch
2015-01-23 16:22     ` Keith Busch
2015-01-23 17:27     ` Christoph Hellwig
2015-01-23 17:27       ` Christoph Hellwig
2015-01-23 17:50       ` Keith Busch
2015-01-23 17:50         ` Keith Busch
2015-01-25 14:41         ` Christoph Hellwig [this message]
2015-01-25 14:41           ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2015-01-23 23:57 Yan Liu
2015-01-23 23:57 ` Yan Liu
2015-01-25 14:59 ` Christoph Hellwig
2015-01-25 14:59   ` Christoph Hellwig
2015-01-26 18:02   ` Keith Busch
2015-01-26 18:02     ` Keith Busch
2015-01-22  0:28 Yan Liu
2015-01-22  0:28 ` Yan Liu
2015-01-22  0:47 ` Keith Busch
2015-01-22  0:47   ` Keith Busch
2015-01-22  8:45   ` Christoph Hellwig
2015-01-22  8:45     ` Christoph Hellwig
2015-01-22 15:21     ` Keith Busch
2015-01-22 15:21       ` Keith Busch
2015-01-22 15:49       ` Christoph Hellwig
2015-01-22 15:49         ` Christoph Hellwig
2015-01-22 16:58         ` Keith Busch
2015-01-22 16:58           ` Keith Busch
     [not found]   ` <CADMsRTZjajAj682a5FH-AmpphoQ4vw5QxqnJiGEQ+Jg_f7TvoA@mail.gmail.com>
2015-01-22 14:22     ` Keith Busch
2015-01-22 14:22       ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150125144146.GA23199@infradead.org \
    --to=hch@infradead.org \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=willy@linux.intel.com \
    --cc=yan@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.