From: Jesse Barnes <jbarnes@virtuousgeek.org> To: Oded Gabbay <oded.gabbay@amd.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "jroedel@suse.de" <jroedel@suse.de>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, <iommu@lists.linux-foundation.org>, "Bridgman, John" <John.Bridgman@amd.com>, "Elifaz, Dana" <Dana.Elifaz@amd.com> Subject: Re: [PATCH 2/2] iommu/amd: use handle_mm_fault directly v2 Date: Mon, 26 Jan 2015 15:01:55 -0800 [thread overview] Message-ID: <20150126150155.292bf707@jbarnes-hsw> (raw) In-Reply-To: <54C4ECBC.5070301@amd.com> On Sun, 25 Jan 2015 15:16:44 +0200 Oded Gabbay <oded.gabbay@amd.com> wrote: > > > On 11/13/2014 12:10 AM, Jesse Barnes wrote: > > This could be useful for debug in the future if we want to track > > major/minor faults more closely, and also avoids the put_page trick we > > used with gup. > > > > In order to do this, we also track the task struct in the PASID state > > structure. This lets us update the appropriate task stats after the > > fault has been handled, and may aid with debug in the future as well. > > > > v2: drop task accounting; GPU activity may have been submitted by a > > different thread than the one binding the PASID (Joerg) > > > > Tested-by: Oded Gabbay<oded.gabbay@amd.com> > > Signed-off-by: Jesse Barnes<jbarnes@virtuousgeek.org> > > Hi Jesse, > > I know I tested your patch a few months ago, but we have a new feature (still > internally) in the driver, which has some conflicts with this patch. > > Our feature is basically doing "exception handling" by registering a callback > function with the iommu driver in inv_ppr_cb. > > Now, with the old code (we used 3.17.2 until a few days ago), this callback > function was called in, at least, three use-cases (which we are testing): > > (1) Writing to a "bad" system memory address, which is *not* in the process's > memory address space. > > (2) Writing to a read-only page, which is inside the process's memory address space > > (3) Reading from a page without permissions, which is inside the process's > memory address space > > With the new code (3.19-rc5), this callback is only called in the first > use-case, while (2) and (3) are handled in handle_mm_fault(), which is now > called from do_fault. The return value of handle_mm_fault() is 0, so > handle_fault_error() is not called and amdkfd doesn't get notification, hence > our test fails. > > This is a problem for us as we want to propagate these exceptions to the user > space HSA runtime, so it could handle them. > > I have 2 questions: > > 1. Why don't we call inv_ppr_cb() in any case ? We do if we fail to allocate the vma or it's in the wrong location, but we could extend the do_fault() handling to do it in more cases. > 2. How come handle_mm_fault() returns 0 in cases (2) and (3) ? Or in other > words, what is considered to be a success in handle_mm_fault() and is it visible > to the user-space process ? handle_mm_fault() is somewhat of a low level function. We can catch more cases in our own do_fault() code if we need to. The x86 __do_page_fault is probably a good reference. I mainly tried to match existing behavior when I added the handle_mm_fault(), but may have missed stuff. As I said, we can extend our do_fault() to handle all the cases we want prior to calling handle_mm_fault(). Thanks, -- Jesse Barnes, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> To: Oded Gabbay <oded.gabbay-5C7GfCeVMHo@public.gmane.org> Cc: "jroedel-l3A5Bk7waGM@public.gmane.org" <jroedel-l3A5Bk7waGM@public.gmane.org>, "Bridgman, John" <John.Bridgman-5C7GfCeVMHo@public.gmane.org>, "Elifaz, Dana" <Dana.Elifaz-5C7GfCeVMHo@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [PATCH 2/2] iommu/amd: use handle_mm_fault directly v2 Date: Mon, 26 Jan 2015 15:01:55 -0800 [thread overview] Message-ID: <20150126150155.292bf707@jbarnes-hsw> (raw) In-Reply-To: <54C4ECBC.5070301-5C7GfCeVMHo@public.gmane.org> On Sun, 25 Jan 2015 15:16:44 +0200 Oded Gabbay <oded.gabbay-5C7GfCeVMHo@public.gmane.org> wrote: > > > On 11/13/2014 12:10 AM, Jesse Barnes wrote: > > This could be useful for debug in the future if we want to track > > major/minor faults more closely, and also avoids the put_page trick we > > used with gup. > > > > In order to do this, we also track the task struct in the PASID state > > structure. This lets us update the appropriate task stats after the > > fault has been handled, and may aid with debug in the future as well. > > > > v2: drop task accounting; GPU activity may have been submitted by a > > different thread than the one binding the PASID (Joerg) > > > > Tested-by: Oded Gabbay<oded.gabbay-5C7GfCeVMHo@public.gmane.org> > > Signed-off-by: Jesse Barnes<jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> > > Hi Jesse, > > I know I tested your patch a few months ago, but we have a new feature (still > internally) in the driver, which has some conflicts with this patch. > > Our feature is basically doing "exception handling" by registering a callback > function with the iommu driver in inv_ppr_cb. > > Now, with the old code (we used 3.17.2 until a few days ago), this callback > function was called in, at least, three use-cases (which we are testing): > > (1) Writing to a "bad" system memory address, which is *not* in the process's > memory address space. > > (2) Writing to a read-only page, which is inside the process's memory address space > > (3) Reading from a page without permissions, which is inside the process's > memory address space > > With the new code (3.19-rc5), this callback is only called in the first > use-case, while (2) and (3) are handled in handle_mm_fault(), which is now > called from do_fault. The return value of handle_mm_fault() is 0, so > handle_fault_error() is not called and amdkfd doesn't get notification, hence > our test fails. > > This is a problem for us as we want to propagate these exceptions to the user > space HSA runtime, so it could handle them. > > I have 2 questions: > > 1. Why don't we call inv_ppr_cb() in any case ? We do if we fail to allocate the vma or it's in the wrong location, but we could extend the do_fault() handling to do it in more cases. > 2. How come handle_mm_fault() returns 0 in cases (2) and (3) ? Or in other > words, what is considered to be a success in handle_mm_fault() and is it visible > to the user-space process ? handle_mm_fault() is somewhat of a low level function. We can catch more cases in our own do_fault() code if we need to. The x86 __do_page_fault is probably a good reference. I mainly tried to match existing behavior when I added the handle_mm_fault(), but may have missed stuff. As I said, we can extend our do_fault() to handle all the cases we want prior to calling handle_mm_fault(). Thanks, -- Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-01-26 23:08 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-12 22:10 [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use Jesse Barnes 2014-11-12 22:10 ` [PATCH 2/2] iommu/amd: use handle_mm_fault directly v2 Jesse Barnes 2015-01-25 13:16 ` Oded Gabbay 2015-01-25 13:16 ` Oded Gabbay 2015-01-26 23:01 ` Jesse Barnes [this message] 2015-01-26 23:01 ` Jesse Barnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150126150155.292bf707@jbarnes-hsw \ --to=jbarnes@virtuousgeek.org \ --cc=Dana.Elifaz@amd.com \ --cc=John.Bridgman@amd.com \ --cc=akpm@linux-foundation.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jroedel@suse.de \ --cc=linux-kernel@vger.kernel.org \ --cc=oded.gabbay@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.