* [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
@ 2015-01-26 16:49 Wolfram Sang
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2015-01-26 16:49 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: David Box, Mika Westerberg, kbuild-all-JC7UmRfGjtg, Wolfram Sang
IOSF_MBI depends on PCI, so we should not select it but depend on it.
This ensures also we compile on X86 only, other archs will break because
of an arch specific include. Also depend on ACPI since this driver uses
it.
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
drivers/i2c/busses/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 83062b2c0e6b..442408d2e7b7 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -467,8 +467,7 @@ config I2C_DESIGNWARE_PCI
config I2C_DESIGNWARE_BAYTRAIL
bool "Intel Baytrail I2C semaphore support"
- depends on I2C_DESIGNWARE_PLATFORM
- select IOSF_MBI
+ depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI
help
This driver enables managed host access to the PMIC I2C bus on select
Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
--
2.1.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
@ 2015-01-26 16:51 ` Wolfram Sang
2015-01-26 18:01 ` David E. Box
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-01-26 16:51 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: David Box, Mika Westerberg, kbuild-all-JC7UmRfGjtg
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> IOSF_MBI depends on PCI, so we should not select it but depend on it.
> This ensures also we compile on X86 only, other archs will break because
> of an arch specific include. Also depend on ACPI since this driver uses
> it.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Depending on IOSF_MBI also helps against the I2C driver being built-in
and IOSF_MBI being a module.
> ---
> drivers/i2c/busses/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 83062b2c0e6b..442408d2e7b7 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -467,8 +467,7 @@ config I2C_DESIGNWARE_PCI
>
> config I2C_DESIGNWARE_BAYTRAIL
> bool "Intel Baytrail I2C semaphore support"
> - depends on I2C_DESIGNWARE_PLATFORM
> - select IOSF_MBI
> + depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI
> help
> This driver enables managed host access to the PMIC I2C bus on select
> Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
> --
> 2.1.3
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-26 16:51 ` Wolfram Sang
@ 2015-01-26 18:01 ` David E. Box
2015-01-26 18:10 ` Wolfram Sang
2015-01-26 18:47 ` David E. Box
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: David E. Box @ 2015-01-26 18:01 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mika Westerberg,
kbuild-all-JC7UmRfGjtg
On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> IOSF_MBI depends on PCI, so we should not select it but depend on it.
> This ensures also we compile on X86 only, other archs will break because
> of an arch specific include. Also depend on ACPI since this driver uses
> it.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Signed-off-by: David E. Box <david.e.box-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> drivers/i2c/busses/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 83062b2c0e6b..442408d2e7b7 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -467,8 +467,7 @@ config I2C_DESIGNWARE_PCI
>
> config I2C_DESIGNWARE_BAYTRAIL
> bool "Intel Baytrail I2C semaphore support"
> - depends on I2C_DESIGNWARE_PLATFORM
> - select IOSF_MBI
> + depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI
> help
> This driver enables managed host access to the PMIC I2C bus on select
> Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
> --
Dave
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
2015-01-26 18:01 ` David E. Box
@ 2015-01-26 18:10 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-01-26 18:10 UTC (permalink / raw)
To: David E. Box
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mika Westerberg,
kbuild-all-JC7UmRfGjtg
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Mon, Jan 26, 2015 at 10:01:10AM -0800, David E. Box wrote:
> On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> > IOSF_MBI depends on PCI, so we should not select it but depend on it.
> > This ensures also we compile on X86 only, other archs will break because
> > of an arch specific include. Also depend on ACPI since this driver uses
> > it.
> >
> > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
>
> Signed-off-by: David E. Box <david.e.box-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
You probably mean Acked-by?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-26 16:51 ` Wolfram Sang
2015-01-26 18:01 ` David E. Box
@ 2015-01-26 18:47 ` David E. Box
2015-01-26 21:00 ` Wolfram Sang
2015-01-27 10:17 ` Mika Westerberg
4 siblings, 0 replies; 7+ messages in thread
From: David E. Box @ 2015-01-26 18:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mika Westerberg,
kbuild-all-JC7UmRfGjtg
On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> IOSF_MBI depends on PCI, so we should not select it but depend on it.
> This ensures also we compile on X86 only, other archs will break because
> of an arch specific include. Also depend on ACPI since this driver uses
> it.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Acked-by: David E. Box <david.e.box-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> drivers/i2c/busses/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 83062b2c0e6b..442408d2e7b7 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -467,8 +467,7 @@ config I2C_DESIGNWARE_PCI
>
> config I2C_DESIGNWARE_BAYTRAIL
> bool "Intel Baytrail I2C semaphore support"
> - depends on I2C_DESIGNWARE_PLATFORM
> - select IOSF_MBI
> + depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI && ACPI
> help
> This driver enables managed host access to the PMIC I2C bus on select
> Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
` (2 preceding siblings ...)
2015-01-26 18:47 ` David E. Box
@ 2015-01-26 21:00 ` Wolfram Sang
2015-01-27 10:17 ` Mika Westerberg
4 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2015-01-26 21:00 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: David Box, Mika Westerberg, kbuild-all-JC7UmRfGjtg
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> IOSF_MBI depends on PCI, so we should not select it but depend on it.
> This ensures also we compile on X86 only, other archs will break because
> of an arch specific include. Also depend on ACPI since this driver uses
> it.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
` (3 preceding siblings ...)
2015-01-26 21:00 ` Wolfram Sang
@ 2015-01-27 10:17 ` Mika Westerberg
4 siblings, 0 replies; 7+ messages in thread
From: Mika Westerberg @ 2015-01-27 10:17 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, David Box, kbuild-all-JC7UmRfGjtg
On Mon, Jan 26, 2015 at 05:49:34PM +0100, Wolfram Sang wrote:
> IOSF_MBI depends on PCI, so we should not select it but depend on it.
> This ensures also we compile on X86 only, other archs will break because
> of an arch specific include. Also depend on ACPI since this driver uses
> it.
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Thanks for taking care of this,
Acked-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-27 10:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-26 16:49 [PATCH] i2c: designware-baytrail: use proper Kconfig dependencies Wolfram Sang
[not found] ` <1422290974-24561-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-26 16:51 ` Wolfram Sang
2015-01-26 18:01 ` David E. Box
2015-01-26 18:10 ` Wolfram Sang
2015-01-26 18:47 ` David E. Box
2015-01-26 21:00 ` Wolfram Sang
2015-01-27 10:17 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.