* [PATCH RESENT] pinctrl: pinctrl-imx: don't use invalid value of conf_reg
@ 2015-01-27 23:05 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-01-27 23:05 UTC (permalink / raw)
To: Dong Aisheng
Cc: linux-arm-kernel, kernel, Shawn Guo, Linus Walleij, linux-gpio
The right check for conf_reg to be invalid it testing against -1 not 0
as is done in the rest of the driver.
This fixes an oops that can be triggered by:
cat /sys/kernel/debug/pinctrl/43fac000.iomuxc/*
Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Notes:
Resent to fix email address of Dong Aisheng
drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 52f2b9404fe0..448f10986c28 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -437,7 +437,7 @@ static void imx_pinconf_dbg_show(struct pinctrl_dev *pctldev,
const struct imx_pin_reg *pin_reg = &info->pin_regs[pin_id];
unsigned long config;
- if (!pin_reg || !pin_reg->conf_reg) {
+ if (!pin_reg || pin_reg->conf_reg == -1) {
seq_printf(s, "N/A");
return;
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH RESENT] pinctrl: pinctrl-imx: don't use invalid value of conf_reg
@ 2015-01-27 23:05 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-01-27 23:05 UTC (permalink / raw)
To: linux-arm-kernel
The right check for conf_reg to be invalid it testing against -1 not 0
as is done in the rest of the driver.
This fixes an oops that can be triggered by:
cat /sys/kernel/debug/pinctrl/43fac000.iomuxc/*
Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Notes:
Resent to fix email address of Dong Aisheng
drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 52f2b9404fe0..448f10986c28 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -437,7 +437,7 @@ static void imx_pinconf_dbg_show(struct pinctrl_dev *pctldev,
const struct imx_pin_reg *pin_reg = &info->pin_regs[pin_id];
unsigned long config;
- if (!pin_reg || !pin_reg->conf_reg) {
+ if (!pin_reg || pin_reg->conf_reg == -1) {
seq_printf(s, "N/A");
return;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESENT] pinctrl: pinctrl-imx: don't use invalid value of conf_reg
2015-01-27 23:05 ` Uwe Kleine-König
@ 2015-01-27 23:14 ` Uwe Kleine-König
-1 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-01-27 23:14 UTC (permalink / raw)
To: linux-gpio, Linus Walleij, Shawn Guo, kernel, linux-arm-kernel
On Wed, Jan 28, 2015 at 12:05:53AM +0100, Uwe Kleine-König wrote:
> Resent to fix email address of Dong Aisheng
I failed here and reused his old address again, please disregard this
mail. Sorry for the noise (again, sigh).
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESENT] pinctrl: pinctrl-imx: don't use invalid value of conf_reg
@ 2015-01-27 23:14 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-01-27 23:14 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 28, 2015 at 12:05:53AM +0100, Uwe Kleine-K?nig wrote:
> Resent to fix email address of Dong Aisheng
I failed here and reused his old address again, please disregard this
mail. Sorry for the noise (again, sigh).
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-27 23:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 23:05 [PATCH RESENT] pinctrl: pinctrl-imx: don't use invalid value of conf_reg Uwe Kleine-König
2015-01-27 23:05 ` Uwe Kleine-König
2015-01-27 23:14 ` Uwe Kleine-König
2015-01-27 23:14 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.