All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
@ 2015-01-27 22:23 ` Rickard Strandqvist
  0 siblings, 0 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:23 UTC (permalink / raw)
  To: Jonathan Cameron, Hartmut Knaack
  Cc: Rickard Strandqvist, Lars-Peter Clausen, Peter Meerwald,
	Greg Kroah-Hartman, Grant Likely, Rob Herring, Alexandre Belloni,
	Marek Vasut, Fabio Estevam, Darshana Padmadas, Aybuke Ozdemir,
	Vaishali Thakkar, Robert Hodaszi, Brian Vandre, linux-iio, devel,
	linux-kernel, devicetree

Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index f053535..887767b 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -1001,7 +1001,7 @@ static ssize_t mxs_lradc_show_scale_available_ch(struct device *dev,
 	int i, len = 0;
 
 	for (i = 0; i < ARRAY_SIZE(lradc->scale_avail[ch]); i++)
-		len += sprintf(buf + len, "%d.%09u ",
+		len += sprintf(buf + len, "%u.%09u ",
 			       lradc->scale_avail[ch][i].integer,
 			       lradc->scale_avail[ch][i].nano);
 
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
@ 2015-01-27 22:23 ` Rickard Strandqvist
  0 siblings, 0 replies; 6+ messages in thread
From: Rickard Strandqvist @ 2015-01-27 22:23 UTC (permalink / raw)
  To: Jonathan Cameron, Hartmut Knaack
  Cc: Rickard Strandqvist, Lars-Peter Clausen, Peter Meerwald,
	Greg Kroah-Hartman, Grant Likely, Rob Herring, Alexandre Belloni,
	Marek Vasut, Fabio Estevam, Darshana Padmadas, Aybuke Ozdemir,
	Vaishali Thakkar, Robert Hodaszi, Brian Vandre,
	linux-iio-u79uwXL29TY76Z2rM5mHXA,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
---
 drivers/staging/iio/adc/mxs-lradc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index f053535..887767b 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -1001,7 +1001,7 @@ static ssize_t mxs_lradc_show_scale_available_ch(struct device *dev,
 	int i, len = 0;
 
 	for (i = 0; i < ARRAY_SIZE(lradc->scale_avail[ch]); i++)
-		len += sprintf(buf + len, "%d.%09u ",
+		len += sprintf(buf + len, "%u.%09u ",
 			       lradc->scale_avail[ch][i].integer,
 			       lradc->scale_avail[ch][i].nano);
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
@ 2015-01-27 22:59   ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2015-01-27 22:59 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald, Greg Kroah-Hartman, Grant Likely, Rob Herring,
	Alexandre Belloni, Fabio Estevam, Darshana Padmadas,
	Aybuke Ozdemir, Vaishali Thakkar, Robert Hodaszi, Brian Vandre,
	linux-iio, devel, linux-kernel, devicetree

On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Makes sense, thanks!

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
@ 2015-01-27 22:59   ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2015-01-27 22:59 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald, Greg Kroah-Hartman, Grant Likely, Rob Herring,
	Alexandre Belloni, Fabio Estevam, Darshana Padmadas,
	Aybuke Ozdemir, Vaishali Thakkar, Robert Hodaszi, Brian Vandre,
	linux-iio-u79uwXL29TY76Z2rM5mHXA,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>

Makes sense, thanks!

Reviewed-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
  2015-01-27 22:59   ` Marek Vasut
@ 2015-02-08 12:07     ` Jonathan Cameron
  -1 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:07 UTC (permalink / raw)
  To: Marek Vasut, Rickard Strandqvist
  Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald,
	Greg Kroah-Hartman, Grant Likely, Rob Herring, Alexandre Belloni,
	Fabio Estevam, Darshana Padmadas, Aybuke Ozdemir,
	Vaishali Thakkar, Robert Hodaszi, Brian Vandre, linux-iio, devel,
	linux-kernel, devicetree

On 27/01/15 22:59, Marek Vasut wrote:
> On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote:
>> Wrong type in printf format string, requires 'int'
>> but the argument type is 'unsigned int'
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> Makes sense, thanks!
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
Applied.
> 
> Best regards,
> Marek Vasut
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string
@ 2015-02-08 12:07     ` Jonathan Cameron
  0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2015-02-08 12:07 UTC (permalink / raw)
  To: Marek Vasut, Rickard Strandqvist
  Cc: Fabio Estevam, devel, Brian Vandre, Lars-Peter Clausen,
	devicetree, Vaishali Thakkar, Greg Kroah-Hartman, linux-kernel,
	linux-iio, Rob Herring, Alexandre Belloni, Peter Meerwald,
	Hartmut Knaack, Grant Likely, Robert Hodaszi, Darshana Padmadas

On 27/01/15 22:59, Marek Vasut wrote:
> On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote:
>> Wrong type in printf format string, requires 'int'
>> but the argument type is 'unsigned int'
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> Makes sense, thanks!
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
Applied.
> 
> Best regards,
> Marek Vasut
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-08 12:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 22:23 [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string Rickard Strandqvist
2015-01-27 22:23 ` Rickard Strandqvist
2015-01-27 22:59 ` Marek Vasut
2015-01-27 22:59   ` Marek Vasut
2015-02-08 12:07   ` Jonathan Cameron
2015-02-08 12:07     ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.