* [patch] ASoC: Intel: remove an unused struct member
@ 2015-01-28 6:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-01-28 6:42 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Jie Yang,
Jarkko Nikula, Christian Engelmayer, Paweł Piskorski,
alsa-devel, kernel-janitors
We never set the ->scratch pointer, so let's delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index eeef9a5..78daa46 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -277,7 +277,6 @@ struct sst_hsw {
/* FW config */
struct sst_hsw_ipc_fw_ready fw_ready;
struct sst_hsw_ipc_fw_version version;
- struct sst_module *scratch;
bool fw_done;
struct sst_fw *sst_fw;
@@ -2135,7 +2134,6 @@ void sst_hsw_dsp_free(struct device *dev, struct sst_pdata *pdata)
dma_free_coherent(hsw->dsp->dma_dev, SST_HSW_DX_CONTEXT_SIZE,
hsw->dx_context, hsw->dx_context_paddr);
sst_dsp_free(hsw->dsp);
- kfree(hsw->scratch);
kthread_stop(hsw->tx_thread);
kfree(hsw->msg);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ASoC: Intel: remove an unused struct member
@ 2015-01-28 6:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-01-28 6:42 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Jie Yang,
Jarkko Nikula, Christian Engelmayer, Paweł Piskorski,
alsa-devel, kernel-janitors
We never set the ->scratch pointer, so let's delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index eeef9a5..78daa46 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -277,7 +277,6 @@ struct sst_hsw {
/* FW config */
struct sst_hsw_ipc_fw_ready fw_ready;
struct sst_hsw_ipc_fw_version version;
- struct sst_module *scratch;
bool fw_done;
struct sst_fw *sst_fw;
@@ -2135,7 +2134,6 @@ void sst_hsw_dsp_free(struct device *dev, struct sst_pdata *pdata)
dma_free_coherent(hsw->dsp->dma_dev, SST_HSW_DX_CONTEXT_SIZE,
hsw->dx_context, hsw->dx_context_paddr);
sst_dsp_free(hsw->dsp);
- kfree(hsw->scratch);
kthread_stop(hsw->tx_thread);
kfree(hsw->msg);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: Intel: remove an unused struct member
2015-01-28 6:42 ` Dan Carpenter
@ 2015-01-28 11:36 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-01-28 11:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Christian Engelmayer, Takashi Iwai, kernel-janitors,
Liam Girdwood, Jarkko Nikula, Paweł Piskorski
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
On Wed, Jan 28, 2015 at 09:42:10AM +0300, Dan Carpenter wrote:
> We never set the ->scratch pointer, so let's delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: Intel: remove an unused struct member
@ 2015-01-28 11:36 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-01-28 11:36 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Christian Engelmayer, Takashi Iwai, kernel-janitors,
Liam Girdwood, Jarkko Nikula, Paweł Piskorski
[-- Attachment #1.1: Type: text/plain, Size: 206 bytes --]
On Wed, Jan 28, 2015 at 09:42:10AM +0300, Dan Carpenter wrote:
> We never set the ->scratch pointer, so let's delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-28 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 6:42 [patch] ASoC: Intel: remove an unused struct member Dan Carpenter
2015-01-28 6:42 ` Dan Carpenter
2015-01-28 11:36 ` Mark Brown
2015-01-28 11:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.