From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robherring2@gmail.com>,
linux-leds@vger.kernel.org,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property
Date: Wed, 28 Jan 2015 09:04:17 +0200 [thread overview]
Message-ID: <20150128070417.GK17565@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <54BF73B9.8060402@samsung.com>
On Wed, Jan 21, 2015 at 10:39:05AM +0100, Jacek Anaszewski wrote:
> I agree. I think that led-sources-cnt is redundant. A list property
> can be read using of_prop_next_u32 function. I missed that and thus
> proposed putting led-sources-cnt in each sub-node to be able to read
> led-sources list with of_property_read_u32_array.
>
> Effectively, I propose to avoid adding led-sources-cnt property.
You can also read the array size using of_get_property().
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2015-01-28 7:04 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 15:22 [PATCH/RFC v10 00/19] LED / flash API integration Jacek Anaszewski
2015-01-09 15:22 ` [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem Jacek Anaszewski
2015-01-09 17:37 ` Pavel Machek
2015-01-26 23:02 ` Bryan Wu
2015-01-09 15:22 ` [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension Jacek Anaszewski
2015-01-09 17:40 ` Pavel Machek
2015-01-12 8:04 ` Jacek Anaszewski
2015-01-26 23:03 ` Bryan Wu
2015-01-09 15:22 ` [PATCH/RFC v10 03/19] DT: leds: Add led-sources property Jacek Anaszewski
2015-01-09 17:42 ` Pavel Machek
[not found] ` <1420816989-1808-4-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 18:33 ` Rob Herring
2015-01-09 18:33 ` Rob Herring
2015-01-12 8:32 ` Jacek Anaszewski
2015-01-12 13:52 ` Rob Herring
2015-01-12 16:10 ` Jacek Anaszewski
2015-01-12 16:55 ` Rob Herring
2015-01-12 17:06 ` Mark Brown
2015-01-15 12:33 ` Sylwester Nawrocki
2015-01-15 14:37 ` Rob Herring
2015-01-15 21:03 ` Pavel Machek
2015-01-16 10:17 ` Sylwester Nawrocki
2015-01-16 10:17 ` Sylwester Nawrocki
[not found] ` <CAL_JsqKpJtUG0G6g1GOuSVpc31oe-dp3qdrKJUE0upG-xRDFhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-13 8:42 ` Jacek Anaszewski
2015-01-13 8:42 ` Jacek Anaszewski
2015-01-15 14:24 ` Rob Herring
2015-01-15 15:53 ` Mark Brown
2015-01-16 9:07 ` Jacek Anaszewski
2015-01-16 13:48 ` Rob Herring
[not found] ` <CAL_Jsq+EFWzs1HP1tVt6P=p=HZn2AtSPjp55YrmMQi_mE+kNfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-16 15:52 ` Jacek Anaszewski
2015-01-16 15:52 ` Jacek Anaszewski
2015-01-20 16:09 ` Jacek Anaszewski
2015-01-20 17:29 ` Rob Herring
2015-01-20 17:40 ` Pavel Machek
2015-01-21 9:39 ` Jacek Anaszewski
2015-01-28 7:04 ` Sakari Ailus [this message]
2015-01-09 15:22 ` [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros Jacek Anaszewski
2015-01-09 17:43 ` Pavel Machek
2015-01-20 11:12 ` Lee Jones
2015-01-20 12:53 ` Jacek Anaszewski
2015-01-28 8:52 ` Sakari Ailus
2015-01-09 15:22 ` [PATCH/RFC v10 05/19] mfd: max77693: Modify flash cell name identifiers Jacek Anaszewski
2015-01-09 17:53 ` Pavel Machek
[not found] ` <1420816989-1808-6-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-20 11:13 ` Lee Jones
2015-01-20 11:13 ` Lee Jones
2015-01-20 12:57 ` Jacek Anaszewski
2015-01-20 12:57 ` Jacek Anaszewski
2015-01-20 15:41 ` Lee Jones
2015-01-09 15:22 ` [PATCH/RFC v10 06/19] mfd: max77693: modifications around max77693_led_platform_data Jacek Anaszewski
2015-01-09 17:56 ` Pavel Machek
[not found] ` <1420816989-1808-7-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-20 11:15 ` Lee Jones
2015-01-20 11:15 ` Lee Jones
2015-01-09 15:22 ` [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros Jacek Anaszewski
2015-01-09 17:59 ` Pavel Machek
2015-01-20 11:17 ` Lee Jones
2015-01-20 13:01 ` Jacek Anaszewski
2015-01-20 14:11 ` Jacek Anaszewski
2015-01-20 15:40 ` Lee Jones
2015-01-20 16:00 ` Pavel Machek
2015-01-20 16:41 ` Lee Jones
2015-01-09 15:22 ` [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell Jacek Anaszewski
[not found] ` <1420816989-1808-9-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 18:46 ` Pavel Machek
2015-01-09 18:46 ` Pavel Machek
2015-01-12 8:52 ` Jacek Anaszewski
2015-01-12 13:25 ` Pavel Machek
2015-01-12 13:46 ` Jacek Anaszewski
2015-02-05 15:34 ` Sakari Ailus
2015-02-05 15:34 ` Sakari Ailus
2015-02-05 16:26 ` Jacek Anaszewski
2015-01-09 15:22 ` [PATCH/RFC v10 09/19] DT: Add documentation for the mfd Maxim max77693 Jacek Anaszewski
2015-01-09 17:52 ` Pavel Machek
2015-01-20 11:21 ` Lee Jones
2015-01-20 14:36 ` Jacek Anaszewski
[not found] ` <54BE67EA.2070507-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-20 15:38 ` Lee Jones
2015-01-20 15:38 ` Lee Jones
[not found] ` <1420816989-1808-1-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 15:23 ` [PATCH/RFC v10 10/19] leds: Add driver for AAT1290 current regulator Jacek Anaszewski
2015-01-09 15:23 ` Jacek Anaszewski
[not found] ` <1420816989-1808-11-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 18:57 ` Pavel Machek
2015-01-09 18:57 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 11/19] of: Add Skyworks Solutions, Inc. vendor prefix Jacek Anaszewski
[not found] ` <1420816989-1808-12-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 18:57 ` Pavel Machek
2015-01-09 18:57 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 12/19] DT: Add documentation for the Skyworks AAT1290 Jacek Anaszewski
2015-01-09 18:58 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 13/19] exynos4-is: Add support for v4l2-flash subdevs Jacek Anaszewski
2015-01-09 19:06 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 14/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control Jacek Anaszewski
[not found] ` <1420816989-1808-15-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 19:06 ` Pavel Machek
2015-01-09 19:06 ` Pavel Machek
2015-02-05 16:36 ` Sakari Ailus
2015-01-09 15:23 ` [PATCH/RFC v10 15/19] media: Add registration helpers for V4L2 flash sub-devices Jacek Anaszewski
2015-01-09 20:54 ` Pavel Machek
2015-01-12 9:46 ` Jacek Anaszewski
2015-01-12 9:46 ` Jacek Anaszewski
2015-01-12 13:27 ` Pavel Machek
2015-02-05 17:59 ` Sakari Ailus
2015-02-09 11:15 ` Jacek Anaszewski
2015-01-09 15:23 ` [PATCH/RFC v10 16/19] Documentation: leds: Add description of v4l2-flash sub-device Jacek Anaszewski
2015-01-09 20:57 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 17/19] DT: Add documentation for exynos4-is 'flashes' property Jacek Anaszewski
2015-01-09 20:57 ` Pavel Machek
2015-01-21 16:32 ` Sylwester Nawrocki
2015-01-22 8:47 ` Jacek Anaszewski
2015-01-09 15:23 ` [PATCH/RFC v10 18/19] leds: max77693: add support for V4L2 Flash sub-device Jacek Anaszewski
2015-01-09 20:59 ` Pavel Machek
2015-01-09 15:23 ` [PATCH/RFC v10 19/19] leds: aat1290: " Jacek Anaszewski
[not found] ` <1420816989-1808-20-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-09 20:59 ` Pavel Machek
2015-01-09 20:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150128070417.GK17565@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=rpurdie@rpsys.net \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.