All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Libin Yang <lbyang@marvell.com>
Subject: Re: [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked
Date: Wed, 28 Jan 2015 14:57:41 -0700	[thread overview]
Message-ID: <20150128145741.02812a8f@lwn.net> (raw)
In-Reply-To: <1422479867-3370921-7-git-send-email-arnd@arndb.de>

On Wed, 28 Jan 2015 22:17:46 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> The mmp ccic driver uses a platform_data structure that has never
> existed in an upstream kernel and always fails to build:

This driver most assuredly did work on XO 1.75 machines, and the
platform_data structure does exist; it's the stuff added by Libin
afterward that apparently broke things.  Strange that it only came out now,
though, nearly two years later. Libin, any thoughts on this?

Meanwhile, it is clearly broken, and I don't have an immediate fix, so,

Acked-by: Jonathan Corbet <corbet@lwn.net>

(Though I would like a different patch subject, since the current one is
wrong).

I think the right thing to do, alas, might be to back out all of Libin's
changes.  They clearly are not being used by anybody and do not seem to be
getting any further development attention.  It would like to keep this
driver working for XO systems for a while yet...but I won't get to it
right away.

Thanks,

jon

WARNING: multiple messages have this Message-ID (diff)
From: corbet@lwn.net (Jonathan Corbet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked
Date: Wed, 28 Jan 2015 14:57:41 -0700	[thread overview]
Message-ID: <20150128145741.02812a8f@lwn.net> (raw)
In-Reply-To: <1422479867-3370921-7-git-send-email-arnd@arndb.de>

On Wed, 28 Jan 2015 22:17:46 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> The mmp ccic driver uses a platform_data structure that has never
> existed in an upstream kernel and always fails to build:

This driver most assuredly did work on XO 1.75 machines, and the
platform_data structure does exist; it's the stuff added by Libin
afterward that apparently broke things.  Strange that it only came out now,
though, nearly two years later. Libin, any thoughts on this?

Meanwhile, it is clearly broken, and I don't have an immediate fix, so,

Acked-by: Jonathan Corbet <corbet@lwn.net>

(Though I would like a different patch subject, since the current one is
wrong).

I think the right thing to do, alas, might be to back out all of Libin's
changes.  They clearly are not being used by anybody and do not seem to be
getting any further development attention.  It would like to keep this
driver working for XO systems for a while yet...but I won't get to it
right away.

Thanks,

jon

  reply	other threads:[~2015-01-29  1:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 21:17 [PATCH 0/7] [media] ARM randconfig fixes Arnd Bergmann
2015-01-28 21:17 ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 1/7] [media] timberdale: do not select TIMB_DMA Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 2/7] [media] radio/aimslab: use mdelay instead of udelay Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 3/7] [media] staging/davinci/vpfe/dm365: add missing dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-29 10:26   ` Lad, Prabhakar
2015-01-29 10:26     ` Lad, Prabhakar
2015-01-28 21:17 ` [PATCH 4/7] [media] siano: fix Kconfig dependencies Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 5/7] [media] gspca: add INPUT dependency Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 6/7] [media] marvell-ccic: MMP_CAMERA never worked Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:57   ` Jonathan Corbet [this message]
2015-01-28 21:57     ` Jonathan Corbet
2015-01-28 22:11   ` [PATCH v2 6/7] [media] marvell-ccic: MMP_CAMERA no longer builds Arnd Bergmann
2015-01-28 22:11     ` Arnd Bergmann
2015-01-28 21:17 ` [PATCH 7/7] [media] marvell-ccic needs VIDEOBUF2_DMA_SG Arnd Bergmann
2015-01-28 21:17   ` Arnd Bergmann
2015-01-28 21:58   ` Jonathan Corbet
2015-01-28 21:58     ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128145741.02812a8f@lwn.net \
    --to=corbet@lwn.net \
    --cc=arnd@arndb.de \
    --cc=lbyang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.