From: "Pali Rohár" <pali.rohar@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, Sebastian Reichel <sre@debian.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio
Date: Wed, 28 Jan 2015 15:09:17 +0100 [thread overview]
Message-ID: <201501281509.17333@pali> (raw)
In-Reply-To: <201501271511.08933@pali>
[-- Attachment #1: Type: Text/Plain, Size: 1744 bytes --]
> > > It is quite important to keep qemu working, really.
> > > Debugging early boot on hardware is very hard, for
> > > example.
> >
> > I understand, but looking at the history of the driver, if
> > it fails now with the jack-detection GPIO, it should have
> > been failing in the past as well. What triggered this
> > sudden qemu does not like jack-detection GPIO? Before the
> > devm_gpiod_get() conversion the driver should have failed in
> > snd_soc_jack_add_gpios() phase.
>
> With 3.12 kernel rx51-audio driver loads without any problem.
> So there is some regression. Here is dmesg log from 3.12
> kernel:
>
> [ 1.123779] rx51-audio rx51-audio: tlv320aic3x-hifi <->
> omap- mcbsp.2 mapping ok
> [ 1.130737] tlv320aic3x-codec 2-0019: ASoC: mux b Right
> Line1L Mux has no paths
> [ 1.131347] tlv320aic3x-codec 2-0019: ASoC: mux b Left
> Line1R Mux has no paths
> [ 1.133697] tlv320aic3x-codec 2-0018: ASoC: mux Right
> Line1L Mux has no paths
> [ 1.134307] tlv320aic3x-codec 2-0018: ASoC: mux Left Line1R
> Mux has no paths
> [ 1.137451] input: RX-51 AV Jack as /devices/platform/rx51-
> audio/sound/card0/input2
>
> I will try to investigate where is problem...
>
Ok, problem found and solved. Please drop my patch and sorry for
a noise.
As is visible in above lines AV Jack is working fine on non DT
kernel (3.12) and fails on DT kernel.
Reason is because I have another non-mainline driver which is
using GPIOs and in non DT kernel is initialized *after* audio.
And in DT kernel is initialized *before* audio.
Once I changed my non-mainline driver to not request av jack
gpio, rx51-audio driver loads fine in qemu.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@debian.org>,
linux-omap@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio
Date: Wed, 28 Jan 2015 15:09:17 +0100 [thread overview]
Message-ID: <201501281509.17333@pali> (raw)
In-Reply-To: <201501271511.08933@pali>
[-- Attachment #1.1: Type: Text/Plain, Size: 1744 bytes --]
> > > It is quite important to keep qemu working, really.
> > > Debugging early boot on hardware is very hard, for
> > > example.
> >
> > I understand, but looking at the history of the driver, if
> > it fails now with the jack-detection GPIO, it should have
> > been failing in the past as well. What triggered this
> > sudden qemu does not like jack-detection GPIO? Before the
> > devm_gpiod_get() conversion the driver should have failed in
> > snd_soc_jack_add_gpios() phase.
>
> With 3.12 kernel rx51-audio driver loads without any problem.
> So there is some regression. Here is dmesg log from 3.12
> kernel:
>
> [ 1.123779] rx51-audio rx51-audio: tlv320aic3x-hifi <->
> omap- mcbsp.2 mapping ok
> [ 1.130737] tlv320aic3x-codec 2-0019: ASoC: mux b Right
> Line1L Mux has no paths
> [ 1.131347] tlv320aic3x-codec 2-0019: ASoC: mux b Left
> Line1R Mux has no paths
> [ 1.133697] tlv320aic3x-codec 2-0018: ASoC: mux Right
> Line1L Mux has no paths
> [ 1.134307] tlv320aic3x-codec 2-0018: ASoC: mux Left Line1R
> Mux has no paths
> [ 1.137451] input: RX-51 AV Jack as /devices/platform/rx51-
> audio/sound/card0/input2
>
> I will try to investigate where is problem...
>
Ok, problem found and solved. Please drop my patch and sorry for
a noise.
As is visible in above lines AV Jack is working fine on non DT
kernel (3.12) and fails on DT kernel.
Reason is because I have another non-mainline driver which is
using GPIOs and in non DT kernel is initialized *after* audio.
And in DT kernel is initialized *before* audio.
Once I changed my non-mainline driver to not request av jack
gpio, rx51-audio driver loads fine in qemu.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-01-28 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 20:51 [PATCH] ASoC: rx51: do not fail if could not get jack detection gpio Pali Rohár
2015-01-26 20:51 ` Pali Rohár
2015-01-27 13:27 ` Peter Ujfalusi
2015-01-27 13:27 ` Peter Ujfalusi
2015-01-27 13:32 ` Pavel Machek
2015-01-27 13:32 ` Pavel Machek
2015-01-27 13:41 ` Peter Ujfalusi
2015-01-27 14:11 ` Pali Rohár
2015-01-27 14:11 ` Pali Rohár
2015-01-28 14:09 ` Pali Rohár [this message]
2015-01-28 14:09 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501281509.17333@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=sre@debian.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.