All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"
@ 2015-01-27 15:45 Stefan Roese
  2015-01-27 16:02 ` Tom Rini
  2015-01-29 14:00 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Roese @ 2015-01-27 15:45 UTC (permalink / raw)
  To: u-boot

Microblaze currently doesn't use printf in SPL. So this one line was the only
reference to it and resulted in the printf functionality to be pulled in.
Exceeding the 4k size limit. Lets change the printf back to puts so that
Microblaze is fixed again. The only drawback is that the detected boot-device
number will not be printed. But this message alone should be helpful enough
to get an idea where the boot process is broken.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Tom Rini <trini@ti.com>
Cc: Michal Simek <michal.simek@xilinx.com>
---
 common/spl/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index 1826c47..daaeb50 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -231,7 +231,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 #endif
 	default:
 #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
-		printf("SPL: Unsupported Boot Device %d\n", boot_device);
+		puts("SPL: Unsupported Boot Device!\n");
 #endif
 		hang();
 	}
-- 
2.2.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"
  2015-01-27 15:45 [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device" Stefan Roese
@ 2015-01-27 16:02 ` Tom Rini
  2015-01-27 18:02   ` Michal Simek
  2015-01-29 14:00 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Tom Rini @ 2015-01-27 16:02 UTC (permalink / raw)
  To: u-boot

On Tue, Jan 27, 2015 at 04:45:09PM +0100, Stefan Roese wrote:

> Microblaze currently doesn't use printf in SPL. So this one line was the only
> reference to it and resulted in the printf functionality to be pulled in.
> Exceeding the 4k size limit. Lets change the printf back to puts so that
> Microblaze is fixed again. The only drawback is that the detected boot-device
> number will not be printed. But this message alone should be helpful enough
> to get an idea where the boot process is broken.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Michal Simek <michal.simek@xilinx.com>

Since we have a debug() higher up that will print out what the value is,
I'm OK with this and I'll apply shortly, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150127/d09b40aa/attachment.pgp>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device"
  2015-01-27 16:02 ` Tom Rini
@ 2015-01-27 18:02   ` Michal Simek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2015-01-27 18:02 UTC (permalink / raw)
  To: u-boot

On 01/27/2015 05:02 PM, Tom Rini wrote:
> On Tue, Jan 27, 2015 at 04:45:09PM +0100, Stefan Roese wrote:
> 
>> Microblaze currently doesn't use printf in SPL. So this one line was the only
>> reference to it and resulted in the printf functionality to be pulled in.
>> Exceeding the 4k size limit. Lets change the printf back to puts so that
>> Microblaze is fixed again. The only drawback is that the detected boot-device
>> number will not be printed. But this message alone should be helpful enough
>> to get an idea where the boot process is broken.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Tom Rini <trini@ti.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
> 
> Since we have a debug() higher up that will print out what the value is,
> I'm OK with this and I'll apply shortly, thanks!
> 

Works for me.
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150127/f8399cfc/attachment.pgp>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] spl: Change printf to puts for "Unsupported boot-device"
  2015-01-27 15:45 [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device" Stefan Roese
  2015-01-27 16:02 ` Tom Rini
@ 2015-01-29 14:00 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2015-01-29 14:00 UTC (permalink / raw)
  To: u-boot

On Tue, Jan 27, 2015 at 04:45:09PM +0100, Stefan Roese wrote:

> Microblaze currently doesn't use printf in SPL. So this one line was the only
> reference to it and resulted in the printf functionality to be pulled in.
> Exceeding the 4k size limit. Lets change the printf back to puts so that
> Microblaze is fixed again. The only drawback is that the detected boot-device
> number will not be printed. But this message alone should be helpful enough
> to get an idea where the boot process is broken.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150129/34cfbf35/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-29 14:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-27 15:45 [U-Boot] [PATCH] spl: Change printf to puts for "Unsupported boot-device" Stefan Roese
2015-01-27 16:02 ` Tom Rini
2015-01-27 18:02   ` Michal Simek
2015-01-29 14:00 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.