All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Satoru Takeuchi <satoru.takeuchi@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ktest: console pty support
Date: Thu, 29 Jan 2015 15:39:39 -0600	[thread overview]
Message-ID: <20150129213939.GA20952@treble.redhat.com> (raw)
In-Reply-To: <20150129154441.1b248e93@gandalf.local.home>

On Thu, Jan 29, 2015 at 03:44:41PM -0500, Steven Rostedt wrote:
> On Wed, 28 Jan 2015 13:38:37 -0600
> Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> 
> > These patches can be applied on top of yesterday's "ktest: restore tty settings
> > after closing console" patch.  They create a pty pair for the console to
> > prevent the console child process from messing up ktest's tty settings.
> > 
> > v2 changes:
> > - rebased onto the stty save/restore patch
> > - added a patch to enable user input to the console
> > 
> > Josh Poimboeuf (2):
> >   ktest: give console process a dedicated tty
> >   ktest: enable user input to the console
> > 
> >  tools/testing/ktest/ktest.pl | 117 ++++++++++++++++++++++++++++++++++---------
> >  1 file changed, 93 insertions(+), 24 deletions(-)
> > 
> 
> OK, I applied these and been using ktest since. But after one of my
> tests failed (got a bug report), I had no console. I think there's a
> die someplace that does not put everything back.
> 
> Think you could find out where?

Can you tell if it died via dodie()?  Looks like that wouldn't clean up
the stty settings.

-- 
Josh

  reply	other threads:[~2015-01-29 21:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 19:38 [PATCH v2 0/2] ktest: console pty support Josh Poimboeuf
2015-01-28 19:38 ` [PATCH v2 1/2] ktest: give console process a dedicated tty Josh Poimboeuf
2015-01-28 19:38 ` [PATCH v2 2/2] ktest: enable user input to the console Josh Poimboeuf
2015-01-29 20:44 ` [PATCH v2 0/2] ktest: console pty support Steven Rostedt
2015-01-29 21:39   ` Josh Poimboeuf [this message]
2015-01-29 22:07     ` Steven Rostedt
2015-01-30  2:54       ` [PATCH] ktest: cleanup terminal on dodie() failure Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129213939.GA20952@treble.redhat.com \
    --to=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=satoru.takeuchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.