Re: [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link

[Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>]

On Mon, Feb 02, 2015 at 08:10:17AM +0000, Chen, Jing D wrote:
> Hi Neil,
> 
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org]
> > Sent: Sunday, February 01, 2015 8:51 AM
> > To: Chen, Jing D
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k
> > lib into link
> > 
> > On Fri, Jan 30, 2015 at 01:07:34PM +0800, Chen Jing D(Mark) wrote:
> > > From: Jeff Shaw <jeffrey.b.shaw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > Signed-off-by: Jeff Shaw <jeffrey.b.shaw-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Chen Jing D(Mark) <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> > >  mk/rte.app.mk |    4 ++++
> > >  1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> > > index 4294d9a..87d8763 100644
> > > --- a/mk/rte.app.mk
> > > +++ b/mk/rte.app.mk
> > > @@ -211,6 +211,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
> > >  LDLIBS += -lrte_pmd_i40e
> > >  endif
> > >
> > > +ifeq ($(CONFIG_RTE_LIBRTE_FM10K_PMD),y)
> > > +LDLIBS += -lrte_pmd_fm10k
> > > +endif
> > > +
> > >  ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> > >  LDLIBS += -lrte_pmd_ixgbe
> > >  endif
> > > --
> > > 1.7.7.6
> > >
> > >
> > This patch should be merged with patch 17, and patch 2, and placed at the
> > end of
> > your series to avoid a FTBFS issue
> 
> My rationale is to make every single patch not to break the compile. So, I'd like to
> add the binary library into compile and link in last 2 patches, after all the actual code
> are patched.  For Patch 2, I think you are right, maybe a better way is to move it as 
> patch "16". 
> 
> But I'm not sure whether I should merge these 3 together. You know, somebody may
> not happy to see the changes in different directory to appear in single patch.
>  
As Thomas notes, its fine to change multiple directories, its the functionality
add and ability to compile that needs to be atomic to a commit.
Neil

> > Neil
> 
>