From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()
Date: Mon, 2 Feb 2015 11:27:55 -0500 [thread overview]
Message-ID: <20150202162755.GA6096@laptop.bfoster> (raw)
In-Reply-To: <54CB2487.6040602@sandeen.net>
On Fri, Jan 30, 2015 at 12:28:23AM -0600, Eric Sandeen wrote:
> Because this is usually the first question asked...
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
Good idea.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/libxfs/util.c b/libxfs/util.c
> index 9504e33..6464a1b 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char *fmt, ...)
> va_start(ap, fmt);
> vfprintf(stderr, fmt, ap);
> fprintf(stderr, " This is a bug.\n");
> + fprintf(stderr, "%s version %s\n", progname, VERSION);
> fprintf(stderr, "Please capture the filesystem metadata with "
> "xfs_metadump and\nreport it to xfs@oss.sgi.com.\n");
> va_end(ap);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-02-02 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 6:28 [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err() Eric Sandeen
2015-02-02 16:27 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202162755.GA6096@laptop.bfoster \
--to=bfoster@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.