[PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()

[PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()

[Eric Sandeen]

Because this is usually the first question asked...

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/libxfs/util.c b/libxfs/util.c
index 9504e33..6464a1b 100644
--- a/libxfs/util.c
+++ b/libxfs/util.c
@@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char *fmt, ...)
 	va_start(ap, fmt);
 	vfprintf(stderr, fmt, ap);
 	fprintf(stderr, "  This is a bug.\n");
+	fprintf(stderr, "%s version %s\n", progname, VERSION);
 	fprintf(stderr, "Please capture the filesystem metadata with "
 			"xfs_metadump and\nreport it to xfs@oss.sgi.com.\n");
 	va_end(ap);

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] libxfs: report VERSION in libxfs_fs_repair_cmn_err()

[Brian Foster]

On Fri, Jan 30, 2015 at 12:28:23AM -0600, Eric Sandeen wrote:
> Because this is usually the first question asked...
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---

Good idea.

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> diff --git a/libxfs/util.c b/libxfs/util.c
> index 9504e33..6464a1b 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -718,6 +718,7 @@ libxfs_fs_repair_cmn_err(int level, xfs_mount_t *mp, char *fmt, ...)
>  	va_start(ap, fmt);
>  	vfprintf(stderr, fmt, ap);
>  	fprintf(stderr, "  This is a bug.\n");
> +	fprintf(stderr, "%s version %s\n", progname, VERSION);
>  	fprintf(stderr, "Please capture the filesystem metadata with "
>  			"xfs_metadump and\nreport it to xfs@oss.sgi.com.\n");
>  	va_end(ap);
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs