* Multiple declarations for intel_fbc_enabled
@ 2015-02-02 16:40 Ed Maste
2015-02-02 17:46 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Ed Maste @ 2015-02-02 16:40 UTC (permalink / raw)
To: intel-gfx
A FreeBSD developer discovered that intel_fbc_enabled has a
declaration in two headers:
sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
We have a slightly older version of the i915 driver on FreeBSD, but I
see that this is still the case in Linux (although the "extern" has
been removed from one of them). Commit 85208be added the one in
intel_drv.h and didn't remove the existing one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Multiple declarations for intel_fbc_enabled
2015-02-02 16:40 Multiple declarations for intel_fbc_enabled Ed Maste
@ 2015-02-02 17:46 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2015-02-02 17:46 UTC (permalink / raw)
To: Ed Maste; +Cc: intel-gfx
On Mon, Feb 02, 2015 at 11:40:13AM -0500, Ed Maste wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
>
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
>
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.
Seems to be fixed already with
commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date: Mon Dec 8 14:09:10 2014 -0200
drm/i915: Move FBC stuff to intel_fbc.c
which will be in 3.20. Thanks for reporting anyway.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Multiple declarations for intel_fbc_enabled
2015-02-04 13:27 ` Jani Nikula
@ 2015-02-05 2:24 ` Ed Maste
0 siblings, 0 replies; 5+ messages in thread
From: Ed Maste @ 2015-02-05 2:24 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On 4 February 2015 at 08:27, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 02 Feb 2015, Ed Maste <carpeddiem@gmail.com> wrote:
>> A FreeBSD developer discovered that intel_fbc_enabled has a
>> declaration in two headers:
>>
>> ...
>
> Fixed by
>
> commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Thanks.
Sorry for the double post - one was stuck in moderation by the mailing
list software, presumably because it came from a non-subscribed
address.
I've added linux-next now and will check there if we find other issues
in the future.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Multiple declarations for intel_fbc_enabled
2015-02-02 15:42 Ed Maste
@ 2015-02-04 13:27 ` Jani Nikula
2015-02-05 2:24 ` Ed Maste
0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2015-02-04 13:27 UTC (permalink / raw)
To: Ed Maste, intel-gfx
On Mon, 02 Feb 2015, Ed Maste <carpeddiem@gmail.com> wrote:
> A FreeBSD developer discovered that intel_fbc_enabled has a
> declaration in two headers:
>
> sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
> sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
> drm_device *dev);
>
> We have a slightly older version of the i915 driver on FreeBSD, but I
> see that this is still the case in Linux (although the "extern" has
> been removed from one of them). Commit 85208be added the one in
> intel_drv.h and didn't remove the existing one.
Fixed by
commit 7ff0ebcc1e30e3216c8c62ee71f59ac830b10364
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
Date: Mon Dec 8 14:09:10 2014 -0200
drm/i915: Move FBC stuff to intel_fbc.c
which is queued for v3.20.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Multiple declarations for intel_fbc_enabled
@ 2015-02-02 15:42 Ed Maste
2015-02-04 13:27 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Ed Maste @ 2015-02-02 15:42 UTC (permalink / raw)
To: intel-gfx
A FreeBSD developer discovered that intel_fbc_enabled has a
declaration in two headers:
sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct
drm_device *dev);
We have a slightly older version of the i915 driver on FreeBSD, but I
see that this is still the case in Linux (although the "extern" has
been removed from one of them). Commit 85208be added the one in
intel_drv.h and didn't remove the existing one.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-05 2:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02 16:40 Multiple declarations for intel_fbc_enabled Ed Maste
2015-02-02 17:46 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2015-02-02 15:42 Ed Maste
2015-02-04 13:27 ` Jani Nikula
2015-02-05 2:24 ` Ed Maste
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.