Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile()

From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile()
Date: Mon, 2 Feb 2015 20:34:02 +0100	[thread overview]
Message-ID: <20150202193402.GE19586@noname.redhat.com> (raw)
In-Reply-To: <1422284444-12529-10-git-send-email-mreitz@redhat.com>

Am 26.01.2015 um 16:00 hat Max Reitz geschrieben:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-io.c | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)
> 
> diff --git a/qemu-io.c b/qemu-io.c
> index 91a445a..81f8f64 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -39,7 +39,6 @@ static ReadLineState *readline_state;
>  static int close_f(BlockDriverState *bs, int argc, char **argv)
>  {
>      blk_unref(qemuio_blk);
> -    qemuio_bs = NULL;
>      qemuio_blk = NULL;
>      return 0;
>  }

This doesn't seem to be correct at this point in the series. qemuio_bs
is still passed to qemuio_command(), which checks whether non-global
commands are allowed to run using init_check_command().

At the end of the series, please remove qemuio_bs altogether. This
version of the series leaves it around without any reader.

Kevin