All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: "'Changman Lee'" <cm224.lee@samsung.com>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache
Date: Mon, 2 Feb 2015 14:50:39 -0800	[thread overview]
Message-ID: <20150202225039.GA34575@jaegeuk-mac02.mot.com> (raw)
In-Reply-To: <009c01d03e94$685cab90$391602b0$@samsung.com>

On Mon, Feb 02, 2015 at 10:59:28AM +0800, Chao Yu wrote:
> Hi all,
> 
> > -----Original Message-----
> > From: Chao Yu [mailto:chao2.yu@samsung.com]
> > Sent: Monday, January 26, 2015 1:52 PM
> > To: Jaegeuk Kim; Changman Lee
> > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache
> > 
> > This patch adds core functions including slab cache init function and
> > init/lookup/update/shrink/destroy function for rb-tree based extent cache.
> > 
> > Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail
> > design and implementation of extent cache.
> > 
> > Todo:
> >  * add a cached_ei into struct extent_tree for a quick recent cache.
> >  * register rb-based extent cache shrink with mm shrink interface.
> >  * disable dir inode's extent cache.
> > 
> > v2:
> >  o move set_extent_info and __is_{extent,back,front}_mergeable into f2fs.h.
> >  o introduce __{attach,detach}_extent_node for code readability.
> >  o use f2fs_kmem_cache_alloc/f2fs_radix_tree_insert for code readability.
> >  o fix some coding style and typo issues.
> >  o get rid of node/tree count stat in f2fs_{shrink,destroy}_extent_tree.
> > 
> 
> There is an obviously bug in this patch, with it we will encounter an oops easily,
> My mistaken, Please ignore this patch set, sorry for the noise. :(
> 
> I will send a v3 later.

Hi Chao,

Okay, then I'll remove all the patches in this series from my testing branch.
Note that, I confirmed the patches till 05/10 have no problem.

Thanks,

> 
> Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache
Date: Mon, 2 Feb 2015 14:50:39 -0800	[thread overview]
Message-ID: <20150202225039.GA34575@jaegeuk-mac02.mot.com> (raw)
In-Reply-To: <009c01d03e94$685cab90$391602b0$@samsung.com>

On Mon, Feb 02, 2015 at 10:59:28AM +0800, Chao Yu wrote:
> Hi all,
> 
> > -----Original Message-----
> > From: Chao Yu [mailto:chao2.yu@samsung.com]
> > Sent: Monday, January 26, 2015 1:52 PM
> > To: Jaegeuk Kim; Changman Lee
> > Cc: linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> > Subject: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache
> > 
> > This patch adds core functions including slab cache init function and
> > init/lookup/update/shrink/destroy function for rb-tree based extent cache.
> > 
> > Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail
> > design and implementation of extent cache.
> > 
> > Todo:
> >  * add a cached_ei into struct extent_tree for a quick recent cache.
> >  * register rb-based extent cache shrink with mm shrink interface.
> >  * disable dir inode's extent cache.
> > 
> > v2:
> >  o move set_extent_info and __is_{extent,back,front}_mergeable into f2fs.h.
> >  o introduce __{attach,detach}_extent_node for code readability.
> >  o use f2fs_kmem_cache_alloc/f2fs_radix_tree_insert for code readability.
> >  o fix some coding style and typo issues.
> >  o get rid of node/tree count stat in f2fs_{shrink,destroy}_extent_tree.
> > 
> 
> There is an obviously bug in this patch, with it we will encounter an oops easily,
> My mistaken, Please ignore this patch set, sorry for the noise. :(
> 
> I will send a v3 later.

Hi Chao,

Okay, then I'll remove all the patches in this series from my testing branch.
Note that, I confirmed the patches till 05/10 have no problem.

Thanks,

> 
> Thanks,

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/

  reply	other threads:[~2015-02-02 22:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  5:51 [f2fs-dev][PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache Chao Yu
2015-02-02  2:59 ` [f2fs-dev] [PATCH " Chao Yu
2015-02-02 22:50   ` Jaegeuk Kim [this message]
2015-02-02 22:50     ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150202225039.GA34575@jaegeuk-mac02.mot.com \
    --to=jaegeuk@kernel.org \
    --cc=chao2.yu@samsung.com \
    --cc=cm224.lee@samsung.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.