* [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
@ 2015-02-04 15:34 Julian Scheel
2015-02-04 16:19 ` Yann E. MORIN
2015-02-07 21:48 ` Yann E. MORIN
0 siblings, 2 replies; 5+ messages in thread
From: Julian Scheel @ 2015-02-04 15:34 UTC (permalink / raw)
To: buildroot
Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
so export it.
Signed-off-by: Julian Scheel <julian@jusst.de>
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index e554a30..92ae3fa 100644
--- a/Makefile
+++ b/Makefile
@@ -349,6 +349,7 @@ endif
# Scripts in support/ or post-build scripts may need to reference
# these locations, so export them so it is easier to use
export BR2_CONFIG
+export BR2_EXTERNAL
export TARGET_DIR
export STAGING_DIR
export HOST_DIR
--
2.2.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
2015-02-04 15:34 [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts Julian Scheel
@ 2015-02-04 16:19 ` Yann E. MORIN
2015-02-04 16:21 ` Yann E. MORIN
2015-02-07 21:48 ` Yann E. MORIN
1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-02-04 16:19 UTC (permalink / raw)
To: buildroot
Julian, All,
On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> so export it.
As discussed on IRC, there is another solution to export BR2_EXTERNAL,
which is to add it to EXTRA_ENV, like so:
br2-external: make it available to post-{build,image} scripts
Currently, BR2_EXTERNAL is not always exported to sub-processes that we
spawn, like post-build or post-image scripts. This all depends on how
the user passes BR2_EXTERNAL; consider the following:
- make BR2_EXTERNAL=/path/to/br2-ext
- BR2_EXTERNAL=/path/to/br2-ext make
In the first case, it is just a make variable, not an environment
variable, and thus not exported, while in the second case it is an
environment variable and gets exported to all sub-processes make may
spawn.
Explicitly export it using EXTRA_ENV.
Reported-by: Julian Scheel <julian@jusst.de>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/Makefile.in b/package/Makefile.in
index 70529f8..803b162 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -326,7 +326,8 @@ HOST_MAKE_ENV = \
EXTRA_ENV = \
PATH=$(BR_PATH) \
BR2_DL_DIR=$(BR2_DL_DIR) \
-BUILD_DIR=$(BUILD_DIR)
+BUILD_DIR=$(BUILD_DIR) \
+BR2_EXTERNAL=$(BR2_EXTERNAL)
################################################################################
# settings we need to pass to configure
Regards,
Yann E. MORIN.
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index e554a30..92ae3fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -349,6 +349,7 @@ endif
> # Scripts in support/ or post-build scripts may need to reference
> # these locations, so export them so it is easier to use
> export BR2_CONFIG
> +export BR2_EXTERNAL
> export TARGET_DIR
> export STAGING_DIR
> export HOST_DIR
> --
> 2.2.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
2015-02-04 16:19 ` Yann E. MORIN
@ 2015-02-04 16:21 ` Yann E. MORIN
2015-02-07 15:11 ` Romain Naour
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-02-04 16:21 UTC (permalink / raw)
To: buildroot
Julian, All,
On 2015-02-04 17:19 +0100, Yann E. MORIN spake thusly:
> On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> > Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> > so export it.
>
> As discussed on IRC, there is another solution to export BR2_EXTERNAL,
> which is to add it to EXTRA_ENV, like so:
[--SNIP--]
And to complete my previous reply: I don;t really mind which way we're
doing it: your solution or mine are equaly acceptable to me.
Regards,
Yann E. MORIN.
> > Signed-off-by: Julian Scheel <julian@jusst.de>
> > ---
> > Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Makefile b/Makefile
> > index e554a30..92ae3fa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -349,6 +349,7 @@ endif
> > # Scripts in support/ or post-build scripts may need to reference
> > # these locations, so export them so it is easier to use
> > export BR2_CONFIG
> > +export BR2_EXTERNAL
> > export TARGET_DIR
> > export STAGING_DIR
> > export HOST_DIR
> > --
> > 2.2.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
2015-02-04 16:21 ` Yann E. MORIN
@ 2015-02-07 15:11 ` Romain Naour
0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2015-02-07 15:11 UTC (permalink / raw)
To: buildroot
Hi Yann, Julian, All,
Le 04/02/2015 17:21, Yann E. MORIN a ?crit :
> Julian, All,
>
> On 2015-02-04 17:19 +0100, Yann E. MORIN spake thusly:
>> On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
>>> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
>>> so export it.
>>
>> As discussed on IRC, there is another solution to export BR2_EXTERNAL,
>> which is to add it to EXTRA_ENV, like so:
> [--SNIP--]
>
> And to complete my previous reply: I don;t really mind which way we're
> doing it: your solution or mine are equaly acceptable to me.
>
> Regards,
> Yann E. MORIN.
>
>>> Signed-off-by: Julian Scheel <julian@jusst.de>
>>> ---
>>> Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index e554a30..92ae3fa 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -349,6 +349,7 @@ endif
>>> # Scripts in support/ or post-build scripts may need to reference
>>> # these locations, so export them so it is easier to use
>>> export BR2_CONFIG
>>> +export BR2_EXTERNAL
I have applied the same patch to be able to use BR2_EXTERNAL in a post-image
script. But I'm agree that adding BR2_EXTERNAL to EXTRA_ENV is enough.
Best regards,
Romain
>>> export TARGET_DIR
>>> export STAGING_DIR
>>> export HOST_DIR
>>> --
>>> 2.2.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>> --
>> .-----------------.--------------------.------------------.--------------------.
>> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
>> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
>> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
>> '------------------------------^-------^------------------^--------------------'
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts
2015-02-04 15:34 [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts Julian Scheel
2015-02-04 16:19 ` Yann E. MORIN
@ 2015-02-07 21:48 ` Yann E. MORIN
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-02-07 21:48 UTC (permalink / raw)
To: buildroot
Julian, All,
On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> so export it.
Peter has applied the alternative patch I submitted.
Thanks for the report! :-)
Regards,
Yann E. MORIN.
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index e554a30..92ae3fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -349,6 +349,7 @@ endif
> # Scripts in support/ or post-build scripts may need to reference
> # these locations, so export them so it is easier to use
> export BR2_CONFIG
> +export BR2_EXTERNAL
> export TARGET_DIR
> export STAGING_DIR
> export HOST_DIR
> --
> 2.2.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-07 21:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04 15:34 [Buildroot] [PATCH] Export BR2_EXTERNAL for post-build/support scripts Julian Scheel
2015-02-04 16:19 ` Yann E. MORIN
2015-02-04 16:21 ` Yann E. MORIN
2015-02-07 15:11 ` Romain Naour
2015-02-07 21:48 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.