All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: fix machine driver warnings
@ 2015-02-06  0:19 yang.a.fang
  2015-02-06  7:22 ` Takashi Iwai
  2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
  0 siblings, 2 replies; 15+ messages in thread
From: yang.a.fang @ 2015-02-06  0:19 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	kevin.strasser, vinod.koul, Fang, Yang A, mengdong.lin

From: "Fang, Yang A" <yang.a.fang@intel.com>

this patch will fix below sparse warnings

warning: incorrect type in argument 2 (different base types)
expected unsigned int [unsigned] val
got restricted snd_pcm_format_t [usertype] <noident>

sound/soc/intel/haswell.c:61:37
sound/soc/intel/broadwell.c:115:37:
sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
sound/soc/intel/cht_bsw_rt5672.c:183:37:
sound/soc/intel/cht_bsw_rt5645.c:208:37:

Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
---
 sound/soc/intel/broadwell.c         |    2 +-
 sound/soc/intel/bytcr_dpcm_rt5640.c |    2 +-
 sound/soc/intel/cht_bsw_rt5645.c    |    2 +-
 sound/soc/intel/cht_bsw_rt5672.c    |    2 +-
 sound/soc/intel/haswell.c           |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
index 9cf7d01..0ca4015 100644
--- a/sound/soc/intel/broadwell.c
+++ b/sound/soc/intel/broadwell.c
@@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	/* set SSP0 to 16 bit */
 	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
 				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+				    (__force int)SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/bytcr_dpcm_rt5640.c b/sound/soc/intel/bytcr_dpcm_rt5640.c
index 5930862..b171443 100644
--- a/sound/soc/intel/bytcr_dpcm_rt5640.c
+++ b/sound/soc/intel/bytcr_dpcm_rt5640.c
@@ -115,7 +115,7 @@ static int byt_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	/* set SSP2 to 24-bit */
 	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
 				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+				    (__force int)SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5645.c b/sound/soc/intel/cht_bsw_rt5645.c
index b6f8377..7781fbe 100644
--- a/sound/soc/intel/cht_bsw_rt5645.c
+++ b/sound/soc/intel/cht_bsw_rt5645.c
@@ -205,7 +205,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	/* set SSP2 to 24-bit */
 	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
 				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+				    (__force int)SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5672.c b/sound/soc/intel/cht_bsw_rt5672.c
index ff01662..b1842fa 100644
--- a/sound/soc/intel/cht_bsw_rt5672.c
+++ b/sound/soc/intel/cht_bsw_rt5672.c
@@ -180,7 +180,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	/* set SSP2 to 24-bit */
 	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
 				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+				    (__force int)SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/haswell.c b/sound/soc/intel/haswell.c
index 35edf51..b19f1ce 100644
--- a/sound/soc/intel/haswell.c
+++ b/sound/soc/intel/haswell.c
@@ -58,7 +58,7 @@ static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	/* set SSP0 to 16 bit */
 	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
 				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+				    (__force int)SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH] ASoC: Intel: fix machine driver warnings
  2015-02-06  0:19 [PATCH] ASoC: Intel: fix machine driver warnings yang.a.fang
@ 2015-02-06  7:22 ` Takashi Iwai
  2015-02-06  7:42   ` Fang, Yang A
  2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
  1 sibling, 1 reply; 15+ messages in thread
From: Takashi Iwai @ 2015-02-06  7:22 UTC (permalink / raw)
  To: yang.a.fang
  Cc: alsa-devel, harshapriya.n, praveen.k.jain, lgirdwood,
	kevin.strasser, denny.iriawan, broonie, mengdong.lin, vinod.koul

At Thu,  5 Feb 2015 16:19:16 -0800,
yang.a.fang@intel.com wrote:
> 
> From: "Fang, Yang A" <yang.a.fang@intel.com>
> 
> this patch will fix below sparse warnings
> 
> warning: incorrect type in argument 2 (different base types)
> expected unsigned int [unsigned] val
> got restricted snd_pcm_format_t [usertype] <noident>
> 
> sound/soc/intel/haswell.c:61:37
> sound/soc/intel/broadwell.c:115:37:
> sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
> sound/soc/intel/cht_bsw_rt5672.c:183:37:
> sound/soc/intel/cht_bsw_rt5645.c:208:37:
> 
> Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> ---
>  sound/soc/intel/broadwell.c         |    2 +-
>  sound/soc/intel/bytcr_dpcm_rt5640.c |    2 +-
>  sound/soc/intel/cht_bsw_rt5645.c    |    2 +-
>  sound/soc/intel/cht_bsw_rt5672.c    |    2 +-
>  sound/soc/intel/haswell.c           |    2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
> index 9cf7d01..0ca4015 100644
> --- a/sound/soc/intel/broadwell.c
> +++ b/sound/soc/intel/broadwell.c
> @@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
>  	/* set SSP0 to 16 bit */
>  	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
>  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> -				    SNDRV_PCM_FORMAT_S16_LE);
> +				    (__force int)SNDRV_PCM_FORMAT_S16_LE);
>  	return 0;
>  }

Oh, it's ugly, but unavoidable as long as we use this form.

Maybe it's better to provide a helper, e.g. params_set_format() to do
the forced cast.

Also, it would be possible to provide the whole hw constraints stuff
to make it working independently.  But I guess it's overkill for DPCM
hwparam fixups.


Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ASoC: Intel: fix machine driver warnings
  2015-02-06  7:22 ` Takashi Iwai
@ 2015-02-06  7:42   ` Fang, Yang A
  2015-02-06  7:46     ` Takashi Iwai
  0 siblings, 1 reply; 15+ messages in thread
From: Fang, Yang A @ 2015-02-06  7:42 UTC (permalink / raw)
  To: 'Takashi Iwai'
  Cc: alsa-devel, N, Harshapriya, Jain, Praveen K, lgirdwood, Strasser,
	Kevin, Iriawan, Denny, broonie, Lin, Mengdong, Koul, Vinod



> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Thursday, February 05, 2015 11:23 PM
> To: Fang, Yang A
> Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> Iriawan, Denny; N, Harshapriya; Jain, Praveen K; Strasser, Kevin; Koul, Vinod;
> Lin, Mengdong
> Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix machine driver warnings
> 
> At Thu,  5 Feb 2015 16:19:16 -0800,
> yang.a.fang@intel.com wrote:
> >
> > From: "Fang, Yang A" <yang.a.fang@intel.com>
> >
> > this patch will fix below sparse warnings
> >
> > warning: incorrect type in argument 2 (different base types) expected
> > unsigned int [unsigned] val got restricted snd_pcm_format_t [usertype]
> > <noident>
> >
> > sound/soc/intel/haswell.c:61:37
> > sound/soc/intel/broadwell.c:115:37:
> > sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
> > sound/soc/intel/cht_bsw_rt5672.c:183:37:
> > sound/soc/intel/cht_bsw_rt5645.c:208:37:
> >
> > Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> > ---
> >  sound/soc/intel/broadwell.c         |    2 +-
> >  sound/soc/intel/bytcr_dpcm_rt5640.c |    2 +-
> >  sound/soc/intel/cht_bsw_rt5645.c    |    2 +-
> >  sound/soc/intel/cht_bsw_rt5672.c    |    2 +-
> >  sound/soc/intel/haswell.c           |    2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
> > index 9cf7d01..0ca4015 100644
> > --- a/sound/soc/intel/broadwell.c
> > +++ b/sound/soc/intel/broadwell.c
> > @@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct
> snd_soc_pcm_runtime *rtd,
> >  	/* set SSP0 to 16 bit */
> >  	snd_mask_set(&params-
> >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > -				    SNDRV_PCM_FORMAT_S16_LE);
> > +				    (__force
> int)SNDRV_PCM_FORMAT_S16_LE);
> >  	return 0;
> >  }
> 
> Oh, it's ugly, but unavoidable as long as we use this form.
> 
> Maybe it's better to provide a helper, e.g. params_set_format() to do the
> forced cast.
> 
> Also, it would be possible to provide the whole hw constraints stuff to make
> it working independently.  But I guess it's overkill for DPCM hwparam fixups.
> 
> 
> Takashi

Hi Takashi,

Thanks for the feedback. Are you looking for something like this?
> >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > -				    SNDRV_PCM_FORMAT_S16_LE);
> > +				   params_set_format( SNDRV_PCM_FORMAT_S16_LE));

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ASoC: Intel: fix machine driver warnings
  2015-02-06  7:42   ` Fang, Yang A
@ 2015-02-06  7:46     ` Takashi Iwai
  2015-02-06  7:49       ` Fang, Yang A
  0 siblings, 1 reply; 15+ messages in thread
From: Takashi Iwai @ 2015-02-06  7:46 UTC (permalink / raw)
  To: Fang, Yang A
  Cc: alsa-devel, N, Harshapriya, Jain, Praveen K, lgirdwood, Strasser,
	Kevin, Iriawan, Denny, broonie, Lin, Mengdong, Koul, Vinod

At Fri, 6 Feb 2015 07:42:03 +0000,
Fang, Yang A wrote:
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Thursday, February 05, 2015 11:23 PM
> > To: Fang, Yang A
> > Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> > Iriawan, Denny; N, Harshapriya; Jain, Praveen K; Strasser, Kevin; Koul, Vinod;
> > Lin, Mengdong
> > Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix machine driver warnings
> > 
> > At Thu,  5 Feb 2015 16:19:16 -0800,
> > yang.a.fang@intel.com wrote:
> > >
> > > From: "Fang, Yang A" <yang.a.fang@intel.com>
> > >
> > > this patch will fix below sparse warnings
> > >
> > > warning: incorrect type in argument 2 (different base types) expected
> > > unsigned int [unsigned] val got restricted snd_pcm_format_t [usertype]
> > > <noident>
> > >
> > > sound/soc/intel/haswell.c:61:37
> > > sound/soc/intel/broadwell.c:115:37:
> > > sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
> > > sound/soc/intel/cht_bsw_rt5672.c:183:37:
> > > sound/soc/intel/cht_bsw_rt5645.c:208:37:
> > >
> > > Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> > > ---
> > >  sound/soc/intel/broadwell.c         |    2 +-
> > >  sound/soc/intel/bytcr_dpcm_rt5640.c |    2 +-
> > >  sound/soc/intel/cht_bsw_rt5645.c    |    2 +-
> > >  sound/soc/intel/cht_bsw_rt5672.c    |    2 +-
> > >  sound/soc/intel/haswell.c           |    2 +-
> > >  5 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
> > > index 9cf7d01..0ca4015 100644
> > > --- a/sound/soc/intel/broadwell.c
> > > +++ b/sound/soc/intel/broadwell.c
> > > @@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct
> > snd_soc_pcm_runtime *rtd,
> > >  	/* set SSP0 to 16 bit */
> > >  	snd_mask_set(&params-
> > >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > > -				    SNDRV_PCM_FORMAT_S16_LE);
> > > +				    (__force
> > int)SNDRV_PCM_FORMAT_S16_LE);
> > >  	return 0;
> > >  }
> > 
> > Oh, it's ugly, but unavoidable as long as we use this form.
> > 
> > Maybe it's better to provide a helper, e.g. params_set_format() to do the
> > forced cast.
> > 
> > Also, it would be possible to provide the whole hw constraints stuff to make
> > it working independently.  But I guess it's overkill for DPCM hwparam fixups.
> > 
> > 
> > Takashi
> 
> Hi Takashi,
> 
> Thanks for the feedback. Are you looking for something like this?
> > >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > > -				    SNDRV_PCM_FORMAT_S16_LE);
> > > +				   params_set_format( SNDRV_PCM_FORMAT_S16_LE));

No, something like below in pcm_params.h:

static inline void params_set_format(struct snd_pcm_hw_params *p,
				     snd_pcm_format_t format)
{
	snd_mask_set(p, (__force int)format);
}


Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH] ASoC: Intel: fix machine driver warnings
  2015-02-06  7:46     ` Takashi Iwai
@ 2015-02-06  7:49       ` Fang, Yang A
  0 siblings, 0 replies; 15+ messages in thread
From: Fang, Yang A @ 2015-02-06  7:49 UTC (permalink / raw)
  To: 'Takashi Iwai'
  Cc: alsa-devel, N, Harshapriya, Jain, Praveen K, lgirdwood, Strasser,
	Kevin, Iriawan, Denny, broonie, Lin, Mengdong, Koul, Vinod



> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Thursday, February 05, 2015 11:47 PM
> To: Fang, Yang A
> Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> Iriawan, Denny; N, Harshapriya; Jain, Praveen K; Strasser, Kevin; Koul, Vinod;
> Lin, Mengdong
> Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix machine driver warnings
> 
> At Fri, 6 Feb 2015 07:42:03 +0000,
> Fang, Yang A wrote:
> >
> > > -----Original Message-----
> > > From: Takashi Iwai [mailto:tiwai@suse.de]
> > > Sent: Thursday, February 05, 2015 11:23 PM
> > > To: Fang, Yang A
> > > Cc: broonie@kernel.org; lgirdwood@gmail.com;
> > > alsa-devel@alsa-project.org; Iriawan, Denny; N, Harshapriya; Jain,
> > > Praveen K; Strasser, Kevin; Koul, Vinod; Lin, Mengdong
> > > Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix machine driver
> > > warnings
> > >
> > > At Thu,  5 Feb 2015 16:19:16 -0800,
> > > yang.a.fang@intel.com wrote:
> > > >
> > > > From: "Fang, Yang A" <yang.a.fang@intel.com>
> > > >
> > > > this patch will fix below sparse warnings
> > > >
> > > > warning: incorrect type in argument 2 (different base types)
> > > > expected unsigned int [unsigned] val got restricted
> > > > snd_pcm_format_t [usertype] <noident>
> > > >
> > > > sound/soc/intel/haswell.c:61:37
> > > > sound/soc/intel/broadwell.c:115:37:
> > > > sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
> > > > sound/soc/intel/cht_bsw_rt5672.c:183:37:
> > > > sound/soc/intel/cht_bsw_rt5645.c:208:37:
> > > >
> > > > Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> > > > ---
> > > >  sound/soc/intel/broadwell.c         |    2 +-
> > > >  sound/soc/intel/bytcr_dpcm_rt5640.c |    2 +-
> > > >  sound/soc/intel/cht_bsw_rt5645.c    |    2 +-
> > > >  sound/soc/intel/cht_bsw_rt5672.c    |    2 +-
> > > >  sound/soc/intel/haswell.c           |    2 +-
> > > >  5 files changed, 5 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/sound/soc/intel/broadwell.c
> > > > b/sound/soc/intel/broadwell.c index 9cf7d01..0ca4015 100644
> > > > --- a/sound/soc/intel/broadwell.c
> > > > +++ b/sound/soc/intel/broadwell.c
> > > > @@ -112,7 +112,7 @@ static int broadwell_ssp0_fixup(struct
> > > snd_soc_pcm_runtime *rtd,
> > > >  	/* set SSP0 to 16 bit */
> > > >  	snd_mask_set(&params-
> > > >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > > >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > > > -				    SNDRV_PCM_FORMAT_S16_LE);
> > > > +				    (__force
> > > int)SNDRV_PCM_FORMAT_S16_LE);
> > > >  	return 0;
> > > >  }
> > >
> > > Oh, it's ugly, but unavoidable as long as we use this form.
> > >
> > > Maybe it's better to provide a helper, e.g. params_set_format() to
> > > do the forced cast.
> > >
> > > Also, it would be possible to provide the whole hw constraints stuff
> > > to make it working independently.  But I guess it's overkill for DPCM
> hwparam fixups.
> > >
> > >
> > > Takashi
> >
> > Hi Takashi,
> >
> > Thanks for the feedback. Are you looking for something like this?
> > > >masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > > >  				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
> > > > -				    SNDRV_PCM_FORMAT_S16_LE);
> > > > +
> params_set_format( SNDRV_PCM_FORMAT_S16_LE));
> 
> No, something like below in pcm_params.h:
> 
> static inline void params_set_format(struct snd_pcm_hw_params *p,
> 				     snd_pcm_format_t format)
> {
> 	snd_mask_set(p, (__force int)format);
> }
> 
> 
> Takashi

I see. 

Thanks
Yang

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH v2 1/2] ALSA: Add params_set_format helper
  2015-02-06  0:19 [PATCH] ASoC: Intel: fix machine driver warnings yang.a.fang
  2015-02-06  7:22 ` Takashi Iwai
@ 2015-02-09  0:01 ` yang.a.fang
  2015-02-09  0:01   ` [PATCH v2 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
                     ` (2 more replies)
  1 sibling, 3 replies; 15+ messages in thread
From: yang.a.fang @ 2015-02-09  0:01 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	kevin.strasser, vinod.koul, Fang, Yang A, tiwai, mengdong.lin

From: "Fang, Yang A" <yang.a.fang@intel.com>

Add a helper to set pcm format directly from params

Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
---
 include/sound/pcm_params.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
index 6b1c78f..e6fe584 100644
--- a/include/sound/pcm_params.h
+++ b/include/sound/pcm_params.h
@@ -366,4 +366,11 @@ params_physical_width(const struct snd_pcm_hw_params *p)
 	return snd_pcm_format_physical_width(params_format(p));
 }
 
+static inline void
+params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
+{
+	snd_mask_set(&p->masks[SNDRV_PCM_HW_PARAM_FORMAT -
+		SNDRV_PCM_HW_PARAM_FIRST_MASK], (__force int)fmt);
+}
+
 #endif /* __SOUND_PCM_PARAMS_H */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH v2 2/2] ASoC: Intel: fix machine driver warnings
  2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
@ 2015-02-09  0:01   ` yang.a.fang
  2015-02-09  6:40   ` [PATCH v2 1/2] ALSA: Add params_set_format helper Takashi Iwai
  2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
  2 siblings, 0 replies; 15+ messages in thread
From: yang.a.fang @ 2015-02-09  0:01 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	kevin.strasser, vinod.koul, Fang, Yang A, tiwai, mengdong.lin

From: "Fang, Yang A" <yang.a.fang@intel.com>

this patch will fix below sparse warnings

warning: incorrect type in argument 2 (different base types) expected
unsigned int [unsigned] val got restricted snd_pcm_format_t [usertype]
<noident>

sound/soc/intel/haswell.c:61:37
sound/soc/intel/broadwell.c:115:37:
sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
sound/soc/intel/cht_bsw_rt5672.c:183:37:
sound/soc/intel/cht_bsw_rt5645.c:208:37:

Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
---
 sound/soc/intel/broadwell.c         |    4 +---
 sound/soc/intel/bytcr_dpcm_rt5640.c |    4 +---
 sound/soc/intel/cht_bsw_rt5645.c    |    4 +---
 sound/soc/intel/cht_bsw_rt5672.c    |    4 +---
 sound/soc/intel/haswell.c           |    4 +---
 5 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
index 9cf7d01..fba2ef5 100644
--- a/sound/soc/intel/broadwell.c
+++ b/sound/soc/intel/broadwell.c
@@ -110,9 +110,7 @@ static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/bytcr_dpcm_rt5640.c b/sound/soc/intel/bytcr_dpcm_rt5640.c
index 5930862..3b262d0 100644
--- a/sound/soc/intel/bytcr_dpcm_rt5640.c
+++ b/sound/soc/intel/bytcr_dpcm_rt5640.c
@@ -113,9 +113,7 @@ static int byt_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5645.c b/sound/soc/intel/cht_bsw_rt5645.c
index b6f8377..0fc5db7 100644
--- a/sound/soc/intel/cht_bsw_rt5645.c
+++ b/sound/soc/intel/cht_bsw_rt5645.c
@@ -203,9 +203,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5672.c b/sound/soc/intel/cht_bsw_rt5672.c
index ff01662..c56f9df 100644
--- a/sound/soc/intel/cht_bsw_rt5672.c
+++ b/sound/soc/intel/cht_bsw_rt5672.c
@@ -178,9 +178,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/haswell.c b/sound/soc/intel/haswell.c
index 35edf51..00fddd3 100644
--- a/sound/soc/intel/haswell.c
+++ b/sound/soc/intel/haswell.c
@@ -56,9 +56,7 @@ static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/2] ALSA: Add params_set_format helper
  2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
  2015-02-09  0:01   ` [PATCH v2 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
@ 2015-02-09  6:40   ` Takashi Iwai
  2015-02-09  6:58     ` Fang, Yang A
  2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
  2 siblings, 1 reply; 15+ messages in thread
From: Takashi Iwai @ 2015-02-09  6:40 UTC (permalink / raw)
  To: yang.a.fang
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	lgirdwood, kevin.strasser, vinod.koul, broonie, mengdong.lin

At Sun,  8 Feb 2015 16:01:36 -0800,
yang.a.fang@intel.com wrote:
> 
> From: "Fang, Yang A" <yang.a.fang@intel.com>
> 
> Add a helper to set pcm format directly from params
> 
> Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> ---
>  include/sound/pcm_params.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> index 6b1c78f..e6fe584 100644
> --- a/include/sound/pcm_params.h
> +++ b/include/sound/pcm_params.h
> @@ -366,4 +366,11 @@ params_physical_width(const struct snd_pcm_hw_params *p)
>  	return snd_pcm_format_physical_width(params_format(p));
>  }
>  
> +static inline void
> +params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
> +{
> +	snd_mask_set(&p->masks[SNDRV_PCM_HW_PARAM_FORMAT -
> +		SNDRV_PCM_HW_PARAM_FIRST_MASK], (__force int)fmt);

Use hw_params_mask().


Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/2] ALSA: Add params_set_format helper
  2015-02-09  6:40   ` [PATCH v2 1/2] ALSA: Add params_set_format helper Takashi Iwai
@ 2015-02-09  6:58     ` Fang, Yang A
  2015-02-09  7:54       ` Takashi Iwai
  0 siblings, 1 reply; 15+ messages in thread
From: Fang, Yang A @ 2015-02-09  6:58 UTC (permalink / raw)
  To: 'Takashi Iwai'
  Cc: alsa-devel, Iriawan, Denny, N, Harshapriya, Jain, Praveen K,
	lgirdwood, Strasser, Kevin, Koul, Vinod, broonie, Lin, Mengdong



> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Sunday, February 08, 2015 10:41 PM
> To: Fang, Yang A
> Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> N, Harshapriya; Koul, Vinod; Jain, Praveen K; Iriawan, Denny; Strasser, Kevin;
> Lin, Mengdong
> Subject: Re: [PATCH v2 1/2] ALSA: Add params_set_format helper
> 
> At Sun,  8 Feb 2015 16:01:36 -0800,
> yang.a.fang@intel.com wrote:
> >
> > From: "Fang, Yang A" <yang.a.fang@intel.com>
> >
> > Add a helper to set pcm format directly from params
> >
> > Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> > ---
> >  include/sound/pcm_params.h |    7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> > index 6b1c78f..e6fe584 100644
> > --- a/include/sound/pcm_params.h
> > +++ b/include/sound/pcm_params.h
> > @@ -366,4 +366,11 @@ params_physical_width(const struct
> snd_pcm_hw_params *p)
> >  	return snd_pcm_format_physical_width(params_format(p));
> >  }
> >
> > +static inline void
> > +params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t
> fmt)
> > +{
> > +	snd_mask_set(&p->masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > +		SNDRV_PCM_HW_PARAM_FIRST_MASK], (__force int)fmt);
> 
> Use hw_params_mask().
> 
> 
> Takashi

Did not find hw_params_mask .
Do you mean change params_set_format (struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
To 
hw_params_mask(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt) ?

Thanks,
Yang

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH v2 1/2] ALSA: Add params_set_format helper
  2015-02-09  6:58     ` Fang, Yang A
@ 2015-02-09  7:54       ` Takashi Iwai
  0 siblings, 0 replies; 15+ messages in thread
From: Takashi Iwai @ 2015-02-09  7:54 UTC (permalink / raw)
  To: Fang, Yang A
  Cc: alsa-devel, Iriawan, Denny, N, Harshapriya, Jain, Praveen K,
	lgirdwood, Strasser, Kevin, Koul, Vinod, broonie, Lin, Mengdong

At Mon, 9 Feb 2015 06:58:39 +0000,
Fang, Yang A wrote:
> 
> 
> 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Sunday, February 08, 2015 10:41 PM
> > To: Fang, Yang A
> > Cc: broonie@kernel.org; lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> > N, Harshapriya; Koul, Vinod; Jain, Praveen K; Iriawan, Denny; Strasser, Kevin;
> > Lin, Mengdong
> > Subject: Re: [PATCH v2 1/2] ALSA: Add params_set_format helper
> > 
> > At Sun,  8 Feb 2015 16:01:36 -0800,
> > yang.a.fang@intel.com wrote:
> > >
> > > From: "Fang, Yang A" <yang.a.fang@intel.com>
> > >
> > > Add a helper to set pcm format directly from params
> > >
> > > Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
> > > ---
> > >  include/sound/pcm_params.h |    7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> > > index 6b1c78f..e6fe584 100644
> > > --- a/include/sound/pcm_params.h
> > > +++ b/include/sound/pcm_params.h
> > > @@ -366,4 +366,11 @@ params_physical_width(const struct
> > snd_pcm_hw_params *p)
> > >  	return snd_pcm_format_physical_width(params_format(p));
> > >  }
> > >
> > > +static inline void
> > > +params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t
> > fmt)
> > > +{
> > > +	snd_mask_set(&p->masks[SNDRV_PCM_HW_PARAM_FORMAT -
> > > +		SNDRV_PCM_HW_PARAM_FIRST_MASK], (__force int)fmt);
> > 
> > Use hw_params_mask().
> > 
> > 
> > Takashi
> 
> Did not find hw_params_mask .
> Do you mean change params_set_format (struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
> To 
> hw_params_mask(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt) ?

No, just like

static inline void params_set_format(struct snd_pcm_hw_params *p,
				     snd_pcm_format_t fmt)
{
	snd_mask_set(hw_param_mask(p, SNDRV_PCM_HW_PARAM_FORMAT),
		     (__force int)fmt);
}


Takashi

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH v3 1/2] ALSA: Add params_set_format helper
  2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
  2015-02-09  0:01   ` [PATCH v2 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
  2015-02-09  6:40   ` [PATCH v2 1/2] ALSA: Add params_set_format helper Takashi Iwai
@ 2015-02-09  8:18   ` yang.a.fang
  2015-02-09  8:18     ` [PATCH v3 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
                       ` (2 more replies)
  2 siblings, 3 replies; 15+ messages in thread
From: yang.a.fang @ 2015-02-09  8:18 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	kevin.strasser, vinod.koul, Fang, Yang A, tiwai, mengdong.lin

From: "Fang, Yang A" <yang.a.fang@intel.com>

Add a helper to set pcm format directly from params

Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
---
 include/sound/pcm_params.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
index 6b1c78f..f41a2d7 100644
--- a/include/sound/pcm_params.h
+++ b/include/sound/pcm_params.h
@@ -366,4 +366,11 @@ params_physical_width(const struct snd_pcm_hw_params *p)
 	return snd_pcm_format_physical_width(params_format(p));
 }
 
+static inline void
+params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
+{
+	snd_mask_set(hw_param_mask(p, SNDRV_PCM_HW_PARAM_FORMAT),
+		(__force int)fmt);
+}
+
 #endif /* __SOUND_PCM_PARAMS_H */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [PATCH v3 2/2] ASoC: Intel: fix machine driver warnings
  2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
@ 2015-02-09  8:18     ` yang.a.fang
  2015-02-09 10:50     ` [PATCH v3 1/2] ALSA: Add params_set_format helper Takashi Iwai
  2015-02-23 14:20     ` Mark Brown
  2 siblings, 0 replies; 15+ messages in thread
From: yang.a.fang @ 2015-02-09  8:18 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	kevin.strasser, vinod.koul, Fang, Yang A, tiwai, mengdong.lin

From: "Fang, Yang A" <yang.a.fang@intel.com>

this patch will fix below sparse warnings

warning: incorrect type in argument 2 (different base types) expected
unsigned int [unsigned] val got restricted snd_pcm_format_t [usertype]
<noident>

sound/soc/intel/haswell.c:61:37
sound/soc/intel/broadwell.c:115:37:
sound/soc/intel/bytcr_dpcm_rt5640.c:118:37:
sound/soc/intel/cht_bsw_rt5672.c:183:37:
sound/soc/intel/cht_bsw_rt5645.c:208:37:

Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>
---
 sound/soc/intel/broadwell.c         |    4 +---
 sound/soc/intel/bytcr_dpcm_rt5640.c |    4 +---
 sound/soc/intel/cht_bsw_rt5645.c    |    4 +---
 sound/soc/intel/cht_bsw_rt5672.c    |    4 +---
 sound/soc/intel/haswell.c           |    4 +---
 5 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/sound/soc/intel/broadwell.c b/sound/soc/intel/broadwell.c
index 9cf7d01..fba2ef5 100644
--- a/sound/soc/intel/broadwell.c
+++ b/sound/soc/intel/broadwell.c
@@ -110,9 +110,7 @@ static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/bytcr_dpcm_rt5640.c b/sound/soc/intel/bytcr_dpcm_rt5640.c
index 5930862..3b262d0 100644
--- a/sound/soc/intel/bytcr_dpcm_rt5640.c
+++ b/sound/soc/intel/bytcr_dpcm_rt5640.c
@@ -113,9 +113,7 @@ static int byt_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5645.c b/sound/soc/intel/cht_bsw_rt5645.c
index b6f8377..0fc5db7 100644
--- a/sound/soc/intel/cht_bsw_rt5645.c
+++ b/sound/soc/intel/cht_bsw_rt5645.c
@@ -203,9 +203,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/cht_bsw_rt5672.c b/sound/soc/intel/cht_bsw_rt5672.c
index ff01662..c56f9df 100644
--- a/sound/soc/intel/cht_bsw_rt5672.c
+++ b/sound/soc/intel/cht_bsw_rt5672.c
@@ -178,9 +178,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP2 to 24-bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S24_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
 	return 0;
 }
 
diff --git a/sound/soc/intel/haswell.c b/sound/soc/intel/haswell.c
index 35edf51..00fddd3 100644
--- a/sound/soc/intel/haswell.c
+++ b/sound/soc/intel/haswell.c
@@ -56,9 +56,7 @@ static int haswell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd,
 	channels->min = channels->max = 2;
 
 	/* set SSP0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_HW_PARAM_FIRST_MASK],
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;
 }
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] ALSA: Add params_set_format helper
  2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
  2015-02-09  8:18     ` [PATCH v3 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
@ 2015-02-09 10:50     ` Takashi Iwai
  2015-02-10  8:11       ` Mark Brown
  2015-02-23 14:20     ` Mark Brown
  2 siblings, 1 reply; 15+ messages in thread
From: Takashi Iwai @ 2015-02-09 10:50 UTC (permalink / raw)
  To: yang.a.fang
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	lgirdwood, kevin.strasser, vinod.koul, broonie, mengdong.lin

At Mon,  9 Feb 2015 00:18:11 -0800,
yang.a.fang@intel.com wrote:
> 
> From: "Fang, Yang A" <yang.a.fang@intel.com>
> 
> Add a helper to set pcm format directly from params
> 
> Signed-off-by: Fang, Yang A <yang.a.fang@intel.com>

Mark, feel free to take my ack when you apply these patches.
  Reviewed-by: Takashi Iwai <tiwai@suse.de>

thanks,

Takashi

> ---
>  include/sound/pcm_params.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/sound/pcm_params.h b/include/sound/pcm_params.h
> index 6b1c78f..f41a2d7 100644
> --- a/include/sound/pcm_params.h
> +++ b/include/sound/pcm_params.h
> @@ -366,4 +366,11 @@ params_physical_width(const struct snd_pcm_hw_params *p)
>  	return snd_pcm_format_physical_width(params_format(p));
>  }
>  
> +static inline void
> +params_set_format(struct snd_pcm_hw_params *p, snd_pcm_format_t fmt)
> +{
> +	snd_mask_set(hw_param_mask(p, SNDRV_PCM_HW_PARAM_FORMAT),
> +		(__force int)fmt);
> +}
> +
>  #endif /* __SOUND_PCM_PARAMS_H */
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] ALSA: Add params_set_format helper
  2015-02-09 10:50     ` [PATCH v3 1/2] ALSA: Add params_set_format helper Takashi Iwai
@ 2015-02-10  8:11       ` Mark Brown
  0 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2015-02-10  8:11 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: alsa-devel, denny.iriawan, yang.a.fang, praveen.k.jain,
	lgirdwood, kevin.strasser, harshapriya.n, mengdong.lin,
	vinod.koul


[-- Attachment #1.1: Type: text/plain, Size: 214 bytes --]

On Mon, Feb 09, 2015 at 11:50:27AM +0100, Takashi Iwai wrote:

> Mark, feel free to take my ack when you apply these patches.
>   Reviewed-by: Takashi Iwai <tiwai@suse.de>

OK, it'll be after the merge window now.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] ALSA: Add params_set_format helper
  2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
  2015-02-09  8:18     ` [PATCH v3 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
  2015-02-09 10:50     ` [PATCH v3 1/2] ALSA: Add params_set_format helper Takashi Iwai
@ 2015-02-23 14:20     ` Mark Brown
  2 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2015-02-23 14:20 UTC (permalink / raw)
  To: yang.a.fang
  Cc: alsa-devel, denny.iriawan, harshapriya.n, praveen.k.jain,
	lgirdwood, kevin.strasser, vinod.koul, tiwai, mengdong.lin


[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

On Mon, Feb 09, 2015 at 12:18:11AM -0800, yang.a.fang@intel.com wrote:
> From: "Fang, Yang A" <yang.a.fang@intel.com>
> 
> Add a helper to set pcm format directly from params

Applied both, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-02-23 14:21 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06  0:19 [PATCH] ASoC: Intel: fix machine driver warnings yang.a.fang
2015-02-06  7:22 ` Takashi Iwai
2015-02-06  7:42   ` Fang, Yang A
2015-02-06  7:46     ` Takashi Iwai
2015-02-06  7:49       ` Fang, Yang A
2015-02-09  0:01 ` [PATCH v2 1/2] ALSA: Add params_set_format helper yang.a.fang
2015-02-09  0:01   ` [PATCH v2 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
2015-02-09  6:40   ` [PATCH v2 1/2] ALSA: Add params_set_format helper Takashi Iwai
2015-02-09  6:58     ` Fang, Yang A
2015-02-09  7:54       ` Takashi Iwai
2015-02-09  8:18   ` [PATCH v3 " yang.a.fang
2015-02-09  8:18     ` [PATCH v3 2/2] ASoC: Intel: fix machine driver warnings yang.a.fang
2015-02-09 10:50     ` [PATCH v3 1/2] ALSA: Add params_set_format helper Takashi Iwai
2015-02-10  8:11       ` Mark Brown
2015-02-23 14:20     ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.