m25p80 spi1.0: unrecognized JEDEC id

m25p80 spi1.0: unrecognized JEDEC id

[Fabio Estevam]

Hi,

Running linux-next 20150209 on a mx28evk I see that m25p80 is not
detected correctly:

m25p80 spi1.0: unrecognized JEDEC id bytes: bf, 24, 40

On 3.19 it probes fine though:

m25p80 spi1.0: sst25vf016b (2048 Kbytes)

I can start bisecting it, but just wondering if someone is aware of
this issue or has any ideas.

Thanks,

Fabio Estevam

Re: m25p80 spi1.0: unrecognized JEDEC id

[Brian Norris]

On Mon, Feb 09, 2015 at 08:09:02PM -0200, Fabio Estevam wrote:
> Hi,
> 
> Running linux-next 20150209 on a mx28evk I see that m25p80 is not
> detected correctly:
> 
> m25p80 spi1.0: unrecognized JEDEC id bytes: bf, 24, 40

That's not good. I don't see anything in MTD's -next that should cause
that though.

> On 3.19 it probes fine though:
> 
> m25p80 spi1.0: sst25vf016b (2048 Kbytes)
> 
> I can start bisecting it, but just wondering if someone is aware of
> this issue or has any ideas.

I'm not aware of this. Please keep me updated if you find anything.

Brian

Re: m25p80 spi1.0: unrecognized JEDEC id

[Fabio Estevam]

On Mon, Feb 9, 2015 at 8:18 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> On Mon, Feb 09, 2015 at 08:09:02PM -0200, Fabio Estevam wrote:
>> Hi,
>>
>> Running linux-next 20150209 on a mx28evk I see that m25p80 is not
>> detected correctly:
>>
>> m25p80 spi1.0: unrecognized JEDEC id bytes: bf, 24, 40
>
> That's not good. I don't see anything in MTD's -next that should cause
> that though.

Yes, I have just tested other platform (mx6) with linux-next and
m25p80 can be probed.

Looks like the issue is mxs specific and comes from other area (spi
driver, dma, clocks, etc).

Regards,

Fabio Estevam

Re: m25p80 spi1.0: unrecognized JEDEC id

[Marek Vasut]

On Tuesday, February 10, 2015 at 12:39:22 AM, Fabio Estevam wrote:
> On Mon, Feb 9, 2015 at 8:18 PM, Brian Norris
> 
> <computersforpeace@gmail.com> wrote:
> > On Mon, Feb 09, 2015 at 08:09:02PM -0200, Fabio Estevam wrote:
> >> Hi,
> >> 
> >> Running linux-next 20150209 on a mx28evk I see that m25p80 is not
> >> detected correctly:
> >> 
> >> m25p80 spi1.0: unrecognized JEDEC id bytes: bf, 24, 40
> > 
> > That's not good. I don't see anything in MTD's -next that should cause
> > that though.
> 
> Yes, I have just tested other platform (mx6) with linux-next and
> m25p80 can be probed.
> 
> Looks like the issue is mxs specific and comes from other area (spi
> driver, dma, clocks, etc).

Was the clock patch mucking with FRAC0 and FRAC1 merged by any chance?

Best regards,
Marek Vasut

Re: m25p80 spi1.0: unrecognized JEDEC id

[Fabio Estevam]

Hi Marek,

On Tue, Feb 10, 2015 at 8:55 AM, Marek Vasut <marex@denx.de> wrote:
> On Tuesday, February 10, 2015 at 12:39:22 AM, Fabio Estevam wrote:

> Was the clock patch mucking with FRAC0 and FRAC1 merged by any chance?

Thanks for your suggestion! You are right: If I revert Stefan's patch:

commit 039e5970750775f102b255de9bf914e04955c6da ("clk: mxs: Fix
invalid 32-bit access to frac registers")

then the SPI NOR flash is probed correctly on mx28evk.

Stefan,

Could you please take a look?

Thanks,

Fabio Estevam