* [PATCH] rtl2832: remove compiler warning
@ 2015-02-08 22:44 Luis de Bethencourt
2015-02-08 22:46 ` Luis de Bethencourt
2015-02-10 10:57 ` Antti Palosaari
0 siblings, 2 replies; 6+ messages in thread
From: Luis de Bethencourt @ 2015-02-08 22:44 UTC (permalink / raw)
To: linux-media; +Cc: crope, mchehab, linux-kernel
Cleaning the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
tmp, this line would never run because we go to err. It is still nice to avoid
compiler warnings.
Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
---
drivers/media/dvb-frontends/rtl2832.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index 5d2d8f4..ad36d1c 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
struct rtl2832_dev *dev = fe->demodulator_priv;
struct i2c_client *client = dev->client;
int ret;
- u32 tmp;
+ u32 tmp = 0;
dev_dbg(&client->dev, "\n");
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl2832: remove compiler warning
2015-02-08 22:44 [PATCH] rtl2832: remove compiler warning Luis de Bethencourt
@ 2015-02-08 22:46 ` Luis de Bethencourt
2015-02-10 10:57 ` Antti Palosaari
1 sibling, 0 replies; 6+ messages in thread
From: Luis de Bethencourt @ 2015-02-08 22:46 UTC (permalink / raw)
To: linux-media; +Cc: crope, mchehab, linux-kernel
On Sun, Feb 08, 2015 at 10:44:22PM +0000, Luis de Bethencourt wrote:
> Cleaning the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..ad36d1c 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 tmp = 0;
>
> dev_dbg(&client->dev, "\n");
>
> --
> 2.1.0
>
Hello all :)
This warning can be seen in:
http://hverkuil.home.xs4all.nl/logs/Saturday.log
Thank you Hans for the daily build and logs.
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl2832: remove compiler warning
2015-02-08 22:44 [PATCH] rtl2832: remove compiler warning Luis de Bethencourt
2015-02-08 22:46 ` Luis de Bethencourt
@ 2015-02-10 10:57 ` Antti Palosaari
2015-02-10 14:05 ` Luis de Bethencourt
2015-02-10 23:35 ` Mauro Carvalho Chehab
1 sibling, 2 replies; 6+ messages in thread
From: Antti Palosaari @ 2015-02-10 10:57 UTC (permalink / raw)
To: Luis de Bethencourt, linux-media; +Cc: mchehab, linux-kernel
On 02/09/2015 12:44 AM, Luis de Bethencourt wrote:
> Cleaning the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..ad36d1c 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 tmp = 0;
>
> dev_dbg(&client->dev, "\n");
I looked the code and I cannot see how it could used as uninitialized.
Dunno how it could be fixed properly.
Also, I think idiom to say compiler that variable could be uninitialized
is to store its own value. But I am fine with zero initialization too.
u32 tmp = tmp;
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl2832: remove compiler warning
2015-02-10 10:57 ` Antti Palosaari
@ 2015-02-10 14:05 ` Luis de Bethencourt
2015-02-10 23:35 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 6+ messages in thread
From: Luis de Bethencourt @ 2015-02-10 14:05 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, mchehab, linux-kernel
On Tue, Feb 10, 2015 at 12:57:24PM +0200, Antti Palosaari wrote:
> On 02/09/2015 12:44 AM, Luis de Bethencourt wrote:
> >Cleaning the following compiler warning:
> >rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
> >
> >Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> >tmp, this line would never run because we go to err. It is still nice to avoid
> >compiler warnings.
> >
> >Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> >---
> > drivers/media/dvb-frontends/rtl2832.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> >index 5d2d8f4..ad36d1c 100644
> >--- a/drivers/media/dvb-frontends/rtl2832.c
> >+++ b/drivers/media/dvb-frontends/rtl2832.c
> >@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> > struct rtl2832_dev *dev = fe->demodulator_priv;
> > struct i2c_client *client = dev->client;
> > int ret;
> >- u32 tmp;
> >+ u32 tmp = 0;
> >
> > dev_dbg(&client->dev, "\n");
>
> I looked the code and I cannot see how it could used as uninitialized. Dunno
> how it could be fixed properly.
Hi Antti,
I agree. If rtl2832_rd_demod_reg() in line 696 doesn't set tmp it is because
it has errored out. Which means rtl2832_read_status() itself will goto err
before the check for 'if (tmp == 11)' line that generates the warning.
I mentioned this in my commit message :)
>
> Also, I think idiom to say compiler that variable could be uninitialized is
> to store its own value. But I am fine with zero initialization too.
>
> u32 tmp = tmp;
>
> regards
> Antti
>
> --
> http://palosaari.fi/
If you prefer I use the 'u32 tmp = tmp;' I am happy to change my patch.
You say you are fine with zero initialization too, but I prefer offering
whatever you think is best.
Thanks for taking the time to look at this,
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl2832: remove compiler warning
2015-02-10 10:57 ` Antti Palosaari
2015-02-10 14:05 ` Luis de Bethencourt
@ 2015-02-10 23:35 ` Mauro Carvalho Chehab
2015-02-11 11:13 ` Luis de Bethencourt
1 sibling, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2015-02-10 23:35 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Luis de Bethencourt, linux-media, linux-kernel
Em Tue, 10 Feb 2015 12:57:24 +0200
Antti Palosaari <crope@iki.fi> escreveu:
> On 02/09/2015 12:44 AM, Luis de Bethencourt wrote:
> > Cleaning the following compiler warning:
> > rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
> >
> > Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> > tmp, this line would never run because we go to err. It is still nice to avoid
> > compiler warnings.
> >
> > Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> > ---
> > drivers/media/dvb-frontends/rtl2832.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> > index 5d2d8f4..ad36d1c 100644
> > --- a/drivers/media/dvb-frontends/rtl2832.c
> > +++ b/drivers/media/dvb-frontends/rtl2832.c
> > @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> > struct rtl2832_dev *dev = fe->demodulator_priv;
> > struct i2c_client *client = dev->client;
> > int ret;
> > - u32 tmp;
> > + u32 tmp = 0;
> >
> > dev_dbg(&client->dev, "\n");
>
> I looked the code and I cannot see how it could used as uninitialized.
> Dunno how it could be fixed properly.
>
> Also, I think idiom to say compiler that variable could be uninitialized
> is to store its own value. But I am fine with zero initialization too.
>
> u32 tmp = tmp;
Actually, the right way is to declare it as:
u32 uninitialized_var(tmp)
The syntax to suppress compiler warnings depends on the compiler:
include/linux/compiler-clang.h:#define uninitialized_var(x) x = *(&(x))
include/linux/compiler-gcc.h:#define uninitialized_var(x) x = x
Also, using uninitialized_var() better documents it.
Regards,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtl2832: remove compiler warning
2015-02-10 23:35 ` Mauro Carvalho Chehab
@ 2015-02-11 11:13 ` Luis de Bethencourt
0 siblings, 0 replies; 6+ messages in thread
From: Luis de Bethencourt @ 2015-02-11 11:13 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Antti Palosaari, linux-media, linux-kernel
On Tue, Feb 10, 2015 at 09:35:52PM -0200, Mauro Carvalho Chehab wrote:
> Em Tue, 10 Feb 2015 12:57:24 +0200
> Antti Palosaari <crope@iki.fi> escreveu:
>
> > On 02/09/2015 12:44 AM, Luis de Bethencourt wrote:
> > > Cleaning the following compiler warning:
> > > rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
> > >
> > > Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> > > tmp, this line would never run because we go to err. It is still nice to avoid
> > > compiler warnings.
> > >
> > > Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> > > ---
> > > drivers/media/dvb-frontends/rtl2832.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> > > index 5d2d8f4..ad36d1c 100644
> > > --- a/drivers/media/dvb-frontends/rtl2832.c
> > > +++ b/drivers/media/dvb-frontends/rtl2832.c
> > > @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> > > struct rtl2832_dev *dev = fe->demodulator_priv;
> > > struct i2c_client *client = dev->client;
> > > int ret;
> > > - u32 tmp;
> > > + u32 tmp = 0;
> > >
> > > dev_dbg(&client->dev, "\n");
> >
> > I looked the code and I cannot see how it could used as uninitialized.
> > Dunno how it could be fixed properly.
> >
> > Also, I think idiom to say compiler that variable could be uninitialized
> > is to store its own value. But I am fine with zero initialization too.
> >
> > u32 tmp = tmp;
>
> Actually, the right way is to declare it as:
>
> u32 uninitialized_var(tmp)
>
> The syntax to suppress compiler warnings depends on the compiler:
>
> include/linux/compiler-clang.h:#define uninitialized_var(x) x = *(&(x))
> include/linux/compiler-gcc.h:#define uninitialized_var(x) x = x
>
> Also, using uninitialized_var() better documents it.
>
> Regards,
> Mauro
Hi Mauro,
That is a way more elegant solution. Great!
I will check out that compiler-clang header file, it's interesting.
I just sent a revised patch using this :)
Thanks,
Luis
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-11 11:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-08 22:44 [PATCH] rtl2832: remove compiler warning Luis de Bethencourt
2015-02-08 22:46 ` Luis de Bethencourt
2015-02-10 10:57 ` Antti Palosaari
2015-02-10 14:05 ` Luis de Bethencourt
2015-02-10 23:35 ` Mauro Carvalho Chehab
2015-02-11 11:13 ` Luis de Bethencourt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.