All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: rui.zhang@intel.com, edubezval@gmail.com, kgene@kernel.org,
	b.zolnierkie@samsung.com, kyungmin.park@samsung.com,
	amit.daniel@samsung.com, a.kesavan@samsung.com,
	inki.dae@samsung.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table
Date: Mon, 16 Feb 2015 16:07:54 +0100	[thread overview]
Message-ID: <20150216160754.18ee3ebb@amdc2363> (raw)
In-Reply-To: <1424096414-4327-4-git-send-email-cw00.choi@samsung.com>

Hi Chanwoo,

> This patch cleanup the code to use oneline for entry of exynos
> compatible table.
> 
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 38
> ++++++++++-------------------------- 1 file changed, 10
> insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c
> b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void
> *id) }
>  
>  static const struct of_device_id exynos_tmu_match[] = {
> -	{
> -		.compatible = "samsung,exynos3250-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos4210-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos4412-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5250-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5260-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5420-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5420-tmu-ext-triminfo",
> -	},
> -	{
> -		.compatible = "samsung,exynos5440-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos7-tmu",
> -	},
> -	{},
> +	{ .compatible = "samsung,exynos3250-tmu", },
> +	{ .compatible = "samsung,exynos4210-tmu", },
> +	{ .compatible = "samsung,exynos4412-tmu", },
> +	{ .compatible = "samsung,exynos5250-tmu", },
> +	{ .compatible = "samsung,exynos5260-tmu", },
> +	{ .compatible = "samsung,exynos5420-tmu", },
> +	{ .compatible = "samsung,exynos5420-tmu-ext-triminfo", },
> +	{ .compatible = "samsung,exynos5440-tmu", },
> +	{ .compatible = "samsung,exynos7-tmu", },
> +	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, exynos_tmu_match);
>  

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

Thanks for clean up!

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

WARNING: multiple messages have this Message-ID (diff)
From: l.majewski@samsung.com (Lukasz Majewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table
Date: Mon, 16 Feb 2015 16:07:54 +0100	[thread overview]
Message-ID: <20150216160754.18ee3ebb@amdc2363> (raw)
In-Reply-To: <1424096414-4327-4-git-send-email-cw00.choi@samsung.com>

Hi Chanwoo,

> This patch cleanup the code to use oneline for entry of exynos
> compatible table.
> 
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 38
> ++++++++++-------------------------- 1 file changed, 10
> insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c
> b/drivers/thermal/samsung/exynos_tmu.c index b199fff..7e6baf5 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -919,34 +919,16 @@ static irqreturn_t exynos_tmu_irq(int irq, void
> *id) }
>  
>  static const struct of_device_id exynos_tmu_match[] = {
> -	{
> -		.compatible = "samsung,exynos3250-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos4210-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos4412-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5250-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5260-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5420-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos5420-tmu-ext-triminfo",
> -	},
> -	{
> -		.compatible = "samsung,exynos5440-tmu",
> -	},
> -	{
> -		.compatible = "samsung,exynos7-tmu",
> -	},
> -	{},
> +	{ .compatible = "samsung,exynos3250-tmu", },
> +	{ .compatible = "samsung,exynos4210-tmu", },
> +	{ .compatible = "samsung,exynos4412-tmu", },
> +	{ .compatible = "samsung,exynos5250-tmu", },
> +	{ .compatible = "samsung,exynos5260-tmu", },
> +	{ .compatible = "samsung,exynos5420-tmu", },
> +	{ .compatible = "samsung,exynos5420-tmu-ext-triminfo", },
> +	{ .compatible = "samsung,exynos5440-tmu", },
> +	{ .compatible = "samsung,exynos7-tmu", },
> +	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, exynos_tmu_match);
>  

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

Thanks for clean up!

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2015-02-16 15:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 14:20 [PATCH 0/3] thermal: exynos: Fix NULL pointer error and bug of PD_DET_EN of Exynos7 Chanwoo Choi
2015-02-16 14:20 ` Chanwoo Choi
2015-02-16 14:20 ` [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting Chanwoo Choi
2015-02-16 14:20   ` Chanwoo Choi
2015-02-16 15:06   ` Lukasz Majewski
2015-02-16 15:06     ` Lukasz Majewski
2015-02-16 16:15     ` Chanwoo Choi
2015-02-16 16:15       ` Chanwoo Choi
2015-02-16 16:28       ` Lukasz Majewski
2015-02-16 16:28         ` Lukasz Majewski
2015-02-16 17:00         ` Chanwoo Choi
2015-02-16 17:00           ` Chanwoo Choi
2015-02-16 14:20 ` [PATCH 2/3] thermal: exynos: Fix wrong control of power down detection mode for Exynos7 Chanwoo Choi
2015-02-16 14:20   ` Chanwoo Choi
2015-02-16 14:20 ` [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table Chanwoo Choi
2015-02-16 14:20   ` Chanwoo Choi
2015-02-16 15:07   ` Lukasz Majewski [this message]
2015-02-16 15:07     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216160754.18ee3ebb@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=a.kesavan@samsung.com \
    --cc=amit.daniel@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=edubezval@gmail.com \
    --cc=inki.dae@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.