[PATCH RT] sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq()

[PATCH RT] sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq()

[Steven Rostedt]

I talked with Peter Zijlstra about this, and he told me that the clearing
of the PF_NO_SETAFFINITY flag was to deal with the optimization of
migrate_disable/enable() that ignores tasks that have that flag set. But
that optimization was removed when I did a rework of the cpu hotplug code.

I found that ignoring tasks that had that flag set would cause those tasks
to not sync with the hotplug code and cause the kernel to crash. Thus it
needed to not treat them special and those tasks had to go though the same
work as tasks without that flag set.

Now that those tasks are not treated special, there's no reason to clear the
flag.

May still need to be tested as the migrate_me() code does not ignore those
flags.

Cc: stable-rt@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index ce80b93..352239e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1393,12 +1393,6 @@ out:
 		}
 	}
 
-	/*
-	 * Clear PF_NO_SETAFFINITY, otherwise we wreckage
-	 * migrate_disable/enable. See optimization for
-	 * PF_NO_SETAFFINITY tasks there.
-	 */
-	p->flags &= ~PF_NO_SETAFFINITY;
 	return dest_cpu;
 }
 

Re: [PATCH RT] sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq()

[Sebastian Andrzej Siewior]

* Steven Rostedt | 2014-07-01 11:14:44 [-0400]:

>I talked with Peter Zijlstra about this, and he told me that the clearing
>of the PF_NO_SETAFFINITY flag was to deal with the optimization of
>migrate_disable/enable() that ignores tasks that have that flag set. But
>that optimization was removed when I did a rework of the cpu hotplug code.

This has been already applied. You took it into v3.14 and while applying
the latest v3.14 patches it made its way into v3.18 as well.

Sebastian