All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Kees Cook <keescook@chromium.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	live-patching@vger.kernel.org, Linux-MM <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2] x86, kaslr: propagate base load address calculation
Date: Tue, 17 Feb 2015 13:39:33 +0100	[thread overview]
Message-ID: <20150217123933.GC26165@pd.tnic> (raw)
In-Reply-To: <alpine.LNX.2.00.1502171319040.2279@pobox.suse.cz>

On Tue, Feb 17, 2015 at 01:21:20PM +0100, Jiri Kosina wrote:
> I don't have strong feelings either way. It seems slightly nicer
> to have a predictable oops output format no matter the CONFIG_
> options and command-line contents, but if you feel like seeing the
> 'Kernel offset: 0' in 'nokaslr' and !CONFIG_RANDOMIZE_BASE cases is
> unnecessary noise, feel free to make this change to my patch.

Well, wouldn't it be wrong to print this line if kaslr is disabled?
Because of the ambiguity in that case: that line could mean either we
randomized to 0 or kaslr is disabled but you can't know that from the
"0" in there, right?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Kees Cook <keescook@chromium.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	live-patching@vger.kernel.org, Linux-MM <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2] x86, kaslr: propagate base load address calculation
Date: Tue, 17 Feb 2015 13:39:33 +0100	[thread overview]
Message-ID: <20150217123933.GC26165@pd.tnic> (raw)
In-Reply-To: <alpine.LNX.2.00.1502171319040.2279@pobox.suse.cz>

On Tue, Feb 17, 2015 at 01:21:20PM +0100, Jiri Kosina wrote:
> I don't have strong feelings either way. It seems slightly nicer
> to have a predictable oops output format no matter the CONFIG_
> options and command-line contents, but if you feel like seeing the
> 'Kernel offset: 0' in 'nokaslr' and !CONFIG_RANDOMIZE_BASE cases is
> unnecessary noise, feel free to make this change to my patch.

Well, wouldn't it be wrong to print this line if kaslr is disabled?
Because of the ambiguity in that case: that line could mean either we
randomized to 0 or kaslr is disabled but you can't know that from the
"0" in there, right?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-02-17 12:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 13:17 [PATCH] x86, kaslr: propagate base load address calculation Jiri Kosina
2015-02-10 13:17 ` Jiri Kosina
2015-02-10 17:25 ` Kees Cook
2015-02-10 17:25   ` Kees Cook
2015-02-10 23:07   ` Jiri Kosina
2015-02-10 23:07     ` Jiri Kosina
2015-02-10 23:13     ` Jiri Kosina
2015-02-10 23:13       ` Jiri Kosina
2015-02-13 15:04       ` [PATCH v2] " Jiri Kosina
2015-02-13 15:04         ` Jiri Kosina
2015-02-13 17:49         ` Kees Cook
2015-02-13 17:49           ` Kees Cook
2015-02-13 22:20           ` Jiri Kosina
2015-02-13 22:20             ` Jiri Kosina
2015-02-13 23:25             ` Kees Cook
2015-02-13 23:25               ` Kees Cook
2015-02-16 11:55               ` Borislav Petkov
2015-02-16 11:55                 ` Borislav Petkov
2015-02-16 19:27                 ` Kees Cook
2015-02-16 19:27                   ` Kees Cook
2015-02-16 19:42                   ` Borislav Petkov
2015-02-16 19:42                     ` Borislav Petkov
2015-02-17 10:44         ` Borislav Petkov
2015-02-17 10:44           ` Borislav Petkov
2015-02-17 12:21           ` Jiri Kosina
2015-02-17 12:21             ` Jiri Kosina
2015-02-17 12:39             ` Borislav Petkov [this message]
2015-02-17 12:39               ` Borislav Petkov
2015-02-17 16:45               ` Kees Cook
2015-02-17 16:45                 ` Kees Cook
2015-02-17 22:31                 ` Borislav Petkov
2015-02-17 22:31                   ` Borislav Petkov
2015-02-18  3:33                   ` Kees Cook
2015-02-18  3:33                     ` Kees Cook
2015-02-18  8:32                     ` Borislav Petkov
2015-02-18  8:32                       ` Borislav Petkov
2015-02-18 10:46                       ` Jiri Kosina
2015-02-18 10:46                         ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150217123933.GC26165@pd.tnic \
    --to=bp@alien8.de \
    --cc=hpa@linux.intel.com \
    --cc=jkosina@suse.cz \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=live-patching@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.