[PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support

[PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20150215-v3.19' tag. Here we add the eMMC device tree support
for the R8A7794-based SILK board. It depends on the other R8A7794/SILK patches
posted last week in order to apply, and on the R8A7794 MMCIF PFC driver patch
in order for the pins to be configured.

[1/2] ARM: shmobile: r8a7794: add MMCIF DT support
[2/2] ARM: shmobile: silk: add eMMC DT support

WBR, Sergei

[PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20150215-v3.19' tag. Here we add the eMMC device tree support
for the R8A7794-based SILK board. It depends on the other R8A7794/SILK patches
posted last week in order to apply, and on the R8A7794 MMCIF PFC driver patch
in order for the pins to be configured.

[1/2] ARM: shmobile: r8a7794: add MMCIF DT support
[2/2] ARM: shmobile: silk: add eMMC DT support

WBR, Sergei

[PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20150215-v3.19' tag. Here we add the eMMC device tree support
for the R8A7794-based SILK board. It depends on the other R8A7794/SILK patches
posted last week in order to apply, and on the R8A7794 MMCIF PFC driver patch
in order for the pins to be configured.

[1/2] ARM: shmobile: r8a7794: add MMCIF DT support
[2/2] ARM: shmobile: silk: add eMMC DT support

WBR, Sergei

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Define the generic R8A7794 part of the MMCIF0 device node.

Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
=================================--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
@@ -346,6 +346,17 @@
 		status = "disabled";
 	};
 
+	mmcif0: mmc@ee200000 {
+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
+		dma-names = "tx", "rx";
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	clocks {
 		#address-cells = <2>;
 		#size-cells = <2>;

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Define the generic R8A7794 part of the MMCIF0 device node.

Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
@@ -346,6 +346,17 @@
 		status = "disabled";
 	};
 
+	mmcif0: mmc@ee200000 {
+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
+		dma-names = "tx", "rx";
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	clocks {
 		#address-cells = <2>;
 		#size-cells = <2>;

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Define the generic R8A7794 part of the MMCIF0 device node.

Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
@@ -346,6 +346,17 @@
 		status = "disabled";
 	};
 
+	mmcif0: mmc at ee200000 {
+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
+		reg = <0 0xee200000 0 0x80>;
+		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
+		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
+		dma-names = "tx", "rx";
+		reg-io-width = <4>;
+		status = "disabled";
+	};
+
 	clocks {
 		#address-cells = <2>;
 		#size-cells = <2>;

[PATCH 2/2] ARM: shmobile: silk: add eMMC DT support

[Sergei Shtylyov]

Define the SILK board dependent part of the MMCIF device node (the board has
eMMC chip) along with the  necessary voltage regulator (note that the Vcc/Vccq
regulator is dummy -- it's required by the MMCIF driver but doesn't actually
exist on the board).

Based on the original patch by Vladimir Barinov
<vladimir.barinov@cogentembedded.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794-silk.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
=================================--- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
@@ -30,6 +30,15 @@
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x40000000>;
 	};
+
+	d3_3v: regulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "D3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
 };
 
 &extal_clk {
@@ -51,6 +60,11 @@
 		renesas,groups = "intc_irq8";
 		renesas,function = "intc";
 	};
+
+	mmcif0_pins: mmcif0 {
+		renesas,groups = "mmc_data8", "mmc_ctrl";
+		renesas,function = "mmc";
+	};
 };
 
 &scif2 {
@@ -75,3 +89,14 @@
 		micrel,led-mode = <1>;
 	};
 };
+
+&mmcif0 {
+	pinctrl-0 = <&mmcif0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&d3_3v>;
+	vqmmc-supply = <&d3_3v>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};

[PATCH 2/2] ARM: shmobile: silk: add eMMC DT support

[Sergei Shtylyov]

Define the SILK board dependent part of the MMCIF device node (the board has
eMMC chip) along with the  necessary voltage regulator (note that the Vcc/Vccq
regulator is dummy -- it's required by the MMCIF driver but doesn't actually
exist on the board).

Based on the original patch by Vladimir Barinov
<vladimir.barinov@cogentembedded.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794-silk.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
@@ -30,6 +30,15 @@
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x40000000>;
 	};
+
+	d3_3v: regulator@0 {
+		compatible = "regulator-fixed";
+		regulator-name = "D3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
 };
 
 &extal_clk {
@@ -51,6 +60,11 @@
 		renesas,groups = "intc_irq8";
 		renesas,function = "intc";
 	};
+
+	mmcif0_pins: mmcif0 {
+		renesas,groups = "mmc_data8", "mmc_ctrl";
+		renesas,function = "mmc";
+	};
 };
 
 &scif2 {
@@ -75,3 +89,14 @@
 		micrel,led-mode = <1>;
 	};
 };
+
+&mmcif0 {
+	pinctrl-0 = <&mmcif0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&d3_3v>;
+	vqmmc-supply = <&d3_3v>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};

[PATCH 2/2] ARM: shmobile: silk: add eMMC DT support

[Sergei Shtylyov]

Define the SILK board dependent part of the MMCIF device node (the board has
eMMC chip) along with the  necessary voltage regulator (note that the Vcc/Vccq
regulator is dummy -- it's required by the MMCIF driver but doesn't actually
exist on the board).

Based on the original patch by Vladimir Barinov
<vladimir.barinov@cogentembedded.com>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/boot/dts/r8a7794-silk.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
@@ -30,6 +30,15 @@
 		device_type = "memory";
 		reg = <0 0x40000000 0 0x40000000>;
 	};
+
+	d3_3v: regulator at 0 {
+		compatible = "regulator-fixed";
+		regulator-name = "D3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
 };
 
 &extal_clk {
@@ -51,6 +60,11 @@
 		renesas,groups = "intc_irq8";
 		renesas,function = "intc";
 	};
+
+	mmcif0_pins: mmcif0 {
+		renesas,groups = "mmc_data8", "mmc_ctrl";
+		renesas,function = "mmc";
+	};
 };
 
 &scif2 {
@@ -75,3 +89,14 @@
 		micrel,led-mode = <1>;
 	};
 };
+
+&mmcif0 {
+	pinctrl-0 = <&mmcif0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&d3_3v>;
+	vqmmc-supply = <&d3_3v>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Tue, Feb 17, 2015 at 01:59:02AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7794 part of the MMCIF0 device node.
> 
> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> =================================> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -346,6 +346,17 @@
>  		status = "disabled";
>  	};
>  
> +	mmcif0: mmc@ee200000 {
> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

Please submit a patch to add "renesas,mmcif-r8a7794" to
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
I looked and I couldn't find such a change in-tree or in-flight.

> +		reg = <0 0xee200000 0 0x80>;
> +		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
> +		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
> +		dma-names = "tx", "rx";
> +		reg-io-width = <4>;
> +		status = "disabled";
> +	};
> +
>  	clocks {
>  		#address-cells = <2>;
>  		#size-cells = <2>;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Tue, Feb 17, 2015 at 01:59:02AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7794 part of the MMCIF0 device node.
> 
> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -346,6 +346,17 @@
>  		status = "disabled";
>  	};
>  
> +	mmcif0: mmc@ee200000 {
> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

Please submit a patch to add "renesas,mmcif-r8a7794" to
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
I looked and I couldn't find such a change in-tree or in-flight.

> +		reg = <0 0xee200000 0 0x80>;
> +		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
> +		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
> +		dma-names = "tx", "rx";
> +		reg-io-width = <4>;
> +		status = "disabled";
> +	};
> +
>  	clocks {
>  		#address-cells = <2>;
>  		#size-cells = <2>;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Tue, Feb 17, 2015 at 01:59:02AM +0300, Sergei Shtylyov wrote:
> Define the generic R8A7794 part of the MMCIF0 device node.
> 
> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -346,6 +346,17 @@
>  		status = "disabled";
>  	};
>  
> +	mmcif0: mmc at ee200000 {
> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

Please submit a patch to add "renesas,mmcif-r8a7794" to
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
I looked and I couldn't find such a change in-tree or in-flight.

> +		reg = <0 0xee200000 0 0x80>;
> +		interrupts = <0 169 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&mstp3_clks R8A7794_CLK_MMCIF0>;
> +		dmas = <&dmac0 0xd1>, <&dmac0 0xd2>;
> +		dma-names = "tx", "rx";
> +		reg-io-width = <4>;
> +		status = "disabled";
> +	};
> +
>  	clocks {
>  		#address-cells = <2>;
>  		#size-cells = <2>;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Hello.

On 02/19/2015 07:10 PM, Simon Horman wrote:

>> Define the generic R8A7794 part of the MMCIF0 device node.

>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>   1 file changed, 11 insertions(+)

>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> =================================>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>>   		status = "disabled";
>>   	};
>>
>> +	mmcif0: mmc@ee200000 {
>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.

    That file doesn't match the reality at all. It says:

<<
- compatible: must contain one of the following
         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
         - "renesas,sh-mmcif" for the generic MMCIF
 >>

while in reality, the driver only matches on the latter string and doesn't 
care for the SoC specific strings.

WBR, Sergei

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Hello.

On 02/19/2015 07:10 PM, Simon Horman wrote:

>> Define the generic R8A7794 part of the MMCIF0 device node.

>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>   1 file changed, 11 insertions(+)

>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>>   		status = "disabled";
>>   	};
>>
>> +	mmcif0: mmc@ee200000 {
>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.

    That file doesn't match the reality at all. It says:

<<
- compatible: must contain one of the following
         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
         - "renesas,sh-mmcif" for the generic MMCIF
 >>

while in reality, the driver only matches on the latter string and doesn't 
care for the SoC specific strings.

WBR, Sergei

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

Hello.

On 02/19/2015 07:10 PM, Simon Horman wrote:

>> Define the generic R8A7794 part of the MMCIF0 device node.

>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>> ---
>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>   1 file changed, 11 insertions(+)

>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>>   		status = "disabled";
>>   	};
>>
>> +	mmcif0: mmc at ee200000 {
>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.

    That file doesn't match the reality at all. It says:

<<
- compatible: must contain one of the following
         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
         - "renesas,sh-mmcif" for the generic MMCIF
 >>

while in reality, the driver only matches on the latter string and doesn't 
care for the SoC specific strings.

WBR, Sergei

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Thu, Feb 19, 2015 at 08:02:56PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 02/19/2015 07:10 PM, Simon Horman wrote:
> 
> >>Define the generic R8A7794 part of the MMCIF0 device node.
> 
> >>Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>---
> >>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> 
> >>Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>=================================> >>--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> >>+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>@@ -346,6 +346,17 @@
> >>  		status = "disabled";
> >>  	};
> >>
> >>+	mmcif0: mmc@ee200000 {
> >>+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> 
> >Please submit a patch to add "renesas,mmcif-r8a7794" to
> >Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> >I looked and I couldn't find such a change in-tree or in-flight.
> 
>    That file doesn't match the reality at all. It says:
> 
> <<
> - compatible: must contain one of the following
>         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>         - "renesas,sh-mmcif" for the generic MMCIF
> >>
> 
> while in reality, the driver only matches on the latter string and doesn't
> care for the SoC specific strings.

By documenting the binding in that file it exists and may be used in DT
nodes. It may or may not be used by the driver now or in the future.

For better or worse this one way that bindings may be handled.

Strictly speaking it shouldn't be used in DT before it exists,
even only in the documentation. But in this case its just a minor
update to an existing scheme so it seems unlikely to be rejected.

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Thu, Feb 19, 2015 at 08:02:56PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 02/19/2015 07:10 PM, Simon Horman wrote:
> 
> >>Define the generic R8A7794 part of the MMCIF0 device node.
> 
> >>Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>---
> >>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> 
> >>Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>===================================================================
> >>--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> >>+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>@@ -346,6 +346,17 @@
> >>  		status = "disabled";
> >>  	};
> >>
> >>+	mmcif0: mmc@ee200000 {
> >>+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> 
> >Please submit a patch to add "renesas,mmcif-r8a7794" to
> >Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> >I looked and I couldn't find such a change in-tree or in-flight.
> 
>    That file doesn't match the reality at all. It says:
> 
> <<
> - compatible: must contain one of the following
>         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>         - "renesas,sh-mmcif" for the generic MMCIF
> >>
> 
> while in reality, the driver only matches on the latter string and doesn't
> care for the SoC specific strings.

By documenting the binding in that file it exists and may be used in DT
nodes. It may or may not be used by the driver now or in the future.

For better or worse this one way that bindings may be handled.

Strictly speaking it shouldn't be used in DT before it exists,
even only in the documentation. But in this case its just a minor
update to an existing scheme so it seems unlikely to be rejected.

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Simon Horman]

On Thu, Feb 19, 2015 at 08:02:56PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 02/19/2015 07:10 PM, Simon Horman wrote:
> 
> >>Define the generic R8A7794 part of the MMCIF0 device node.
> 
> >>Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >>---
> >>  arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> 
> >>Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>===================================================================
> >>--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> >>+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> >>@@ -346,6 +346,17 @@
> >>  		status = "disabled";
> >>  	};
> >>
> >>+	mmcif0: mmc at ee200000 {
> >>+		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> 
> >Please submit a patch to add "renesas,mmcif-r8a7794" to
> >Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> >I looked and I couldn't find such a change in-tree or in-flight.
> 
>    That file doesn't match the reality at all. It says:
> 
> <<
> - compatible: must contain one of the following
>         - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>         - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>         - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>         - "renesas,sh-mmcif" for the generic MMCIF
> >>
> 
> while in reality, the driver only matches on the latter string and doesn't
> care for the SoC specific strings.

By documenting the binding in that file it exists and may be used in DT
nodes. It may or may not be used by the driver now or in the future.

For better or worse this one way that bindings may be handled.

Strictly speaking it shouldn't be used in DT before it exists,
even only in the documentation. But in this case its just a minor
update to an existing scheme so it seems unlikely to be rejected.

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

On 02/19/2015 08:55 PM, Simon Horman wrote:

>>>> Define the generic R8A7794 part of the MMCIF0 device node.

>>>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>>> ---
>>>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>>>   1 file changed, 11 insertions(+)

>>>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> =================================>>>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>>>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> @@ -346,6 +346,17 @@
>>>>   		status = "disabled";
>>>>   	};
>>>>
>>>> +	mmcif0: mmc@ee200000 {
>>>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

>>> Please submit a patch to add "renesas,mmcif-r8a7794" to
>>> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
>>> I looked and I couldn't find such a change in-tree or in-flight.

>>     That file doesn't match the reality at all. It says:

>> <<
>> - compatible: must contain one of the following
>>          - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>>          - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>>          - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>>          - "renesas,sh-mmcif" for the generic MMCIF
>>>>

>> while in reality, the driver only matches on the latter string and doesn't
>> care for the SoC specific strings.

> By documenting the binding in that file it exists and may be used in DT
> nodes. It may or may not be used by the driver now or in the future.

    What's the use of binding the driver doesn't understand?

> For better or worse this one way that bindings may be handled.

> Strictly speaking it shouldn't be used in DT before it exists,
> even only in the documentation. But in this case its just a minor
> update to an existing scheme so it seems unlikely to be rejected.

    I don't think the minor update will be rejected, I just wanted to say that 
the binding should be edited to better reflect the reality as well. And it 
falls on my shoulders, unfortunately. :-)

WBR, Sergei

Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

On 02/19/2015 08:55 PM, Simon Horman wrote:

>>>> Define the generic R8A7794 part of the MMCIF0 device node.

>>>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>>> ---
>>>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>>>   1 file changed, 11 insertions(+)

>>>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> ===================================================================
>>>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>>>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> @@ -346,6 +346,17 @@
>>>>   		status = "disabled";
>>>>   	};
>>>>
>>>> +	mmcif0: mmc@ee200000 {
>>>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

>>> Please submit a patch to add "renesas,mmcif-r8a7794" to
>>> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
>>> I looked and I couldn't find such a change in-tree or in-flight.

>>     That file doesn't match the reality at all. It says:

>> <<
>> - compatible: must contain one of the following
>>          - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>>          - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>>          - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>>          - "renesas,sh-mmcif" for the generic MMCIF
>>>>

>> while in reality, the driver only matches on the latter string and doesn't
>> care for the SoC specific strings.

> By documenting the binding in that file it exists and may be used in DT
> nodes. It may or may not be used by the driver now or in the future.

    What's the use of binding the driver doesn't understand?

> For better or worse this one way that bindings may be handled.

> Strictly speaking it shouldn't be used in DT before it exists,
> even only in the documentation. But in this case its just a minor
> update to an existing scheme so it seems unlikely to be rejected.

    I don't think the minor update will be rejected, I just wanted to say that 
the binding should be edited to better reflect the reality as well. And it 
falls on my shoulders, unfortunately. :-)

WBR, Sergei

[PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support

[Sergei Shtylyov]

On 02/19/2015 08:55 PM, Simon Horman wrote:

>>>> Define the generic R8A7794 part of the MMCIF0 device node.

>>>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.

>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

>>>> ---
>>>>   arch/arm/boot/dts/r8a7794.dtsi |   11 +++++++++++
>>>>   1 file changed, 11 insertions(+)

>>>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> ===================================================================
>>>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>>>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> @@ -346,6 +346,17 @@
>>>>   		status = "disabled";
>>>>   	};
>>>>
>>>> +	mmcif0: mmc at ee200000 {
>>>> +		compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";

>>> Please submit a patch to add "renesas,mmcif-r8a7794" to
>>> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
>>> I looked and I couldn't find such a change in-tree or in-flight.

>>     That file doesn't match the reality at all. It says:

>> <<
>> - compatible: must contain one of the following
>>          - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>>          - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>>          - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>>          - "renesas,sh-mmcif" for the generic MMCIF
>>>>

>> while in reality, the driver only matches on the latter string and doesn't
>> care for the SoC specific strings.

> By documenting the binding in that file it exists and may be used in DT
> nodes. It may or may not be used by the driver now or in the future.

    What's the use of binding the driver doesn't understand?

> For better or worse this one way that bindings may be handled.

> Strictly speaking it shouldn't be used in DT before it exists,
> even only in the documentation. But in this case its just a minor
> update to an existing scheme so it seems unlikely to be rejected.

    I don't think the minor update will be rejected, I just wanted to say that 
the binding should be edited to better reflect the reality as well. And it 
falls on my shoulders, unfortunately. :-)

WBR, Sergei