* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-22 16:59 ` Charles Keepax
0 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2015-02-22 16:59 UTC (permalink / raw)
To: swarren, lee
Cc: linux, robh+dt, pawel.moll, galak, devicetree, linux-arm-kernel,
linux-rpi-kernel, linux-kernel
This patch adds a header file for the constants used in pincontrol
configuration for the bcm2835.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 4 +-
arch/arm/boot/dts/bcm2835-rpi-b.dts | 4 +-
arch/arm/boot/dts/bcm2835-rpi.dtsi | 8 ++--
arch/arm/boot/dts/bcm2835.dtsi | 4 ++-
include/dt-bindings/pinctrl/pinctrl-bcm2835.h | 39 +++++++++++++++++++++++++
5 files changed, 50 insertions(+), 9 deletions(-)
create mode 100644 include/dt-bindings/pinctrl/pinctrl-bcm2835.h
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
index e479515..e3418c2 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
@@ -1,5 +1,5 @@
/dts-v1/;
-/include/ "bcm2835-rpi.dtsi"
+#include "bcm2835-rpi.dtsi"
/ {
compatible = "raspberrypi,model-b-plus", "brcm,bcm2835";
@@ -25,6 +25,6 @@
/* I2S interface */
i2s_alt0: i2s_alt0 {
brcm,pins = <18 19 20 21>;
- brcm,function = <4>; /* alt0 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT0>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b.dts b/arch/arm/boot/dts/bcm2835-rpi-b.dts
index bafa46f..541788a 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b.dts
@@ -1,5 +1,5 @@
/dts-v1/;
-/include/ "bcm2835-rpi.dtsi"
+#include "bcm2835-rpi.dtsi"
/ {
compatible = "raspberrypi,model-b", "brcm,bcm2835";
@@ -18,6 +18,6 @@
/* I2S interface */
i2s_alt2: i2s_alt2 {
brcm,pins = <28 29 30 31>;
- brcm,function = <6>; /* alt2 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT2>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index c706448..76b0a40 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -1,4 +1,4 @@
-/include/ "bcm2835.dtsi"
+#include "bcm2835.dtsi"
/ {
memory {
@@ -21,17 +21,17 @@
gpioout: gpioout {
brcm,pins = <6>;
- brcm,function = <1>; /* GPIO out */
+ brcm,function = <BCM2835_PIN_FUNC_GPIO_OUT>;
};
alt0: alt0 {
brcm,pins = <0 1 2 3 4 5 7 8 9 10 11 14 15 40 45>;
- brcm,function = <4>; /* alt0 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT0>;
};
alt3: alt3 {
brcm,pins = <48 49 50 51 52 53>;
- brcm,function = <7>; /* alt3 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT3>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..31f6586 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -1,4 +1,6 @@
-/include/ "skeleton.dtsi"
+#include <dt-bindings/pinctrl/pinctrl-bcm2835.h>
+
+#include "skeleton.dtsi"
/ {
compatible = "brcm,bcm2835";
diff --git a/include/dt-bindings/pinctrl/pinctrl-bcm2835.h b/include/dt-bindings/pinctrl/pinctrl-bcm2835.h
new file mode 100644
index 0000000..c74532e
--- /dev/null
+++ b/include/dt-bindings/pinctrl/pinctrl-bcm2835.h
@@ -0,0 +1,39 @@
+/*
+ * This header provides constants for BCM2835 pinctrl bindings.
+ *
+ * Copyright 2015, Cirrus Logic Inc.
+ *
+ * Author: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _DT_BINDINGS_PINCTRL_BCM2835_H
+#define _DT_BINDINGS_PINCTRL_BCM2835_H
+
+/* IRQ Flags */
+#define BCM2835_PIN_IRQ_RISING 1
+#define BCM2835_PIN_IRQ_FALLING 2
+#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
+ BCM2835_PIN_IRQ_FALLING)
+#define BCM2835_PIN_IRQ_LOW 4
+#define BCM2835_PIN_IRQ_HIGH 8
+
+/* Pin Function Settings */
+#define BCM2835_PIN_FUNC_GPIO_IN 0
+#define BCM2835_PIN_FUNC_GPIO_OUT 1
+#define BCM2835_PIN_FUNC_ALT5 2
+#define BCM2835_PIN_FUNC_ALT4 3
+#define BCM2835_PIN_FUNC_ALT0 4
+#define BCM2835_PIN_FUNC_ALT1 5
+#define BCM2835_PIN_FUNC_ALT2 6
+#define BCM2835_PIN_FUNC_ALT3 7
+
+/* Pin Pull Settings */
+#define BCM2835_PIN_PULL_NONE 0
+#define BCM2835_PIN_PULL_DOWN 1
+#define BCM2835_PIN_PULL_UP 2
+
+#endif
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-22 16:59 ` Charles Keepax
0 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2015-02-22 16:59 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds a header file for the constants used in pincontrol
configuration for the bcm2835.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 4 +-
arch/arm/boot/dts/bcm2835-rpi-b.dts | 4 +-
arch/arm/boot/dts/bcm2835-rpi.dtsi | 8 ++--
arch/arm/boot/dts/bcm2835.dtsi | 4 ++-
include/dt-bindings/pinctrl/pinctrl-bcm2835.h | 39 +++++++++++++++++++++++++
5 files changed, 50 insertions(+), 9 deletions(-)
create mode 100644 include/dt-bindings/pinctrl/pinctrl-bcm2835.h
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
index e479515..e3418c2 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
@@ -1,5 +1,5 @@
/dts-v1/;
-/include/ "bcm2835-rpi.dtsi"
+#include "bcm2835-rpi.dtsi"
/ {
compatible = "raspberrypi,model-b-plus", "brcm,bcm2835";
@@ -25,6 +25,6 @@
/* I2S interface */
i2s_alt0: i2s_alt0 {
brcm,pins = <18 19 20 21>;
- brcm,function = <4>; /* alt0 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT0>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b.dts b/arch/arm/boot/dts/bcm2835-rpi-b.dts
index bafa46f..541788a 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b.dts
@@ -1,5 +1,5 @@
/dts-v1/;
-/include/ "bcm2835-rpi.dtsi"
+#include "bcm2835-rpi.dtsi"
/ {
compatible = "raspberrypi,model-b", "brcm,bcm2835";
@@ -18,6 +18,6 @@
/* I2S interface */
i2s_alt2: i2s_alt2 {
brcm,pins = <28 29 30 31>;
- brcm,function = <6>; /* alt2 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT2>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index c706448..76b0a40 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -1,4 +1,4 @@
-/include/ "bcm2835.dtsi"
+#include "bcm2835.dtsi"
/ {
memory {
@@ -21,17 +21,17 @@
gpioout: gpioout {
brcm,pins = <6>;
- brcm,function = <1>; /* GPIO out */
+ brcm,function = <BCM2835_PIN_FUNC_GPIO_OUT>;
};
alt0: alt0 {
brcm,pins = <0 1 2 3 4 5 7 8 9 10 11 14 15 40 45>;
- brcm,function = <4>; /* alt0 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT0>;
};
alt3: alt3 {
brcm,pins = <48 49 50 51 52 53>;
- brcm,function = <7>; /* alt3 */
+ brcm,function = <BCM2835_PIN_FUNC_ALT3>;
};
};
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index 3342cb1..31f6586 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -1,4 +1,6 @@
-/include/ "skeleton.dtsi"
+#include <dt-bindings/pinctrl/pinctrl-bcm2835.h>
+
+#include "skeleton.dtsi"
/ {
compatible = "brcm,bcm2835";
diff --git a/include/dt-bindings/pinctrl/pinctrl-bcm2835.h b/include/dt-bindings/pinctrl/pinctrl-bcm2835.h
new file mode 100644
index 0000000..c74532e
--- /dev/null
+++ b/include/dt-bindings/pinctrl/pinctrl-bcm2835.h
@@ -0,0 +1,39 @@
+/*
+ * This header provides constants for BCM2835 pinctrl bindings.
+ *
+ * Copyright 2015, Cirrus Logic Inc.
+ *
+ * Author: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _DT_BINDINGS_PINCTRL_BCM2835_H
+#define _DT_BINDINGS_PINCTRL_BCM2835_H
+
+/* IRQ Flags */
+#define BCM2835_PIN_IRQ_RISING 1
+#define BCM2835_PIN_IRQ_FALLING 2
+#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
+ BCM2835_PIN_IRQ_FALLING)
+#define BCM2835_PIN_IRQ_LOW 4
+#define BCM2835_PIN_IRQ_HIGH 8
+
+/* Pin Function Settings */
+#define BCM2835_PIN_FUNC_GPIO_IN 0
+#define BCM2835_PIN_FUNC_GPIO_OUT 1
+#define BCM2835_PIN_FUNC_ALT5 2
+#define BCM2835_PIN_FUNC_ALT4 3
+#define BCM2835_PIN_FUNC_ALT0 4
+#define BCM2835_PIN_FUNC_ALT1 5
+#define BCM2835_PIN_FUNC_ALT2 6
+#define BCM2835_PIN_FUNC_ALT3 7
+
+/* Pin Pull Settings */
+#define BCM2835_PIN_PULL_NONE 0
+#define BCM2835_PIN_PULL_DOWN 1
+#define BCM2835_PIN_PULL_UP 2
+
+#endif
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
2015-02-22 16:59 ` Charles Keepax
@ 2015-02-22 20:13 ` Arnd Bergmann
-1 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2015-02-22 20:13 UTC (permalink / raw)
To: Charles Keepax
Cc: swarren, lee, linux, robh+dt, pawel.moll, galak, devicetree,
linux-arm-kernel, linux-rpi-kernel, linux-kernel
On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
> +
> +/* IRQ Flags */
> +#define BCM2835_PIN_IRQ_RISING 1
> +#define BCM2835_PIN_IRQ_FALLING 2
> +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
> + BCM2835_PIN_IRQ_FALLING)
> +#define BCM2835_PIN_IRQ_LOW 4
> +#define BCM2835_PIN_IRQ_HIGH 8
Are these different from the standard definitions?
> +/* Pin Function Settings */
> +#define BCM2835_PIN_FUNC_GPIO_IN 0
> +#define BCM2835_PIN_FUNC_GPIO_OUT 1
> +#define BCM2835_PIN_FUNC_ALT5 2
> +#define BCM2835_PIN_FUNC_ALT4 3
> +#define BCM2835_PIN_FUNC_ALT0 4
> +#define BCM2835_PIN_FUNC_ALT1 5
> +#define BCM2835_PIN_FUNC_ALT2 6
> +#define BCM2835_PIN_FUNC_ALT3 7
Why are these required? They don't seem to be used by any driver,
which leads me to suspect that they are just the hardware numbers.
In that case, don't add any syntactical sugar like that and just
use the hardware numbers directly.
What's with the strange mapping of numbers anyway?
Arnd
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-22 20:13 ` Arnd Bergmann
0 siblings, 0 replies; 11+ messages in thread
From: Arnd Bergmann @ 2015-02-22 20:13 UTC (permalink / raw)
To: linux-arm-kernel
On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
> +
> +/* IRQ Flags */
> +#define BCM2835_PIN_IRQ_RISING 1
> +#define BCM2835_PIN_IRQ_FALLING 2
> +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
> + BCM2835_PIN_IRQ_FALLING)
> +#define BCM2835_PIN_IRQ_LOW 4
> +#define BCM2835_PIN_IRQ_HIGH 8
Are these different from the standard definitions?
> +/* Pin Function Settings */
> +#define BCM2835_PIN_FUNC_GPIO_IN 0
> +#define BCM2835_PIN_FUNC_GPIO_OUT 1
> +#define BCM2835_PIN_FUNC_ALT5 2
> +#define BCM2835_PIN_FUNC_ALT4 3
> +#define BCM2835_PIN_FUNC_ALT0 4
> +#define BCM2835_PIN_FUNC_ALT1 5
> +#define BCM2835_PIN_FUNC_ALT2 6
> +#define BCM2835_PIN_FUNC_ALT3 7
Why are these required? They don't seem to be used by any driver,
which leads me to suspect that they are just the hardware numbers.
In that case, don't add any syntactical sugar like that and just
use the hardware numbers directly.
What's with the strange mapping of numbers anyway?
Arnd
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
2015-02-22 20:13 ` Arnd Bergmann
@ 2015-02-22 21:31 ` Charles Keepax
-1 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2015-02-22 21:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: swarren, lee, linux, robh+dt, pawel.moll, galak, devicetree,
linux-arm-kernel, linux-rpi-kernel, linux-kernel
On Sun, Feb 22, 2015 at 09:13:23PM +0100, Arnd Bergmann wrote:
> On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
> > +
> > +/* IRQ Flags */
> > +#define BCM2835_PIN_IRQ_RISING 1
> > +#define BCM2835_PIN_IRQ_FALLING 2
> > +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
> > + BCM2835_PIN_IRQ_FALLING)
> > +#define BCM2835_PIN_IRQ_LOW 4
> > +#define BCM2835_PIN_IRQ_HIGH 8
>
> Are these different from the standard definitions?
>
> > +/* Pin Function Settings */
> > +#define BCM2835_PIN_FUNC_GPIO_IN 0
> > +#define BCM2835_PIN_FUNC_GPIO_OUT 1
> > +#define BCM2835_PIN_FUNC_ALT5 2
> > +#define BCM2835_PIN_FUNC_ALT4 3
> > +#define BCM2835_PIN_FUNC_ALT0 4
> > +#define BCM2835_PIN_FUNC_ALT1 5
> > +#define BCM2835_PIN_FUNC_ALT2 6
> > +#define BCM2835_PIN_FUNC_ALT3 7
>
> Why are these required? They don't seem to be used by any driver,
> which leads me to suspect that they are just the hardware numbers.
>
> In that case, don't add any syntactical sugar like that and just
> use the hardware numbers directly.
Yeah they are just hardware numbers, I wasn't aware there was a
preference to use the numbers directly in which case just ignore
this patch.
>
> What's with the strange mapping of numbers anyway?
You would need to ask Broadcom that :-)
Thanks,
Charles
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-22 21:31 ` Charles Keepax
0 siblings, 0 replies; 11+ messages in thread
From: Charles Keepax @ 2015-02-22 21:31 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Feb 22, 2015 at 09:13:23PM +0100, Arnd Bergmann wrote:
> On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
> > +
> > +/* IRQ Flags */
> > +#define BCM2835_PIN_IRQ_RISING 1
> > +#define BCM2835_PIN_IRQ_FALLING 2
> > +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
> > + BCM2835_PIN_IRQ_FALLING)
> > +#define BCM2835_PIN_IRQ_LOW 4
> > +#define BCM2835_PIN_IRQ_HIGH 8
>
> Are these different from the standard definitions?
>
> > +/* Pin Function Settings */
> > +#define BCM2835_PIN_FUNC_GPIO_IN 0
> > +#define BCM2835_PIN_FUNC_GPIO_OUT 1
> > +#define BCM2835_PIN_FUNC_ALT5 2
> > +#define BCM2835_PIN_FUNC_ALT4 3
> > +#define BCM2835_PIN_FUNC_ALT0 4
> > +#define BCM2835_PIN_FUNC_ALT1 5
> > +#define BCM2835_PIN_FUNC_ALT2 6
> > +#define BCM2835_PIN_FUNC_ALT3 7
>
> Why are these required? They don't seem to be used by any driver,
> which leads me to suspect that they are just the hardware numbers.
>
> In that case, don't add any syntactical sugar like that and just
> use the hardware numbers directly.
Yeah they are just hardware numbers, I wasn't aware there was a
preference to use the numbers directly in which case just ignore
this patch.
>
> What's with the strange mapping of numbers anyway?
You would need to ask Broadcom that :-)
Thanks,
Charles
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-23 19:08 ` Stephen Warren
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Warren @ 2015-02-23 19:08 UTC (permalink / raw)
To: Charles Keepax, lee, Stefan Wahren
Cc: linux, robh+dt, pawel.moll, galak, devicetree, linux-arm-kernel,
linux-rpi-kernel, linux-kernel, Arnd Bergmann
On 02/22/2015 09:59 AM, Charles Keepax wrote:
> This patch adds a header file for the constants used in pincontrol
> configuration for the bcm2835.
This seems like a duplicate of the following series:
https://lkml.org/lkml/2015/1/16/402
[PATCH 0/4] ARM: bcm2835: DT improvements
[PATCH 1/4] dt-bindings: Add vendor prefix for Raspberry Pi
[PATCH 2/4] dt-bindings: Add root properties for Raspberry Pi B and B+
[PATCH 3/4] ARM: bcm2835: Add header file for pinctrl constants
https://lkml.org/lkml/2015/1/16/405
[PATCH 4/4] ARM: bcm2835: Use pinctrl header
Lee, are you planning on applying one/both/some of these?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-23 19:08 ` Stephen Warren
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Warren @ 2015-02-23 19:08 UTC (permalink / raw)
To: Charles Keepax, lee-DgEjT+Ai2ygdnm+yROfE0A, Stefan Wahren
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, galak-sgV2jX0FEOL9JmXXK+q4OQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Arnd Bergmann
On 02/22/2015 09:59 AM, Charles Keepax wrote:
> This patch adds a header file for the constants used in pincontrol
> configuration for the bcm2835.
This seems like a duplicate of the following series:
https://lkml.org/lkml/2015/1/16/402
[PATCH 0/4] ARM: bcm2835: DT improvements
[PATCH 1/4] dt-bindings: Add vendor prefix for Raspberry Pi
[PATCH 2/4] dt-bindings: Add root properties for Raspberry Pi B and B+
[PATCH 3/4] ARM: bcm2835: Add header file for pinctrl constants
https://lkml.org/lkml/2015/1/16/405
[PATCH 4/4] ARM: bcm2835: Use pinctrl header
Lee, are you planning on applying one/both/some of these?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-23 19:08 ` Stephen Warren
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Warren @ 2015-02-23 19:08 UTC (permalink / raw)
To: linux-arm-kernel
On 02/22/2015 09:59 AM, Charles Keepax wrote:
> This patch adds a header file for the constants used in pincontrol
> configuration for the bcm2835.
This seems like a duplicate of the following series:
https://lkml.org/lkml/2015/1/16/402
[PATCH 0/4] ARM: bcm2835: DT improvements
[PATCH 1/4] dt-bindings: Add vendor prefix for Raspberry Pi
[PATCH 2/4] dt-bindings: Add root properties for Raspberry Pi B and B+
[PATCH 3/4] ARM: bcm2835: Add header file for pinctrl constants
https://lkml.org/lkml/2015/1/16/405
[PATCH 4/4] ARM: bcm2835: Use pinctrl header
Lee, are you planning on applying one/both/some of these?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ARM: bcm2835: Add header file for pinctrl constants
2015-02-22 20:13 ` Arnd Bergmann
@ 2015-02-23 19:11 ` Stephen Warren
-1 siblings, 0 replies; 11+ messages in thread
From: Stephen Warren @ 2015-02-23 19:11 UTC (permalink / raw)
To: Arnd Bergmann, Charles Keepax
Cc: lee, linux, robh+dt, pawel.moll, galak, devicetree,
linux-arm-kernel, linux-rpi-kernel, linux-kernel
On 02/22/2015 01:13 PM, Arnd Bergmann wrote:
> On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
>> +
>> +/* IRQ Flags */
>> +#define BCM2835_PIN_IRQ_RISING 1
>> +#define BCM2835_PIN_IRQ_FALLING 2
>> +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
>> + BCM2835_PIN_IRQ_FALLING)
>> +#define BCM2835_PIN_IRQ_LOW 4
>> +#define BCM2835_PIN_IRQ_HIGH 8
>
> Are these different from the standard definitions?
>
>> +/* Pin Function Settings */
>> +#define BCM2835_PIN_FUNC_GPIO_IN 0
>> +#define BCM2835_PIN_FUNC_GPIO_OUT 1
>> +#define BCM2835_PIN_FUNC_ALT5 2
>> +#define BCM2835_PIN_FUNC_ALT4 3
>> +#define BCM2835_PIN_FUNC_ALT0 4
>> +#define BCM2835_PIN_FUNC_ALT1 5
>> +#define BCM2835_PIN_FUNC_ALT2 6
>> +#define BCM2835_PIN_FUNC_ALT3 7
>
> Why are these required? They don't seem to be used by any driver,
> which leads me to suspect that they are just the hardware numbers.
>
> In that case, don't add any syntactical sugar like that and just
> use the hardware numbers directly.
>
> What's with the strange mapping of numbers anyway?
Especially given that the number->semantics meaning is a little
non-linear it seems like using #defines/... to document what the numbers
mean seems reasonable. It allows easily validating the DT files without
having to go look up the meaning of the numbers in the documentation.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ARM: bcm2835: Add header file for pinctrl constants
@ 2015-02-23 19:11 ` Stephen Warren
0 siblings, 0 replies; 11+ messages in thread
From: Stephen Warren @ 2015-02-23 19:11 UTC (permalink / raw)
To: linux-arm-kernel
On 02/22/2015 01:13 PM, Arnd Bergmann wrote:
> On Sunday 22 February 2015 16:59:56 Charles Keepax wrote:
>> +
>> +/* IRQ Flags */
>> +#define BCM2835_PIN_IRQ_RISING 1
>> +#define BCM2835_PIN_IRQ_FALLING 2
>> +#define BCM2835_PIN_IRQ_EDGE (BCM2835_PIN_IRQ_RISING | \
>> + BCM2835_PIN_IRQ_FALLING)
>> +#define BCM2835_PIN_IRQ_LOW 4
>> +#define BCM2835_PIN_IRQ_HIGH 8
>
> Are these different from the standard definitions?
>
>> +/* Pin Function Settings */
>> +#define BCM2835_PIN_FUNC_GPIO_IN 0
>> +#define BCM2835_PIN_FUNC_GPIO_OUT 1
>> +#define BCM2835_PIN_FUNC_ALT5 2
>> +#define BCM2835_PIN_FUNC_ALT4 3
>> +#define BCM2835_PIN_FUNC_ALT0 4
>> +#define BCM2835_PIN_FUNC_ALT1 5
>> +#define BCM2835_PIN_FUNC_ALT2 6
>> +#define BCM2835_PIN_FUNC_ALT3 7
>
> Why are these required? They don't seem to be used by any driver,
> which leads me to suspect that they are just the hardware numbers.
>
> In that case, don't add any syntactical sugar like that and just
> use the hardware numbers directly.
>
> What's with the strange mapping of numbers anyway?
Especially given that the number->semantics meaning is a little
non-linear it seems like using #defines/... to document what the numbers
mean seems reasonable. It allows easily validating the DT files without
having to go look up the meaning of the numbers in the documentation.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-02-23 19:15 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-22 16:59 [PATCH] ARM: bcm2835: Add header file for pinctrl constants Charles Keepax
2015-02-22 16:59 ` Charles Keepax
2015-02-22 20:13 ` Arnd Bergmann
2015-02-22 20:13 ` Arnd Bergmann
2015-02-22 21:31 ` Charles Keepax
2015-02-22 21:31 ` Charles Keepax
2015-02-23 19:11 ` Stephen Warren
2015-02-23 19:11 ` Stephen Warren
2015-02-23 19:08 ` Stephen Warren
2015-02-23 19:08 ` Stephen Warren
2015-02-23 19:08 ` Stephen Warren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.