* [patch] fujitsu-laptop: simplify show_brightness_changed()
@ 2015-02-26 20:41 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-02-26 20:41 UTC (permalink / raw)
To: Jonathan Woithe; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
->brightness_changed is either 0 or 1, and never a negative. We can
just remove this code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 2a9afa2..aa5ee98 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -444,14 +444,7 @@ static ssize_t
show_brightness_changed(struct device *dev,
struct device_attribute *attr, char *buf)
{
-
- int ret;
-
- ret = fujitsu->brightness_changed;
- if (ret < 0)
- return ret;
-
- return sprintf(buf, "%i\n", ret);
+ return sprintf(buf, "%i\n", fujitsu->brightness_changed);
}
static ssize_t show_lcd_level(struct device *dev,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] fujitsu-laptop: simplify show_brightness_changed()
@ 2015-02-26 20:41 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-02-26 20:41 UTC (permalink / raw)
To: Jonathan Woithe; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
->brightness_changed is either 0 or 1, and never a negative. We can
just remove this code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 2a9afa2..aa5ee98 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -444,14 +444,7 @@ static ssize_t
show_brightness_changed(struct device *dev,
struct device_attribute *attr, char *buf)
{
-
- int ret;
-
- ret = fujitsu->brightness_changed;
- if (ret < 0)
- return ret;
-
- return sprintf(buf, "%i\n", ret);
+ return sprintf(buf, "%i\n", fujitsu->brightness_changed);
}
static ssize_t show_lcd_level(struct device *dev,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] fujitsu-laptop: simplify show_brightness_changed()
2015-02-26 20:41 ` Dan Carpenter
@ 2015-02-26 22:16 ` Jonathan Woithe
-1 siblings, 0 replies; 4+ messages in thread
From: Jonathan Woithe @ 2015-02-26 22:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
On Thu, Feb 26, 2015 at 11:41:43PM +0300, Dan Carpenter wrote:
> ->brightness_changed is either 0 or 1, and never a negative. We can
> just remove this code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I agree. Thanks for spotting this.
Acked-by: Jonathan Woithe <jwoithe@just42.net>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 2a9afa2..aa5ee98 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -444,14 +444,7 @@ static ssize_t
> show_brightness_changed(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> -
> - int ret;
> -
> - ret = fujitsu->brightness_changed;
> - if (ret < 0)
> - return ret;
> -
> - return sprintf(buf, "%i\n", ret);
> + return sprintf(buf, "%i\n", fujitsu->brightness_changed);
> }
>
> static ssize_t show_lcd_level(struct device *dev,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] fujitsu-laptop: simplify show_brightness_changed()
@ 2015-02-26 22:16 ` Jonathan Woithe
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Woithe @ 2015-02-26 22:16 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Darren Hart, platform-driver-x86, kernel-janitors
On Thu, Feb 26, 2015 at 11:41:43PM +0300, Dan Carpenter wrote:
> ->brightness_changed is either 0 or 1, and never a negative. We can
> just remove this code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
I agree. Thanks for spotting this.
Acked-by: Jonathan Woithe <jwoithe@just42.net>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 2a9afa2..aa5ee98 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -444,14 +444,7 @@ static ssize_t
> show_brightness_changed(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> -
> - int ret;
> -
> - ret = fujitsu->brightness_changed;
> - if (ret < 0)
> - return ret;
> -
> - return sprintf(buf, "%i\n", ret);
> + return sprintf(buf, "%i\n", fujitsu->brightness_changed);
> }
>
> static ssize_t show_lcd_level(struct device *dev,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-26 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 20:41 [patch] fujitsu-laptop: simplify show_brightness_changed() Dan Carpenter
2015-02-26 20:41 ` Dan Carpenter
2015-02-26 22:04 ` Jonathan Woithe
2015-02-26 22:16 ` Jonathan Woithe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.