* [patch] IB/ipath: remove some left over code
@ 2015-02-26 20:43 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-26 20:43 UTC (permalink / raw)
To: Mike Marciniszyn, Dave Olson
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors
"ret" is always zero here after commit c4bce8032ef4 ('IB/ipath: Add new
chip-specific functions to older chips, consistent init').
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I just happened to spot this dead code when I was reviewing a different
static checker warning:
drivers/infiniband/hw/ipath/ipath_verbs.c:2266 show_hca()
warn: bool is not less than zero.
It looks to me that this code returns 0 on success and 1 on failure so
the warning is correct. This is very strange. The documentation
doesn't say anything about what the return codes mean so it is all very
puzzling.
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6110.c b/drivers/infiniband/hw/ipath/ipath_iba6110.c
index 7cc3054..3de90e9 100644
--- a/drivers/infiniband/hw/ipath/ipath_iba6110.c
+++ b/drivers/infiniband/hw/ipath/ipath_iba6110.c
@@ -721,10 +721,6 @@ static int ipath_ht_boardname(struct ipath_devdata *dd, char *name,
if (n)
snprintf(name, namelen, "%s", n);
- if (ret) {
- ipath_dev_err(dd, "Unsupported InfiniPath board %s!\n", name);
- goto bail;
- }
if (dd->ipath_majrev != 3 || (dd->ipath_minrev < 2 ||
dd->ipath_minrev > 4)) {
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] IB/ipath: remove some left over code
@ 2015-02-26 20:43 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-26 20:43 UTC (permalink / raw)
To: Mike Marciniszyn, Dave Olson
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors
"ret" is always zero here after commit c4bce8032ef4 ('IB/ipath: Add new
chip-specific functions to older chips, consistent init').
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I just happened to spot this dead code when I was reviewing a different
static checker warning:
drivers/infiniband/hw/ipath/ipath_verbs.c:2266 show_hca()
warn: bool is not less than zero.
It looks to me that this code returns 0 on success and 1 on failure so
the warning is correct. This is very strange. The documentation
doesn't say anything about what the return codes mean so it is all very
puzzling.
diff --git a/drivers/infiniband/hw/ipath/ipath_iba6110.c b/drivers/infiniband/hw/ipath/ipath_iba6110.c
index 7cc3054..3de90e9 100644
--- a/drivers/infiniband/hw/ipath/ipath_iba6110.c
+++ b/drivers/infiniband/hw/ipath/ipath_iba6110.c
@@ -721,10 +721,6 @@ static int ipath_ht_boardname(struct ipath_devdata *dd, char *name,
if (n)
snprintf(name, namelen, "%s", n);
- if (ret) {
- ipath_dev_err(dd, "Unsupported InfiniPath board %s!\n", name);
- goto bail;
- }
if (dd->ipath_majrev != 3 || (dd->ipath_minrev < 2 ||
dd->ipath_minrev > 4)) {
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [patch] IB/ipath: remove some left over code
2015-02-26 20:43 ` Dan Carpenter
(?)
@ 2015-03-17 1:09 ` Marciniszyn, Mike
-1 siblings, 0 replies; 3+ messages in thread
From: Marciniszyn, Mike @ 2015-03-17 1:09 UTC (permalink / raw)
To: Dan Carpenter, infinipath, Dave Olson
Cc: Roland Dreier, Hefty, Sean, Hal Rosenstock, linux-rdma, kernel-janitors
> Subject: [patch] IB/ipath: remove some left over code
Thanks for the patch!
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-17 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 20:43 [patch] IB/ipath: remove some left over code Dan Carpenter
2015-02-26 20:43 ` Dan Carpenter
2015-03-17 1:09 ` Marciniszyn, Mike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.