[PATCH] staging: lustre: fld_request.c: Remove else after return.

[PATCH] staging: lustre: fld_request.c: Remove else after return.

[Alberto Pires de Oliveira Neto]

very sorry for the html patch. It was my first one.

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
index b8d17e1..0b00301 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld,
 		CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
 			fld->lcf_name, name, tar->ft_idx);
 		return 0;
-	} else {
-		CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
-		       fld->lcf_name, name, tar->ft_idx);
-	}
+	} 
+	CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n",
+			fld->lcf_name, name, tar->ft_idx);
 
 	OBD_ALLOC_PTR(target);
 	if (target == NULL)
-- 
1.9.1

Re: [PATCH] staging: lustre: fld_request.c: Remove else after return.

[Sudip Mukherjee]

On Thu, Feb 26, 2015 at 11:58:39PM -0300, Alberto Pires de Oliveira Neto wrote:
> very sorry for the html patch. It was my first one.

this should not be your commit message. Your commit message should say about your patch. This can be written as a comment after ---


regards
sudip

> 
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>

Re: [PATCH] staging: lustre: fld_request.c: Remove else after return.

[Sudip Mukherjee]

On Fri, Feb 27, 2015 at 11:59:21AM -0300, Alberto Pires de Oliveira Neto wrote:
> Sorry, still getting the hang of it. Should I resend the patch ?
better. and then your subject line should have [PATCH v2].

regards
sudip

Re: [PATCH] staging: lustre: fld_request.c: Remove else after return.

[Alberto Pires de Oliveira Neto]

Ok, it's done.

Thanks again.

On Sat, Feb 28, 2015 at 6:29 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Fri, Feb 27, 2015 at 11:59:21AM -0300, Alberto Pires de Oliveira Neto wrote:
>> Sorry, still getting the hang of it. Should I resend the patch ?
> better. and then your subject line should have [PATCH v2].
>
> regards
> sudip

Re: [PATCH] staging: lustre: fld_request.c: Remove else after return.

[Alberto Pires de Oliveira Neto]

Hi,

  I'm terribly sorry. It's my first patch. I used git send-email to send it.
  It's also my first time using sendgrid as a relay, and it seems that
there was "convert text to html" option turned on by default.
  I tested again and now it seems ok.

I send the patch again.

Thanks, for the patience.


On Thu, Feb 26, 2015 at 10:30 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 26, 2015 at 10:20:06PM -0300, Alberto Pires de Oliveira Neto wrote:
>> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
>>
>> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/
>> lustre/lustre/fld/fld_request.c index b8d17e1..0b00301 100644 --- a/drivers/
>> staging/lustre/lustre/fld/fld_request.c +++ b/drivers/staging/lustre/lustre/fld
>> /fld_request.c @@ -217,10 +217,9 @@ int fld_client_add_target(struct
>> lu_client_fld *fld,
>>
>> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
>>         fld->lcf_name, name, tar->ft_idx);
>> return 0;
>>
>>   • } else {
>>
>>   • CDEBUG(D_INFO, “%s: Adding target %s (idx %llu)\n”,
>>
>>   • fld->lcf_name, name, tar->ft_idx);
>>
>>   • }
>>
>> + } + CDEBUG(D_INFO, “%s: Adding target %s (idx %llu)\n”, + fld->lcf_name,
>> name, tar->ft_idx);
>>
>> OBD_ALLOC_PTR(target);
>> if (target == NULL)
>>
>> — 1.9.1
>>
>> *
>
> You sent an html patch, which obviously can not be applied :(

Re: [PATCH] staging: lustre: fld_request.c: Remove else after return.

[Greg KH]

On Thu, Feb 26, 2015 at 10:20:06PM -0300, Alberto Pires de Oliveira Neto wrote:
> Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
> 
> drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/
> lustre/lustre/fld/fld_request.c index b8d17e1..0b00301 100644 --- a/drivers/
> staging/lustre/lustre/fld/fld_request.c +++ b/drivers/staging/lustre/lustre/fld
> /fld_request.c @@ -217,10 +217,9 @@ int fld_client_add_target(struct
> lu_client_fld *fld,
> 
> CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n",
>         fld->lcf_name, name, tar->ft_idx);
> return 0;
> 
>   • } else {
> 
>   • CDEBUG(D_INFO, “%s: Adding target %s (idx %llu)\n”,
> 
>   • fld->lcf_name, name, tar->ft_idx);
> 
>   • }
> 
> + } + CDEBUG(D_INFO, “%s: Adding target %s (idx %llu)\n”, + fld->lcf_name,
> name, tar->ft_idx);
> 
> OBD_ALLOC_PTR(target);
> if (target == NULL)
> 
> — 1.9.1
> 
> *

You sent an html patch, which obviously can not be applied :(